MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2024-12-28 16:15:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,749 Commits 25 Branches 43 Tags 98 MiB
6163269832
Commit Graph

2913 Commits

Author SHA1 Message Date
Björn Ricks
382459ce9b Allow anonymous access to /content-codes url 
The content-codes url provides a mapping of dmap content codes to names, it's
types and sizes. It doesn't contain any private information and therefore should
be available to anonymous users too.
 2016-07-13 19:52:58 +02:00
ejurgensen
d3078c6534 [remote] Increase pairing success log level 2016-07-10 20:38:03 +02:00
ejurgensen
a99d1b2038 [db] Add song_length to group info (fixes #265) 2016-06-11 23:10:13 +02:00
ejurgensen
547783d008 Merge pull request #268 from chme/threadexit 
Refactor thread exit handling
 2016-06-11 22:57:09 +02:00
chme
c0c6cca79f [commands] Add some code comments 2016-06-11 10:56:27 +02:00
chme
32ac6c2ea9 [commands] Rename commands_cmdloop_break to commands_base_destroy and 
free commands_base after breaking the libevent loop
 2016-06-11 10:56:27 +02:00
chme
a9a656042b [player] Cleanup: player clock is the only sync-source available 2016-06-11 10:37:09 +02:00
chme
5258ee712c [commands] Added functionality to break the event loop of a command base 2016-06-11 09:52:31 +02:00
ejurgensen
3527113a9b [filescanner] Option to import iTunes smart playlists 2016-06-04 23:30:01 +02:00
ejurgensen
777c0c8d27 Merge pull request #264 from bjoernricks/allow-origin 
Allow to add Access-Control-Allow-Origin header to responses
 2016-06-04 20:19:25 +02:00
Björn Ricks
6b6a1e65e1 Allow to add Access-Control-Allow-Origin header to responses 
Add a new general config setting allow_origin that is included as
Access-Control-Allow-Origin header in http responses. This allows to make http
request against forked-daapd from browsers with enabled CORS
(https://www.w3.org/TR/cors/) via JavaScript XMLHttpRequest.

Per default the setting is not defined and no Access-Control-Allow-Origin header
is included in the response.
 2016-06-02 13:32:41 +02:00
chme
610ae6a048 [commands] Move function documentation to their implementation 
Also adds some aditional code documentation and an attempt at making
command_cb easier to understand
 2016-05-21 07:57:44 +02:00
chme
5dc1cba5c8 On deinit free event base before freeing command base and pipes 2016-05-21 06:48:02 +02:00
chme
6112c38220 [commands] do not cast return of calloc and allocate struct command on 
stack if executed in sync
 2016-05-21 05:59:45 +02:00
chme
3c9a7d9119 [player] Use generic commands for inter thread communication 2016-05-15 08:42:15 +02:00
chme
85d57394e5 [cache] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
dd192bd99c [spotify] Use generic commands util 2016-05-15 08:42:15 +02:00
chme
32944d7273 [worker] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
3823900394 [filescanner] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
4aacf487e8 [mpd] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
9856536fd7 [commands] Add generic functionality for inter-thread communication 
using libevent and pipes
 2016-05-15 08:42:15 +02:00
ejurgensen
1cc4c034d0 [filescanner] Add support for Monkey's audio 2016-05-06 00:30:58 +02:00
ejurgensen
1fbb4b0d59 [transcode] Fix problem for file types where ffmpeg decode returns 0 
It seems ffmpeg/libav reads a file type like Monkey's audio in large
chunks, so that each packet must be passed to the decoder multiple
times. The decoder will return 0 until the packet is completed. This
change makes forked-daapd able to deal with a return value of 0.
 2016-05-06 00:23:07 +02:00
ejurgensen
9a56044c77 [misc] Explicitly check for pthread_setname_np/pthread_set_name_np 
Seems there is no pthread_setname_np in OpenWrt
 2016-05-05 19:39:15 +02:00
ejurgensen
95d0c25be3 [outputs] Forgot an include 2016-05-05 18:49:27 +02:00
ejurgensen
7c68eab11e [streaming] Log error message from write() 2016-05-05 18:48:47 +02:00
ejurgensen
1f10c6a928 [player] Always reselect output devices when they return online 
Consider this use case:
1. Playback stops, device switched off
2. Device switched back on, playback started by user
Before this commit, the device would be unselected when it came back on.
I don't think that is desirable, so with this commit the selection will
stay (except if the device comes back on during playback).
 2016-04-30 23:55:45 +02:00
ejurgensen
960f89fcbd [player] Remove unused var 2016-04-14 10:04:21 +02:00
ejurgensen
ad01d65047 [alsa] Let the user configure an offset to sync audio if required 2016-04-14 09:48:48 +02:00
ejurgensen
e23fed4ac4 [alsa] Avoid call to snd_pcm_prepare if already in the right state 2016-04-14 09:48:48 +02:00
ejurgensen
19181007f4 [alsa] Increase max latency variance 
Latency on the RPi varies quite a bit
 2016-04-14 09:48:48 +02:00
ejurgensen
632bfd9a33 [alsa] Add low-tech sync with the player (and AirPlay) 2016-04-14 09:48:48 +02:00
ejurgensen
eca41e306e [alsa] Try to measure latency 2016-04-14 09:48:48 +02:00
ejurgensen
857055a18d [player] Insert duplicate packets slowly on timer overrun 2016-04-14 09:48:48 +02:00
ejurgensen
084a86597b [laudio] Remove OSS4 support and move dummy output to outputs interface 2016-04-14 09:48:48 +02:00
ejurgensen
1a5e1da9ae [alsa] Fixup of volume return values 2016-04-14 09:48:47 +02:00
ejurgensen
acc1ff4a47 [player] Sort devices and autoselect based on priority 2016-04-14 09:48:47 +02:00
ejurgensen
c5bb83480d [alsa] Add rewritten ALSA to generic outputs interface 2016-04-14 09:48:47 +02:00
ejurgensen
f1fb86e7e1 [raop] Stop writing when a teardown has been requested 2016-04-14 09:48:47 +02:00
ejurgensen
617303d545 [player] Purge laudio from player.c 2016-04-14 09:48:47 +02:00
ejurgensen
36755031cb [outputs] Make a wrapper for mp3 streaming so it can be included in 
the generic outputs interface and so special handling in player.c can
be removed
 2016-04-14 09:48:47 +02:00
ejurgensen
a07c24d625 [player] Fix possible segfault after playback stop on FreeBSD/machines with lo-res timers 2016-04-14 08:55:59 +02:00
ejurgensen
bf27a879df [filescanner] Use libinotify for FreeBSD (should fix issue #245) 
Filescanner was broken in FreeBSD. Besides fixing this, using
libinotify instead of kqueue directly should make the code easier
to maintain, since it will be less divergent.

This commit includes these changes:
- Add libinotify to FreeBSD install scripts
- Fix reading multiple events from inotify fd (possible bug in Linux too)
- Deferred scanning since FreeBSD doesn't have IN_CLOSE_WRITE
- Configure search for inotify library
- Removal of kqueue stuff
 2016-04-12 22:11:56 +02:00
ejurgensen
3be8afac7b [daap] Fix problem where playlists in Remote are not in correct order 
Apparantly having "LIMIT -1 OFFSET 0" makes (certain versions?) of
sqlite3 unable to do the "ORDER BY". Might be a bug in sqlite. This
is only a partial fix, which will work for queries that don't actually
use an index. Those few that do may still be broken.
 2016-04-10 00:11:33 +02:00
chme
7713096d84 [mpd] Return playlists if 'lsinfo' is called without any parameters 2016-04-05 21:04:44 +02:00
ejurgensen
36a9ed8fe8 [raop] Omit timing request source address check 
Creates a problem with ipv6 where the timer request source address may
differ from the address that mdns gave us when we created the seesion.
See https://github.com/mikebrady/shairport-sync/issues/254
 2016-03-29 19:36:40 +02:00
ejurgensen
a22aff5d1f [filescanner] Switch misplaced arguments in process_directories (FreeBSD) 
Should help with issue #239. Also change process_directory so it uses
same argument order as process_directories.
 2016-03-27 20:35:23 +02:00
ejurgensen
42e68311eb [transcode] Increase read timeout slightly 2016-03-25 20:56:08 +01:00
ejurgensen
dbf9a208b8 [dacp] Don't return hard error if queue item goes missing 
Remote doesn't seem to like the 500 Internal error we were sending
if queue item went missing, e.g. during pause.
 2016-03-23 20:38:19 +01:00
ejurgensen
c4713d8b39 [httpd] Improve log message 2016-03-21 19:26:54 +01:00
ejurgensen
7d1d52e8f0 [transcode] Fix missing channel number for newer ffmpeg (closes #241) 2016-03-20 19:22:16 +01:00
chme
1fb1fc7d2d [player] Add config option to disable clearing the queue after playback 
stops (default is clearing the queue) and if true do not clear the
queue.

This option is necessary because some dacp clients rely on the queue
being empty if player is stopped. Retune for example does not always
show the queue contents if player state is stopped.
 2016-03-20 07:45:21 +01:00
chme
e3750957f5 [player] Allow removing by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
ed2fe682fe [player] Allow moving by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
cb919515e4 [dacp] Start playback from selected song in the playqueue if player is 
stopped
 2016-03-19 09:40:36 +01:00
chme
d000ea571b [dacp] Return the playqueue even if player is stopped 2016-03-19 09:40:36 +01:00
chme
07947a526d [mpd] Do not start playback automatically after adding songs to the 
queue
 2016-03-19 09:40:36 +01:00
chme
d35894ac15 [mpd] Return correct item-id for command 'addid' and return correct 
number of items in the queue if player is stopped for command 'status'
 2016-03-19 09:40:36 +01:00
ejurgensen
b454a2fd60 [general] Put back support for platforms without pipe2(), see issue #239 2016-03-17 22:20:16 +01:00
ejurgensen
ec43195633 [alsa] Really don't query snd_pcm_delay() during an underrun 2016-03-17 13:56:15 +01:00
ejurgensen
e65361ba17 [alsa] Don't query snd_pcm_delay() during an underrun 2016-03-17 12:54:17 +01:00
ejurgensen
d2d52c7d68 [alsa] Do not kill threshold, it gives underruns after snd_pcm_prepare() 2016-03-17 12:46:51 +01:00
ejurgensen
8b2c68af0e [alsa] Try to fix issue where devices with small buffers would 
overrun, rendering the device unusable because snd_pcm_writei()
starts blocking. This is just a poor temporary fix until we
either start using SND_PCM_NONBLOCK or put alsa in it's own thread
or implement Pulseaudio...
 2016-03-16 22:54:27 +01:00
ejurgensen
5f3578ec65 [alsa] Some extra logging for debugging 2016-03-15 22:59:12 +01:00
ejurgensen
abce1d0eeb Merge pull request #237 from chme/threadnames 
Set thread names
 2016-03-12 17:18:34 +01:00
chme
98d6db002f Set thread names to make it easier to identify threads during debugging 2016-03-12 14:01:08 +01:00
chme
9a5b67031e [player] Remove unnecessary check for plid != 0 and set plid always to 0 
if queue changed
 2016-03-12 14:01:08 +01:00
ejurgensen
fba6293be6 Merge pull request #238 from chme/spotifyvirtualpath 
[spotify] Add the owner of playlist to the virtual path
 2016-03-12 13:23:47 +01:00
chme
3e8221e377 [spotify] Add the owner of playlist to the virtual path of a spotify 
playlist to avoid duplicate virtual paths
 2016-03-12 13:10:08 +01:00
chme
39c60cb211 [mpd] Fix indentation 2016-03-12 08:27:59 +01:00
chme
cd5aee1595 [mpd] Allways return an error message if mpd command exits with error, 
otherwise the command will lead to a segfault (e. g. calling lsinfo with
a non existent directory path segfaults)
 2016-03-12 08:27:59 +01:00
ejurgensen
598ae1bd71 [chromecast] json-c < 0.11 compability 2016-03-06 21:33:49 +01:00
ejurgensen
bd61399e49 [player] Only catch up by lowering sample rate if data_kind is http or pipe 2016-03-06 10:55:10 +01:00
ejurgensen
4d1a45e5d8 Merge pull request #235 from chme/queuemovefix 
[queue] Fix moving a song to the last position in the queue failed
 2016-03-05 15:04:36 +01:00
chme
1ec7ad683e [queue] Fix moving a song to the last position in the queue failed 2016-03-05 14:26:17 +01:00
chme
167d5117be [spotify] Remove options to exclude starred songs from the artist/album 
override
 2016-03-05 12:55:34 +01:00
ejurgensen
7aba0bf332 [filescanner] Support TDR tag (date released) and parse years better 2016-03-05 00:14:45 +01:00
ejurgensen
1188a79e57 [filescanner] Also set year if date tag present 2016-03-04 22:37:56 +01:00
ejurgensen
cbaea95ff4 [filescanner] Support for songdatereleased and songhasbeenplayed 2016-03-04 22:37:56 +01:00
ejurgensen
7135406531 [filescanner] Log message if user attempts to use LastFM/Spotify on unsupported build 2016-03-03 22:20:13 +01:00
ejurgensen
3000341acd [player] Different timer catch up for files + remove timer abort 
Timer abort should no longer apply since we may catch up for more
than a second. Introduce separate catch up strategies for files and
streams, since for files we can read at our own pace.
 2016-02-28 22:28:37 +01:00
ejurgensen
220494e8b1 Merge pull request #232 from chme/mpdmove 
[mpd] Implement mpd command 'move'
 2016-02-28 20:28:24 +01:00
chme
494a936caa [mpd] Implement mpd command 'move' 2016-02-21 19:01:52 +01:00
chme
c1dcc0a937 [db] Make loading of playlistitem count optional 2016-02-21 18:05:11 +01:00
ejurgensen
29dbc6bd9d [chromecast] Don't set cert file, doesn't seem very portable 2016-02-12 22:04:07 +01:00
ejurgensen
a824f73779 [player] Remove some debug log messages 2016-02-12 22:00:10 +01:00
ejurgensen
00d4148a90 [raop] Move RAOP specific states away from the generic output state enum 2016-02-12 21:59:26 +01:00
ejurgensen
48592406ed [chromecast] Fix probe segfault 2016-02-12 21:26:06 +01:00
ejurgensen
565d29529a [chromecast] Remove log message 2016-02-11 22:54:47 +01:00
ejurgensen
441f36a58b [chromecast] Fix segfault when cleaning up after missing reply 2016-02-11 20:04:30 +01:00
ejurgensen
bd75281340 [player] Save speaker name and rename raop_ to output_ 2016-02-11 20:04:30 +01:00
ejurgensen
93ea34796a [chromecast] Fix typo 2016-02-11 20:04:30 +01:00
ejurgensen
23db4c3f4e [chromecast] Support protobuf v1 2016-02-11 20:04:30 +01:00
ejurgensen
dcdefea721 [chromecast] Don't let a reply timeout crash the callbacks 2016-02-11 20:04:30 +01:00
ejurgensen
f4719e8681 [chromecast] Add a reply timeout so we don't freeze if a response goes missing 2016-02-11 20:04:30 +01:00
ejurgensen
483a428bae [chromecast] Try to improve session handling + actually remove device on mdns cb 2016-02-11 20:04:29 +01:00
ejurgensen
e4d209f8a0 [chromecast] Support for most basic functionality 2016-02-11 20:04:29 +01:00
ejurgensen
7d6c670fee [chromecast] Fix host address, some more commands, add flush timer 2016-02-11 20:04:29 +01:00
ejurgensen
5049426573 [raop] Protect against possible invalid reads in for loops 2016-02-11 20:04:29 +01:00
ejurgensen
ebf2d7722e [chromecast] Fixup cb register error + use actual hostname 2016-02-11 20:04:29 +01:00
ejurgensen
5e239cfbb2 [chromecast] Volume support and fix double free 2016-02-11 20:04:29 +01:00
ejurgensen
153ed98dba [chromecast] Begin adding actual Chromecast support (basic playback) 2016-02-11 20:04:29 +01:00
ejurgensen
cd841ad7b5 [outputs] Reorganise new generic output interface 2016-02-11 20:04:29 +01:00
ejurgensen
233fa24ffd [raop] Fix possibly old "read after free" bug 2016-02-11 20:04:29 +01:00
ejurgensen
ffe8653d9e [chromecast] Remove RAOP specifics from player.c, add generic output interface 2016-02-11 20:04:29 +01:00
ejurgensen
4c887ba7bb [chromecast] First building blocks for supporting ChromeCast 2016-02-11 20:04:29 +01:00
ejurgensen
62eb1a067d [player] Rename ticks to overrun and safeguard against decreasing from 0 2016-02-11 20:02:17 +01:00
ejurgensen
5f5a138c77 [player] Fix for player getting ahead of network streams (issue #218) 
Issue caused stuttering after a few hours. This fix will check if
the player is getting behind the playback timer. Apparently, we
sometimes get samples at a rate slightly below 44100 from network
streams, and then we end up consuming too quickly. This introduces
a way of reducing consumption if that happens.
 2016-02-11 08:29:29 +01:00
ejurgensen
73cddbb9de [transcode] Fix type of stream_index so the tests make sense 2016-02-06 19:51:13 +01:00
ejurgensen
3aab9b2622 Merge pull request #227 from chme/plchangesposid 
[mpd] Implement command 'plchangesposid'
 2016-02-06 13:10:20 +01:00
ejurgensen
e9986e9c9f [filescanner] Remove var not used in FreeBSD section 2016-02-06 11:08:45 +01:00
chme
73d5832d98 [filescanner] Fix use of uninitialized variable 2016-02-06 10:30:10 +01:00
chme
4878dce0b0 [mpd] Implement command 'plchangesposid' 2016-02-06 08:39:01 +01:00
chme
b84df9c5c3 [filescanner] Fix compile error on freebsd 2016-02-06 07:44:19 +01:00
chme
491bf54fdb [directories/spotify] Init db with disabled spotify-root-directory and 
enable only on successful login to spotify
 2016-01-31 08:14:03 +01:00
chme
cd5462e241 [filescanner] attempt at fixing compile errors on freebsd after the 
introduction of the directories table
 2016-01-31 08:14:03 +01:00
chme
8600c21424 [db-upgrade] add column date_released to files table, add column name to 
speakers table
 2016-01-31 08:14:03 +01:00
chme
dcfec5c1d4 [filescanner] Do not process parent directories on inotify callback 2016-01-29 19:29:02 +01:00
chme
9197f0f64b [spotify] fixup - added error handling 2016-01-24 18:59:05 +01:00
chme
1a6565e512 [directories] Initialize root directories on db init 2016-01-24 18:51:22 +01:00
chme
7678f98879 fixup - use sizeof instead of PATH_MAX 2016-01-24 18:51:22 +01:00
chme
c23cbde6ac fixup - remove unused enum, remove unused local variable, remove 
duplicate error log for failure in create_virtual_path, remove
unnecessary empty lines
 2016-01-24 18:51:22 +01:00
chme
171e30aead [mpd] use qualifier in select queries, return error message if an error 
occurs (otherwise this results in a segfault)
 2016-01-24 18:51:22 +01:00
chme
2611d06ab7 [mpd] add support for commands 'listall' and 'listallinfo' 2016-01-24 18:51:22 +01:00
chme
7703a997c4 [db/filescanner/spotify] Replace filelist-view with separate 
directories-table
to increase the performance of the mpd command 'lsinfo'
 2016-01-24 18:51:22 +01:00
chme
3740486348 [db] Move database upgrade logic to separate file 2016-01-24 18:51:22 +01:00
chme
1d69a3de90 [mpd] Add fallback to IPv4 if IPv6 failed 2016-01-24 18:51:22 +01:00
chme
9a1c8409cf [mpd] optimize query selecting files for virtual_path to use the index 2016-01-24 18:51:21 +01:00
ejurgensen
5f2fe87351 [spotify] Move purge so Spotify files get cleared even on empty .spotify (closes #219) 2016-01-17 15:29:31 +01:00
chme
532e9c3a32 [spotify/artwork] Remove spotify songs after playlist update and delete 
cached artwork for removed spotify songs
 2016-01-16 17:02:57 +01:00
ejurgensen
0f58495e0d [cache] Prevent log errors if cache disabled 2016-01-09 01:26:59 +01:00
ejurgensen
d356a0ae5c [spotify] Split artwork_get so we don't wait for artwork callback in the Spotify thread (which might be playing) 2016-01-09 00:36:30 +01:00
ejurgensen
22a1e16c12 [artwork] Move timebase back, it must be set for the AVCodecContext for libav (and older versions of ffmpeg?) 2016-01-07 23:42:27 +01:00
ejurgensen
3a31074c07 [spotify] Increase artwork timeout slightly 2016-01-07 23:11:19 +01:00
ejurgensen
1b24a86169 [artwork] Tidy up artwork.c and handle remaining ffmpeg deprecated warning 2016-01-07 22:48:04 +01:00
ejurgensen
89e3864035 [spotify] Wait for Spotify artwork now that the worker gets artwork async for the player thread 2016-01-07 22:25:25 +01:00
ejurgensen
d56576094a [artwork] Do like libav says: "Using AVStream.codec.time_base as a timebase hint to the muxer is deprecated. Set AVStream.time_base instead." 2016-01-06 23:02:43 +01:00
ejurgensen
1f1d79025d [artwork] Keep a raw Spotify source image in case rescaling is not required 2016-01-06 22:39:32 +01:00
ejurgensen
0d55e055c0 [ffmpeg] Update most deprecated functions 2016-01-05 23:22:01 +01:00
ejurgensen
7caf8cc66a [artwork] Add ability to rescale Spotify (should improve caching so we don't save too large images) 2016-01-05 21:44:44 +01:00
ejurgensen
9a0a390a73 [artwork] Get rid of legacy libav/ffmpeg support in artwork.c 2016-01-03 12:24:21 +01:00
ejurgensen
c3d9f65f8b [artwork] Adjust existing code to new structure 2016-01-03 12:24:20 +01:00
ejurgensen
238ee3c122 [artwork] Refactor artwork to make it easier to add new backends (WIP) 2016-01-03 12:24:20 +01:00
ejurgensen
599fb20e0b [cache] Fix return values in cache_artwork_get_impl 2016-01-03 12:24:20 +01:00
ejurgensen
6cabbc4ab7 [httpd] Add fallback to IPv4 if v6 fails 2015-12-21 21:52:21 +01:00
chme
32e1923b39 [mpd] make global event_base static 2015-12-19 09:09:50 +01:00
chme
3b7e1b2737 [mpd] Add missing close for command pipe on deinit 2015-12-19 08:46:38 +01:00
ejurgensen
e8ea00896d [listener] Fix #205 where listener_remove could break the linked list and orphan some cb's 2015-12-16 23:16:58 +01:00
ejurgensen
6e58af75cf [http_daapd] Add option to hide albums/artists with just one track 2015-12-12 23:28:48 +01:00
chme
40da57346f [mpd] fix duplicate return of 'nextsong', 'nextsongid' and return 
item-id as 'nextsongid'
 2015-12-12 09:26:55 +01:00
chme
6d1d2a485c [mpd] fix seek command 
Compare the position of the song to be seeked with the position of the
current playing one
 2015-12-12 09:26:44 +01:00
ejurgensen
93a6765c8c [transcode] Fix freeze problem where av_read_frame would block on broken connections 2015-12-09 20:00:09 +01:00
ejurgensen
100cecce3f [mpd] Add missing db_query_end (was causing database locks) 2015-12-06 20:22:12 +01:00
ejurgensen
d43b306212 [config] Change ipv6 default to enabled 2015-12-03 22:08:55 +01:00
ejurgensen
7a4ce2f68d [http] Title and artist were swapped when reading ICY packet metadata 2015-11-29 00:55:30 +01:00
chme
b2d2e9286f [mpd] implement range support for 'delete' command 2015-11-22 12:06:01 +01:00
chme
6d720dec94 [queue] Ignore moving an item to its current position (would results in 
an invalid queue)
 2015-11-22 07:08:59 +01:00
chme
8fc8d08b42 [player] Add missing notification of playlist changes after removing an 
item from the playlist
 2015-11-21 14:23:06 +01:00
chme
10fceb6d3f [mpd] Fix segfault executing "decoders" command 2015-11-21 14:23:06 +01:00
ejurgensen
9cc4927d50 Merge pull request #198 from chme/mpdzeroconf 
[mpd] Announce mpd support with avahi/zeroconf
 2015-11-07 08:11:32 +01:00
chme
2195db0800 [mpd] Announce mpd support with avahi/zeroconf 2015-11-06 19:50:18 +01:00
chme
461a956288 [mpd] Return the correct values for number of songs, artists, albums and 
song length sum in the "stats" command (wrong values are still reported
for uptime, db_update and playtime)
 2015-11-06 19:11:00 +01:00
chme
0e0fbd006f [queue] fix segfault if query for queue-items returned an empty result 
set

This happen for example if a wrong path is passed in "mpc add
[virtual_path]"
 2015-11-01 12:47:04 +01:00
chme
350944cddd [mpd] fix seekid command 
Seeking with the seekid command for the currently playing item got
broken after introducing the item-id (comparison of item-id passed from
client to db-id)
 2015-11-01 12:06:18 +01:00
chme
7b5c80acf4 [queue] If the playing item is not in the queue anymore, the next item 
should be the first item in the queue

This solves the problem that after clearing the queue and adding new
items while playing, aborts playback when skipped to the next item.
 2015-11-01 11:59:39 +01:00
chme
abc689a7e1 [mpd] fix sort in queue after adding songs with findadd and searchadd 
commands

Always add songs sorted by artist, album, disc, track. Adding by title
is almost never the expected order of songs.
 2015-11-01 11:46:54 +01:00
chme
d0232a2315 [mpd] Return playlists if lsinfo is called with an empty path (same 
handling as if the path is the root directory "/")
 2015-10-31 12:53:52 +01:00
ejurgensen
316af87189 Merge pull request #193 from chme/mpd 
[mpd] Add support for moveid and close command
 2015-10-31 11:31:27 +01:00
ejurgensen
6ba350e406 Merge pull request #192 from chme/history 
[dacp] Fix playing from history for Remote
 2015-10-31 11:31:10 +01:00
chme
ba63157429 [mpd] Add 'close' command (ignore the command and does not send a 
response)
 2015-10-31 07:56:52 +01:00
chme
f9c6aa6c48 [mpd] Implement command moveid (movings items in the queue by item-id) 2015-10-31 07:56:51 +01:00
chme
1c409846d5 [player/queue] Add player commands to move queue-items by item-id 2015-10-31 07:56:50 +01:00
chme
c2ba2f6779 [dacp] Fix playing from history for Remote 2015-10-31 06:18:05 +01:00
ejurgensen
7894a4d85f [transcode] Don't push NULL frames to filtergraph when flushing, can lead to segfault 2015-10-25 19:59:06 +01:00
chme
94895b8eed [player] if source is not pausable (http-streams or pipe) abort playback 
on pause command 

This restores the behaviour before the queue/player-refactoring.
 2015-10-25 09:00:47 +01:00
ejurgensen
43893dff48 Merge pull request #189 from chme/mpd 
Fix item-id in mpd commands "playlistid", "playlistinfo", "plchanges"
 2015-10-24 09:05:58 +02:00
chme
51eb423065 [mpd] Fix item-id in playlist items 2015-10-24 06:06:24 +02:00
ejurgensen
3e80e5c517 [transcode] Don't pass error to player on eof + some comments and cleaning 2015-10-22 22:09:19 +02:00
ejurgensen
e20d2c544d [transcode] Comments and raise MAX_BAD_PACKETS to 5 2015-10-22 21:01:43 +02:00
ejurgensen
058b2fb0d6 [transcode] Improve decoding to allow for decoder special cases, like decoders not processing 
entire packets, rejecting packets and not returning frames. Should fix issue with network
streams not opening.
 2015-10-21 23:53:21 +02:00
ejurgensen
9853b8f9bd Merge pull request #188 from chme/playerfixes 
Playerfixes
 2015-10-19 22:15:43 +02:00
chme
551f441273 [dacp] Fix playing from playspec request 2015-10-19 21:55:43 +02:00
chme
7592462571 [player] Fix segfault if reading from source failed for all queue items 2015-10-19 21:33:43 +02:00
ejurgensen
55104015e0 Full removal of libevent 1 legacy code. Also drop pipe() in FreeBSD, since pipe2 is available now. 2015-10-19 21:15:29 +02:00
chme
48691748cd [mpd] fix log message if binding of artwork http server failed 2015-10-18 14:25:29 +02:00
ejurgensen
2a610812a5 Refactor transcode.c so it can actually transcode + use new capability to support mp3 streaming. 
Also includes the skeleton for perhaps supporting video in the future. Adds more fine-grained
ffmpeg/libav compability checks. Dependency on libavresample/libswresample exchanged with
dependency on libavfilter, which seems more versatile.
 2015-10-09 23:58:27 +02:00
James Le Cuirot
7cf35d1e8b
Allow ANTLR 3.5 to work 
This involves a harmless backwards-compatible adjustment to the
grammar. I can't explain why this is necessary but this might help.

http://stackoverflow.com/questions/20057063/follow-set-in-is-undefined-in-generated-parser
 2015-10-05 23:10:45 +01:00
chme
199b765a7d [player] Store item-ids in history to allow start of playback from the 
previously played items in dacp
 2015-10-04 08:05:37 +02:00
chme
b19a7280b9 [player] remove unused player_queue struct 2015-10-04 08:05:37 +02:00
chme
fbce3a7d57 [player] Confusing naming of ids cleaned up 2015-10-04 08:05:37 +02:00
chme
ba3385b0ec [queue] Remove queue_info and queue_item_info structs 2015-10-04 08:05:37 +02:00
chme
35df9455b9 [queue] Fix memory leak in queue_make_item 2015-10-04 08:05:36 +02:00
chme
100e08da9d Rename make_queue functions 2015-10-04 08:05:36 +02:00
chme
064dfef2de [player] cleanup metadata_trigger 
metadata_trigger is always called for the current streaming item and
source_open makes sure that the stream_start and output_start values are
set correctly
 2015-10-04 08:05:36 +02:00
chme
64698eb3a4 [player] Some minor cleanup (error handling, comments) 2015-10-04 08:05:36 +02:00
chme
a06424a701 [mpd] Expose queue-item-id instead of dbmfi-id in mpd commands 
[player] Reshuffle on end of playlist and repeat mode is "repeat all"
 2015-10-04 07:59:58 +02:00
chme
cb2805800b [player] Fix segfault if pause requested in the last two seconds of the 
last item in the playqueue (cur_streaming is already NULL)
 2015-10-04 07:59:58 +02:00
chme
2b037b67d9 [player] Combine stream_stop and stream_cleanup into one function 2015-10-04 07:59:58 +02:00
chme
e44a160b9a [player] Improve error handling 2015-10-04 07:59:58 +02:00
chme
4595a2f4a6 [player] Add missing metadata trigger on item change (after eof) 2015-10-04 07:59:58 +02:00
chme
c8a61015fc [dacp] Fix playing of radio streams after queue refactoring 2015-10-04 07:59:58 +02:00
chme
f4faac3cc8 [spotify] Remove duplicate method "resume" in favor of "play" 2015-10-04 07:59:58 +02:00
chme
58069e67f8 [player/spotify] adjust spotify integration to refactoring of player 2015-10-04 07:59:58 +02:00
chme
e1147c00a1 [player] Refactor player to better fit the queue refactor 2015-10-04 07:59:58 +02:00
chme
1f53d7ab1a [queue] Refactor queue handling 
Decouple the playing/streaming item from the queue. Move all queue
related functions to seperate file queue.h/c.
Introduce internal item "head" to make iterating over the play-queue and
shuffle-queue easier.
 2015-10-04 07:59:57 +02:00
chme
10d7097f98 [player] rename "queue_*"-functions to "playerqueue_*" (avoid naming 
conflicts with later introduced separate queue file
 2015-10-04 07:57:39 +02:00
chme
1fbedaa54f [player] Refactor queue_get 2015-10-04 07:57:38 +02:00
chme
f0a6a48599 [player] Refactor queue_remove functions 2015-10-04 07:57:38 +02:00
chme
8e1834cdea Rename make_queue function and set as static 2015-10-04 07:57:38 +02:00
chme
1812848ee1 Move client protocol specific make_queue functions out of player.c/h 2015-10-04 07:57:38 +02:00
ejurgensen
cba9bc05e9 Expire sessions without strict timeout (closes #163) 2015-10-03 10:00:42 +02:00
ejurgensen
ebba164a0d Change MPD deinit position so it matches the init order, and so it will not get called if httpd fails to start 2015-09-29 23:14:44 +02:00
ejurgensen
5125e24cfe Let db_build_query_index_clause() always return an initialized idx, even on failure 2015-09-29 22:51:23 +02:00
chme
cf70c514b6 Fix memory leak if index clause is used 2015-09-29 22:43:32 +02:00
chme
a1e2f53ab1 Fix memory leak if index clause is used 2015-09-29 22:42:53 +02:00
chme
0245813d34 Fix memory leak when parsing smart playlists 2015-09-29 22:42:30 +02:00
chme
1ed240d92c Fix memory leak due to missing free for evconnlistener 2015-09-29 22:42:09 +02:00
ejurgensen
6c26d87997 Make some global vars in lastfm.c static 2015-09-28 21:22:51 +02:00
ejurgensen
4db6318a82 Fix issue where volume gets set to -1 on startup of raop devices 2015-09-27 15:24:04 +02:00
ejurgensen
50bcdd2551 Plug minor memleaks in cache.c 2015-09-23 22:29:17 +02:00
ejurgensen
294d7a270f Protect against possible segfault if the artwork pixel format is unknown 
- thank you groinwood for reporting this bug
 2015-08-24 21:27:55 +02:00
ejurgensen
317ad2ba41 Always treat podcasts, audiobooks and compilations as audio, even if video stream is present 2015-08-05 22:36:28 +02:00
ejurgensen
68912efa1f Enable resuming playback from saved position for certain media kinds (eg audiobooks) 2015-08-04 22:33:32 +02:00
ejurgensen
7881df67f6 Hack to push live ICY metadata/artwork to remote clients 2015-07-31 14:43:22 +02:00
ejurgensen
1fe6521aff Remove libevent 1 support in httpd_dacp 2015-07-30 22:50:11 +02:00
ejurgensen
3ba76e8f40 Remove libevent 1 support in httpd_daap 2015-07-29 23:05:47 +02:00
ejurgensen
7e9cf80ec0 Reorganize configure.ac according to subject (and my taste) 2015-07-21 23:00:55 +02:00
ejurgensen
bf72547b9b Drop legacy FLAC, Musepack and WMA file scanners (ffmpeg/libav can do this now) 2015-07-21 22:16:50 +02:00
chme
c6851eac9b [mpd] use the same image size as in raop_metadata_prepare (max 600x600) 
to increase artwork cache hits
 2015-07-18 07:34:48 +02:00
chme
1ab318d725 [mpd] support serving artwork over http 2015-07-18 07:17:21 +02:00
ejurgensen
d870b97142 Remove LastFM thread now that it can run from the worker thread 2015-06-27 23:24:07 +02:00
ejurgensen
b6703ab7cd Don't retrieve ICY StreamUrls without jpg/png extension (don't want to risk initiating a major, useless download) 2015-06-20 23:11:18 +02:00
ejurgensen
ec0ba2c5fa Fix problem where the http client would ignore the last line in a m3u because of missing CRLF (issue #169) 2015-06-18 23:03:11 +02:00
chme
ceca9135c5 [mpd] add special handling to command "lsinfo" if the root directory was 
passed as argument.

Clients like ympd and ncmpcpp are relying on this (deprecated) behavior
 2015-06-14 07:11:17 +02:00
chme
b9b3671d58 [mpd] add support for command "decoders" 2015-06-14 07:11:17 +02:00
chme
426e827712 [mpd] Return whole queue for command "playlistinfo" if given argument is 
-1 (not a valid position in the queue)
 2015-06-13 14:38:56 +02:00
ejurgensen
879c2ef350 Avoid cache regeneration triggering during db_query_run (in case the query is long running, like db_files_update_songalbumid might be) 2015-06-08 23:07:56 +02:00
ejurgensen
335517a2e8 Prevent this database deadlock: 
1. bulk scan begins transaction, locking the db
2. cache regeneration is triggered, but waits for db to unlock
3. bulk scan calls cache_artwork_ping, which can't return because cache thread is waiting
-> scan thread is waiting for cache thread, which is waiting for scan thread
 2015-06-08 22:24:33 +02:00
ejurgensen
4fffc057b6 Change queue_remove() to fix segfault because source_head/shuffle_head could become invalid, and to protect against invalid input in general (ref issue #160). 
Also try to failsafe source_position() and implement next_ps() all around.
 2015-06-08 00:21:49 +02:00
ejurgensen
3dde23e060 Include terminating null in u8_normalize - not necessary now, but just to be safe 2015-06-06 14:47:54 +02:00
ejurgensen
6224fdb025 UTF-8 conversion was returning string without null termination (thank you @stephan-01010011, ref pr #168) 2015-06-06 14:22:24 +02:00
ejurgensen
a9437acc1a Rework pr #162 to avoid mem leaks and string termination problems 2015-06-05 23:55:57 +02:00
ejurgensen
7d231b992b Fix typo 2015-06-04 22:17:49 +02:00
ejurgensen
cd14522915 Swap misplaced args in db.c 2015-06-04 22:10:30 +02:00
ejurgensen
271c5ff344 Change DB upgrade from v18->v19 to v18->v18.01 2015-06-04 21:58:01 +02:00
chme
7cd96690c0 Remove file extension for playlists from virtual_path during scan and 
update db to v19 removing the file extensions from the stored playlists

An existing file extension in the virtual path leads to wrong entries in
MPDroid (and mpd does also not return the file extension).
 2015-06-04 08:11:46 +02:00
ejurgensen
3655e26703 Code style 2015-06-02 23:10:04 +02:00
ejurgensen
64ef66f030 Merge pull request #162 from stephan-01010011/master 
Fixed bug that caused icy header metadata to be not correctly encoded
 2015-06-03 00:05:56 +03:00
ejurgensen
7a0dfef136 Add sub-sorting when sort=artists, because otherwise Tunesremote SE will not play the artist's tracks in proper order 2015-06-01 23:36:16 +02:00
stephan-01010011
32727bd296 Fixed bug that caused icy header metadata to be not correctly 
encoded/converted. Characters above x7F were replaced by '?' character
although the rfc defines a ISO−8859−1 encoding for descriptive
field-content.

According to rfc2616 the field-content is defined as follows:
<the OCTETs making up the field-value and consisting of either *TEXT or
combinations of token, separators, and quoted-string>
The TEXT rule is only used for descriptive field contents and values
that are not intended to be interpreted by the message parser. Words of
*TEXT MAY contain characters from character sets other than ISO- 8859-1
only when encoded according to the rules of RFC 2047.

In the previous implementation the icy metadata was converted based on
fromcode "ascii".

Following incoming icy header field-values should be encoded as
"ISO−8859−1" before adding them to the metadata structure.

- misc.c unicode_fixup_string enhanced by an additional parameter to
define the fromcode
- misc.h unicode_fixup_string prototype updated
- filescanner.c function fixup_tags updated to stay compatible to the
previous implementation using fromcode "ascii"
- db.c function unicode_fixup_mfi updated to stay compatible to the
previous implementation using fromcode "ascii"
- http.c function metadata_header_get enhanced to encode the header
field-content as "ISO−8859−1" to comply with rfc2616
 2015-05-31 14:05:31 +01:00