Commit Graph

2913 Commits

Author SHA1 Message Date
ejurgensen
94a55d9fc9 [scan] readdir_r deprecated, use readdir instead 2016-11-19 23:50:14 +01:00
ejurgensen
bdd6bab982 [-] Lots of housekeeping thanks to scan-build and input from @acmay 2016-11-19 23:08:50 +01:00
ejurgensen
8525c278ec [http] Fix crash with URLs without any "." chars in the path (issue #311, @credit acmay) 2016-11-17 19:24:55 +01:00
ejurgensen
bb2a73ddab [spotify] Keep saved tracks through restarts + misc fixing up 2016-11-13 22:13:35 +01:00
chme
2c801ca6db [db] Small code improvements (avoid hard coded values in query strings) 2016-11-12 12:35:22 +01:00
chme
6690ba32eb [player/transcode/httpd] Pass path, data_kind and song_length to
transcode_decode_setup/transcode_setup
2016-11-12 09:11:40 +01:00
chme
477088a36c [player/pipe] Only pass path to pipe_setup 2016-11-12 09:11:40 +01:00
chme
2db3318ce7 [player/spotify] Only pass spotify-path to spotify_playback_setup 2016-11-12 09:11:40 +01:00
ejurgensen
3040346a65 [spotify] Use Spotify OAuth and web api to get saved tracks/albums 2016-11-05 13:44:23 +01:00
ejurgensen
8c0db10e67 [http] Move Curl https client from lastfm to http so it is available for other modules 2016-11-05 13:43:35 +01:00
ejurgensen
575b6e13a8 [httpd] Hooks for OAuth user interface and callbacks 2016-11-05 13:38:15 +01:00
ejurgensen
807951976c [configure/mdns] Register CNAME forked-daapd.local + generalize CURL detection in configure.ac 2016-11-05 13:33:30 +01:00
ejurgensen
90ecc61ed7 [mdns] CNAME record so we have fixed uri for OAuth redirects
- also refactor mdns_avahi
2016-11-05 13:31:13 +01:00
ejurgensen
33c22a59b9 Merge pull request #304 from chme/cleanup
Minor cleanup of mdns and dacp
2016-11-04 19:17:17 +01:00
chme
eddab1f1c0 [dacp] Use correct log domain 2016-11-04 19:10:07 +01:00
chme
b75c07625c [mdns] Use %zu for size_t in printf (removes warning about wrong
argument type)
2016-11-04 19:09:59 +01:00
chme
f326cae142 [db] Remove duplication of db schema version 2016-11-04 14:31:15 +01:00
chme
f7aa3c225b [db] Move initialization of new db into its own file (db_init.c) 2016-11-04 14:31:15 +01:00
ejurgensen
91c3eb622c [mdns] Put the record browser back
We need to browse through all records so that we can filter out link-local that Avahi sometimes gives us
2016-10-31 22:04:27 +01:00
ejurgensen
087bc942ec Merge pull request #299 from chme/pipeoutput
Fifo output
2016-10-31 19:07:37 +01:00
chme
4f2d994151 [outputs] Remove unused old alsa output 2016-10-31 18:47:45 +01:00
chme
65732ccaf6 [outputs] New output type 'fifo' 2016-10-31 18:47:45 +01:00
ejurgensen
be6580d23e [mdns] Also ignore ipv4 link-local announcements 2016-10-30 20:04:08 +01:00
chme
60f9c779b6 [mpd] Add new command 'outputvolume' to set volume for a specific output 2016-10-25 22:40:48 +02:00
chme
bdb2c74934 [player/dacp/mpd] Pass absolute volume to speaker enumerate callback and
add absolute volume to mpd 'outputs' command
2016-10-25 22:40:48 +02:00
ejurgensen
a549f81861 [filescanner] Make for filetypes_ignore work for known file types as well 2016-10-25 09:08:56 +02:00
ejurgensen
bc1fb4b385 [mdns] Ignore ipv6 link-local mdns announcements 2016-10-23 23:27:34 +02:00
chme
39314c1560 [mpd] Do not treat playback_start return value > 0 as an error 2016-10-23 08:25:19 +02:00
chme
3981c67e3a [player] Do not execute the bottom half if playback_start is called
while player is already playing (results in s segfault after adding new
items through dacp clients)
2016-10-23 08:25:19 +02:00
chme
16149d5c61 [command] Only execute "bottom half" function if main command function
returns 0
2016-10-23 08:25:19 +02:00
ejurgensen
c0d07ae93b [httpd] Allow HEAD for evhttp requests just to be safe 2016-10-21 23:06:00 +02:00
ejurgensen
2ce1c8d28f [httpd] Enable OPTIONS for evhttp (if CORS headers are enabled) 2016-10-19 21:22:14 +02:00
ejurgensen
54a09fce63 [httpd] Add requirement for Access-Control-Request-Method for preflight CORS 2016-10-19 17:29:22 +02:00
ejurgensen
57945a592c [httpd] Reply to CORS preflight requests 2016-10-18 23:04:51 +02:00
ejurgensen
c44f4310b7 [httpd] Replace evhttp_send_error with the httpd_send_error wrapper 2016-10-18 22:45:22 +02:00
ejurgensen
fe7373e442 [httpd] Implement httpd_send_error, a modified evhttp_send_error, which
can include CORS headers (credit @bjoernricks and libevent)
2016-10-17 23:08:02 +02:00
ejurgensen
40c49f1fde [httpd] Use httpd_send_reply() wrapper in httpd_*, dmap_common and mpd 2016-10-17 22:25:31 +02:00
ejurgensen
e1cfccbce7 [httpd] Exchange evhttp_send_reply with httpd_send_reply in httpd.c 2016-10-17 22:14:10 +02:00
ejurgensen
0b29b4368d [httpd] Enable CORS headers by default (Access-Control-Allow-Origin: *) 2016-10-17 22:03:32 +02:00
ejurgensen
7dc2a46261 [cache] Save daap replies gzipped - should improve performance 2016-10-17 19:40:25 +02:00
ejurgensen
249d923af2 [httpd] Allow caller of httpd_send_reply to avoid gzipping 2016-10-17 14:18:13 +02:00
ejurgensen
d8696e72ea [httpd] Don't gzip small messages 2016-10-17 14:09:16 +02:00
ejurgensen
f7185db035 [httpd] Reduce memcpy when gzipping a response 2016-10-16 23:36:27 +02:00
ejurgensen
0c6af89807 [raop] Just remove ipv6 address if we can't connect with the one avahi gave us 2016-10-15 19:14:01 +02:00
ejurgensen
03513c56a8 [mdns] Simplify avahi implementation, e.g. drop record browser
- record browser and link level filtering doesn't seem required (I may regret this...)
- fix cast.c so it does not browse for ipv6 when disabled
2016-10-15 19:12:56 +02:00
ejurgensen
1e3df5ba52 [-] Add forgotten type in err2str() 2016-10-11 21:32:16 +02:00
ejurgensen
94e133e8dc [raop] Temporary fix for issue #293 2016-10-09 00:42:48 +02:00
ejurgensen
9a997551a2 [pulseaudio] Remove PA_STREAM_ADJUST_LATENCY - seems we then get a better match with the requested value 2016-10-08 21:40:49 +02:00
ejurgensen
9bd2ef4f42 [pulseaudio] Misc improvements
- Set volume on stream startup
- Change cleanup on server exit
- README update
2016-10-07 22:35:04 +02:00
ejurgensen
8b842b18d5 [pulseaudio] Add start/stop, config latency, avoid underruns when pausing and misc 2016-10-06 23:35:09 +02:00
ejurgensen
a0dfb5c93e [pulseaudio] Under/overrun detection + request 2 sec latency 2016-10-05 21:13:26 +02:00
ejurgensen
bc8c77c0d1 [pulseaudio] Go full async + some cleaning up 2016-10-05 08:53:14 +02:00
ejurgensen
a03bc2a4e2 [commands] A bit of cleanup 2016-10-02 22:05:53 +02:00
ejurgensen
8f6033e787 [pulseaudio] More logging 2016-10-02 18:48:00 +02:00
ejurgensen
07efdfe24e [pulseaudio] Drop autostarting again, won't work when running as non-root 2016-09-28 21:17:34 +02:00
ejurgensen
44ad4a8848 Merge branch 'autopulse' 2016-09-26 21:32:27 +02:00
ejurgensen
ac9900ff1a [pulseaudio] Modification of f202b5d: Now always try to start Pulseaudio 2016-09-26 20:48:00 +02:00
ejurgensen
89e3f05585 Merge pull request #288 from pcoultha/mixer_device
[ALSA] Add mixer_device configuration file option for ALSA
2016-09-26 00:11:28 +02:00
Pat Coulthard
ae79800493 Add mixer_device configuration file option for ALSA
Support a separate mixer_device configuration file option for
advanced ALSA configurations. Previously, ALSA local output
happened to work becasue "default" is valid as both a PCM and a
mixer. Now you can separately specify the device name for PCM
output and mixer operations.

In my setup, I am using the following setup:
card = "default:CARD=NVidia"
mixer = "Front"
mixer_device = "hw:CARD=NVidia"
2016-09-25 15:52:15 -05:00
ejurgensen
b3a1e744d6 [player] Fix possible segfault on http timeouts
Cause: 1) av_read_frame blocks and times out, 2) cur_streaming gets set to NULL, 3) playback timer callback where cur_streaming gets deref
2016-09-25 22:19:59 +02:00
ejurgensen
e5d328061b [logger] Be better at logging ffmpeg/libav error messages 2016-09-25 22:01:07 +02:00
ejurgensen
f202b5d2e9 [pulseaudio] Try to spawn Pulseaudio if it doesn't by itself
Requiring the user to set up Pulseaudio in system mode is not optimal. This
would, however, be required especially on headless systems. This is the
sledgehammer alternative to starting Pulseaudio.
2016-09-20 22:17:29 +02:00
ejurgensen
9355015b3c [main] Use waitpid instead of obsolete wait3 2016-09-20 22:17:04 +02:00
ejurgensen
ac290b8b65 [player] Config option to disable speaker autoselection (closes #282) 2016-09-10 23:26:06 +02:00
ejurgensen
3d6d4e8521 [config] Print build info in the log 2016-09-07 22:18:29 +02:00
ejurgensen
d66a130064 [lastfm] Also scrobble after regular daap streaming
Ref https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813940
2016-09-02 21:52:45 +02:00
ejurgensen
7f0d34d4e1 [pulseaudio] Remove temp log messages 2016-08-29 21:56:05 +02:00
ejurgensen
7af9c25964 Merge branch 'pulseaudio1' 2016-08-28 22:37:41 +02:00
ejurgensen
1d862dd701 [pulseaudio] Extra state check when changing volume 2016-08-28 22:33:58 +02:00
ejurgensen
4318aa19b5 [commands] Update comment 2016-08-25 23:07:43 +02:00
ejurgensen
fa6c6a1832 [pulseaudio] Kill sessions if context becomes invalid 2016-08-25 22:31:25 +02:00
ejurgensen
84a5772439 [Pulseaudio] Implement flush, avoid adding known sinks and misc fixing up 2016-08-24 23:06:25 +02:00
ejurgensen
9b243f855a [pulseaudio] Support for setting volume 2016-08-24 21:23:33 +02:00
ejurgensen
998ae31a56 [cast] Fixup switched format strings 2016-08-22 21:22:47 +02:00
ejurgensen
202d9b951e [cast] Use proper print formats for size_t 2016-08-22 21:18:24 +02:00
ejurgensen
da8fa6a686 [cast] Just run empty callback on last request to time out. Running more is unsafe since the first is likely to free the session. 2016-08-13 23:33:06 +02:00
ejurgensen
61457f2a09 [cast] Change how we read from TLS and fix bug due to masking of negative enum, ref issue #270 and #275
(should have been two commits...)
2016-08-13 23:31:41 +02:00
ejurgensen
8a9d8c31da [alsa] Remove risky negative enum (risky when AND'ing with ALSA_F_STARTED) 2016-08-13 17:08:14 +02:00
ejurgensen
d3db30e46d [smartpl] Add smart playlist support for file modification time 2016-08-13 16:53:09 +02:00
chme
1238fe124a [commands] Stop command execution, if command function returns an unkown
command state
2016-08-06 06:50:27 +02:00
chme
da83af04e2 [player] Fix return value in repeat_set if repeat mode did not change 2016-08-06 06:36:42 +02:00
chme
30d43bef4f [player] Fix return value in volume_setrel_speaker if device is not
selected
2016-08-06 06:34:34 +02:00
chme
2ae94e8f82 [player] Fix return value in playback_prev_bh if source_open failed 2016-08-06 06:31:09 +02:00
chme
cd9a3bae07 [player] Fix return value in playback_start_item if source_open failed 2016-08-06 06:29:55 +02:00
chme
21d2c95eeb [spotify] Fix return of playback_eot if spotify returns an error 2016-08-06 06:26:38 +02:00
chme
388c5f4311 [filescanner] Fix building directory structure with trailing '/' (second
attempt)
2016-08-01 21:27:05 +02:00
ejurgensen
cbc3323111 [cast] Try to fix issue #270 by making a GET_STATUS if the normal reply to a LAUNCH does not arrive 2016-08-01 09:05:09 +02:00
ejurgensen
306dd47f1e [cast] Fix for issue #275 where gnutls returns the 4 byte prefix of
a Chromecast response together with the response message itself
2016-08-01 00:12:08 +02:00
ejurgensen
187ed6c1f7 [cast] Log raw replies when in DEBUG_CONNECTION mode 2016-07-31 23:36:27 +02:00
ejurgensen
1e02dc51fd [mpd] Modify output enum logging to show shortid as well 2016-07-31 23:28:03 +02:00
ejurgensen
561228d9f7 [misc] Add missing const qualifier 2016-07-31 23:27:57 +02:00
chme
cebf07b2f8 [filescanner] Fix building directory structure with trailing '/'
Library directories with a trailing '/' (like '/srv/music/') lead to an
unbrowsable directory structure. The trailing '/' resulted in an update
to the library directory in the directories table with a parent_id
pointing to itself.
2016-07-31 07:41:11 +02:00
chme
595f7c6091 [mpd] Fix copy/paste error in log message 2016-07-30 08:33:23 +02:00
chme
e6b53cb88e [mpd] Fix mpd command 'playid' if player is already playing
While playing issueing command 'playid' starts playback of the song with
the given item-id (if this song is already playing, it starts from the
beginning).
2016-07-30 08:33:22 +02:00
chme
9af09c204d [mpd] Fix mpd command 'play' if player is already playing
While playing issueing command 'play' with a songposition -1 does noting
in mpd, with songposition > 0 it starts playback of the song at this
position (if this song is already playing, it starts from the
beginning).
2016-07-30 08:31:54 +02:00
ejurgensen
db6823d676 [pulseaudio] Support for adding/removing sinks 2016-07-30 00:05:32 +02:00
ejurgensen
ed03c90916 [mpd] Fix typos 2016-07-29 19:26:46 +02:00
ejurgensen
4399466f21 [pulseaudio] Friendly naming of sinks in speaker list 2016-07-21 23:15:06 +02:00
ejurgensen
eb40415348 [pulseaudio] A bit of renaming 2016-07-21 22:31:39 +02:00
ejurgensen
5b67f84855 [pulseaudio] First draft 2016-07-21 22:13:32 +02:00
Björn Ricks
382459ce9b Allow anonymous access to /content-codes url
The content-codes url provides a mapping of dmap content codes to names, it's
types and sizes. It doesn't contain any private information and therefore should
be available to anonymous users too.
2016-07-13 19:52:58 +02:00
ejurgensen
d3078c6534 [remote] Increase pairing success log level 2016-07-10 20:38:03 +02:00
ejurgensen
a99d1b2038 [db] Add song_length to group info (fixes #265) 2016-06-11 23:10:13 +02:00
ejurgensen
547783d008 Merge pull request #268 from chme/threadexit
Refactor thread exit handling
2016-06-11 22:57:09 +02:00
chme
c0c6cca79f [commands] Add some code comments 2016-06-11 10:56:27 +02:00
chme
32ac6c2ea9 [commands] Rename commands_cmdloop_break to commands_base_destroy and
free commands_base after breaking the libevent loop
2016-06-11 10:56:27 +02:00
chme
a9a656042b [player] Cleanup: player clock is the only sync-source available 2016-06-11 10:37:09 +02:00
chme
5258ee712c [commands] Added functionality to break the event loop of a command base 2016-06-11 09:52:31 +02:00
ejurgensen
3527113a9b [filescanner] Option to import iTunes smart playlists 2016-06-04 23:30:01 +02:00
ejurgensen
777c0c8d27 Merge pull request #264 from bjoernricks/allow-origin
Allow to add Access-Control-Allow-Origin header to responses
2016-06-04 20:19:25 +02:00
Björn Ricks
6b6a1e65e1 Allow to add Access-Control-Allow-Origin header to responses
Add a new general config setting allow_origin that is included as
Access-Control-Allow-Origin header in http responses. This allows to make http
request against forked-daapd from browsers with enabled CORS
(https://www.w3.org/TR/cors/) via JavaScript XMLHttpRequest.

Per default the setting is not defined and no Access-Control-Allow-Origin header
is included in the response.
2016-06-02 13:32:41 +02:00
chme
610ae6a048 [commands] Move function documentation to their implementation
Also adds some aditional code documentation and an attempt at making
command_cb easier to understand
2016-05-21 07:57:44 +02:00
chme
5dc1cba5c8 On deinit free event base before freeing command base and pipes 2016-05-21 06:48:02 +02:00
chme
6112c38220 [commands] do not cast return of calloc and allocate struct command on
stack if executed in sync
2016-05-21 05:59:45 +02:00
chme
3c9a7d9119 [player] Use generic commands for inter thread communication 2016-05-15 08:42:15 +02:00
chme
85d57394e5 [cache] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
dd192bd99c [spotify] Use generic commands util 2016-05-15 08:42:15 +02:00
chme
32944d7273 [worker] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
3823900394 [filescanner] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
4aacf487e8 [mpd] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
9856536fd7 [commands] Add generic functionality for inter-thread communication
using libevent and pipes
2016-05-15 08:42:15 +02:00
ejurgensen
1cc4c034d0 [filescanner] Add support for Monkey's audio 2016-05-06 00:30:58 +02:00
ejurgensen
1fbb4b0d59 [transcode] Fix problem for file types where ffmpeg decode returns 0
It seems ffmpeg/libav reads a file type like Monkey's audio in large
chunks, so that each packet must be passed to the decoder multiple
times. The decoder will return 0 until the packet is completed. This
change makes forked-daapd able to deal with a return value of 0.
2016-05-06 00:23:07 +02:00
ejurgensen
9a56044c77 [misc] Explicitly check for pthread_setname_np/pthread_set_name_np
Seems there is no pthread_setname_np in OpenWrt
2016-05-05 19:39:15 +02:00
ejurgensen
95d0c25be3 [outputs] Forgot an include 2016-05-05 18:49:27 +02:00
ejurgensen
7c68eab11e [streaming] Log error message from write() 2016-05-05 18:48:47 +02:00
ejurgensen
1f10c6a928 [player] Always reselect output devices when they return online
Consider this use case:
1. Playback stops, device switched off
2. Device switched back on, playback started by user
Before this commit, the device would be unselected when it came back on.
I don't think that is desirable, so with this commit the selection will
stay (except if the device comes back on during playback).
2016-04-30 23:55:45 +02:00
ejurgensen
960f89fcbd [player] Remove unused var 2016-04-14 10:04:21 +02:00
ejurgensen
ad01d65047 [alsa] Let the user configure an offset to sync audio if required 2016-04-14 09:48:48 +02:00
ejurgensen
e23fed4ac4 [alsa] Avoid call to snd_pcm_prepare if already in the right state 2016-04-14 09:48:48 +02:00
ejurgensen
19181007f4 [alsa] Increase max latency variance
Latency on the RPi varies quite a bit
2016-04-14 09:48:48 +02:00
ejurgensen
632bfd9a33 [alsa] Add low-tech sync with the player (and AirPlay) 2016-04-14 09:48:48 +02:00
ejurgensen
eca41e306e [alsa] Try to measure latency 2016-04-14 09:48:48 +02:00
ejurgensen
857055a18d [player] Insert duplicate packets slowly on timer overrun 2016-04-14 09:48:48 +02:00
ejurgensen
084a86597b [laudio] Remove OSS4 support and move dummy output to outputs interface 2016-04-14 09:48:48 +02:00
ejurgensen
1a5e1da9ae [alsa] Fixup of volume return values 2016-04-14 09:48:47 +02:00
ejurgensen
acc1ff4a47 [player] Sort devices and autoselect based on priority 2016-04-14 09:48:47 +02:00
ejurgensen
c5bb83480d [alsa] Add rewritten ALSA to generic outputs interface 2016-04-14 09:48:47 +02:00
ejurgensen
f1fb86e7e1 [raop] Stop writing when a teardown has been requested 2016-04-14 09:48:47 +02:00
ejurgensen
617303d545 [player] Purge laudio from player.c 2016-04-14 09:48:47 +02:00
ejurgensen
36755031cb [outputs] Make a wrapper for mp3 streaming so it can be included in
the generic outputs interface and so special handling in player.c can
be removed
2016-04-14 09:48:47 +02:00
ejurgensen
a07c24d625 [player] Fix possible segfault after playback stop on FreeBSD/machines with lo-res timers 2016-04-14 08:55:59 +02:00
ejurgensen
bf27a879df [filescanner] Use libinotify for FreeBSD (should fix issue #245)
Filescanner was broken in FreeBSD. Besides fixing this, using
libinotify instead of kqueue directly should make the code easier
to maintain, since it will be less divergent.

This commit includes these changes:
- Add libinotify to FreeBSD install scripts
- Fix reading multiple events from inotify fd (possible bug in Linux too)
- Deferred scanning since FreeBSD doesn't have IN_CLOSE_WRITE
- Configure search for inotify library
- Removal of kqueue stuff
2016-04-12 22:11:56 +02:00
ejurgensen
3be8afac7b [daap] Fix problem where playlists in Remote are not in correct order
Apparantly having "LIMIT -1 OFFSET 0" makes (certain versions?) of
sqlite3 unable to do the "ORDER BY". Might be a bug in sqlite. This
is only a partial fix, which will work for queries that don't actually
use an index. Those few that do may still be broken.
2016-04-10 00:11:33 +02:00
chme
7713096d84 [mpd] Return playlists if 'lsinfo' is called without any parameters 2016-04-05 21:04:44 +02:00
ejurgensen
36a9ed8fe8 [raop] Omit timing request source address check
Creates a problem with ipv6 where the timer request source address may
differ from the address that mdns gave us when we created the seesion.
See https://github.com/mikebrady/shairport-sync/issues/254
2016-03-29 19:36:40 +02:00
ejurgensen
a22aff5d1f [filescanner] Switch misplaced arguments in process_directories (FreeBSD)
Should help with issue #239. Also change process_directory so it uses
same argument order as process_directories.
2016-03-27 20:35:23 +02:00
ejurgensen
42e68311eb [transcode] Increase read timeout slightly 2016-03-25 20:56:08 +01:00
ejurgensen
dbf9a208b8 [dacp] Don't return hard error if queue item goes missing
Remote doesn't seem to like the 500 Internal error we were sending
if queue item went missing, e.g. during pause.
2016-03-23 20:38:19 +01:00
ejurgensen
c4713d8b39 [httpd] Improve log message 2016-03-21 19:26:54 +01:00