mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2025-11-09 13:39:48 -05:00
This issue mostly arises when push is enabled, but it also overloaded websocket connections. We would send a notification on every deleted cipher, which could be up-to 500 items. If push is enabled, it could overload the Push servers, and it would return a 429 error. This PR fixes this by not sending out a message on every single cipher during a multi delete actions. It will send a single push message to sync the vault once finished. The only caveat here is that there seems to be a bug with the mobile clients which ignores these global sync notifications. But, preventing a 429, which could cause a long term block of the sending server by the push servers, this is probably the best way, and, it is the same as Bitwarden it self does. Fixes #4693 Signed-off-by: BlackDex <black.dex@gmail.com>
21 KiB
21 KiB