Commit Graph

3773 Commits

Author SHA1 Message Date
ejurgensen db4068f046 [artwork] Hardcode destination pixel format for png rescaling since
avcode_find_best_pix_fmt_of_list() does not live up to its name
(fixes issue #345)
2017-01-25 21:02:41 +01:00
ejurgensen 084de7811e [raop] Fix missing uint64 cast, which since commit fdd85cc was giving too short song lengths 2017-01-23 23:41:10 +01:00
sshambar 297de6d86c [osx] Added INSTALL instructions for macports (#344)
Also fixed antlr3_install.sh to handle missing /usr/local/bin
2017-01-23 22:13:50 +01:00
sshambar bc4b046897 [logger] Add missing include (#342) 2017-01-23 08:41:23 +01:00
ejurgensen 36d9051a91 [misc] Fixup coding style 2017-01-22 23:47:45 +01:00
ejurgensen 5dc8eea4c2 [main] Re-include pthread.h that was removed in pr #334, needs to be
here because it is used by the gcrypt macro
2017-01-22 23:35:38 +01:00
ejurgensen 91ae0c1ec6 Merge pull request #341 from sshambar/fixscripts
Updated pairing and antlr install scripts
2017-01-21 21:56:39 +01:00
ejurgensen f7bd6fc447 Merge pull request #335 from sshambar/fixosx
OSX patches
2017-01-21 21:56:16 +01:00
Scott Shambarger 07c40a27ea [scripts] Update antlr35_install to support non-sudo install, more options.
Added support for using curl in addition to wget. Added support for compiling
as non-root, and installing later as root w/o sudo.  Added GNU Make check.
Made all downloads and urls vars at top of script.  Added usage.
Allow cancelling downloads, or using exiting downloaded files (offline).
Allow setting any install prefix. Auto-detect if on 64bit OS.
Better handling of various errors.
2017-01-21 15:37:24 -05:00
Scott Shambarger 37b1678103 [scripts] Minor updates to pairinghelper.sh option parsing 2017-01-21 15:36:42 -05:00
Scott Shambarger 2cf2eb32aa [scripts] Updated pairinghelper.sh to handle repeated attempts at pairing
Added Usage help, allow a custom config-file, provide better feedback
with unable to read logs or write to media directory.  Fixed log parsing
to only look for pairing success or failure after most recent remote
discovery to allow repeated pairing attempts (possibly with different
remotes).  Better timeout handling, especially as FreeBSD has a delay
in processing the pairing file.
2017-01-21 13:10:59 -05:00
Scott Shambarger 836320518b Merge branch 'master' into fixosx 2017-01-21 13:04:38 -05:00
ejurgensen 8ffdd6dd86 Merge pull request #334 from sshambar/fixthreads
[threads] Added missing initializers, check errors on mutex/cond calls
2017-01-21 18:53:51 +01:00
Scott Shambarger a837389ac5 Minor change: remove unused include, init variable. 2017-01-21 08:51:51 -08:00
Scott Shambarger 6f7355dfce Merge branch 'fixthreads' into fixosx 2017-01-21 10:38:47 -05:00
sshambar b128271656 Merge branch 'master' into fixthreads 2017-01-21 10:27:26 -05:00
Scott Shambarger 8e3797ec43 [threads] Update mutex/cond functions to use new CHECK_ERR macros
Added various macros to check return values and log any errors and abort
if the call fails.
Updated logging to handle early errors before logging initialized.
2017-01-21 07:11:20 -08:00
chme e092a9ff3e [spotify] Respect settings for 'artist_override' and 'album_override' (#340)
when scanning spotify through the web api

The goal is to reduce the artist/album cluttering that happens because
of the users spotify playlists. If 'artist_override' is true, all tracks
not in a saved album are treated as part of a compilation giving them
the configured album-artist (e. g. "Various artists"). I
'album_override' is true, tracks not in a saved album will use the
playlistname as albumname.
2017-01-21 10:17:33 +01:00
chme 62dd1bb407 [travic-ci] Added configuration file for travis-ci (#339)
Builds different configuration with scan-build reporting failure if
scan-build found issues. Due to the ANTLR3 generated files the checker
deadcode.DeadStores needs to be disabled or all builds will fail.
2017-01-21 10:13:40 +01:00
ejurgensen 516a6f434c Merge pull request #337 from chme/libraryfix
Fix memory leaks / scan-build issues
2017-01-20 19:15:04 +01:00
chme 6163269832 [dacp/db] Fix issue found with scan-build
- Result of operation is garbage or undefined in dacp_reply_cue_play
- Uninitialized argument value in dacp_reply_playqueuecontents
- Uninitialized argument value in queue_fetch_byposrelativetoitem
2017-01-20 19:00:11 +01:00
chme 4e869f6fda [dacp] Fix indentation 2017-01-20 19:00:11 +01:00
chme dea5c50b67 [player] Fix memleaks found with scan-build 2017-01-20 19:00:11 +01:00
chme 825236c8bb [spotify_webapi] Fix memory leaks 2017-01-20 19:00:11 +01:00
ejurgensen 583a968775 Merge pull request #331 from chme/library2
Rework library scan / spotify webapi integration
2017-01-18 20:42:08 +01:00
chme a4180a5902 [spotify] Increase log level for skipping playlists during scan 2017-01-18 20:32:02 +01:00
chme e8d6b17784 fix indentation 2017-01-18 20:28:56 +01:00
chme 77086c9b82 [library] Check for init/deinit functions in library source 2017-01-18 20:12:14 +01:00
chme 69c3a9c6dc Add missing log domains 2017-01-18 20:10:18 +01:00
Scott Shambarger 9c50429abc [dnssd] Reworked resolve to use timeout, fixed network order on port 2017-01-17 01:36:03 -05:00
Scott Shambarger 879d9a80aa [osx] Remove incorrect calculations for timer_getoverrun 2017-01-14 23:29:07 -05:00
chme 00efed7988 [filescanner] Fix scanning of fifos 2017-01-14 13:59:14 +01:00
Scott Shambarger bb68d59a6e [osx] Added missing timer/clock functions, support Bonjour mDNS on OSX
Added configure checks needed to detect missing functions on OSX
Added compat clock functions using clock_get_time on OSX
Added compat timer functions using clock_gettime and setitimer on OSX
Added byteswap functions on OSX
2017-01-14 00:56:43 -05:00
Scott Shambarger b54d94fda6 [threads] Added missing initializers, check errors on mutex/cond calls 2017-01-13 17:32:59 -05:00
chme a15923c377 [spotify] Fix for expired spotify access token and some cleanup 2017-01-13 19:20:24 +01:00
chme 528614909c [filescanner/library] Move filescanner to subfolder 2017-01-13 19:02:47 +01:00
chme 9c9c583b81 [library] move declaration scan_metadata_ffmpeg back to filescanner.h 2017-01-13 18:56:37 +01:00
chme 2cfb4b6a28 [spotify] Simplify parsing of artist/album-artist name
forked-daapd does not support a 1:n relationship between tracks and
artists. Just take the first artist the spotify web api returns
(libspotify does also return only one artist, so this should not
introduce a regression).
2017-01-13 18:56:37 +01:00
chme 03c5ecd690 [spotify] Split into smaller db transactions (do not keep an open
transaction between requests)
2017-01-13 18:56:37 +01:00
chme f632789f8b [spotify] Set missing values for year, artwork, type, codectype,
description and improve logging
2017-01-13 18:56:37 +01:00
chme ab3582dd69 [spotify_webapi] Cleanup: remove unused functions 2017-01-13 18:56:37 +01:00
chme 66bbcf0576 [spotify] Ignore playlist updates with missing uri 2017-01-13 18:56:37 +01:00
chme 8ee3ef5b15 [filescanner] Trigger library-scan on .init-rescan / .full-rescan 2017-01-13 18:56:37 +01:00
chme 510d38c059 [library/filescanner/spotify] Rework full-rescan logic 2017-01-13 18:56:37 +01:00
chme 4e60626749 [db] Add missing purge of directories in db_purge_all 2017-01-13 18:56:37 +01:00
chme 65ce902e3c [db_init] Set admint.value to VARCHAR(255)
Only a cosmetic change to avoid future confusion. sqlite3 ignores the
number of chars given to VARCHAR (see https://sqlite.org/faq.html#q9 ),
a db upgrade is therefor not necessary.
2017-01-13 18:56:37 +01:00
chme 99945fa576 [spotify] Rescan of single playlists if update trigger received from
libspotify (Readds "spotify:savedtracks" playlist to avoid deletion of
saved tracks)
2017-01-13 18:56:37 +01:00
chme adac1d3b5f [spotify] Trigger scan after retrieving a valid access token from the
webinterface

Library now offers the function "library_exec_async". This allows
library sources to offer functions that will be executed in
the library thread. Useful to allow partial scans of only one source.
2017-01-13 18:56:37 +01:00
chme ae1a45bacc [library/spotify] Implement rescan in spotify.c and purge old files
after rescan
2017-01-13 18:56:37 +01:00
chme 0bea83cafa [spotify] Scan saved albums and playlist using the spotify web api 2017-01-13 18:56:37 +01:00