Commit Graph

5670 Commits

Author SHA1 Message Date
whatdoineed2do/Ray 8f9356ff11 [http,conf] allow user to request no ssl peer verification
This solves for the case where hosted RSS podcasts have self signed or
expired certs:  using default (verify peer) in these instances results
in 'SSL peer certificate or SSH remote key was not OK'
2021-12-18 17:00:05 +00:00
ejurgensen 5efe0eeb0f [pipe] Fix regression in commit 6646802
Don't try to apply pipe metadata if parsing failed. Resolves #1366.
2021-12-12 10:32:42 +01:00
ejurgensen d6cc0e453d [airplay] Update pair_ap to 0.12
Better input validation of public keys
2021-12-06 22:49:34 +01:00
ejurgensen aa56d0e849
Merge pull request #1363 from owntone/airplay_pairing1
Update pair_ap to version 0.11
2021-12-05 12:17:32 +01:00
ejurgensen 088e26c1f0 [airplay] Fix rare pairing bug due to incorrect SRP padding (ref #1280)
Update pair_ap to version 0.11, which it fixes an issue where some randomized
values of SRP "a" are short enough that they require padding.
2021-12-04 23:05:33 +01:00
ejurgensen 1418bfb245 [scan] Don't iTunes playlist scan timestamp on failed scan
Also some refactoring.

Closes #1359
2021-12-01 20:11:54 +01:00
ejurgensen a55f2c6220 Add owntone@.service to .gitignore (ref PR #1353) 2021-11-29 16:35:56 +01:00
ejurgensen fee5075b0b
[docs] Update INSTALL, use package manager for antlr3
The version of antlr3 that is in Fedora 35 seems to work, so no reason to use the special script.
2021-11-28 20:58:53 +01:00
ejurgensen b71c353fc9 [spotify] Update librespot-c for better connection handling
- New attempt at fixing #1317: Don't prevent reconnection if a request is queued
- Protection against flooding Spotify with reconnection attempts
- Don't reconnect when getting a stop request during blocked download
2021-11-27 15:10:56 +01:00
Derek Atkins 434fc4652c
Add a SystemD template service for owntone (issue #1353)
Create a SystemD template and document how to use it for multiple instances of owntone
2021-11-25 22:11:59 +01:00
Derek Atkins 28b2822d9d
Updates to spec file
* Get SPEC file to build with 28.2 and FC35
* Owntone requires avahi, so declare that
* Update configure options based on new code
* Remove spotify and lastfm options; we always build with those
* Clean up service-file handling
* Install systemd file correctly through build system
2021-11-23 21:40:03 +01:00
ejurgensen ce5634e372 [spotify] Fix log message typo 2021-11-20 14:55:27 +01:00
ejurgensen c994797f95
Update bug report template 2021-11-20 11:01:04 +01:00
ejurgensen 6646802832 [pipe] Fix deadlock coming from metadata pipe (issue #1343)
Cause of deadlock:
  new volume pipe metadata -> lock pipe mutex -> set player volume waiting for
  player -> player waiting for input write -> input write waiting for get
  metadata -> get metadata waiting for mutex

Change implementation so lock is only held while parsing/storing metadata,
where it is required, and not when calling the player.
2021-11-15 23:13:13 +01:00
ejurgensen 0d67f26662 [artwork] Fix memleak on pipe artwork error 2021-11-15 22:57:43 +01:00
ejurgensen 4c5217d3d9
Merge pull request #1339 from owntone/spotify_disconnect1
Fix for Spotify disconnect issues
2021-11-08 23:35:40 +01:00
ejurgensen 6d54886030 [librespot-c] Close connection if peer disconnects
Attempt to fix possible bad state where librespot-c keeps try to using a
connection even after the access point has disconnected.
2021-11-04 17:20:55 +01:00
ejurgensen 5e66dbd8c9 [spotify] Fix Spotify initialization issues
* loading library even though library playback login failed
2021-11-01 10:37:17 +01:00
ejurgensen 65d578f8c8 [scan] Ignore 0-byte files in library so ffmpeg 3.2 doesn't crash 2021-10-29 23:08:37 +02:00
whatdoineed2do a5f75dab36
[jsonapi] /api/library/*/{id} returns 404 (instead of 500) on not finding item (#1326)
Co-authored-by: whatdoineed2do/Ray <whatdoineed2do@nospam.gmail.com>
2021-10-25 17:36:51 +02:00
ejurgensen 383146eb35
Merge pull request #1327 from owntone/jsonapi-multi-track-put3
[jsonapi] Add PUT /api/library/tracks endpoint (update multiple tracks)
2021-10-10 23:45:26 +02:00
ejurgensen d2ee9f20fb [jsonapi] Add PUT /api/library/tracks endpoint (update multiple tracks)
Also fix error in json doc (track->id type)
2021-10-10 23:31:34 +02:00
ejurgensen 41e3733ccc [misc] Make safe_xxx integer conversions safer by checking for NULL input
Also don't touch output on error + fix missing check for return in db.c
2021-10-09 23:39:00 +02:00
ejurgensen c4d57aa5d1 [spotify] Clear spotify_status on logout (clears logged_in and username) 2021-10-05 20:46:44 +02:00
ejurgensen de2e1b32ed
Merge pull request #1322 from owntone/ci_fixups2
Fix MacOS workflow
2021-10-01 20:43:55 +02:00
ejurgensen c50f386d68 Fix MacOS build failure due to missing OpenSSL
Seems OpenSSL headers aren't installed by default any more on the virtual host,
but they are required by libwebsockets
2021-10-01 19:52:38 +02:00
ejurgensen af61c10756 Remove forked-daapd name from MacOS workflow file 2021-10-01 19:03:55 +02:00
ejurgensen ae7280b770 [library] Fix macos format warning
library.c:233:123: warning: format specifies type 'long' but the argument has type '__darwin_suseconds_t' (aka 'int') [-Wformat]
2021-10-01 19:01:32 +02:00
ejurgensen 679c142212 [db] Remove unused strdup_if() 2021-10-01 18:58:13 +02:00
ejurgensen 5e93080aa2 [airplay] Fix warning about int type seqnum 2021-10-01 16:52:47 +02:00
ejurgensen aff8ac6a6b [raop] Fix warning about int type seqnum 2021-10-01 16:52:02 +02:00
ejurgensen 7572560bf2 [chromecast] Fix format and type errors 2021-10-01 16:44:30 +02:00
ejurgensen 5ce6c69424
[docs] Update README, remove notice about speaker autoselection 2021-09-30 21:34:08 +02:00
ejurgensen 63c3d59d2f [spotify] Preserve fine-grained errors from request_make() 2021-09-24 19:17:47 +02:00
ejurgensen d6dc92359e Merge branch 'whatdoineed2do-db-files-review-flag' 2021-09-17 23:02:13 +02:00
ejurgensen 6692411040 [-] Fixup PR 1309 (usermark) 2021-09-17 22:58:21 +02:00
whatdoineed2do/Ray 45c5f0b347 [docs] update for "usermark" 2021-09-16 10:51:54 +01:00
whatdoineed2do/Ray 4d5c256327 [db,jsonapi] revert usermark from queue item table 2021-09-16 10:43:55 +01:00
whatdoineed2do/Ray 16cf3cb44b [jsonapi] use u32 types for parsing param: rating 2021-09-16 09:11:31 +01:00
whatdoineed2do/Ray 52d1ba7dd4 [db,jsonapi] remove DB_FILES_USERMARK_MAX 2021-09-15 08:40:07 +01:00
whatdoineed2do/Ray d43ce017f5 [db,jsonapi,smartpl] db usermark flag review 2021-09-08 14:51:55 +01:00
whatdoineed2do/Ray e65203e1e2 [db] expand file tbl's flag values 2021-09-07 11:49:24 +01:00
whatdoineed2do/Ray ad573b8bc7 [db,jsonapi]] update api/library/tracks and db to accept 'flag' param 2021-09-06 20:15:35 +01:00
whatdoineed2do/Ray 5cbb5f061d [smartpl] add review 'flag' 2021-09-06 20:15:35 +01:00
whatdoineed2do/Ray 4dcc9b602e [db] add review 'flag' column to files/queue tbls 2021-09-06 20:15:35 +01:00
Christian Meffert 29cd5a7a19
Merge pull request #1286 from chme/spotify_podcasts
[spotify] Scan spotify podcast subscriptions into library
2021-09-04 12:06:26 +02:00
Christian Meffert 80679180b7
Merge pull request #1305 from chme/smartpl-fix-error-check
Fix wrong check for NULL after creating smartpl parser
2021-09-04 10:25:56 +02:00
chme d8a344d87c Fix wrong check for NULL after creating smartpl parser 2021-09-04 09:55:11 +02:00
Christian Meffert 5731c53393
Merge pull request #1296 from cdlenfert/master
Add a solid background to PNG to prevent iOS defaulting to black
2021-09-04 09:47:57 +02:00
chme ce3e79d804 [spotify] Move "has_podcast_support" to spotify_status and expose this
flag in the web API
2021-09-04 09:46:29 +02:00