Commit Graph

3295 Commits

Author SHA1 Message Date
ejurgensen
35253fdeb1 Merge pull request #196 from chme/mpdadd
[queue] fix segfault if query for queue-items returned an empty result
2015-11-01 16:38:48 +01:00
chme
0e0fbd006f [queue] fix segfault if query for queue-items returned an empty result
set

This happen for example if a wrong path is passed in "mpc add
[virtual_path]"
2015-11-01 12:47:04 +01:00
ejurgensen
7a9b8d5c63 Merge pull request #195 from chme/mpdfindadd
some fixes
2015-11-01 12:29:51 +01:00
chme
350944cddd [mpd] fix seekid command
Seeking with the seekid command for the currently playing item got
broken after introducing the item-id (comparison of item-id passed from
client to db-id)
2015-11-01 12:06:18 +01:00
chme
7b5c80acf4 [queue] If the playing item is not in the queue anymore, the next item
should be the first item in the queue

This solves the problem that after clearing the queue and adding new
items while playing, aborts playback when skipped to the next item.
2015-11-01 11:59:39 +01:00
chme
abc689a7e1 [mpd] fix sort in queue after adding songs with findadd and searchadd
commands

Always add songs sorted by artist, album, disc, track. Adding by title
is almost never the expected order of songs.
2015-11-01 11:46:54 +01:00
ejurgensen
6859377a17 Merge pull request #194 from chme/mpd
[mpd] Return playlists if lsinfo is called with an empty path
2015-10-31 13:06:52 +01:00
chme
d0232a2315 [mpd] Return playlists if lsinfo is called with an empty path (same
handling as if the path is the root directory "/")
2015-10-31 12:53:52 +01:00
ejurgensen
316af87189 Merge pull request #193 from chme/mpd
[mpd] Add support for moveid and close command
2015-10-31 11:31:27 +01:00
ejurgensen
6ba350e406 Merge pull request #192 from chme/history
[dacp] Fix playing from history for Remote
2015-10-31 11:31:10 +01:00
chme
ba63157429 [mpd] Add 'close' command (ignore the command and does not send a
response)
2015-10-31 07:56:52 +01:00
chme
f9c6aa6c48 [mpd] Implement command moveid (movings items in the queue by item-id) 2015-10-31 07:56:51 +01:00
chme
1c409846d5 [player/queue] Add player commands to move queue-items by item-id 2015-10-31 07:56:50 +01:00
chme
c2ba2f6779 [dacp] Fix playing from history for Remote 2015-10-31 06:18:05 +01:00
ejurgensen
7894a4d85f [transcode] Don't push NULL frames to filtergraph when flushing, can lead to segfault 2015-10-25 19:59:06 +01:00
ejurgensen
ac3d47430c Merge pull request #190 from chme/pausestream
Restore behaviour for pause command when playing http-streams
2015-10-25 09:37:31 +01:00
chme
94895b8eed [player] if source is not pausable (http-streams or pipe) abort playback
on pause command 

This restores the behaviour before the queue/player-refactoring.
2015-10-25 09:00:47 +01:00
ejurgensen
43893dff48 Merge pull request #189 from chme/mpd
Fix item-id in mpd commands "playlistid", "playlistinfo", "plchanges"
2015-10-24 09:05:58 +02:00
chme
51eb423065 [mpd] Fix item-id in playlist items 2015-10-24 06:06:24 +02:00
ejurgensen
3e80e5c517 [transcode] Don't pass error to player on eof + some comments and cleaning 2015-10-22 22:09:19 +02:00
ejurgensen
e20d2c544d [transcode] Comments and raise MAX_BAD_PACKETS to 5 2015-10-22 21:01:43 +02:00
ejurgensen
058b2fb0d6 [transcode] Improve decoding to allow for decoder special cases, like decoders not processing
entire packets, rejecting packets and not returning frames. Should fix issue with network
streams not opening.
2015-10-21 23:53:21 +02:00
ejurgensen
9853b8f9bd Merge pull request #188 from chme/playerfixes
Playerfixes
2015-10-19 22:15:43 +02:00
chme
551f441273 [dacp] Fix playing from playspec request 2015-10-19 21:55:43 +02:00
chme
7592462571 [player] Fix segfault if reading from source failed for all queue items 2015-10-19 21:33:43 +02:00
ejurgensen
55104015e0 Full removal of libevent 1 legacy code. Also drop pipe() in FreeBSD, since pipe2 is available now. 2015-10-19 21:15:29 +02:00
ejurgensen
2dfd25c557 README update 2015-10-19 20:56:35 +02:00
ejurgensen
4ec8bddd90 Update INSTALL to reflect libav and antlr changes 2015-10-19 19:50:06 +02:00
chme
48691748cd [mpd] fix log message if binding of artwork http server failed 2015-10-18 14:25:29 +02:00
ejurgensen
2a610812a5 Refactor transcode.c so it can actually transcode + use new capability to support mp3 streaming.
Also includes the skeleton for perhaps supporting video in the future. Adds more fine-grained
ffmpeg/libav compability checks. Dependency on libavresample/libswresample exchanged with
dependency on libavfilter, which seems more versatile.
2015-10-09 23:58:27 +02:00
ejurgensen
da3d32902e Merge pull request #185 from chewi/master
Allow ANTLR 3.5 to work and update script
2015-10-08 23:51:15 +02:00
James Le Cuirot
5fe4f67d20
Update ANTLR script to 3.5.2
This is beneficial because 3.4 is broken under Java 8. It appears that
the C library didn't change in 3.5 so the 3.4 tarball is still used
for that part.
2015-10-06 22:09:18 +01:00
James Le Cuirot
7cf35d1e8b
Allow ANTLR 3.5 to work
This involves a harmless backwards-compatible adjustment to the
grammar. I can't explain why this is necessary but this might help.

http://stackoverflow.com/questions/20057063/follow-set-in-is-undefined-in-generated-parser
2015-10-05 23:10:45 +01:00
ejurgensen
34cc45b12d Merge pull request #183 from chme/queuerefactor3
Queue/player refactoring
2015-10-05 22:38:34 +02:00
chme
199b765a7d [player] Store item-ids in history to allow start of playback from the
previously played items in dacp
2015-10-04 08:05:37 +02:00
chme
b19a7280b9 [player] remove unused player_queue struct 2015-10-04 08:05:37 +02:00
chme
fbce3a7d57 [player] Confusing naming of ids cleaned up 2015-10-04 08:05:37 +02:00
chme
ba3385b0ec [queue] Remove queue_info and queue_item_info structs 2015-10-04 08:05:37 +02:00
chme
35df9455b9 [queue] Fix memory leak in queue_make_item 2015-10-04 08:05:36 +02:00
chme
100e08da9d Rename make_queue functions 2015-10-04 08:05:36 +02:00
chme
064dfef2de [player] cleanup metadata_trigger
metadata_trigger is always called for the current streaming item and
source_open makes sure that the stream_start and output_start values are
set correctly
2015-10-04 08:05:36 +02:00
chme
64698eb3a4 [player] Some minor cleanup (error handling, comments) 2015-10-04 08:05:36 +02:00
chme
a06424a701 [mpd] Expose queue-item-id instead of dbmfi-id in mpd commands
[player] Reshuffle on end of playlist and repeat mode is "repeat all"
2015-10-04 07:59:58 +02:00
chme
cb2805800b [player] Fix segfault if pause requested in the last two seconds of the
last item in the playqueue (cur_streaming is already NULL)
2015-10-04 07:59:58 +02:00
chme
2b037b67d9 [player] Combine stream_stop and stream_cleanup into one function 2015-10-04 07:59:58 +02:00
chme
e44a160b9a [player] Improve error handling 2015-10-04 07:59:58 +02:00
chme
4595a2f4a6 [player] Add missing metadata trigger on item change (after eof) 2015-10-04 07:59:58 +02:00
chme
c8a61015fc [dacp] Fix playing of radio streams after queue refactoring 2015-10-04 07:59:58 +02:00
chme
f4faac3cc8 [spotify] Remove duplicate method "resume" in favor of "play" 2015-10-04 07:59:58 +02:00
chme
58069e67f8 [player/spotify] adjust spotify integration to refactoring of player 2015-10-04 07:59:58 +02:00