Commit Graph

2773 Commits

Author SHA1 Message Date
ejurgensen
561228d9f7 [misc] Add missing const qualifier 2016-07-31 23:27:57 +02:00
chme
cebf07b2f8 [filescanner] Fix building directory structure with trailing '/'
Library directories with a trailing '/' (like '/srv/music/') lead to an
unbrowsable directory structure. The trailing '/' resulted in an update
to the library directory in the directories table with a parent_id
pointing to itself.
2016-07-31 07:41:11 +02:00
chme
595f7c6091 [mpd] Fix copy/paste error in log message 2016-07-30 08:33:23 +02:00
chme
e6b53cb88e [mpd] Fix mpd command 'playid' if player is already playing
While playing issueing command 'playid' starts playback of the song with
the given item-id (if this song is already playing, it starts from the
beginning).
2016-07-30 08:33:22 +02:00
chme
9af09c204d [mpd] Fix mpd command 'play' if player is already playing
While playing issueing command 'play' with a songposition -1 does noting
in mpd, with songposition > 0 it starts playback of the song at this
position (if this song is already playing, it starts from the
beginning).
2016-07-30 08:31:54 +02:00
ejurgensen
db6823d676 [pulseaudio] Support for adding/removing sinks 2016-07-30 00:05:32 +02:00
ejurgensen
ed03c90916 [mpd] Fix typos 2016-07-29 19:26:46 +02:00
ejurgensen
4399466f21 [pulseaudio] Friendly naming of sinks in speaker list 2016-07-21 23:15:06 +02:00
ejurgensen
eb40415348 [pulseaudio] A bit of renaming 2016-07-21 22:31:39 +02:00
ejurgensen
5b67f84855 [pulseaudio] First draft 2016-07-21 22:13:32 +02:00
Björn Ricks
382459ce9b Allow anonymous access to /content-codes url
The content-codes url provides a mapping of dmap content codes to names, it's
types and sizes. It doesn't contain any private information and therefore should
be available to anonymous users too.
2016-07-13 19:52:58 +02:00
ejurgensen
d3078c6534 [remote] Increase pairing success log level 2016-07-10 20:38:03 +02:00
ejurgensen
a99d1b2038 [db] Add song_length to group info (fixes #265) 2016-06-11 23:10:13 +02:00
ejurgensen
547783d008 Merge pull request #268 from chme/threadexit
Refactor thread exit handling
2016-06-11 22:57:09 +02:00
chme
c0c6cca79f [commands] Add some code comments 2016-06-11 10:56:27 +02:00
chme
32ac6c2ea9 [commands] Rename commands_cmdloop_break to commands_base_destroy and
free commands_base after breaking the libevent loop
2016-06-11 10:56:27 +02:00
chme
a9a656042b [player] Cleanup: player clock is the only sync-source available 2016-06-11 10:37:09 +02:00
chme
5258ee712c [commands] Added functionality to break the event loop of a command base 2016-06-11 09:52:31 +02:00
ejurgensen
3527113a9b [filescanner] Option to import iTunes smart playlists 2016-06-04 23:30:01 +02:00
ejurgensen
777c0c8d27 Merge pull request #264 from bjoernricks/allow-origin
Allow to add Access-Control-Allow-Origin header to responses
2016-06-04 20:19:25 +02:00
Björn Ricks
6b6a1e65e1 Allow to add Access-Control-Allow-Origin header to responses
Add a new general config setting allow_origin that is included as
Access-Control-Allow-Origin header in http responses. This allows to make http
request against forked-daapd from browsers with enabled CORS
(https://www.w3.org/TR/cors/) via JavaScript XMLHttpRequest.

Per default the setting is not defined and no Access-Control-Allow-Origin header
is included in the response.
2016-06-02 13:32:41 +02:00
chme
610ae6a048 [commands] Move function documentation to their implementation
Also adds some aditional code documentation and an attempt at making
command_cb easier to understand
2016-05-21 07:57:44 +02:00
chme
5dc1cba5c8 On deinit free event base before freeing command base and pipes 2016-05-21 06:48:02 +02:00
chme
6112c38220 [commands] do not cast return of calloc and allocate struct command on
stack if executed in sync
2016-05-21 05:59:45 +02:00
chme
3c9a7d9119 [player] Use generic commands for inter thread communication 2016-05-15 08:42:15 +02:00
chme
85d57394e5 [cache] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
dd192bd99c [spotify] Use generic commands util 2016-05-15 08:42:15 +02:00
chme
32944d7273 [worker] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
3823900394 [filescanner] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
4aacf487e8 [mpd] Use generic inter thread commands util 2016-05-15 08:42:15 +02:00
chme
9856536fd7 [commands] Add generic functionality for inter-thread communication
using libevent and pipes
2016-05-15 08:42:15 +02:00
ejurgensen
1cc4c034d0 [filescanner] Add support for Monkey's audio 2016-05-06 00:30:58 +02:00
ejurgensen
1fbb4b0d59 [transcode] Fix problem for file types where ffmpeg decode returns 0
It seems ffmpeg/libav reads a file type like Monkey's audio in large
chunks, so that each packet must be passed to the decoder multiple
times. The decoder will return 0 until the packet is completed. This
change makes forked-daapd able to deal with a return value of 0.
2016-05-06 00:23:07 +02:00
ejurgensen
9a56044c77 [misc] Explicitly check for pthread_setname_np/pthread_set_name_np
Seems there is no pthread_setname_np in OpenWrt
2016-05-05 19:39:15 +02:00
ejurgensen
95d0c25be3 [outputs] Forgot an include 2016-05-05 18:49:27 +02:00
ejurgensen
7c68eab11e [streaming] Log error message from write() 2016-05-05 18:48:47 +02:00
ejurgensen
1f10c6a928 [player] Always reselect output devices when they return online
Consider this use case:
1. Playback stops, device switched off
2. Device switched back on, playback started by user
Before this commit, the device would be unselected when it came back on.
I don't think that is desirable, so with this commit the selection will
stay (except if the device comes back on during playback).
2016-04-30 23:55:45 +02:00
ejurgensen
960f89fcbd [player] Remove unused var 2016-04-14 10:04:21 +02:00
ejurgensen
ad01d65047 [alsa] Let the user configure an offset to sync audio if required 2016-04-14 09:48:48 +02:00
ejurgensen
e23fed4ac4 [alsa] Avoid call to snd_pcm_prepare if already in the right state 2016-04-14 09:48:48 +02:00
ejurgensen
19181007f4 [alsa] Increase max latency variance
Latency on the RPi varies quite a bit
2016-04-14 09:48:48 +02:00
ejurgensen
632bfd9a33 [alsa] Add low-tech sync with the player (and AirPlay) 2016-04-14 09:48:48 +02:00
ejurgensen
eca41e306e [alsa] Try to measure latency 2016-04-14 09:48:48 +02:00
ejurgensen
857055a18d [player] Insert duplicate packets slowly on timer overrun 2016-04-14 09:48:48 +02:00
ejurgensen
084a86597b [laudio] Remove OSS4 support and move dummy output to outputs interface 2016-04-14 09:48:48 +02:00
ejurgensen
1a5e1da9ae [alsa] Fixup of volume return values 2016-04-14 09:48:47 +02:00
ejurgensen
acc1ff4a47 [player] Sort devices and autoselect based on priority 2016-04-14 09:48:47 +02:00
ejurgensen
c5bb83480d [alsa] Add rewritten ALSA to generic outputs interface 2016-04-14 09:48:47 +02:00
ejurgensen
f1fb86e7e1 [raop] Stop writing when a teardown has been requested 2016-04-14 09:48:47 +02:00
ejurgensen
617303d545 [player] Purge laudio from player.c 2016-04-14 09:48:47 +02:00
ejurgensen
36755031cb [outputs] Make a wrapper for mp3 streaming so it can be included in
the generic outputs interface and so special handling in player.c can
be removed
2016-04-14 09:48:47 +02:00
ejurgensen
a07c24d625 [player] Fix possible segfault after playback stop on FreeBSD/machines with lo-res timers 2016-04-14 08:55:59 +02:00
ejurgensen
bf27a879df [filescanner] Use libinotify for FreeBSD (should fix issue #245)
Filescanner was broken in FreeBSD. Besides fixing this, using
libinotify instead of kqueue directly should make the code easier
to maintain, since it will be less divergent.

This commit includes these changes:
- Add libinotify to FreeBSD install scripts
- Fix reading multiple events from inotify fd (possible bug in Linux too)
- Deferred scanning since FreeBSD doesn't have IN_CLOSE_WRITE
- Configure search for inotify library
- Removal of kqueue stuff
2016-04-12 22:11:56 +02:00
ejurgensen
3be8afac7b [daap] Fix problem where playlists in Remote are not in correct order
Apparantly having "LIMIT -1 OFFSET 0" makes (certain versions?) of
sqlite3 unable to do the "ORDER BY". Might be a bug in sqlite. This
is only a partial fix, which will work for queries that don't actually
use an index. Those few that do may still be broken.
2016-04-10 00:11:33 +02:00
chme
7713096d84 [mpd] Return playlists if 'lsinfo' is called without any parameters 2016-04-05 21:04:44 +02:00
ejurgensen
36a9ed8fe8 [raop] Omit timing request source address check
Creates a problem with ipv6 where the timer request source address may
differ from the address that mdns gave us when we created the seesion.
See https://github.com/mikebrady/shairport-sync/issues/254
2016-03-29 19:36:40 +02:00
ejurgensen
a22aff5d1f [filescanner] Switch misplaced arguments in process_directories (FreeBSD)
Should help with issue #239. Also change process_directory so it uses
same argument order as process_directories.
2016-03-27 20:35:23 +02:00
ejurgensen
42e68311eb [transcode] Increase read timeout slightly 2016-03-25 20:56:08 +01:00
ejurgensen
dbf9a208b8 [dacp] Don't return hard error if queue item goes missing
Remote doesn't seem to like the 500 Internal error we were sending
if queue item went missing, e.g. during pause.
2016-03-23 20:38:19 +01:00
ejurgensen
c4713d8b39 [httpd] Improve log message 2016-03-21 19:26:54 +01:00
ejurgensen
7d1d52e8f0 [transcode] Fix missing channel number for newer ffmpeg (closes #241) 2016-03-20 19:22:16 +01:00
chme
1fb1fc7d2d [player] Add config option to disable clearing the queue after playback
stops (default is clearing the queue) and if true do not clear the
queue.

This option is necessary because some dacp clients rely on the queue
being empty if player is stopped. Retune for example does not always
show the queue contents if player state is stopped.
2016-03-20 07:45:21 +01:00
chme
e3750957f5 [player] Allow removing by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
ed2fe682fe [player] Allow moving by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
cb919515e4 [dacp] Start playback from selected song in the playqueue if player is
stopped
2016-03-19 09:40:36 +01:00
chme
d000ea571b [dacp] Return the playqueue even if player is stopped 2016-03-19 09:40:36 +01:00
chme
07947a526d [mpd] Do not start playback automatically after adding songs to the
queue
2016-03-19 09:40:36 +01:00
chme
d35894ac15 [mpd] Return correct item-id for command 'addid' and return correct
number of items in the queue if player is stopped for command 'status'
2016-03-19 09:40:36 +01:00
ejurgensen
b454a2fd60 [general] Put back support for platforms without pipe2(), see issue #239 2016-03-17 22:20:16 +01:00
ejurgensen
ec43195633 [alsa] Really don't query snd_pcm_delay() during an underrun 2016-03-17 13:56:15 +01:00
ejurgensen
e65361ba17 [alsa] Don't query snd_pcm_delay() during an underrun 2016-03-17 12:54:17 +01:00
ejurgensen
d2d52c7d68 [alsa] Do not kill threshold, it gives underruns after snd_pcm_prepare() 2016-03-17 12:46:51 +01:00
ejurgensen
8b2c68af0e [alsa] Try to fix issue where devices with small buffers would
overrun, rendering the device unusable because snd_pcm_writei()
starts blocking. This is just a poor temporary fix until we
either start using SND_PCM_NONBLOCK or put alsa in it's own thread
or implement Pulseaudio...
2016-03-16 22:54:27 +01:00
ejurgensen
5f3578ec65 [alsa] Some extra logging for debugging 2016-03-15 22:59:12 +01:00
ejurgensen
abce1d0eeb Merge pull request #237 from chme/threadnames
Set thread names
2016-03-12 17:18:34 +01:00
chme
98d6db002f Set thread names to make it easier to identify threads during debugging 2016-03-12 14:01:08 +01:00
chme
9a5b67031e [player] Remove unnecessary check for plid != 0 and set plid always to 0
if queue changed
2016-03-12 14:01:08 +01:00
ejurgensen
fba6293be6 Merge pull request #238 from chme/spotifyvirtualpath
[spotify] Add the owner of playlist to the virtual path
2016-03-12 13:23:47 +01:00
chme
3e8221e377 [spotify] Add the owner of playlist to the virtual path of a spotify
playlist to avoid duplicate virtual paths
2016-03-12 13:10:08 +01:00
chme
39c60cb211 [mpd] Fix indentation 2016-03-12 08:27:59 +01:00
chme
cd5aee1595 [mpd] Allways return an error message if mpd command exits with error,
otherwise the command will lead to a segfault (e. g. calling lsinfo with
a non existent directory path segfaults)
2016-03-12 08:27:59 +01:00
ejurgensen
598ae1bd71 [chromecast] json-c < 0.11 compability 2016-03-06 21:33:49 +01:00
ejurgensen
bd61399e49 [player] Only catch up by lowering sample rate if data_kind is http or pipe 2016-03-06 10:55:10 +01:00
ejurgensen
4d1a45e5d8 Merge pull request #235 from chme/queuemovefix
[queue] Fix moving a song to the last position in the queue failed
2016-03-05 15:04:36 +01:00
chme
1ec7ad683e [queue] Fix moving a song to the last position in the queue failed 2016-03-05 14:26:17 +01:00
chme
167d5117be [spotify] Remove options to exclude starred songs from the artist/album
override
2016-03-05 12:55:34 +01:00
ejurgensen
7aba0bf332 [filescanner] Support TDR tag (date released) and parse years better 2016-03-05 00:14:45 +01:00
ejurgensen
1188a79e57 [filescanner] Also set year if date tag present 2016-03-04 22:37:56 +01:00
ejurgensen
cbaea95ff4 [filescanner] Support for songdatereleased and songhasbeenplayed 2016-03-04 22:37:56 +01:00
ejurgensen
7135406531 [filescanner] Log message if user attempts to use LastFM/Spotify on unsupported build 2016-03-03 22:20:13 +01:00
ejurgensen
3000341acd [player] Different timer catch up for files + remove timer abort
Timer abort should no longer apply since we may catch up for more
than a second. Introduce separate catch up strategies for files and
streams, since for files we can read at our own pace.
2016-02-28 22:28:37 +01:00
ejurgensen
220494e8b1 Merge pull request #232 from chme/mpdmove
[mpd] Implement mpd command 'move'
2016-02-28 20:28:24 +01:00
chme
494a936caa [mpd] Implement mpd command 'move' 2016-02-21 19:01:52 +01:00
chme
c1dcc0a937 [db] Make loading of playlistitem count optional 2016-02-21 18:05:11 +01:00
ejurgensen
29dbc6bd9d [chromecast] Don't set cert file, doesn't seem very portable 2016-02-12 22:04:07 +01:00
ejurgensen
a824f73779 [player] Remove some debug log messages 2016-02-12 22:00:10 +01:00
ejurgensen
00d4148a90 [raop] Move RAOP specific states away from the generic output state enum 2016-02-12 21:59:26 +01:00
ejurgensen
48592406ed [chromecast] Fix probe segfault 2016-02-12 21:26:06 +01:00
ejurgensen
565d29529a [chromecast] Remove log message 2016-02-11 22:54:47 +01:00
ejurgensen
441f36a58b [chromecast] Fix segfault when cleaning up after missing reply 2016-02-11 20:04:30 +01:00