Commit Graph

5276 Commits

Author SHA1 Message Date
ejurgensen 1f45967481 [player] Fix autoselect so it also applies when there are no selected devices (second attempt)
Second attempt at fixing regression in version 27.2. First attempt was commit 2345885.

Closes #1091.
2020-09-21 17:12:18 +02:00
ejurgensen 513a09e6d1 [player] Reduce log severity of devices not starting 2020-09-06 23:18:08 +02:00
ejurgensen 2345885f19 [player] Fix autoselect so it also applies when there are no selected devices
Regression in version 27.2. Closes #1091.
2020-09-06 00:12:15 +02:00
ejurgensen 500f57ba1a [player] Clear up return value of outputs_start()
Should return 0 if no devices at all, or if none selected. Should not return
negative from failure to stop unselected devices.
2020-09-06 00:08:40 +02:00
Christian Meffert 7040382688
Merge pull request #1083 from chme/groups-metadata-alternative
Metadata for albums and artists (alternative approach)
2020-08-30 19:11:21 +02:00
chme 6f5822e461 [jsonapi] Map fields time_added, time_played, seek for album / artist 2020-08-30 09:08:41 +02:00
chme a74a3e5add [db] Add fields time_added, time_played, seek to group object 2020-08-30 09:08:41 +02:00
chme 382467eb9c [jsonapi] Map additional metadata for artist and album 2020-08-30 09:08:41 +02:00
chme 8afae4a41b [db] Fetch additional metadata for artist and album in group query 2020-08-30 09:08:41 +02:00
ejurgensen bb9536ef44 [scan] Early skip if file should be ignored
Avoids needless logging, e.g. from failed lstat(). Closes #1078.
2020-08-22 21:38:12 +02:00
ejurgensen c5df688caf [alsa] Align commit bfe99e5 with coding style 2020-08-22 21:36:10 +02:00
whatdoineed2do/Ray bfe99e56f7 [alsa] use alsamixer volume adjustment algorithm 2020-08-22 21:25:17 +02:00
whatdoineed2do/Ray fc5df02d29 [configure] explictly check for 'fabs' and some other math functions to incl -lm 2020-08-22 21:25:17 +02:00
ejurgensen 11de4c09bc [misc] Also have buildopts[] have disabled features + regex 2020-08-19 20:12:06 +02:00
ejurgensen a5ddb3c85d [player] Fix for volumes of unselected devices being reduced
Closes #1077
2020-08-13 20:48:48 +02:00
ejurgensen 9ecd32771c
Update CodeQL analysis workflow
Don't use autobuild
2020-08-11 21:34:38 +02:00
ejurgensen 76d1648511
Enable code scanning workflow (beta) 2020-08-10 23:19:57 +02:00
ejurgensen de5060bc57 [db] Remove a FIXME, not much of an issue 2020-08-10 23:03:37 +02:00
ejurgensen d77927d3c3 [xcode] Fix incorrect error check, unsigned int can't be negative
av_find_best_stream() returns an int, with negative being an error

Credit lgtm.com
2020-08-10 22:56:08 +02:00
ejurgensen d9177dfb25 [artwork] Remove some superfluous checks
Credit lgtm.com
2020-08-10 22:50:04 +02:00
ejurgensen a0876e532c [websocket] Prefix globals with websocket_
Avoids e.g. "event" being both the name of a global and a parameter name in
send_notify_reply()

credit lgtm.com
2020-08-10 22:36:00 +02:00
ejurgensen 23be5aa749 [config] Name change to avoid overlapping/hiding global variable "cfg"
credit lgtm.com
2020-08-10 22:29:02 +02:00
ejurgensen 5e6b5fbe8a [httpd/logger] Use gmtime_r/localtime_r instead of gmtime/localtime
gmtime and localtime are not thread safe

credit lgtm.com
2020-08-10 22:23:21 +02:00
ejurgensen fada4c0ee7 [lastfm] Fix incorrect error condition test 2020-08-10 22:08:35 +02:00
ejurgensen 47779e59e7 [input] Fix memleak of path when seting up a new input file
Credit @whatdoineed2do

Closes #1067
2020-08-10 22:01:49 +02:00
whatdoineed2do/Ray 249809469d [README] fix anchor link 2020-08-10 21:51:44 +02:00
whatdoineed2do/Ray 3a0d4edc21 [README,config] db backup 2020-08-10 21:51:44 +02:00
whatdoineed2do/Ray 76d35f5abc [scan] bulk_scan() counter reset before processing any library dirs 2020-08-09 22:33:23 +02:00
ejurgensen 55d5289c05 [player] Add settings for persisting repeat, shuffle and consume
Closes issue #963
2020-07-24 20:15:03 +02:00
ejurgensen 3245b81e60 [settings] Add shorthand macros for getting/setting options 2020-07-24 20:15:03 +02:00
whatdoineed2do/Ray d567bd004a [db,conf,json] new backup endpoint 2020-07-24 20:07:42 +02:00
ejurgensen 2ca10d9bba Bump to version 27.2 2020-07-24 00:48:49 +02:00
ejurgensen 607283528b ChangeLog and README for forked-daapd 27.2 2020-07-24 00:48:05 +02:00
ejurgensen a71444d3e1 [player] Limit auto reconnection + add option for user override
With this commit auto reconnection per default will only be done for ATV4s and
HomePods. Reconnection is not always desirable, for instance if the device cuts
the connection because it is busy with something else, ref. issue #934.

The commit also adds an option to override auto reconnection, thus either
enabling it for other devices or disabling it for affected devices.
2020-07-24 00:10:26 +02:00
ejurgensen e8bdcd2365 [xcode] Use ffmpeg's "image2pipe" muxer instead of "image2"
With ffmpeg 4.3 it seems image2 no longer works for non-file output, so use
image2pipe instead.

Closes #1061
2020-07-19 23:52:42 +02:00
ejurgensen d0a7d5114b [http] Drop own Shoutcast metadata requestor, rely on ffmpeg now
ffmpeg/libav has been capable of this since approx 2016, so the fallback
functions can be dropped now.

Also means we don't add automatically add Icy-MetaData: 1 to request
headers any more.
2020-07-17 00:08:16 +02:00
ejurgensen 3e707c4060 [http] Make libcurl a hard requirement
Always using libcurl makes the code simpler, plus makes sure we always have a
https client
2020-07-16 23:30:05 +02:00
ejurgensen 941fb47c1d [player] Only resurrect speakers that fail during playback
Fix bug where we would resurrect speakers, incl restart playback, if the speaker
disconnected after a flush.

Closes #1057
2020-07-16 23:08:58 +02:00
ejurgensen c4d6e1c251 [raop] Extra logging of invalid retransmit headers 2020-07-16 21:30:48 +02:00
ejurgensen 019b921dc4
Merge pull request #1055 from whatdoineed2do/readme-als-with-devnames
[README] show configuration using ALSA device aliases
2020-07-15 23:10:14 +02:00
whatdoineed2do/Ray e598e4a592 [README] show configuration using ALSA device aliases 2020-07-15 13:41:00 +01:00
ejurgensen 703f528599
Merge pull request #1054 from whatdoineed2do/alsa-dump-card-with-devnames
[alsa] dump_card() includes ALSA device name
2020-07-15 10:14:14 +02:00
whatdoineed2do/Ray c6c1e8f9ee [alsa] dump_card() includes ALSA device name
Include ALSA's device name in the ALSA modules 'info' logging to help
identify sound devices as seen by the system for assisting config setup

Many configs use ALSA's hw ids to refer to device but ALSA can also use
device names:

    laudio: Available ALSA playback mixer(s) on hw:0 CARD=Intel (HDA Intel): 'Master' 'Headphone' 'Speaker' 'PCM' 'Mic' 'Beep'
    laudio: Available ALSA playback mixer(s) on hw:1 CARD=E30 (E30): 'E30 '

From the example above can use these ALSA names interchangably:
    'hw:0' and 'hw:Intel'
    'hw:1' and 'hw:E30'
2020-07-14 21:55:46 +01:00
ejurgensen 5a864351d3
[cfg] Minor text changes 2020-07-06 11:31:04 +02:00
ejurgensen 6be2678fe6 Update issue templates 2020-07-06 10:37:58 +02:00
ejurgensen 41688ac53b Update issue templates 2020-07-06 10:37:10 +02:00
ejurgensen ec6265dcc7 Update issue templates 2020-07-06 10:35:59 +02:00
ejurgensen a5ae190d7c Update issue templates 2020-07-06 10:30:51 +02:00
ejurgensen 67f16138c5 [pipe] Change int64_t print mask for log message
Removes compiler warning
2020-07-05 20:59:03 +02:00
ejurgensen 2f702ed3ef Merge branch 'spotify_logout1' 2020-07-05 20:45:54 +02:00