Commit Graph

2735 Commits

Author SHA1 Message Date
ejurgensen
ad01d65047 [alsa] Let the user configure an offset to sync audio if required 2016-04-14 09:48:48 +02:00
ejurgensen
e23fed4ac4 [alsa] Avoid call to snd_pcm_prepare if already in the right state 2016-04-14 09:48:48 +02:00
ejurgensen
19181007f4 [alsa] Increase max latency variance
Latency on the RPi varies quite a bit
2016-04-14 09:48:48 +02:00
ejurgensen
632bfd9a33 [alsa] Add low-tech sync with the player (and AirPlay) 2016-04-14 09:48:48 +02:00
ejurgensen
eca41e306e [alsa] Try to measure latency 2016-04-14 09:48:48 +02:00
ejurgensen
857055a18d [player] Insert duplicate packets slowly on timer overrun 2016-04-14 09:48:48 +02:00
ejurgensen
084a86597b [laudio] Remove OSS4 support and move dummy output to outputs interface 2016-04-14 09:48:48 +02:00
ejurgensen
1a5e1da9ae [alsa] Fixup of volume return values 2016-04-14 09:48:47 +02:00
ejurgensen
acc1ff4a47 [player] Sort devices and autoselect based on priority 2016-04-14 09:48:47 +02:00
ejurgensen
c5bb83480d [alsa] Add rewritten ALSA to generic outputs interface 2016-04-14 09:48:47 +02:00
ejurgensen
f1fb86e7e1 [raop] Stop writing when a teardown has been requested 2016-04-14 09:48:47 +02:00
ejurgensen
617303d545 [player] Purge laudio from player.c 2016-04-14 09:48:47 +02:00
ejurgensen
36755031cb [outputs] Make a wrapper for mp3 streaming so it can be included in
the generic outputs interface and so special handling in player.c can
be removed
2016-04-14 09:48:47 +02:00
ejurgensen
a07c24d625 [player] Fix possible segfault after playback stop on FreeBSD/machines with lo-res timers 2016-04-14 08:55:59 +02:00
ejurgensen
bf27a879df [filescanner] Use libinotify for FreeBSD (should fix issue #245)
Filescanner was broken in FreeBSD. Besides fixing this, using
libinotify instead of kqueue directly should make the code easier
to maintain, since it will be less divergent.

This commit includes these changes:
- Add libinotify to FreeBSD install scripts
- Fix reading multiple events from inotify fd (possible bug in Linux too)
- Deferred scanning since FreeBSD doesn't have IN_CLOSE_WRITE
- Configure search for inotify library
- Removal of kqueue stuff
2016-04-12 22:11:56 +02:00
ejurgensen
3be8afac7b [daap] Fix problem where playlists in Remote are not in correct order
Apparantly having "LIMIT -1 OFFSET 0" makes (certain versions?) of
sqlite3 unable to do the "ORDER BY". Might be a bug in sqlite. This
is only a partial fix, which will work for queries that don't actually
use an index. Those few that do may still be broken.
2016-04-10 00:11:33 +02:00
chme
7713096d84 [mpd] Return playlists if 'lsinfo' is called without any parameters 2016-04-05 21:04:44 +02:00
ejurgensen
36a9ed8fe8 [raop] Omit timing request source address check
Creates a problem with ipv6 where the timer request source address may
differ from the address that mdns gave us when we created the seesion.
See https://github.com/mikebrady/shairport-sync/issues/254
2016-03-29 19:36:40 +02:00
ejurgensen
a22aff5d1f [filescanner] Switch misplaced arguments in process_directories (FreeBSD)
Should help with issue #239. Also change process_directory so it uses
same argument order as process_directories.
2016-03-27 20:35:23 +02:00
ejurgensen
42e68311eb [transcode] Increase read timeout slightly 2016-03-25 20:56:08 +01:00
ejurgensen
dbf9a208b8 [dacp] Don't return hard error if queue item goes missing
Remote doesn't seem to like the 500 Internal error we were sending
if queue item went missing, e.g. during pause.
2016-03-23 20:38:19 +01:00
ejurgensen
c4713d8b39 [httpd] Improve log message 2016-03-21 19:26:54 +01:00
ejurgensen
7d1d52e8f0 [transcode] Fix missing channel number for newer ffmpeg (closes #241) 2016-03-20 19:22:16 +01:00
chme
1fb1fc7d2d [player] Add config option to disable clearing the queue after playback
stops (default is clearing the queue) and if true do not clear the
queue.

This option is necessary because some dacp clients rely on the queue
being empty if player is stopped. Retune for example does not always
show the queue contents if player state is stopped.
2016-03-20 07:45:21 +01:00
chme
e3750957f5 [player] Allow removing by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
ed2fe682fe [player] Allow moving by position (dacp-requests) if player is stopped 2016-03-19 09:40:36 +01:00
chme
cb919515e4 [dacp] Start playback from selected song in the playqueue if player is
stopped
2016-03-19 09:40:36 +01:00
chme
d000ea571b [dacp] Return the playqueue even if player is stopped 2016-03-19 09:40:36 +01:00
chme
07947a526d [mpd] Do not start playback automatically after adding songs to the
queue
2016-03-19 09:40:36 +01:00
chme
d35894ac15 [mpd] Return correct item-id for command 'addid' and return correct
number of items in the queue if player is stopped for command 'status'
2016-03-19 09:40:36 +01:00
ejurgensen
b454a2fd60 [general] Put back support for platforms without pipe2(), see issue #239 2016-03-17 22:20:16 +01:00
ejurgensen
ec43195633 [alsa] Really don't query snd_pcm_delay() during an underrun 2016-03-17 13:56:15 +01:00
ejurgensen
e65361ba17 [alsa] Don't query snd_pcm_delay() during an underrun 2016-03-17 12:54:17 +01:00
ejurgensen
d2d52c7d68 [alsa] Do not kill threshold, it gives underruns after snd_pcm_prepare() 2016-03-17 12:46:51 +01:00
ejurgensen
8b2c68af0e [alsa] Try to fix issue where devices with small buffers would
overrun, rendering the device unusable because snd_pcm_writei()
starts blocking. This is just a poor temporary fix until we
either start using SND_PCM_NONBLOCK or put alsa in it's own thread
or implement Pulseaudio...
2016-03-16 22:54:27 +01:00
ejurgensen
5f3578ec65 [alsa] Some extra logging for debugging 2016-03-15 22:59:12 +01:00
ejurgensen
abce1d0eeb Merge pull request #237 from chme/threadnames
Set thread names
2016-03-12 17:18:34 +01:00
chme
98d6db002f Set thread names to make it easier to identify threads during debugging 2016-03-12 14:01:08 +01:00
chme
9a5b67031e [player] Remove unnecessary check for plid != 0 and set plid always to 0
if queue changed
2016-03-12 14:01:08 +01:00
ejurgensen
fba6293be6 Merge pull request #238 from chme/spotifyvirtualpath
[spotify] Add the owner of playlist to the virtual path
2016-03-12 13:23:47 +01:00
chme
3e8221e377 [spotify] Add the owner of playlist to the virtual path of a spotify
playlist to avoid duplicate virtual paths
2016-03-12 13:10:08 +01:00
chme
39c60cb211 [mpd] Fix indentation 2016-03-12 08:27:59 +01:00
chme
cd5aee1595 [mpd] Allways return an error message if mpd command exits with error,
otherwise the command will lead to a segfault (e. g. calling lsinfo with
a non existent directory path segfaults)
2016-03-12 08:27:59 +01:00
ejurgensen
598ae1bd71 [chromecast] json-c < 0.11 compability 2016-03-06 21:33:49 +01:00
ejurgensen
bd61399e49 [player] Only catch up by lowering sample rate if data_kind is http or pipe 2016-03-06 10:55:10 +01:00
ejurgensen
4d1a45e5d8 Merge pull request #235 from chme/queuemovefix
[queue] Fix moving a song to the last position in the queue failed
2016-03-05 15:04:36 +01:00
chme
1ec7ad683e [queue] Fix moving a song to the last position in the queue failed 2016-03-05 14:26:17 +01:00
chme
167d5117be [spotify] Remove options to exclude starred songs from the artist/album
override
2016-03-05 12:55:34 +01:00
ejurgensen
7aba0bf332 [filescanner] Support TDR tag (date released) and parse years better 2016-03-05 00:14:45 +01:00
ejurgensen
1188a79e57 [filescanner] Also set year if date tag present 2016-03-04 22:37:56 +01:00
ejurgensen
cbaea95ff4 [filescanner] Support for songdatereleased and songhasbeenplayed 2016-03-04 22:37:56 +01:00
ejurgensen
7135406531 [filescanner] Log message if user attempts to use LastFM/Spotify on unsupported build 2016-03-03 22:20:13 +01:00
ejurgensen
3000341acd [player] Different timer catch up for files + remove timer abort
Timer abort should no longer apply since we may catch up for more
than a second. Introduce separate catch up strategies for files and
streams, since for files we can read at our own pace.
2016-02-28 22:28:37 +01:00
ejurgensen
220494e8b1 Merge pull request #232 from chme/mpdmove
[mpd] Implement mpd command 'move'
2016-02-28 20:28:24 +01:00
chme
494a936caa [mpd] Implement mpd command 'move' 2016-02-21 19:01:52 +01:00
chme
c1dcc0a937 [db] Make loading of playlistitem count optional 2016-02-21 18:05:11 +01:00
ejurgensen
29dbc6bd9d [chromecast] Don't set cert file, doesn't seem very portable 2016-02-12 22:04:07 +01:00
ejurgensen
a824f73779 [player] Remove some debug log messages 2016-02-12 22:00:10 +01:00
ejurgensen
00d4148a90 [raop] Move RAOP specific states away from the generic output state enum 2016-02-12 21:59:26 +01:00
ejurgensen
48592406ed [chromecast] Fix probe segfault 2016-02-12 21:26:06 +01:00
ejurgensen
565d29529a [chromecast] Remove log message 2016-02-11 22:54:47 +01:00
ejurgensen
441f36a58b [chromecast] Fix segfault when cleaning up after missing reply 2016-02-11 20:04:30 +01:00
ejurgensen
bd75281340 [player] Save speaker name and rename raop_ to output_ 2016-02-11 20:04:30 +01:00
ejurgensen
93ea34796a [chromecast] Fix typo 2016-02-11 20:04:30 +01:00
ejurgensen
23db4c3f4e [chromecast] Support protobuf v1 2016-02-11 20:04:30 +01:00
ejurgensen
dcdefea721 [chromecast] Don't let a reply timeout crash the callbacks 2016-02-11 20:04:30 +01:00
ejurgensen
f4719e8681 [chromecast] Add a reply timeout so we don't freeze if a response goes missing 2016-02-11 20:04:30 +01:00
ejurgensen
483a428bae [chromecast] Try to improve session handling + actually remove device on mdns cb 2016-02-11 20:04:29 +01:00
ejurgensen
e4d209f8a0 [chromecast] Support for most basic functionality 2016-02-11 20:04:29 +01:00
ejurgensen
7d6c670fee [chromecast] Fix host address, some more commands, add flush timer 2016-02-11 20:04:29 +01:00
ejurgensen
5049426573 [raop] Protect against possible invalid reads in for loops 2016-02-11 20:04:29 +01:00
ejurgensen
ebf2d7722e [chromecast] Fixup cb register error + use actual hostname 2016-02-11 20:04:29 +01:00
ejurgensen
5e239cfbb2 [chromecast] Volume support and fix double free 2016-02-11 20:04:29 +01:00
ejurgensen
153ed98dba [chromecast] Begin adding actual Chromecast support (basic playback) 2016-02-11 20:04:29 +01:00
ejurgensen
cd841ad7b5 [outputs] Reorganise new generic output interface 2016-02-11 20:04:29 +01:00
ejurgensen
233fa24ffd [raop] Fix possibly old "read after free" bug 2016-02-11 20:04:29 +01:00
ejurgensen
ffe8653d9e [chromecast] Remove RAOP specifics from player.c, add generic output interface 2016-02-11 20:04:29 +01:00
ejurgensen
4c887ba7bb [chromecast] First building blocks for supporting ChromeCast 2016-02-11 20:04:29 +01:00
ejurgensen
62eb1a067d [player] Rename ticks to overrun and safeguard against decreasing from 0 2016-02-11 20:02:17 +01:00
ejurgensen
5f5a138c77 [player] Fix for player getting ahead of network streams (issue #218)
Issue caused stuttering after a few hours. This fix will check if
the player is getting behind the playback timer. Apparently, we
sometimes get samples at a rate slightly below 44100 from network
streams, and then we end up consuming too quickly. This introduces
a way of reducing consumption if that happens.
2016-02-11 08:29:29 +01:00
ejurgensen
73cddbb9de [transcode] Fix type of stream_index so the tests make sense 2016-02-06 19:51:13 +01:00
ejurgensen
3aab9b2622 Merge pull request #227 from chme/plchangesposid
[mpd] Implement command 'plchangesposid'
2016-02-06 13:10:20 +01:00
ejurgensen
e9986e9c9f [filescanner] Remove var not used in FreeBSD section 2016-02-06 11:08:45 +01:00
chme
73d5832d98 [filescanner] Fix use of uninitialized variable 2016-02-06 10:30:10 +01:00
chme
4878dce0b0 [mpd] Implement command 'plchangesposid' 2016-02-06 08:39:01 +01:00
chme
b84df9c5c3 [filescanner] Fix compile error on freebsd 2016-02-06 07:44:19 +01:00
chme
491bf54fdb [directories/spotify] Init db with disabled spotify-root-directory and
enable only on successful login to spotify
2016-01-31 08:14:03 +01:00
chme
cd5462e241 [filescanner] attempt at fixing compile errors on freebsd after the
introduction of the directories table
2016-01-31 08:14:03 +01:00
chme
8600c21424 [db-upgrade] add column date_released to files table, add column name to
speakers table
2016-01-31 08:14:03 +01:00
chme
dcfec5c1d4 [filescanner] Do not process parent directories on inotify callback 2016-01-29 19:29:02 +01:00
chme
9197f0f64b [spotify] fixup - added error handling 2016-01-24 18:59:05 +01:00
chme
1a6565e512 [directories] Initialize root directories on db init 2016-01-24 18:51:22 +01:00
chme
7678f98879 fixup - use sizeof instead of PATH_MAX 2016-01-24 18:51:22 +01:00
chme
c23cbde6ac fixup - remove unused enum, remove unused local variable, remove
duplicate error log for failure in create_virtual_path, remove
unnecessary empty lines
2016-01-24 18:51:22 +01:00
chme
171e30aead [mpd] use qualifier in select queries, return error message if an error
occurs (otherwise this results in a segfault)
2016-01-24 18:51:22 +01:00
chme
2611d06ab7 [mpd] add support for commands 'listall' and 'listallinfo' 2016-01-24 18:51:22 +01:00
chme
7703a997c4 [db/filescanner/spotify] Replace filelist-view with separate
directories-table
to increase the performance of the mpd command 'lsinfo'
2016-01-24 18:51:22 +01:00
chme
3740486348 [db] Move database upgrade logic to separate file 2016-01-24 18:51:22 +01:00
chme
1d69a3de90 [mpd] Add fallback to IPv4 if IPv6 failed 2016-01-24 18:51:22 +01:00
chme
9a1c8409cf [mpd] optimize query selecting files for virtual_path to use the index 2016-01-24 18:51:21 +01:00