Commit Graph

6747 Commits

Author SHA1 Message Date
ejurgensen
60c0afb5c5 [db] Test with new index 2024-10-28 22:06:31 +01:00
ejurgensen
3b28960675 [docs] Document changing track attribs time_played/time_skipped 2024-10-17 23:42:09 +02:00
ejurgensen
12f728629f [json-api] Setting of track attribs time_played/time_skipped and make generic 2024-10-17 23:31:46 +02:00
ejurgensen
750f83b7e0 [httpd] Fixup commit 5d7e3dc0 in case NULL isn't zero 2024-10-17 19:58:25 +02:00
ejurgensen
5d7e3dc090 [httpd] Add parameter "no_register_playback" for DAAP/RSP streaming 2024-10-17 19:48:14 +02:00
ejurgensen
880f5b2bf6 [json_api] Method for setting skip_count and for setting play_count directly 2024-10-16 16:42:24 +02:00
ejurgensen
8ae25aaf3e
[docs] Update Chromecast note about Nest Hub 2024-10-14 23:09:43 +02:00
ejurgensen
09a70ad993 [docs] Update Makefile.am with updated doc sources 2024-10-11 19:43:06 +02:00
ejurgensen
7da811e3b3 [docs] Brush up the documentation
* Try to organize after expected user need
* Update mkdocs stuff and fix a broken link
* Move web building info to building.md
* Add info about Roku Soundbridge
* Add note about Google Nest not working
2024-10-11 19:29:49 +02:00
ejurgensen
75a1082b0a [mpd] Add getvol, bump version to 0.23.0 2024-10-08 23:43:34 +02:00
ejurgensen
ebec99cc9d [mpc] Support for readpicture and albumart 2024-10-08 20:35:12 +02:00
ejurgensen
601f5a7657 [gh-actions] Add FreeBSD build workflow using vmactions 2024-10-07 23:50:21 +02:00
ejurgensen
81cf713a83 [daap] Fix for Apple Music/iTunes not working on Airplay host (attempt 2)
OwnTone selects ALAC for daap streaming because it thinks the client is an Airplay speaker.

Regression in 28.10 coming from PR #1698.

Fixes #1816
2024-09-30 19:59:34 +02:00
ejurgensen
b9fa790f50 Revert "[daap] Fix for Apple Music/iTunes not working on Airplay host"
This reverts commit 73864e82cd.
2024-09-30 16:13:31 +02:00
ejurgensen
73864e82cd [daap] Fix for Apple Music/iTunes not working on Airplay host
OwnTone selects ALAC for daap streaming because it thinks the client is an Airplay speaker.

Regression in 28.10 coming from PR #1698.

Fixes #1816
2024-09-29 22:22:26 +02:00
ejurgensen
ba4b2c8ddd [httpd/daap] Improve logging of speaker profile selection 2024-09-28 20:31:13 +02:00
ejurgensen
17ef308489 [mpd] Fix outputs enable/disable/toggle not working in v28.10
Also simplify code by using new speaker index from player and remove some code
duplication.

Regression from PR #1779. Fixes #1814.
2024-09-25 19:31:16 +02:00
ejurgensen
a983302b03 [player] Add a index attribute to struct player_speaker_info + a getter 2024-09-25 19:28:53 +02:00
github-actions[bot]
dc41f0d84c [web] Rebuild web interface 2024-09-24 18:40:06 +00:00
Alain Nussbaumer
164d6ac9b2 [web] Update to newer versions of libraries 2024-09-24 20:39:32 +02:00
Fabian Groffen
75222cafd3 [mpd] outputs: drop invalid outputsvolume key
This key confuses some clients, and it isn't emitted by MPD, nor
documented to exist:
9ff8e02e54/src/output/Print.cxx

It was added in bdb2c7493, but without explanation why it was added to
outputs command.

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-09-16 21:21:46 +02:00
ejurgensen
94ce56d7b1 [mpd] Add Bison/Flex parser for complex mpd commands + misc
Some of the misc:
* Initialize query_params from the start of each function
* Reduce code duplication by consolidating the handler's integer conversion
* Go back to classic int return types for handlers
* Change list grouping to respond like mpd
* Sanitize all user string output
2024-09-16 21:17:32 +02:00
ejurgensen
1e485f7d28 [mpd] Make protocol version a #define 2024-09-16 21:17:32 +02:00
ejurgensen
6b55ee2890 [db] free_query_params should also free qp->group
Plus honor qp->order in queue_enum_start() if set by caller
2024-09-16 21:17:32 +02:00
ejurgensen
783f918c5e [mpd] Refactor commit 9962c743 and other stuff in mpd.c 2024-09-16 21:17:32 +02:00
gd
4b8ecfe18d [mpd] Fix: allow password command when not authenticated 2024-09-16 21:17:32 +02:00
gd
e1628ff1a9 [mpd,db] MPD protocol fixes to handling of idle/noidle command and command list.
Command handling:
1. Changed mpd_read_cb() to delegate to mpd_process_line() for each received
command line.
2. mpd_process_line() handles idle state and command list state and delegates
to mpd_process_command() to handle each command line.
If the command was successful it sends OK to the client according the the
command list state.
Error responses are sent by mpd_process_command().
3. mpd_process_command() parses the args and delegates to the individual
command handler.

mpd_input_filter:
1. Removed handling of command lists. They are handled by mpd_process_line().
2. Return BEV_OK if there's at least one complete line of input even if there's
more data in the input buffer.

Idle/noidle:
1. Changed mpd_command_idle() to never write OK to the output buffer.
Instead it is the responsibility of the caller to decide on the response.

2. Removed mpd_command_noidle() instead it is handled in mpd_process_line().
If the client is not in idle state noidle is ignored (no response sent)
If the client is in idle state then it changes idle state to false and sends
OK as the response to the idle command.

Command lists:
1. Added command list state to the client context so commands in the list are
buffered and only executed after receiving command_list_end.

Connection state:
1. Added is_closing flag in the client context to ignore messages received
after freeing the events buffer in intent to close the client connection.

Command arguments parsing:
1. Updated COMMAND_ARGV_MAX to 70 to match current MPD.
2. Changed mpd_pars_range_arg to handle open-ended range.

Command pause:
1. pause is ignored in stopped state instead returning error.

Command move:
1. Changed mpd_command_move() to support moving a range.
2. Added db_queue_move_bypos_range() to support moving a range.

Command password:
1. Password authentication flag set in handler mpd_command_password() instead
of in command processor.

Config:
1. Added config value: "max_command_list_size".
   The maximum allowed size of buffered commands in command list.
2024-09-16 21:17:32 +02:00
ejurgensen
e9485d34ae Bump to version 28.10 2024-09-12 17:23:08 +02:00
ejurgensen
1bee7e0d4b ChangeLog for OwnTone 28.10 2024-09-12 17:21:51 +02:00
ejurgensen
3c99e5a35c [mpd] Set protocol version back 0.20.0
Announcing 0.22.4 without supporting the newer protocol's filters breaks Rigelian
2024-09-12 17:15:48 +02:00
ejurgensen
2bf0505cca Revert "[docs] Add note to README about Spotify being broken"
This reverts commit e82340247d.
2024-09-06 17:06:14 +02:00
ejurgensen
e82340247d [docs] Add note to README about Spotify being broken
Ref #1803
2024-09-05 21:41:15 +02:00
ejurgensen
40c22e3d2f [mpd] Fix possible stack buffer overflow in argument parser 2024-08-28 20:11:07 +02:00
ejurgensen
ecab3266ce [misc] Fix XML-encoding of strings with XML chars
xmlNewDocRawNode() takes unescaped strings, so it can handle a string with
like "Sweet & Low"

Closes #1798
2024-08-23 21:12:25 +02:00
github-actions[bot]
ab63f8f834 [web] Rebuild web interface 2024-08-22 20:06:59 +00:00
Alain Nussbaumer
f08de1fc32 [web] Remove text "No results." at the end of Spotify album list 2024-08-22 22:06:28 +02:00
Alain Nussbaumer
f54a435d15 [web] Fix opening of Spotify playlists 2024-08-22 22:05:29 +02:00
github-actions[bot]
028adbaa1c [web] Rebuild web interface 2024-08-22 19:40:48 +00:00
Alain Nussbaumer
f3a656d313 [web] Fix for package-lock.json 2024-08-22 21:40:18 +02:00
Alain Nussbaumer
f02038f5e9 [web] Upgrade to new version of axios library 2024-08-22 21:37:08 +02:00
Alain Nussbaumer
12eaa85c74 [web] Remove sass processor warnings 2024-08-22 21:34:45 +02:00
Alain Nussbaumer
ee6f81a618 [web] Format translation file 2024-08-22 21:34:45 +02:00
Alain Nussbaumer
8b586728b6 [web] Change to Pinia store 2024-08-22 21:34:45 +02:00
ejurgensen
ed16cc7928 [scan] Fix playlist scanner ignoring lines starting with non-ascii chars
Resolves #1795
2024-08-20 19:05:36 +02:00
ejurgensen
92495a7fac [httpd] Fix crash if websocket init fails, e.g. port can't be bound
Ref PR #1792
2024-08-14 17:44:22 +02:00
Fabian Groffen
282e227c64 [mpd] bump supported version to 0.22.4
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-13 16:10:56 +02:00
Fabian Groffen
a0d7c1a34f [mpd] add binarylimit command (unused still)
Maintain the binary limit, and use the default MPD uses too.  This comes
in handy when we are going to send binary responses such as in PR #1780

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-13 16:10:56 +02:00
Fabian Groffen
42ac0528a9 [mpd] update server version to 0.21.0
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-12 10:40:36 +02:00
Fabian Groffen
c0331f527e [mpd] implement oneshot for single mode as noop for 0.21 protocol
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-12 10:40:36 +02:00
Fabian Groffen
8eae74257d [mpd] add "httpd" output plugin when enable_http_plugin
Return MPD-compatible output of plugin type "httpd" when
enable_http_plugin in mpd section of the config is set.

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-10 20:38:41 +02:00