Klaus Post
6c89a81af4
Fix CreateFile shared buffer corruption. ( #18652 )
...
`(*xlStorageDiskIDCheck).CreateFile` wraps the incoming reader in `xioutil.NewDeadlineReader`.
The wrapped reader is handed to `(*xlStorage).CreateFile`. This performs a Read call via `writeAllDirect`,
which reads into an `ODirectPool` buffer.
`(*DeadlineReader).Read` spawns an async read into the buffer. If a timeout is hit while reading,
the read operation returns to `writeAllDirect`. The operation returns an error and the buffer is reused.
However, if the async `Read` call unblocks, it will write to the now recycled buffer.
Fix: Remove the `DeadlineReader` - it is inherently unsafe. Instead, rely on the network timeouts.
This is not a disk timeout, anyway.
Regression in https://github.com/minio/minio/pull/17745
2023-12-14 10:51:57 -08:00
..
2023-12-07 01:33:56 -08:00
2023-09-04 12:57:37 -07:00
2023-10-10 00:33:42 -07:00
2023-09-14 14:50:16 -07:00
2023-07-03 09:47:40 -07:00
2023-10-11 21:18:17 -07:00
2023-10-11 09:06:40 -07:00
2023-09-14 14:50:16 -07:00
2023-12-07 01:33:56 -08:00
2023-11-24 09:46:55 -08:00
2023-09-04 12:57:37 -07:00
2023-09-04 12:57:37 -07:00
2023-11-29 16:07:35 -08:00
2023-12-05 02:16:33 -08:00
2023-12-08 12:26:01 -08:00
2023-11-21 09:48:06 -08:00
2023-06-19 17:53:08 -07:00
2022-01-03 01:28:52 -08:00
2023-09-25 08:13:08 -07:00
2023-10-23 21:16:40 -07:00
2022-01-02 09:15:06 -08:00
2023-10-11 21:18:17 -07:00
2023-06-07 11:25:26 -07:00
2023-11-22 13:46:17 -08:00
2023-10-11 21:18:17 -07:00
2022-01-02 09:15:06 -08:00
2023-03-06 08:56:10 -08:00
2023-10-23 21:16:40 -07:00
2023-09-14 14:50:16 -07:00
2023-09-18 10:00:54 -07:00
2023-05-05 19:53:12 -07:00
2023-09-04 12:57:37 -07:00
2023-01-05 20:41:19 -08:00
2023-12-13 19:27:55 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-12-06 01:09:22 -08:00
2023-08-29 11:27:23 -07:00
2023-12-02 02:51:33 -08:00
2023-12-06 18:17:03 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-08-29 11:27:23 -07:00
2023-11-22 10:51:46 -08:00
2023-11-22 10:51:46 -08:00
2023-08-29 11:27:23 -07:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2023-12-02 02:51:33 -08:00
2022-12-23 07:46:00 -08:00
2022-07-25 12:37:26 -07:00
2023-11-27 09:15:06 -08:00
2022-08-04 16:10:08 -07:00
2022-05-27 06:00:19 -07:00
2023-08-23 03:07:06 -07:00
2023-11-28 10:39:02 -08:00
2023-09-04 12:57:37 -07:00
2022-10-24 17:44:15 -07:00
2023-07-28 10:49:20 -07:00
2023-12-13 19:27:55 -08:00
2022-05-31 02:57:57 -07:00
2023-12-01 07:56:24 -08:00
2023-06-13 13:52:33 -07:00
2023-11-21 09:48:06 -08:00
2023-12-02 13:02:12 -08:00
2023-09-04 12:57:37 -07:00
2023-05-24 22:52:39 -07:00
2023-11-21 09:48:06 -08:00
2023-09-04 12:57:37 -07:00
2023-09-04 12:57:37 -07:00
2023-09-04 12:57:37 -07:00
2023-09-04 12:57:37 -07:00
2023-09-04 12:57:37 -07:00
2023-11-27 11:30:19 -08:00
2023-09-18 22:13:03 -07:00
2023-09-16 02:28:06 -07:00
2023-10-27 21:08:53 -07:00
2023-08-30 01:00:59 -07:00
2023-08-30 01:00:59 -07:00
2023-12-06 18:17:03 -08:00
2023-08-30 01:00:59 -07:00
2022-08-22 16:53:06 -07:00
2023-07-12 23:51:33 -07:00
2023-08-08 13:27:40 -07:00
2023-09-19 03:18:28 -07:00
2023-12-13 19:27:55 -08:00
2023-08-30 01:00:59 -07:00
2023-08-30 01:00:59 -07:00
2023-08-30 01:00:59 -07:00
2023-10-27 21:08:53 -07:00
2023-09-04 12:57:37 -07:00
2022-10-24 17:44:15 -07:00
2022-06-16 16:10:48 -07:00
2023-11-24 09:59:35 -08:00
2022-09-19 11:05:16 -07:00
2023-12-08 12:04:54 -08:00
2023-09-18 10:00:54 -07:00
2022-12-19 11:10:14 -08:00
2023-12-02 02:51:33 -08:00
2022-01-02 09:15:06 -08:00
2023-06-19 17:53:08 -07:00
2023-10-18 11:05:24 -07:00
2023-10-18 11:05:24 -07:00
2023-08-23 03:07:06 -07:00
2023-09-04 12:57:37 -07:00
2023-07-08 07:31:42 -07:00
2023-07-08 07:31:42 -07:00
2023-08-24 09:26:29 -07:00
2023-09-24 22:15:31 -07:00
2023-12-12 16:11:17 -08:00
2023-07-17 09:52:05 -07:00
2023-03-10 08:53:59 -08:00
2023-08-30 01:00:59 -07:00
2023-11-01 09:09:28 -07:00
2023-10-30 09:59:51 -07:00
2023-12-12 16:11:17 -08:00
2022-08-10 12:46:45 -07:00
2022-09-19 11:05:16 -07:00
2023-09-04 12:57:37 -07:00
2022-10-14 03:08:40 -07:00
2022-08-19 16:21:05 -07:00
2022-09-23 21:17:08 -07:00
2023-10-11 21:18:17 -07:00
2023-12-07 01:33:56 -08:00
2023-12-07 01:33:56 -08:00
2023-12-07 01:33:56 -08:00
2023-12-07 01:33:56 -08:00
2022-07-25 12:37:26 -07:00
2022-05-30 10:58:37 -07:00
2023-10-24 23:33:25 -07:00
2022-07-25 12:37:26 -07:00
2023-08-03 02:18:18 -07:00
2023-11-28 22:35:16 -08:00
2023-05-25 09:39:06 -07:00
2022-08-04 16:10:08 -07:00
2023-08-03 02:18:18 -07:00
2023-12-08 12:26:01 -08:00
2023-11-28 22:35:16 -08:00
2023-11-22 13:46:17 -08:00
2023-12-08 12:26:01 -08:00
2023-09-04 08:24:17 -07:00
2023-07-03 09:47:40 -07:00
2023-11-22 13:46:17 -08:00
2023-11-22 13:46:17 -08:00
2023-12-04 11:13:50 -08:00
2023-11-28 22:35:16 -08:00
2023-12-08 12:26:01 -08:00
2022-01-11 18:48:43 -08:00
2022-07-04 14:02:54 -07:00
2023-07-03 09:47:40 -07:00
2023-12-01 07:56:24 -08:00
2022-10-25 12:36:57 -07:00
2022-10-25 12:36:57 -07:00
2023-10-06 06:55:15 -06:00
2023-12-13 19:27:55 -08:00
2023-07-20 07:48:21 -07:00
2023-12-13 19:27:55 -08:00
2023-12-06 18:17:03 -08:00
2023-12-01 00:18:04 -08:00
2023-06-24 20:29:13 -07:00
2023-12-05 02:16:33 -08:00
2023-08-01 10:54:26 -07:00
2023-11-28 22:35:16 -08:00
2023-12-06 04:31:35 -08:00
2023-12-07 01:33:56 -08:00
2023-11-20 17:09:35 -08:00
2023-12-12 16:16:26 -08:00
2023-12-05 22:34:46 -08:00
2023-12-08 12:04:54 -08:00
2023-11-20 17:09:35 -08:00
2023-12-07 16:22:00 -08:00
2023-05-15 14:08:54 -07:00
2023-11-22 10:51:46 -08:00
2022-05-27 06:00:19 -07:00
2022-11-28 10:20:55 -08:00
2023-11-16 01:51:27 -08:00
2023-01-23 16:42:47 +05:30
2023-07-18 22:25:12 -07:00
2022-01-02 09:15:06 -08:00
2023-11-20 17:09:35 -08:00
2022-03-08 13:58:55 -08:00
2023-07-24 07:56:28 -07:00
2023-05-17 17:05:36 -07:00
2023-11-27 17:20:04 -08:00
2023-12-01 00:18:04 -08:00
2023-12-01 00:18:04 -08:00
2023-04-28 12:24:14 -07:00
2023-09-14 14:50:16 -07:00
2023-09-14 14:50:16 -07:00
2023-08-19 07:37:53 -07:00
2022-07-05 14:45:49 -07:00
2022-07-05 14:45:49 -07:00
2023-07-05 10:40:45 -07:00
2023-12-01 07:56:24 -08:00
2023-11-24 09:59:35 -08:00
2023-10-05 18:16:04 -06:00
2023-03-04 20:57:35 -08:00
2023-11-20 17:09:35 -08:00
2023-11-20 17:09:35 -08:00
2023-11-24 09:07:14 -08:00
2023-03-23 10:26:21 -07:00
2023-11-20 17:09:35 -08:00
2023-11-20 17:09:35 -08:00
2023-09-04 12:57:37 -07:00
2021-11-08 10:26:08 -08:00
2022-03-25 16:29:45 -07:00
2023-09-04 12:57:37 -07:00
2022-01-02 09:15:06 -08:00
2023-09-04 12:57:37 -07:00
2022-10-24 17:44:15 -07:00
2022-12-05 11:18:50 -08:00
2023-10-06 06:55:15 -06:00
2023-12-01 00:18:04 -08:00
2022-09-19 11:05:16 -07:00
2023-07-06 16:02:08 -07:00
2023-11-20 17:09:35 -08:00
2023-11-20 17:09:35 -08:00
2023-12-01 12:01:14 -08:00
2022-11-01 16:41:01 -07:00
2023-12-06 13:19:59 -08:00
2023-12-13 19:27:55 -08:00
2023-09-30 13:40:20 -07:00
2023-12-14 09:09:26 -08:00
2023-10-11 21:18:17 -07:00
2023-12-08 12:26:01 -08:00
2023-06-05 16:56:35 -07:00
2023-11-20 21:33:47 -08:00
2023-05-03 14:12:25 -07:00
2023-09-04 12:57:37 -07:00
2023-06-19 17:53:08 -07:00
2023-12-08 08:13:04 -08:00
2022-12-23 07:46:00 -08:00
2023-11-20 17:09:35 -08:00
2023-11-22 13:46:17 -08:00
2022-12-23 07:46:00 -08:00
2023-11-20 21:33:47 -08:00
2022-12-23 07:46:00 -08:00
2023-11-17 05:29:50 -08:00
2023-12-02 02:51:33 -08:00
2023-09-25 08:13:08 -07:00
2023-10-24 23:33:25 -07:00
2023-11-22 10:51:46 -08:00
2023-05-05 19:53:12 -07:00
2023-11-20 21:33:47 -08:00
2023-11-22 13:46:17 -08:00
2023-05-24 08:00:47 -07:00
2022-01-02 09:15:06 -08:00
2023-11-22 13:46:17 -08:00
2023-11-22 16:33:11 -08:00
2023-09-14 21:58:17 -07:00
2023-11-22 13:46:17 -08:00
2023-09-13 08:14:36 -07:00
2023-11-21 15:08:41 -08:00
2023-10-18 11:08:15 -07:00
2023-10-12 00:08:13 -07:00
2022-09-19 11:05:16 -07:00
2023-09-13 08:14:36 -07:00
2023-09-13 08:14:36 -07:00
2023-09-05 20:22:23 -07:00
2023-09-05 20:22:23 -07:00
2023-08-27 09:57:11 -07:00
2023-11-02 09:49:49 -07:00
2023-11-02 09:49:49 -07:00
2023-11-06 14:26:08 -08:00
2023-12-05 22:34:46 -08:00
2023-12-13 19:27:55 -08:00
2023-11-06 14:26:08 -08:00
2023-09-04 12:57:37 -07:00
2023-11-20 21:33:47 -08:00
2023-09-18 10:00:54 -07:00
2023-09-25 12:35:25 -07:00
2023-10-18 08:06:57 -07:00
2023-01-30 18:33:07 +05:30
2022-10-25 12:36:57 -07:00
2022-10-25 12:36:57 -07:00
2023-11-20 17:09:35 -08:00
2023-10-11 21:18:17 -07:00
2023-09-24 22:15:31 -07:00
2023-12-07 01:33:56 -08:00
2023-12-07 01:33:56 -08:00
2023-12-08 12:04:54 -08:00
2023-09-04 12:57:37 -07:00
2023-06-19 17:53:08 -07:00
2023-12-07 01:33:56 -08:00
2023-10-06 07:51:50 -06:00
2022-10-24 17:44:15 -07:00
2023-12-06 04:31:35 -08:00
2023-12-07 01:33:56 -08:00
2023-02-13 01:26:38 -08:00
2023-07-12 07:18:30 -07:00
2022-10-14 03:08:40 -07:00
2022-08-26 12:52:29 -07:00
2022-10-14 03:08:40 -07:00
2023-03-06 08:56:10 -08:00
2023-11-27 11:30:19 -08:00
2023-10-19 21:32:49 -07:00
2023-12-07 01:33:56 -08:00
2023-11-27 11:30:19 -08:00
2023-06-19 17:53:08 -07:00
2023-08-30 01:00:59 -07:00
2023-08-30 01:00:59 -07:00
2023-08-30 01:00:59 -07:00
2022-11-14 07:16:40 -08:00
2022-11-14 07:16:40 -08:00
2023-10-18 08:06:57 -07:00
2023-12-05 01:14:36 -08:00
2023-11-13 22:32:08 -08:00
2023-11-20 17:09:35 -08:00
2023-11-28 22:35:16 -08:00
2022-09-19 11:05:16 -07:00
2023-11-28 22:35:16 -08:00
2023-11-28 08:39:21 -08:00
2023-11-20 21:33:47 -08:00
2023-12-13 19:27:55 -08:00
2023-11-24 09:07:14 -08:00
2023-11-20 17:09:35 -08:00
2023-11-20 17:09:35 -08:00
2023-11-22 13:46:17 -08:00
2023-12-14 10:51:57 -08:00
2022-12-01 12:10:54 -08:00
2023-08-01 08:45:57 -07:00
2023-05-05 19:53:12 -07:00
2022-05-26 17:58:09 -07:00
2023-10-10 00:33:42 -07:00
2023-09-18 22:13:03 -07:00
2023-11-29 16:07:35 -08:00
2023-08-03 13:24:25 -07:00
2023-10-24 23:33:25 -07:00
2023-06-19 17:53:08 -07:00
2023-09-14 14:50:16 -07:00
2023-10-08 12:17:08 -07:00
2023-10-30 09:59:51 -07:00
2023-08-03 14:16:15 -07:00
2022-08-26 12:52:29 -07:00
2023-12-06 18:17:03 -08:00
2023-05-26 06:31:24 -07:00
2023-04-06 17:47:38 -07:00
2022-01-02 09:15:06 -08:00
2022-01-02 09:15:06 -08:00
2023-03-06 08:56:10 -08:00
2023-07-31 08:36:19 -07:00
2023-12-07 01:33:56 -08:00
2023-09-04 12:57:37 -07:00
2021-11-16 09:28:29 -08:00
2023-06-06 10:12:52 -07:00
2023-11-22 10:51:46 -08:00
2023-10-23 13:55:45 -07:00
2023-12-11 21:51:53 -08:00
2023-06-19 17:53:08 -07:00
2023-06-19 17:53:08 -07:00
2023-09-14 15:28:20 -07:00
2023-09-28 22:33:24 -07:00
2023-11-28 22:35:16 -08:00
2022-07-25 12:37:26 -07:00
2023-11-28 22:35:16 -08:00
2023-12-14 10:51:57 -08:00
2023-03-06 08:56:29 -08:00
2023-09-02 07:49:24 -07:00
2023-09-02 07:49:24 -07:00
2023-09-02 07:49:24 -07:00
2022-08-31 12:28:03 -07:00
2023-06-18 18:20:15 -07:00
2021-11-18 12:15:22 -08:00
2022-08-31 12:28:03 -07:00
2021-12-02 11:29:16 -08:00
2023-09-02 07:49:24 -07:00
2022-10-27 09:46:52 -07:00
2023-11-28 08:31:33 -08:00
2023-09-02 07:49:24 -07:00
2023-03-06 08:56:10 -08:00
2021-11-18 12:15:22 -08:00
2023-12-13 14:54:01 -08:00