Krishnan Parthasarathi 8839c5105a Pass values to closures esp. when passed to defer statement. (#3050) ...

opsID, a variable on the stack, changes over the course of
Completemultipartupload function in xl-v1-multipart.go.  This was
being used in a function closure which was passed to defer
statement. The variables used in the closure depend on their values at
the time of evaluation which is indeterminate behaviour. It is
incorrect to depend on values of variables on stack at the end of
function, when deferred functions are executed.

2016-10-23 09:57:52 -07:00

32 KiB

Raw Blame History

View Raw