minio

Commit Graph

Author	SHA1	Message	Date
Harshavardhana	76e2713ffe	fix: use buffers only when necessary for io.Copy() (#11229 ) Use separate sync.Pool for writes/reads Avoid passing buffers for io.CopyBuffer() if the writer or reader implement io.WriteTo or io.ReadFrom respectively then its useless for sync.Pool to allocate buffers on its own since that will be completely ignored by the io.CopyBuffer Go implementation. Improve this wherever we see this to be optimal. This allows us to be more efficient on memory usage. ``` 385 // copyBuffer is the actual implementation of Copy and CopyBuffer. 386 // if buf is nil, one is allocated. 387 func copyBuffer(dst Writer, src Reader, buf []byte) (written int64, err error) { 388 // If the reader has a WriteTo method, use it to do the copy. 389 // Avoids an allocation and a copy. 390 if wt, ok := src.(WriterTo); ok { 391 return wt.WriteTo(dst) 392 } 393 // Similarly, if the writer has a ReadFrom method, use it to do the copy. 394 if rt, ok := dst.(ReaderFrom); ok { 395 return rt.ReadFrom(src) 396 } ``` From readahead package ``` // WriteTo writes data to w until there's no more data to write or when an error occurs. // The return value n is the number of bytes written. // Any error encountered during the write is also returned. func (a *reader) WriteTo(w io.Writer) (n int64, err error) { if a.err != nil { return 0, a.err } n = 0 for { err = a.fill() if err != nil { return n, err } n2, err := w.Write(a.cur.buffer()) a.cur.inc(n2) n += int64(n2) if err != nil { return n, err } ```	2021-01-06 09:36:55 -08:00
Harshavardhana	cb0eaeaad8	feat: migrate to ROOT_USER/PASSWORD from ACCESS/SECRET_KEY (#11185 )	2021-01-05 10:22:57 -08:00
Harshavardhana	38cf263409	fix: docs remove goreportcard, its deprecated	2020-03-24 14:51:06 -07:00
ebozduman	78be3f8947	Removes the incorrect coverage badge from the docs (#7651 )	2019-05-16 12:11:49 +05:30
kannappanr	5ecac91a55	Replace Minio refs in docs with MinIO and links (#7494 )	2019-04-09 11:39:42 -07:00
Harshavardhana	bab4c90c45	Fix broken links in docs (#6700 )	2018-10-25 11:39:31 +05:30
Harshavardhana	e5e522fc61	docs: fix all Chinese doc links for the new docs site (#6097 ) Additionally fix typos, default to US locale words	2018-06-28 16:02:02 -07:00
kannappanr	f8a3fd0c2a	Create logger package and rename errorIf to LogIf (#5678 ) Removing message from error logging Replace errors.Trace with LogIf	2018-04-05 15:04:40 -07:00
poornas	b7536570f8	update docs for NAS gateway (#5569 )	2018-02-22 09:15:19 +05:30
Harshavardhana	8efa82126b	Convert errors tracer into a separate package (#5221 )	2017-11-25 11:58:29 -08:00
Harshavardhana	135a6a7bb4	Add chinese translation docs. (#5224 )	2017-11-22 15:15:40 -08:00

11 Commits