Commit Graph

2329 Commits

Author SHA1 Message Date
Harshavardhana
9ca3372870 listObjects: Marker should be unescaped before being used internally.
Without this change listObjects() goes into an infinite loop for
files which have special characters i.e "++" encoded with "%2B%2B".

We have to unescape and convert them to their native representation
before being used internally.

Fixes #1052
2016-01-26 23:32:59 -08:00
Harshavardhana
5d87fdb35c Merge pull request #1051 from harshavardhana/fix-multipart
multipart: NewMultipartUpload shouldn't return empty UploadID
2016-01-26 15:15:44 -08:00
Harshavardhana
2e311168ee multipart: NewMultipartUpload shouldn't return empty UploadID
Existing code
```
{
  if os.IsNotExist(e) {
       e = os.MkdirAll(objectDir, 0700)
       if e != nil {
            return "", probe.NewError(e)
       }
  }
  return "", probe.NewError(e)  ---> Error was here.
}
```
For a successful 'MkdirAll' it would still return an empty uploadID,
but the 'error' would be nil. This would succeed the request but
client would fail.

Fix is to re-arrange the logic. Thanks to Alexander Neumann @fd0, for
reporting this problem.
2016-01-26 15:00:34 -08:00
Harshavardhana
e6df2d639c Merge pull request #1050 from fwessels/aws-cli
Updated 'aws s3 ls' example in README.md to include s3://
2016-01-26 14:28:33 -08:00
frankw
dd4c08cd79 Updated 'aws s3 ls' example in README.md to include s3:// (which is apparently needed for other 'aws s3' commands such as 'cp' or 'rm') 2016-01-26 23:09:06 +01:00
Harshavardhana
68a25aa425 Merge pull request #1039 from harshavardhana/channel-ftw
listObjects: Channel based file tree walk.
2016-01-26 12:41:21 -08:00
Harshavardhana
18375b7794 ioutils: Add tests 2016-01-26 12:34:04 -08:00
Harshavardhana
13feabefd5 diskInfo: Add DiskInfo API 2016-01-26 12:08:45 -08:00
Harshavardhana
1341fb79c3 listBuckets: Bump up the limit of max buckets to 1000. 2016-01-26 11:49:17 -08:00
Harshavardhana
f5d6be158e listObjects: Simplify channel based changes. 2016-01-26 02:19:55 -08:00
Harshavardhana
682020ef2f listObjects: Channel based changes.
Supports:
 - prefixes
 - marker
2016-01-25 20:39:38 -08:00
Krishna Srinivas
9e18bfa60e listObjects: Channel based ftw - initial implementation. 2016-01-25 18:58:07 -08:00
Harshavardhana
67a70eb6d6 Merge pull request #1046 from harshavardhana/bucket-not-empty
deleteBucket: Directory not empty error on windows is "directory is n…
2016-01-25 18:04:04 -08:00
Harshavardhana
2ec9b16667 deleteBucket: Directory not empty error on windows is "directory is not empty" 2016-01-25 17:58:43 -08:00
Harshavardhana
35d4521ece Merge pull request #1045 from harshavardhana/get-object-cleanups
api: More cleanups at WebAPI.
2016-01-25 17:45:53 -08:00
Harshavardhana
ae2f15c6d0 api: More cleanups at WebAPI.
- Fixes a bug where bucketName was not denormalized.
- Remove unneeded functions from jwt.go
2016-01-25 17:30:08 -08:00
Harshavardhana
f1ea609175 Merge pull request #1042 from harshavardhana/jwt-api
jwt: Add JWT support for minio server.
2016-01-25 16:45:22 -08:00
Harshavardhana
497f13d733 api: Various fixes.
- limit list buckets to limit only 100 buckets, all uppercase buckets
  are now lowercase and work transparently with all calls.
- Change disk.Stat to disk.GetInfo and return back disk.Info{} struct.
- Introduce new ioutils package which implements ReadDirN(path, n),
  ReadDirNamesN(path, n)
2016-01-25 16:08:27 -08:00
Harshavardhana
432a073e6b Add MakeBucket API. 2016-01-24 22:45:22 -08:00
Harshavardhana
3f1c4bb4b0 Bring in the list APIs implemented by Bala <bala@minio.io> 2016-01-24 16:39:48 -08:00
Harshavardhana
0a9496462a jwt: Add JWT support for minio server.
Please read JWT.md before using this feature.
2016-01-22 17:38:05 -08:00
Harshavardhana
d8fa68ff7e Merge pull request #1040 from hackintoshrao/make-file-edit
Minor changes to Makefile
2016-01-20 01:56:59 -08:00
Karthic Rao
b457a61cb2 Minor changes to Makefile to avoid the make failure when GOPATH/bin is not part of PATH 2016-01-20 14:46:12 +05:30
Anand Babu (AB) Periasamy
9cb590d800 Merge pull request #1038 from harshavardhana/shadow
server: Fix shadowing bug reported by go vet on go1.6beta2
2016-01-18 20:56:42 -08:00
Harshavardhana
1aec985c00 server: Fix shadowing bug reported by go vet on go1.6beta2 2016-01-18 18:45:24 -08:00
Harshavardhana
092ed972d0 Merge pull request #1037 from harshavardhana/add-config
serverConfig: Add a new region config entry.
2016-01-17 01:50:30 -08:00
Harshavardhana
cb7b2762f9 serverConfig: Add a new region config entry.
To change default region from 'us-east-1' to 'custom'.
Add a region value in your 'config.json'.

	"version": "2",
	"credentials": {
		"accessKeyId": "****************",
		"secretAccessKey": "***************",
	        "region": "my-region"
	},
2016-01-17 01:39:11 -08:00
Harshavardhana
8a7bf0dde0 Merge pull request #1036 from harshavardhana/docker
build: Do not hardcode docker binary path
2016-01-15 10:42:13 -08:00
Harshavardhana
023f799820 build: Do not hardcode docker binary path
Fixes #1035
2016-01-15 10:36:45 -08:00
Harshavardhana
8ff43086fb Merge pull request #1034 from harshavardhana/handle-cgo
build: Handle builds on env where CGO_ENABLED=0
2016-01-14 18:28:47 -08:00
Harshavardhana
88686dc6e3 build: Handle builds on env where CGO_ENABLED=0
Fixes #1033
2016-01-14 18:19:01 -08:00
Harshavardhana
3cb92bdf9c Merge pull request #1032 from koolhead17/command-modification
Modified command for adding a host to minio.
2016-01-13 10:52:12 -08:00
koolhead17
d4dbd09a9c Modified command for adding a host to minio. 2016-01-13 23:36:42 +05:30
Harshavardhana
a6941c0b44 Merge pull request #1030 from harshavardhana/expect-100
signature: Add aws-cli work-around for now.
2016-01-09 10:53:54 -08:00
Harshavardhana
8cdaf87c8f signature: Add aws-cli work-around for now.
Golang http server strips off 'Expect' header, if the
client sent this as part of signed headers we need to
handle otherwise we would see a signature mismatch.
`aws-cli` sets this as part of signed headers which is
a bad idea since servers trying to implement AWS

Signature version '4' will all encounter this issue.
According to
 http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20
Expect header is always of form:

   Expect       =  "Expect" ":" 1#expectation
   expectation  =  "100-continue" | expectation-extension

So it safe to assume that '100-continue' is what would
be sent, for the time being keep this work around.
2016-01-09 10:47:59 -08:00
Harshavardhana
70bd51994c Merge pull request #1026 from harshavardhana/add-doc
Add aws-cli documentation.
2016-01-08 20:01:38 -08:00
Harshavardhana
80d175b34c Add aws-cli documentation. 2016-01-08 19:59:23 -08:00
Harshavardhana
c963fe244d Merge pull request #1022 from koolhead17/patch-1
Update README.md
2016-01-08 10:33:10 -08:00
koolhead17
888111816d Update README.md
minor change, adding '--' with help option as we introduced the same with mc.
2016-01-08 23:47:08 +05:30
Harshavardhana
3bf7685327 Merge pull request #1021 from harshavardhana/transfer-encoding
http: Enable Transfer-Encoding chunked transfer
2016-01-08 00:50:31 -08:00
Harshavardhana
0c6a6dc380 http: Enable Transfer-Encoding chunked transfer
Fixes #1020
2016-01-08 00:47:20 -08:00
Harshavardhana
5e06c15b44 Merge pull request #1017 from koolhead17/GOenv-change
Modified instructions for installing Go.
2015-12-29 23:52:22 -08:00
koolhead17
f13ad3e02e Modifed instructions for installing Go. 2015-12-30 12:23:28 +05:30
Harshavardhana
82212f5fbc Merge pull request #1016 from harshavardhana/fix-signautre
s3cmd: Fix signature issues related to s3cmd.
2015-12-28 18:12:21 -08:00
Harshavardhana
d955ce4123 s3cmd: Fix signature issues related to s3cmd.
Support regions both 'us-east-1' and 'US' (short hand for US Standard)
honored by S3.
2015-12-28 18:05:28 -08:00
Harshavardhana
7228bc9919 Merge pull request #1015 from harshavardhana/location
location: Return a set location properly on complete multipart upload…
2015-12-28 15:30:43 -08:00
Harshavardhana
e7474bed43 location: Return a set location properly on complete multipart upload request. 2015-12-28 15:20:06 -08:00
Harshavardhana
d548316343 Merge pull request #1014 from harshavardhana/fixes
handlers: read ContentLength directly from http.Request
2015-12-27 23:07:51 -08:00
Harshavardhana
2f67559684 handlers: read ContentLength value directly from http.Request.
Do not look for Content-Length in headers and try to convert them into
integer representations use ContentLength field from *http.Request*.

If Content-Length is understood to be as '-1' then treat it as an error
condition, since it could be a malformed body to crash the server.

Fixes #1011
2015-12-27 23:03:32 -08:00
Harshavardhana
7aab7ba946 Merge pull request #1013 from harshavardhana/bucket-location
bucket-location: Implement bucket location response.
2015-12-27 00:50:42 -07:00