MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-12 15:33:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

sync to disk only upon successful legacy metadata rename (#10018)

Browse Source
This commit is contained in:
Harshavardhana 2020-07-11 09:37:34 -07:00 committed by GitHub
parent 3520e946a2
commit c0adb52213
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/xl-storage.go
View File

@ -1232,7 +1232,12 @@ func (s *xlStorage) renameLegacyMetadata(volume, path string) error {
dstFilePath := pathJoin(filePath, xlStorageFormatFile)
// Renaming xl.json to xl.meta should be fully synced to disk.
defer globalSync()
defer func() {
if err == nil {
// Sync to disk only upon success.
globalSync()
}
}()
if err = os.Rename(srcFilePath, dstFilePath); err != nil {
switch {
@ -2111,7 +2116,7 @@ func (s *xlStorage) RenameData(srcVolume, srcPath, dataDir, dstVolume, dstPath s
return osErrToFileErr(err)
}
// Sync all the directory operations.
// Sync all the previous directory operations.
globalSync()
for _, entry := range entries {