MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-24 06:05:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

server/http: Add missing keep alive for incoming tcp connections. (#3585)

Browse Source 
This was seen reproducing a bug with @gowithplanb. Windows Cloud
Berry clients do not close their respective connections.
This commit is contained in:
Harshavardhana 2017-01-16 03:38:06 -08:00 committed by GitHub
parent f8a3b1e164
commit b580ad24e2
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
cmd/server-mux.go
View File

@ -151,6 +151,15 @@ type ListenerMuxAcceptRes struct {
err error
}
// Default keep alive interval timeout, on your Linux system to figure out
// maximum probes sent
//
// $ cat /proc/sys/net/ipv4/tcp_keepalive_probes
// 9
//
// Effective value of total keep alive comes upto 9 x 3 * time.Minute = 27 Minutes.
var defaultKeepAliveTimeout = 3 * time.Minute // 3 minutes.
// newListenerMux listens and wraps accepted connections with tls after protocol peeking
func newListenerMux(listener net.Listener, config *tls.Config) *ListenerMux {
l := ListenerMux{
@ -163,11 +172,24 @@ func newListenerMux(listener net.Listener, config *tls.Config) *ListenerMux {
go func() {
// Loop for accepting new connections
for {
conn, err := l.Listener.Accept()
// Extract tcp listener.
tcpListener, ok := l.Listener.(*net.TCPListener)
if !ok {
l.acceptResCh <- ListenerMuxAcceptRes{err: errInvalidArgument}
return
}
// Use accept TCP method to receive the connection.
conn, err := tcpListener.AcceptTCP()
if err != nil {
l.acceptResCh <- ListenerMuxAcceptRes{err: err}
return
}
// Enable keep alive for each connection.
conn.SetKeepAlive(true)
conn.SetKeepAlivePeriod(defaultKeepAliveTimeout)
// Wrap the connection with ConnMux to be able to peek the data in the incoming connection
// and decide if we need to wrap the connection itself with a TLS or not
go func(conn net.Conn) {