MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-10-28 23:35:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unnecessary replication checks (#21569)

Browse Source
This commit is contained in:
M Alvee 2025-09-08 10:43:13 -07:00 committed by GitHub
parent 07c3a429bf
commit ae71d76901
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/erasure-multipart.go
View File

@ -394,9 +394,9 @@ func (er erasureObjects) newMultipartUpload(ctx context.Context, bucket string,
return nil, err
}
// if object doesn't exist and not a replication request return error for If-Match conditional requests
// if object doesn't exist return error for If-Match conditional requests
// If-None-Match should be allowed to proceed for non-existent objects
if err != nil && !opts.ReplicationRequest && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
if err != nil && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
return nil, err
}
}
@ -1118,9 +1118,9 @@ func (er erasureObjects) CompleteMultipartUpload(ctx context.Context, bucket str
return ObjectInfo{}, err
}
// if object doesn't exist and not a replication request return error for If-Match conditional requests
// if object doesn't exist return error for If-Match conditional requests
// If-None-Match should be allowed to proceed for non-existent objects
if err != nil && !opts.ReplicationRequest && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
if err != nil && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
return ObjectInfo{}, err
}
}

4
cmd/erasure-object.go
View File

@ -1278,9 +1278,9 @@ func (er erasureObjects) putObject(ctx context.Context, bucket string, object st
return objInfo, err
}
// if object doesn't exist and not a replication request return error for If-Match conditional requests
// if object doesn't exist return error for If-Match conditional requests
// If-None-Match should be allowed to proceed for non-existent objects
if err != nil && !opts.ReplicationRequest && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
if err != nil && opts.HasIfMatch && (isErrObjectNotFound(err) || isErrVersionNotFound(err)) {
return objInfo, err
}
}

3
cmd/object-api-options.go
View File

@ -420,9 +420,6 @@ func putOptsFromHeaders(ctx context.Context, hdr http.Header, metadata map[strin
MTime: mtime,
PreserveETag: etag,
}
if _, ok := hdr[xhttp.MinIOSourceReplicationRequest]; ok {
op.ReplicationRequest = true
}
return op, nil
}
// default case of passing encryption headers and UserDefined metadata to backend