MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove body from POST request in webhook (#5067)

Browse Source 
When webhook notification is configured, Minio server tries to lookup the
webhook endpoint by making a POST request with body set as releasetag.
We can remove the body from the POST request as the POST body does not
add any specific value.

This discussion on IETF group says empty POSTs are okay
http://lists.w3.org/Archives/Public/ietf-http-wg/2010JulSep/0272.html

Fixes: https://github.com/minio/minio/issues/5066
This commit is contained in:
Nitish Tiwari 2017-10-13 13:29:01 +05:30 committed by GitHub
parent 45463b1d6b
commit ad53c5d859
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/notify-webhook.go
View File

@ -91,10 +91,9 @@ func isNetErrorIgnored(err error) bool {
}
// Lookup endpoint address by successfully POSTting
// a JSON which would send out minio release.
// empty body.
func lookupEndpoint(urlStr string) error {
minioRelease := bytes.NewReader([]byte(ReleaseTag))
req, err := http.NewRequest("POST", urlStr, minioRelease)
req, err := http.NewRequest("POST", urlStr, bytes.NewReader([]byte("")))
if err != nil {
return err
}
@ -107,8 +106,8 @@ func lookupEndpoint(urlStr string) error {
},
}
// Set content-type.
req.Header.Set("Content-Type", "application/json")
// Set content-length to zero as there is no payload.
req.ContentLength = 0
// Set proper server user-agent.
req.Header.Set("User-Agent", globalServerUserAgent)