MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

heal: Check for truncated files (#10399)

Browse Source 
When checking parts we already do a stat for each part.

Since we have the on disk size check if it is at least what we expect.

When checking metadata check if metadata is 0 bytes.
This commit is contained in:
Klaus Post 2020-09-01 12:06:45 -07:00 committed by GitHub
parent a89d6b8e3d
commit 3e1fb17b70
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/xl-storage.go
View File

@ -1812,6 +1812,10 @@ func (s *xlStorage) CheckParts(volume, path string, fi FileInfo) error {
if st.Mode().IsDir() {
return errFileNotFound
}
// Check if shard is truncated.
if st.Size() < fi.Erasure.ShardFileSize(part.Size) {
return errFileCorrupt
}
}
return nil
@ -1860,7 +1864,7 @@ func (s *xlStorage) CheckFile(volume, path string) error {
}
// If its a directory its not a regular file.
if st.Mode().IsDir() {
if st.Mode().IsDir() || st.Size() == 0 {
return errFileNotFound
}