MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-02-27 05:19:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Moving os.MkdirAll() inside atomic for auto parent directory creates

Browse Source
This commit is contained in:
Harshavardhana 2015-07-07 12:35:50 -07:00
parent 5fc377ae57
commit 11b893804c
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/donut/disk/disk.go
View File

@ -153,13 +153,7 @@ func (disk Disk) CreateFile(filename string) (*atomic.File, error) {
return nil, iodine.New(InvalidArgument{}, nil)
}
filePath := filepath.Join(disk.path, filename)
// Create directories if they don't exist
if err := os.MkdirAll(filepath.Dir(filePath), 0700); err != nil {
return nil, iodine.New(err, nil)
}
f, err := atomic.FileCreate(filePath)
f, err := atomic.FileCreate(filepath.Join(disk.path, filename))
if err != nil {
return nil, iodine.New(err, nil)
}

7
pkg/utils/atomic/atomic.go
View File

@ -58,8 +58,13 @@ func (f *File) CloseAndPurge() error {
return nil
}
// FileCreate creates a new file at filePath for atomic writes
// FileCreate creates a new file at filePath for atomic writes, it also creates parent directories if they don't exist
func FileCreate(filePath string) (*File, error) {
// if parent directories do not exist, ioutil.TempFile doesn't create them
// handle such a case with os.MkdirAll()
if err := os.MkdirAll(filepath.Dir(filePath), 0700); err != nil {
return nil, iodine.New(err, nil)
}
f, err := ioutil.TempFile(filepath.Dir(filePath), filepath.Base(filePath))
if err != nil {
return nil, iodine.New(err, nil)