cae790ed7e
[pipe] Harden pict_tmpfile_recreate() against invalid input, take 2
2019-09-22 22:56:18 +02:00
d2921e9444
[pipe] Harden pict_tmpfile_recreate() against invalid input
2019-09-22 20:27:47 +02:00
56d3f42598
Fix a few gcc 8 / scan-build compiler warnings
2019-09-22 00:51:17 +02:00
cf927e7daa
[pipe] Fixup missing condition
2019-09-20 21:51:09 +02:00
e1a0e366cf
[dacp] Make sure Remote updates images from metadata pipes
2019-09-20 21:47:17 +02:00
7316c060b8
[pipe/artwork] Support for artwork via Shairport metadata pipes, take 3
...
This implementation uses a tmpfile for storage of the artwork, plus it uses
artwork_get() which means that it scales the image as requested by the client.
It also does not create a tmpfile unless we actually receive artwork.
2019-09-20 21:47:17 +02:00
ddb91e61ef
[pipe/artwork] Support for artwork via Shairport metadata pipes, take 2
...
This implementation uses a tmpfile for storage of the artwork (instead of the
cache, which may not be enabled).
2019-09-20 21:47:17 +02:00
69fafd873d
[pipe/artwork] Support for artwork via Shairport metadata pipes
...
This implementation uses the cache for storage. Might change that to use a
tmpfile instead.
2019-09-20 21:47:17 +02:00
2e149273e5
[cache] Clear stash if called with called with NULL
2019-09-20 21:47:17 +02:00
1752901529
[misc] Change b64_* to wrap ffmpeg's base64 encoder/decoder
...
Using ffmpeg's is probably better than having our own, plus it provides us with
decoded length, which we will need to support artwork via pipe.
2019-09-20 21:47:17 +02:00
e654276262
[alsa] Fix incorrect use of abs() for float, use fabs() instead
2019-09-18 21:28:15 +02:00
6836a0f277
[mdns] Fix incorrect error check for getaddrinfo (can cause segfault)
...
Non-zero return from getaddrinfo is an error, so since *ai could be a null
pointer when derefenced in the following socket() call.
2019-09-18 21:18:01 +02:00
4ab734343c
[-] Free events on exit (turns out event_base_free does not free them)
...
Credit @whatdoineed2do, ref. pr #797
2019-09-09 22:23:00 +02:00
0a593463b8
Merge pull request #803 from chme/mpdplay
...
[mpd] Fix initial value of 'songpos' in play command
2019-09-08 14:39:33 +02:00
d88182820c
[mpd] Fix initial value of 'songpos' in play command
2019-09-07 08:31:31 +02:00
743edcc3dd
Merge pull request #798 from chme/webupdate
...
Update player web interface to v0.5.5
2019-09-01 13:20:22 +02:00
4f2755facc
[htdocs] Rebuild new player web interface v0.5.5
2019-08-31 10:43:09 +02:00
130d94ef25
[web-src] Prepare next version for player web interface 0.5.5
2019-08-31 10:42:50 +02:00
7925639f5b
Merge pull request #790 from chme/admin_settings
...
Introduce new settings for displaying the composer in the now playing page
2019-08-31 09:05:49 +02:00
862ad928b1
[README] Update JSON API readme with new settings endpoints
2019-08-31 08:43:53 +02:00
8ae382d818
[web-src] Show composer in "now playing" page depending on the settings
...
for "show_composer_now_playing" and "show_composer_for_genre"
2019-08-31 08:08:36 +02:00
9ab1677f1f
[web-src] Add a settings page to the player web interface to change web
...
interface specific options
2019-08-31 08:08:36 +02:00
73470113b6
Merge pull request #795 from whatdoineed2do/jsonapi-memleak
...
[jsonapi] potential memleaks on query_params.filter object
2019-08-30 19:31:44 +02:00
6ad3d8dbef
[jsonapi] potential memleaks on query_params.filter object
2019-08-28 21:35:29 +01:00
ef9c0117c9
[input] Fix pipe playback bringing cpu to 100%
...
When pipe playback is started, but no data is written to the pipe, the input
loop would bring the cpu to 100%. This fix limits the loop like it was before
player refactor.
2019-08-28 22:23:11 +02:00
ef0a194644
Merge pull request #792 from chme/nowplaying_artwork
...
Fix for Remote not showing nowplaying artwork for Spotify tracks
2019-08-25 22:41:36 +02:00
a5c2d6c0f8
[spotify] Return widest image if no max width is given
2019-08-25 11:24:14 +02:00
2cc310b646
[jsonapi] Expose reading and updating settings through the JSON API
2019-08-25 10:39:16 +02:00
02dd0a9445
[settings] Add settings component
...
This adds a new settings component for user configurable options that
can be changed through the JSON API.
The settings are stored in the admin db table and not in the conf-file.
2019-08-25 10:39:16 +02:00
78373af201
[cast] Add a simple delay to stream to a have little bit of sync
...
Since it is unknown how to do real sync on Chromecast, this commit instead adds
a primitive delay to the stream, so that it is at least somewhat closer to
Airplay/local audio.
Also some cleanup of unused stuff.
2019-08-23 19:45:17 +02:00
a5987addd4
[db,jsonapi] case insensitive directory/file listing ( #784 )
...
* [db,jsonapi] case insensitive directory/file listing
* [jsonapi] file listing of playlist uses same VPATH ordering as per directory and files
* [db,jsonapi] sorting via existing S_VPATH
* [db] replace LOWER with COLLATE NOCASE
2019-08-21 22:54:34 +02:00
9cb5810e9a
[player] Avoid repeated resets on output delay when changing track (issue #781 )
2019-08-18 23:12:10 +02:00
19ba9d106a
[input] Buffer full callback should also be made when source reading ends
...
Otherwise the player will wait infinitely
2019-08-18 23:10:56 +02:00
b9b2874a2e
[player] Possible fix for issue #781 where playback status is incorrect
...
pb_suspend() + pb_resume() during track changes made the playback status
incorrect, i.e. pb_session.source_list/playing_now would not match what the
input was actually writing. This attempts to solve it by resetting the
session when pb_suspend() is called, so that the input, input_buffer and
source_list come into sync.
2019-08-17 01:44:45 +02:00
86339eee87
[input] Make input_resume() not reopen tracks that have finished playing
...
If playback was paused during the very last part of the track, the rest of the
track would be read into the input buffer and the input would be closed. With
this commit the input will not be reopened.
Also allow input_flush to be called with null argument.
2019-08-17 01:37:39 +02:00
7dfe4c2b65
[daap] Always use S_PLAYLIST ordering for Q_PL (ref issue #785 )
2019-08-13 21:35:07 +02:00
f9bfec180f
[raop] Fix possible infinite loop + wrong packet resend (fixes issue #775 )
...
Fixes bugs which were due to incorrect handling of unsigned integer wrap-around:
1. Calling packet_resend() with seqnum + len greater than UINT16_MAX => infinite loop
2. Calling rtp_packet_get() with session->seqnum - seqnum greater than pktbuf_next => wrong packet
2019-08-10 22:41:04 +02:00
6578f28621
[raop] Logging change to find cause of issue #775
2019-08-09 23:58:45 +02:00
7ee9a47783
Merge pull request #783 from chme/spotify_collaborative_playlists
...
Allow reading of collaborative/shared Spotify playlists
2019-08-04 12:25:53 +02:00
9ba1e24b6c
[htdocs] Show message in admin web interface if forked-daapd is missing
...
a Spotify web API scope
2019-08-03 12:57:14 +02:00
a87059265d
[spotify] Require Spotify web API scope playlist-read-collaborative
...
Also exposes granted and required Spotify web API scope through the
forked-daapd JSON API.
2019-08-03 12:55:53 +02:00
6c729673a5
Merge pull request #774 from chme/webupdate
...
Update player web interface (v0.5.4)
2019-08-03 09:04:30 +02:00
d996b1ff09
Merge pull request #772 from whatdoineed2do/smartpl-dynamic-dates-context
...
[smartpl] generate dynamic dates for SMARTPL queries
2019-08-03 08:51:57 +02:00
ff9a80dbb9
Merge pull request #782 from whatdoineed2do/streaming-icymeta-overflow
...
[streaming] potential icy-meta overflow fix (for artist+song title > 4064 bytes)
2019-08-01 17:50:29 +02:00
50232bc091
[streaming] icy-meta overflow fix (for artist+song title > 4064 bytes)
2019-08-01 12:42:20 +01:00
0941cf51ff
[streaming] support sending ICY metadata (title) ( #732 )
...
* [streaming] obey Icy-MetaData directive and send icy title
* [streaming] fix 'streaming_sessions' race conditions/dbl frees on shutdown
* [streaming] simplify icy meta sending logic
* [streaming] 'icy request' variable cleanup
* [streaming] icy-meta comment/logging cleanup
2019-07-31 16:34:11 +02:00
cf173df805
[outputs] Fix issue where RTP packet is not available for retransmit
...
Check for sequence number did not account for wrap around, so e.g. a
request for seqnum 65335 when first was 65100 and last was 100 would
not work.
2019-07-20 20:37:22 +02:00
772b18479d
[smartpl] Refactor appending date expression to sql query
2019-07-14 20:51:46 +01:00
92fdb4e5f9
[htdocs] Rebuild player web interface (v0.5.4)
2019-07-14 10:21:31 +02:00
d63632635c
[htdocs] updates web app icons using new custom logo and includes
...
version number to refresh idevice homescreen icon
2019-07-14 10:21:31 +02:00
ejurgensen
Christian Meffert
chme
whatdoineed2do/Ray
whatdoineed2do
Chris Lenfert