ejurgensen
65c72c484b
[misc] Add misc_xml.c to wrap mxml, fixes XML reading of CDATA (et al)
...
The change removes all direct calls to mxml from the modules that need an XML
parser (lastfm.c, pipe.c, rssscanner.c and httpd_rsp.c).
Even with the help of mxml, reading XML is hard, so a layer is added which
helps deal with stuff like whitespace and CDATA. This should make OwnTone more
resilient to any XML variations it might receive.
The changes fixes issue #1677 .
2023-11-12 23:43:38 +01:00
ejurgensen
83ac327d7f
[spotify] Don't log error if a playlist is empty
...
Fixes #1676
2023-10-28 17:38:37 +02:00
ejurgensen
369771bda5
[scan] Handle playlists with Unicode BOM
...
Closes #1674
2023-10-26 23:03:54 +02:00
ejurgensen
253a699001
[scan] Fix reading of FLAC tags
...
Regression from PR #1655 . Closes #1673 .
2023-10-26 22:40:23 +02:00
ejurgensen
9e9dc27a59
Merge pull request #1670 from owntone/gh_build_webui
...
Let Github actions rebuild web UI on push to web-src
2023-10-22 20:19:06 +02:00
ejurgensen
912e00d48d
Merge pull request #1671 from owntone/dependabot/npm_and_yarn/web-src/postcss-8.4.31
...
Bump postcss from 8.4.27 to 8.4.31 in /web-src
2023-10-22 00:04:45 +02:00
dependabot[bot]
8049760703
Bump postcss from 8.4.27 to 8.4.31 in /web-src
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.27 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-10-21 22:02:32 +00:00
ejurgensen
84042a4514
[gh-actions] No compilation workflows if just docs/htdocs/web-src changed
2023-10-21 23:27:47 +02:00
ejurgensen
986fc55dbd
[gh-actions] Add rebuild of web UI workflow on push to web-src
2023-10-21 23:26:47 +02:00
ejurgensen
a9e20abf06
Revert "[web] Add lyrics player to the webinterface"
...
This reverts commit 98a844b409
.
2023-10-21 22:41:45 +02:00
ejurgensen
e4c47c22b3
[scan] Fix issue where m3u genre doesn't override despite m3u_override = true
...
Closes #1668
2023-10-21 22:37:34 +02:00
ejurgensen
5fb41171d6
[gh-actions] Add web UI lint as a PR and push check
2023-10-21 22:33:54 +02:00
ejurgensen
c7f71b478f
[gh-actions] Update checkout version to latest (v4)
2023-10-21 22:32:35 +02:00
ejurgensen
43e95e8ba7
[gh-actions] Also update version of codeql/analyze to v2
2023-10-21 14:47:49 +02:00
ejurgensen
429178e518
[gh-actions] Update checkout and codeql versions
2023-10-21 14:41:12 +02:00
ejurgensen
4365869fb1
Merge pull request #1655 from X-Ryl669/lyrics
...
Add support for Lyrics
2023-10-20 16:20:30 +02:00
ejurgensen
8796368b01
[scan] Fixup lyrics changes
2023-10-19 23:49:53 +02:00
X-Ryl669
98a844b409
[web] Add lyrics player to the webinterface
...
Update icons.js
Add icons in alphabetical order.
Change comment to remove reference to external website
Remove extra line feeds
Co-Authored-by: Alain Nussbaumer <alain.nussbaumer@alleluia.ch>
2023-10-19 23:49:53 +02:00
X-Ryl669
9670f6b079
[httpd] Add fetching lyrics in the JSON api
2023-10-19 23:49:53 +02:00
X-Ryl669
cf8b3ecd3a
[db,library] Add support for parsing lyrics and storing them in DB
2023-10-19 23:49:53 +02:00
Alain Nussbaumer
d7d3a0767d
[web] Correct the use of Bulma variables in the CSS
...
The variables for colors are now correctly referenced in the CSS.
2023-10-08 10:47:26 +02:00
ejurgensen
67de2303f9
Merge pull request #1663 from owntone/esp32
...
[raop] Make compressed ALAC default, but with a config option
2023-10-07 09:32:40 +02:00
ejurgensen
d266c8a56f
[raop] Make compressed ALAC default, but with a config option
...
Closes #1656
2023-10-06 21:39:26 +02:00
ejurgensen
c34acb16c2
Merge pull request #1660 from X-Ryl669/fixSelect
...
Fix select issue on FreeBSD.
2023-10-02 11:15:39 +02:00
X-Ryl669
ab790c2880
[mdns] Fix select issue on FreeBSD.
...
As reported in issue #1654 , using select to test for a (non-blocking) connection success crashes on FreeBSD when the number of opened file descriptor is higher than FDSET_SIZE.
Instead of returning with an error in that case, this commit uses poll instead that's not limited to the number of opened file descriptors, preventing an out-of-bound write.
2023-10-02 09:53:06 +02:00
ejurgensen
8528073003
[daap] Fix for use-after-free
...
Present in 28.7 and 28.8. Closes #1659 .
Credit X-Ryl669.
2023-09-30 23:06:09 +02:00
ejurgensen
4662cd4cce
[scan] Set consistent return type in check_path_in_directories()
2023-09-27 22:46:13 +02:00
ejurgensen
85929dcaa8
Bump version to 28.8
2023-09-05 22:55:47 +02:00
ejurgensen
1aec50bcfd
ChangeLog for OwnTone 28.8
2023-09-05 22:54:45 +02:00
ejurgensen
89c148411e
[gh-actions] Add MacOS run test
2023-09-03 21:16:44 +02:00
ejurgensen
e850549aa1
[gh-actions] Run test with standard install method
2023-09-03 21:01:11 +02:00
ejurgensen
d5335317a6
[gh-actions] Prepare workflow with runtest
2023-09-03 21:01:11 +02:00
ejurgensen
a9e21dcbfd
[main] Add a 'testrun' command line option for Github actions
2023-09-03 21:01:11 +02:00
ejurgensen
3f6c7405ed
[spotify] Don't zero pthread lock when resetting credentials
2023-09-03 20:59:45 +02:00
ejurgensen
6742272221
[gh-actions] Add workflow-dispatch to MacOS workflow
2023-09-02 23:30:42 +02:00
ejurgensen
8b64bb4cd8
[docs] Add link to blog about authentication with Authelia for remote access
...
Credit @X-Ryl669
Closes #1647
2023-09-02 23:07:05 +02:00
ejurgensen
54c2667aea
[misc] Use fcntl+O_NONBLOCK when binding instead of socket+SOCK_NONBLOCK
...
socket() with SOCK_NONBLOCK (O_NONBLOCK) seems not to be possible on MacOS, it
yields 'Protocol wrong type for socket'. Switch to using fcntl() and O_NONBLOCK
instead, hopefully works better cross-platform.
Closes #1644
2023-09-01 17:13:33 +02:00
ejurgensen
9d092c983b
Merge pull request #1648 from whatdoineed2do/library-overwrite-db-entry-fix
2023-09-01 17:06:44 +02:00
whatdoineed2do/Ray
b9b8ced689
[scan] Handles case for file overwrite/move within library that previously original db entry for overwritten file
...
Fixes #1645
2023-09-01 09:17:54 +01:00
ejurgensen
0d94681f16
[gh-actions] Add workflow-dispatch to Ubuntu workflow
2023-08-31 22:59:26 +02:00
ejurgensen
174aa86033
Merge pull request #1646 from owntone/raop_alac_endtag1
...
[raop] Add ALAC end tag to each frame
2023-08-31 17:10:06 +02:00
ejurgensen
b9da6bc80d
Revert "[gh-actions] Update macos.yml, add brew update step"
...
This reverts commit 0f33a896de
.
Reason is that using newest homebrew seems to make the workflow very unstable.
2023-08-30 21:16:18 +02:00
ejurgensen
447e042953
[raop] Add ALAC end tag to each frame
...
The missing end tag makes the ffmpeg alac decoder upset and we can't have that
Credit Mike Brady
2023-08-30 21:00:33 +02:00
ejurgensen
4315c73775
[httpd] Fix building on FreeBSD which doesn't have SYS_gettid
2023-08-29 23:50:19 +02:00
ejurgensen
214ef12cb5
[spotify] Fix free of invalid pointer on http request error
...
Fixes #1643
2023-08-29 20:14:19 +02:00
ejurgensen
9b190dcc2e
Bump version to 28.7
2023-08-28 23:20:53 +02:00
ejurgensen
012bd30552
ChangeLog for OwnTone 28.7
2023-08-28 23:19:43 +02:00
ejurgensen
b213c35801
Revert "[gh-actions] Remove build of sqlite from MacOS workflow mk2"
...
This reverts commit 07a95dce96
.
2023-08-24 23:30:51 +02:00
ejurgensen
07a95dce96
[gh-actions] Remove build of sqlite from MacOS workflow mk2
...
Homebrew's sqlite now comes with sqlite3_unlock_notify (Homebrew issue #55077 ),
so a custom build is no longer required.
2023-08-24 22:52:34 +02:00
ejurgensen
7f6387ff59
Revert "[gh-actions] Remove build of sqlite from MacOS workflow"
...
This reverts commit d159a8d5aa
.
2023-08-24 22:04:21 +02:00