Commit Graph

2931 Commits

Author SHA1 Message Date
chme 7592462571 [player] Fix segfault if reading from source failed for all queue items 2015-10-19 21:33:43 +02:00
ejurgensen 55104015e0 Full removal of libevent 1 legacy code. Also drop pipe() in FreeBSD, since pipe2 is available now. 2015-10-19 21:15:29 +02:00
chme 48691748cd [mpd] fix log message if binding of artwork http server failed 2015-10-18 14:25:29 +02:00
ejurgensen 2a610812a5 Refactor transcode.c so it can actually transcode + use new capability to support mp3 streaming.
Also includes the skeleton for perhaps supporting video in the future. Adds more fine-grained
ffmpeg/libav compability checks. Dependency on libavresample/libswresample exchanged with
dependency on libavfilter, which seems more versatile.
2015-10-09 23:58:27 +02:00
James Le Cuirot 7cf35d1e8b
Allow ANTLR 3.5 to work
This involves a harmless backwards-compatible adjustment to the
grammar. I can't explain why this is necessary but this might help.

http://stackoverflow.com/questions/20057063/follow-set-in-is-undefined-in-generated-parser
2015-10-05 23:10:45 +01:00
chme 199b765a7d [player] Store item-ids in history to allow start of playback from the
previously played items in dacp
2015-10-04 08:05:37 +02:00
chme b19a7280b9 [player] remove unused player_queue struct 2015-10-04 08:05:37 +02:00
chme fbce3a7d57 [player] Confusing naming of ids cleaned up 2015-10-04 08:05:37 +02:00
chme ba3385b0ec [queue] Remove queue_info and queue_item_info structs 2015-10-04 08:05:37 +02:00
chme 35df9455b9 [queue] Fix memory leak in queue_make_item 2015-10-04 08:05:36 +02:00
chme 100e08da9d Rename make_queue functions 2015-10-04 08:05:36 +02:00
chme 064dfef2de [player] cleanup metadata_trigger
metadata_trigger is always called for the current streaming item and
source_open makes sure that the stream_start and output_start values are
set correctly
2015-10-04 08:05:36 +02:00
chme 64698eb3a4 [player] Some minor cleanup (error handling, comments) 2015-10-04 08:05:36 +02:00
chme a06424a701 [mpd] Expose queue-item-id instead of dbmfi-id in mpd commands
[player] Reshuffle on end of playlist and repeat mode is "repeat all"
2015-10-04 07:59:58 +02:00
chme cb2805800b [player] Fix segfault if pause requested in the last two seconds of the
last item in the playqueue (cur_streaming is already NULL)
2015-10-04 07:59:58 +02:00
chme 2b037b67d9 [player] Combine stream_stop and stream_cleanup into one function 2015-10-04 07:59:58 +02:00
chme e44a160b9a [player] Improve error handling 2015-10-04 07:59:58 +02:00
chme 4595a2f4a6 [player] Add missing metadata trigger on item change (after eof) 2015-10-04 07:59:58 +02:00
chme c8a61015fc [dacp] Fix playing of radio streams after queue refactoring 2015-10-04 07:59:58 +02:00
chme f4faac3cc8 [spotify] Remove duplicate method "resume" in favor of "play" 2015-10-04 07:59:58 +02:00
chme 58069e67f8 [player/spotify] adjust spotify integration to refactoring of player 2015-10-04 07:59:58 +02:00
chme e1147c00a1 [player] Refactor player to better fit the queue refactor 2015-10-04 07:59:58 +02:00
chme 1f53d7ab1a [queue] Refactor queue handling
Decouple the playing/streaming item from the queue. Move all queue
related functions to seperate file queue.h/c.
Introduce internal item "head" to make iterating over the play-queue and
shuffle-queue easier.
2015-10-04 07:59:57 +02:00
chme 10d7097f98 [player] rename "queue_*"-functions to "playerqueue_*" (avoid naming
conflicts with later introduced separate queue file
2015-10-04 07:57:39 +02:00
chme 1fbedaa54f [player] Refactor queue_get 2015-10-04 07:57:38 +02:00
chme f0a6a48599 [player] Refactor queue_remove functions 2015-10-04 07:57:38 +02:00
chme 8e1834cdea Rename make_queue function and set as static 2015-10-04 07:57:38 +02:00
chme 1812848ee1 Move client protocol specific make_queue functions out of player.c/h 2015-10-04 07:57:38 +02:00
ejurgensen cba9bc05e9 Expire sessions without strict timeout (closes #163) 2015-10-03 10:00:42 +02:00
ejurgensen ebba164a0d Change MPD deinit position so it matches the init order, and so it will not get called if httpd fails to start 2015-09-29 23:14:44 +02:00
ejurgensen 5125e24cfe Let db_build_query_index_clause() always return an initialized idx, even on failure 2015-09-29 22:51:23 +02:00
chme cf70c514b6 Fix memory leak if index clause is used 2015-09-29 22:43:32 +02:00
chme a1e2f53ab1 Fix memory leak if index clause is used 2015-09-29 22:42:53 +02:00
chme 0245813d34 Fix memory leak when parsing smart playlists 2015-09-29 22:42:30 +02:00
chme 1ed240d92c Fix memory leak due to missing free for evconnlistener 2015-09-29 22:42:09 +02:00
ejurgensen 6c26d87997 Make some global vars in lastfm.c static 2015-09-28 21:22:51 +02:00
ejurgensen 4db6318a82 Fix issue where volume gets set to -1 on startup of raop devices 2015-09-27 15:24:04 +02:00
ejurgensen 50bcdd2551 Plug minor memleaks in cache.c 2015-09-23 22:29:17 +02:00
ejurgensen 294d7a270f Protect against possible segfault if the artwork pixel format is unknown
- thank you groinwood for reporting this bug
2015-08-24 21:27:55 +02:00
ejurgensen 317ad2ba41 Always treat podcasts, audiobooks and compilations as audio, even if video stream is present 2015-08-05 22:36:28 +02:00
ejurgensen 68912efa1f Enable resuming playback from saved position for certain media kinds (eg audiobooks) 2015-08-04 22:33:32 +02:00
ejurgensen 7881df67f6 Hack to push live ICY metadata/artwork to remote clients 2015-07-31 14:43:22 +02:00
ejurgensen 1fe6521aff Remove libevent 1 support in httpd_dacp 2015-07-30 22:50:11 +02:00
ejurgensen 3ba76e8f40 Remove libevent 1 support in httpd_daap 2015-07-29 23:05:47 +02:00
ejurgensen 7e9cf80ec0 Reorganize configure.ac according to subject (and my taste) 2015-07-21 23:00:55 +02:00
ejurgensen bf72547b9b Drop legacy FLAC, Musepack and WMA file scanners (ffmpeg/libav can do this now) 2015-07-21 22:16:50 +02:00
chme c6851eac9b [mpd] use the same image size as in raop_metadata_prepare (max 600x600)
to increase artwork cache hits
2015-07-18 07:34:48 +02:00
chme 1ab318d725 [mpd] support serving artwork over http 2015-07-18 07:17:21 +02:00
ejurgensen d870b97142 Remove LastFM thread now that it can run from the worker thread 2015-06-27 23:24:07 +02:00
ejurgensen b6703ab7cd Don't retrieve ICY StreamUrls without jpg/png extension (don't want to risk initiating a major, useless download) 2015-06-20 23:11:18 +02:00
ejurgensen ec0ba2c5fa Fix problem where the http client would ignore the last line in a m3u because of missing CRLF (issue #169) 2015-06-18 23:03:11 +02:00
chme ceca9135c5 [mpd] add special handling to command "lsinfo" if the root directory was
passed as argument.

Clients like ympd and ncmpcpp are relying on this (deprecated) behavior
2015-06-14 07:11:17 +02:00
chme b9b3671d58 [mpd] add support for command "decoders" 2015-06-14 07:11:17 +02:00
chme 426e827712 [mpd] Return whole queue for command "playlistinfo" if given argument is
-1 (not a valid position in the queue)
2015-06-13 14:38:56 +02:00
ejurgensen 879c2ef350 Avoid cache regeneration triggering during db_query_run (in case the query is long running, like db_files_update_songalbumid might be) 2015-06-08 23:07:56 +02:00
ejurgensen 335517a2e8 Prevent this database deadlock:
1. bulk scan begins transaction, locking the db
2. cache regeneration is triggered, but waits for db to unlock
3. bulk scan calls cache_artwork_ping, which can't return because cache thread is waiting
-> scan thread is waiting for cache thread, which is waiting for scan thread
2015-06-08 22:24:33 +02:00
ejurgensen 4fffc057b6 Change queue_remove() to fix segfault because source_head/shuffle_head could become invalid, and to protect against invalid input in general (ref issue #160).
Also try to failsafe source_position() and implement next_ps() all around.
2015-06-08 00:21:49 +02:00
ejurgensen 3dde23e060 Include terminating null in u8_normalize - not necessary now, but just to be safe 2015-06-06 14:47:54 +02:00
ejurgensen 6224fdb025 UTF-8 conversion was returning string without null termination (thank you @stephan-01010011, ref pr #168) 2015-06-06 14:22:24 +02:00
ejurgensen a9437acc1a Rework pr #162 to avoid mem leaks and string termination problems 2015-06-05 23:55:57 +02:00
ejurgensen 7d231b992b Fix typo 2015-06-04 22:17:49 +02:00
ejurgensen cd14522915 Swap misplaced args in db.c 2015-06-04 22:10:30 +02:00
ejurgensen 271c5ff344 Change DB upgrade from v18->v19 to v18->v18.01 2015-06-04 21:58:01 +02:00
chme 7cd96690c0 Remove file extension for playlists from virtual_path during scan and
update db to v19 removing the file extensions from the stored playlists

An existing file extension in the virtual path leads to wrong entries in
MPDroid (and mpd does also not return the file extension).
2015-06-04 08:11:46 +02:00
ejurgensen 3655e26703 Code style 2015-06-02 23:10:04 +02:00
ejurgensen 64ef66f030 Merge pull request #162 from stephan-01010011/master
Fixed bug that caused icy header metadata to be not correctly encoded
2015-06-03 00:05:56 +03:00
ejurgensen 7a0dfef136 Add sub-sorting when sort=artists, because otherwise Tunesremote SE will not play the artist's tracks in proper order 2015-06-01 23:36:16 +02:00
stephan-01010011 32727bd296 Fixed bug that caused icy header metadata to be not correctly
encoded/converted. Characters above x7F were replaced by '?' character
although the rfc defines a ISO−8859−1 encoding for descriptive
field-content.

According to rfc2616 the field-content is defined as follows:
<the OCTETs making up the field-value and consisting of either *TEXT or
combinations of token, separators, and quoted-string>
The TEXT rule is only used for descriptive field contents and values
that are not intended to be interpreted by the message parser. Words of
*TEXT MAY contain characters from character sets other than ISO- 8859-1
only when encoded according to the rules of RFC 2047.

In the previous implementation the icy metadata was converted based on
fromcode "ascii".

Following incoming icy header field-values should be encoded as
"ISO−8859−1" before adding them to the metadata structure.

- misc.c unicode_fixup_string enhanced by an additional parameter to
define the fromcode
- misc.h unicode_fixup_string prototype updated
- filescanner.c function fixup_tags updated to stay compatible to the
previous implementation using fromcode "ascii"
- db.c function unicode_fixup_mfi updated to stay compatible to the
previous implementation using fromcode "ascii"
- http.c function metadata_header_get enhanced to encode the header
field-content as "ISO−8859−1" to comply with rfc2616
2015-05-31 14:05:31 +01:00
chme 7f09438621 [mpd] support "date" argument in find and search commands 2015-05-30 05:56:53 +02:00
chme 2a04740ca2 [mpd] support "file" argument in list command 2015-05-30 05:56:52 +02:00
chme 4299de5ac7 [mpd] implement plchanges to report all songs in the queue as changed
(ignores the playlist version parameter).

This is necessary in order to get mpd clients (e. g. sonata) relying on
this command to display the queue.
2015-05-30 05:33:32 +02:00
ejurgensen 4a50a7a326 [spotify] Improve Spotify loading efficiency and set time_added so smart playlists will work 2015-05-29 19:47:53 +02:00
ejurgensen 40d7d044be Lower log severity of message in spotify.c 2015-05-27 20:32:27 +02:00
ejurgensen a1e417c571 Rename count_info to fix issue #157 2015-05-26 21:24:10 +02:00
ejurgensen 8dd1e0fde2 Fix problem introduced with commit 475d5db where genres and composers don't get sorted 2015-05-26 21:10:28 +02:00
ejurgensen 79cdfebf34 Merge pull request #150 from chme/mpdidle
Add support for mpd idle command
2015-05-21 22:31:03 +02:00
ejurgensen d6828b90fc Merge pull request #149 from chme/mpdcommands
Add support for additional mpd commands
2015-05-21 22:30:49 +02:00
chme 8c12929b91 Added source code comments, return error value if adding/removing a
listener failed
2015-05-21 07:57:18 +02:00
chme 0b73233197 [mpd] remove libevent1 support 2015-05-21 07:15:05 +02:00
chme 1cde19b5b6 [smartpl] add "grouping" field to smart playlist grammar 2015-05-21 06:22:55 +02:00
ejurgensen 6176f7f4a2 Fix bug where files being copied into library with eg. Samba will get scanned
before writing has finished, which may result in no metadata for the file
2015-05-20 22:38:26 +02:00
chme 41a08d1931 [mpd] rework listener events to use a bit map 2015-05-18 20:12:18 +02:00
chme baffe49887 refactor use for loop to remove item from linked list 2015-05-13 11:37:09 +02:00
chme 3886ec6638 Add version number for playlist (queue)
This is necessary to return a valid playlist id for mpd status command.
2015-05-09 07:46:33 +02:00
chme aa4a12cabe add events for playlist (queue), volume, speaker, options
(random/shuffle) changes
2015-05-09 07:46:33 +02:00
chme d2c7c87191 use listener logic to send dacp update requests 2015-05-09 07:46:33 +02:00
chme 7097dd15eb allow removing of listeners 2015-05-09 07:46:33 +02:00
chme 1714f3dee4 [mpd] move include of libevent from mpd.h to mpd.c 2015-05-09 07:46:33 +02:00
chme 36499f4997 [player] added some source code comments 2015-05-09 07:46:33 +02:00
chme e156181121 [mpd] remove idle client if an eof or error occurred on the event buffer
(fixes segfault after closing the connection of an mpd client)
2015-05-09 07:46:33 +02:00
chme 600e48842f [mpd] idle command 2015-05-09 07:46:33 +02:00
chme 864315eaef [mpd] fix wrong log message 2015-05-09 07:35:15 +02:00
chme 68c392eb9e [mpd] ignore requests for client to client commands "subscribe",
"unsubscribe", "readmessages", "sendmessages"
2015-05-09 07:35:15 +02:00
chme decc482e2c [mpd] only return "id" attribute if song information is requested for
the current playlist

mpd does not expose a persistent song id, instead the id returned in
playlistinfo is a unique id for the song in the queue. The same song has
different ids if it occurs more than once in the queue.
2015-05-09 07:35:15 +02:00
chme 5d22d74dba [mpd] ignore requests for "sticker" 2015-05-09 07:35:15 +02:00
chme 91338c8548 [mpd] ignore requests for "channels" 2015-05-09 07:35:15 +02:00
chme fefd91fabc [mpd] support "track" parameter in commands "list", "find", "search" 2015-05-09 07:35:15 +02:00
chme ed8b69c118 [mpd] return proper error type if playlist does not exist 2015-05-09 07:35:15 +02:00
chme 1300b2f018 [mpd] support "disc" parameter in commands "list", "find", "search" 2015-05-09 07:35:15 +02:00
chme a03a9d1e7c [mpd] support "genre" in commands "find" and "search" 2015-05-09 07:35:15 +02:00
chme 0921675efa [mpd] implement command "searchadd" 2015-05-09 07:35:15 +02:00
chme 76011c927c [mpd] implement command "findadd" 2015-05-09 07:35:15 +02:00
chme fb92040d4b expose generic player_queue_make function 2015-05-09 07:35:15 +02:00
chme 3832692929 move setting query_params.sort out of generic queue make function 2015-05-09 07:35:14 +02:00
chme 3a495a3d48 move setting query_params.idx_type out of generic queue make function 2015-05-09 07:35:14 +02:00
chme b728db8470 [mpd] implement command "tagtypes" to return the list of supported tags 2015-05-09 07:35:14 +02:00
chme 670187387f [mpd] ignore requests for "urlhandlers" 2015-05-09 07:35:14 +02:00
chme eddcd8676d [mpd] ignore requests for "notcommands" 2015-05-09 07:35:14 +02:00
ejurgensen bb01616315 Increase ANTLR timeout for building on slow machines 2015-05-08 22:25:12 +02:00
ejurgensen a183fc3299 Fix #147 where forked-daapd would not listen on IPv6 when enabled 2015-05-07 22:53:37 +02:00
ejurgensen 475d5db573 When a playlist request contains a query make the default sort S_ALBUM,
which should keep audiobooks organized better and be in line with iTunes.

This should fix #91, and I cross my fingers it does not have other
unintended consequences.
2015-05-05 21:46:56 +02:00
ejurgensen f6f584bf84 Fix stupid oversight that can cause segfault
- how typical to discover this right after making a release
2015-05-05 20:51:59 +02:00
chme d19fbe5ed7 fix first item is not shuffled 2015-05-05 18:44:02 +02:00
chme 696cd0b6b9 [mpd] fix command listplaylists after changing the enum for pl_type 2015-05-01 12:22:35 +02:00
chme 0c3712629d attempt to fix compile with antlr3 v3.4 2015-04-27 21:12:22 +02:00
chme 4bf30239bc Remove query from daap cache if rebuild failed 2015-04-27 19:44:03 +02:00
chme 44b6a52669 fix daap query error for media kind 32 2015-04-27 19:44:03 +02:00
chme 3a7cf212fb [mpd] fix command "list" for type "artist" 2015-04-25 05:48:28 +02:00
ejurgensen 072810c4aa Move som comments 2015-04-24 22:57:08 +02:00
ejurgensen fa4496c729 Begin removing support for libevent 1 2015-04-24 22:11:08 +02:00
ejurgensen 5973875881 Disable announcement of webserver 2015-04-24 22:08:53 +02:00
ejurgensen a98f67a7b3 Merge pull request #135 from chme/bulkscan
do not execute individual delete queries for cached artwork files during bulk scan
2015-04-24 21:06:37 +02:00
chme afcc84a790 do not execute individual delete queries for artwork files during bulk
scan
2015-04-24 17:37:48 +02:00
chme 65ad46311d fix wrong enum value for MEDIA_KIND_MUSIC 2015-04-24 17:25:01 +02:00
ejurgensen 0e1de8e0bb Add media_kind music videos and add forgotten return in db upgrade 2015-04-23 23:38:36 +02:00
chme 920af668a1 [smartpl] compare strings case insensitive 2015-04-23 19:17:01 +02:00
chme 8376180fd6 [smartpl] Added rule for enum tags like data_kind and media_kind to
avoid having magic numbers like "media_kind = 1" in smartplaylists. Enum
rules are defined like "media_kind is music" with a fixed set of valid
values after the "is" keyword.
2015-04-23 11:36:36 +02:00
chme 659f9c09bb Use enum values for data_kind and media_kind 2015-04-23 11:34:44 +02:00
chme 9f6afe0607 change pl_type for plain and special playlists and upgrade db to v18 2015-04-23 08:21:11 +02:00
chme 6dc4d53ed9 fix check for empty special playlists 2015-04-23 08:21:11 +02:00
chme baa97b886d [smartpl] include smart playlists in filelist view and recreate the view
during db upgrade to v17
2015-04-23 08:21:11 +02:00
chme 4cac01ed88 [smartpl] Add support for smart playlists 2015-04-23 08:21:10 +02:00
chme a174a1d18c [smartpl] refactoring: repurpose playlist type PL_SMART for user created
smart playlists and introduce new type PL_SPECIAL for special system
playlists
2015-04-23 08:21:10 +02:00
ejurgensen 2c5ab966e5 Adjust log messages 2015-04-22 21:54:31 +02:00
ejurgensen 76fc9d8936 Remove debug messages producing compiler warnings 2015-04-18 23:10:01 +02:00
ejurgensen b819fd800d Change log message showing http request path 2015-04-18 23:09:34 +02:00
ejurgensen 5fa908cd9c Add an artwork "stash" in cache.c so we avoid making redundant http artwork requests 2015-04-18 22:55:00 +02:00
chme 72416e3258 do not add port number to "Host" header if it was not explicitly passed 2015-04-18 13:49:14 +02:00
ejurgensen 76a638a277 Merge pull request #130 from chme/laudio
[laudio] Make output type for local audio configurable
2015-04-16 17:56:01 +02:00
ejurgensen ceae3222bf Downgrade some http client log severities 2015-04-13 21:41:53 +02:00
ejurgensen dbfd034679 Downgrade log severity of "Found query string" in httpd.c 2015-04-13 21:33:00 +02:00
ejurgensen 2d8a6a7102 Drop support for libavformat versions < 53 (issue #128) 2015-04-12 20:05:14 +02:00
ejurgensen 8a0994860f Ignore empty ICY StreamTitles 2015-04-12 18:15:06 +02:00
chme c8e793fd0c [laudio] Makes the output type for local audio configurable and
introduces a dummy output for local audio

Changes configure.ac to control the with-alsa and with-oss4 separately.
This makes it possible to only use the dummy output and compile without
alse+oss4.
2015-04-12 07:03:32 +02:00
ejurgensen 7841e59afc Don't report negative remaining times for streams 2015-04-11 22:38:33 +02:00
ejurgensen 3afd206e93 Add streams to the library even if they are unreachable 2015-04-11 22:36:28 +02:00
ejurgensen 7982bca6f0 Merge branch 'pl2'
Conflicts:
	src/db.c
2015-04-11 21:00:49 +02:00
ejurgensen 7d756230c2 Make raop_metadata_free private again and change a comment in http.c 2015-04-11 20:53:09 +02:00
ejurgensen 99cda05dab Remove player metadata event timer (use the existing instead) 2015-04-11 20:30:31 +02:00
ejurgensen 0397b824a5 Fixup (select between cur_playing and cur_streaming) 2015-04-09 22:33:23 +02:00
ejurgensen e72447954a Some cleaning up of ICY artwork retrieval 2015-04-09 22:22:42 +02:00
ejurgensen 94f94b03fe Swap artwork arguments so destination evbuffer comes first 2015-04-09 21:23:20 +02:00
ejurgensen f1931bfc1a Abandon raop_metadata_arg, and defer metadata time setting 2015-04-09 21:04:35 +02:00
chme 12520f2f1f [mpd] cleanup: remove duplicate logging of error messages 2015-04-08 19:34:59 +02:00
chme a268f836e7 [mpd] fix command list for albumartist 2015-04-08 19:34:59 +02:00
chme b7d5b1650e [mpd] add support for count command 2015-04-08 19:34:59 +02:00
ejurgensen ad81e05ab4 Better thread safety by making sure that the raop globals are only accessed through the player thread 2015-04-07 23:35:56 +02:00
ejurgensen 50ef710549 Fix memleak in artwork.c 2015-04-02 00:40:10 +02:00
ejurgensen 56ece92209 Remember to actually request ICY metadata in transcode.c 2015-04-02 00:09:12 +02:00
ejurgensen be21482d7b Fix memleak in filescanner_ffmpeg arising for ffmpeg versions without icy support 2015-04-02 00:07:49 +02:00
ejurgensen 0f1a27641f Fix minor mem leak in playlist scanner 2015-04-01 23:45:21 +02:00
ejurgensen e101812478 Check for id3 compilation tag (credit @zmatsuo)
Ref. pr #127, issue #83 and maybe issue #63
2015-04-01 23:08:34 +02:00
ejurgensen e084eb71db Polishing worker.c a bit 2015-04-01 14:36:24 +02:00
ejurgensen e4c0c13a20 Remove irrelevant comment 2015-03-31 23:40:52 +02:00
ejurgensen 19ba8fba67 Drop async mode from http client, not needed and probably not working 2015-03-31 23:27:18 +02:00
ejurgensen e49c941a00 Add a worker thread to support async tasks from the player thread
(and maybe others later)
2015-03-31 23:05:24 +02:00
ejurgensen 96200eb808 Use own libevent http client for downloading artwork, ffmpeg seems a
bit too slow
2015-03-31 00:08:29 +02:00
ejurgensen f947948a29 Avoid database locks when raop constructs metadata 2015-03-30 23:11:21 +02:00
ejurgensen e5c8128c9d Minor improvements for rescale_needed() 2015-03-30 23:10:33 +02:00
ejurgensen 4850423118 Make hiding internet streams from normal playlists configurable 2015-03-30 21:10:59 +02:00
ejurgensen 41f39ea5ca Sort playlists with ascending parent id, so that more nested playlists come after
the less nested ones (required by Retune)
2015-03-30 08:54:17 +02:00
ejurgensen 986b37ed29 Adds a playlist folder type, it is needed for sorting since some clients (eg Retune)
require that playlist folders are sent before their content. Playlist folders should,
however, be sent after the base playlists, so the numbering is changed. At the same
time makes the value of the smart playlist type a bit less hardcoded.
2015-03-30 01:03:15 +02:00
ejurgensen 33bc7227ea Make use of Spotify playlist folder configurable 2015-03-30 00:59:55 +02:00
ejurgensen 892fd9c402 Send mpco in daap playlist reply, even when 0 (like iTunes) 2015-03-29 23:34:36 +02:00
ejurgensen a529d78880 Don't crash on no metadata... 2015-03-29 20:16:56 +02:00
ejurgensen 2b2883403e Fixup for libevent 2.0 2015-03-29 01:10:37 +01:00
ejurgensen 0b67ae3974 Some fixup for libav 0.8 2015-03-29 01:02:14 +01:00
ejurgensen ea29a8d988 Remove filescanner_icy.c and consolidate in http.c.
Libav 9 does not support ICY metadata, so in that case we must be able to get it outselves.
2015-03-29 00:29:06 +01:00
ejurgensen b8d8df132b Support for remote m3u playlists (ref pr #79) 2015-03-20 23:40:42 +01:00
chme 516d46232b [mpd] db upgrade v16: remove unused data_kind column from files-query
and rename variable to "type" to match the pl-query
2015-03-20 13:44:29 +01:00
ejurgensen cde8441493 Don't cache internet artwork 2015-03-17 22:04:07 +01:00
ejurgensen d089eaf880 Some protection against mem leak 2015-03-17 22:03:40 +01:00
ejurgensen e5a1495b49 Add DAAP logic for the Radio item 2015-03-16 23:33:42 +01:00
ejurgensen 46e4214b39 Adjust log severity 2015-03-16 21:40:50 +01:00
ejurgensen cf6d94eda2 Fixup dblist for Radio item 2015-03-15 16:26:06 +01:00
chme d7f7a746a2 Added item for "Radio" to DAAP-reply to "/databases" request 2015-03-14 23:44:17 +01:00
ejurgensen 8359a9018d Fixup parent playlist 2015-03-14 23:35:19 +01:00
ejurgensen 618e22d57e Put Spotify playlists in a base playlist 2015-03-14 22:52:07 +01:00
ejurgensen e68c6c4932 Change db_pl_add/db_pl_update so input is playlist struct
- so they work like db_file_add/update and can accept all the struct data (incl. parent_id)
2015-03-14 22:34:03 +01:00
ejurgensen 9fdb8a5247 Add DB and DAAP support for nested playlists 2015-03-14 22:00:57 +01:00
ejurgensen 6221e24f1b Support for live ICY metadata for streams (incl. artwork) 2015-03-14 21:42:53 +01:00
chme 5b0cb6588b [mpd] support for ipv6 2015-03-14 09:51:39 +01:00
chme f41e7014e4 [mpd] add support for commands 'listplaylists', 'listplaylist',
'listplaylistinfo', 'ping'; add support for additional tags
2015-03-10 22:15:33 +01:00
chme 4a1bff500a [mpd] fixes for commands noidle, list (handle special case with second
argument 'album'), addid (sql error if virtual path contains
character ') and fix error messages in various commands
2015-03-10 22:12:33 +01:00
ejurgensen a7f15eadd3 Merge pull request #118 from chme/spotify
Support for Spotify starred playlists and config options to avoid album/artist clutter
2015-03-08 12:57:17 +01:00
chme 988283c25d [spotify] Added config options to use the playlist name as album name 2015-03-08 10:26:40 +01:00
chme 7cc3659d42 [spotify] Added config options to use the compilation artist for spotify
tracks
2015-03-08 10:26:40 +01:00
chme 563195b8a7 [spotify] Add "sp_track_is_starred" api method and log metadata 2015-03-08 10:26:40 +01:00
chme c984bcd157 [spotify] Set the name for the starred playlist 2015-03-08 10:26:40 +01:00
chme 665c76de00 [spotify] Add "sp_session_starred_create" api method and load the
"starred" playlist on login
2015-03-08 10:26:40 +01:00
chme 3fb6864216 [mpd] fix compile error on FreeBSD (thanks to Raivo Hool) 2015-03-08 09:39:33 +01:00
ejurgensen 0fb206d338 Merge pull request #116 from chme/mpdsqlext
[mpd] fix issues with utf8 characters when selecting from filelist
2015-03-07 20:16:24 +01:00
chme 2c0ce9cd56 [mpd] add support for speaker (de)activation through 'outputs',
'disableoutput', 'enableoutput', 'toggleoutput' commands
2015-03-07 18:55:42 +01:00
chme 9c979ef584 [mpd] fix issues with utf8 characters when selecting from filelist (lead
to an infinite loop in MPoD while importing the library and to missing
or wrong entries in ympd)
2015-03-07 10:05:09 +01:00
ejurgensen 6df734f497 Cleanup libevent 2 calls in httpd_daap.c/.h 2015-03-06 21:22:05 +01:00
ejurgensen 684de40be2 Minor change of log severity ("Done with group") 2015-03-05 21:24:27 +01:00
ejurgensen 1a0d2ef59b Reduce log severity 2015-02-28 15:16:19 +01:00
chme 1923e7b67d silence compiler warning in player.c "warning: ignoring return value of
‘read’ ..."
2015-02-28 08:00:10 +01:00
ejurgensen 114ec347bc Merge pull request #110 from chme/dbupdate
Enclose DB upgrade in a single transaction
2015-02-27 23:17:08 +01:00
ejurgensen 01fd561107 Merge pull request #105 from chme/playqueue
Improve behaviour for playing from history
2015-02-26 18:55:38 +01:00
chme 10f2eb2409 Improve behaviour for playing from history 2015-02-26 17:29:13 +01:00
chme 1bbfcf61a5 Enclose DB upgrade in a single transaction (improves performance and in
case of an error does a rollback, keeping the db in a valid state)
2015-02-26 14:09:14 +01:00
ejurgensen c2b5c08f36 Remove embedded libavl (ref commit df9bcade5a) 2015-02-25 22:05:08 +01:00
ejurgensen 72d7ba1452 Remove libavl dependency from filescanner_itunes.c 2015-02-25 21:58:08 +01:00
ejurgensen 3a5d2d560f Remove libavl dependency from httpd_daap.c and also introduce random session id's 2015-02-24 22:58:47 +01:00
chme 5bf43b05db fix compile error when compiled with --enable-itunes 2015-02-23 22:23:01 +01:00
chme a00c25628e fix warning for unused label "mpd_fail" when compiled without mpd
support
2015-02-23 22:21:06 +01:00
chme 795926605d db: add missing field "virtual_path" in struct db_playlist_info (fixes
segfault when loading playlists)
2015-02-23 20:49:53 +01:00
chme 6f7d9f5b44 db: fix wrong number of elements for purge queries 2015-02-23 20:26:42 +01:00
chme ec75664b81 filescanner: set event-base for cmdenv 2015-02-23 20:26:06 +01:00
chme f4fcbfb526 Fix segfault when starting playback for audiobooks (dacp_reply_playspec) 2015-02-22 06:13:21 +01:00
ejurgensen c8158805e3 Merge pull request #64 from chme/mpdprotocol
Add support for the mpd protocol
2015-02-20 22:39:03 +01:00
ejurgensen 02581f1aab Align OSS with ALSA so that forked-daapd will start even when there is no sound device 2015-02-19 10:30:34 +01:00
chme 3eab952867 fixup: rename db_mpd_build_query to db_mpd_start_query, removed unused
function from db.h
2015-02-15 13:59:35 +01:00
chme 7024f2f3e7 (basic) support for mpd commands 'find' and 'list' 2015-02-15 13:55:24 +01:00
chme 911b982815 support for mpd command 'search' 2015-02-15 09:51:38 +01:00
chme 63a480d5fc refactor playback_start, added comments to clarify the use of
item_range, renamed some variables (avoid using "song")
2015-02-14 22:39:51 +01:00
chme df5b0f779a Use view for filelist instead of separate table 2015-02-14 22:38:14 +01:00
ejurgensen df9bcade5a Embed libavl (v0.3.5), it is no longer available upstream and the dependency is a hassle 2015-02-14 20:58:01 +01:00
chme aa0abc1664 Add mpd command "playlistid"; add dummy implementation for mpd command
"idle"
2015-02-14 08:50:18 +01:00
chme ad23c0ff30 Add missing free of virtual_path for playlists 2015-02-14 08:50:18 +01:00
chme 0c936c9bea Do not trigger a new rescan if one is already running; fix log domains
in filescanner; default to "file:" for virtual paths (fixes segfaults on
pipes)
2015-02-14 08:50:18 +01:00
chme 8401d5ad09 Removed unnecessary creation of index on db update 2015-02-14 08:50:18 +01:00
chme 830054bd71 Initial support for mpd protocol 2015-02-14 08:50:18 +01:00
ejurgensen 3cd7b27bac Remove FreeBSD/OSS4 hacks and add FreeBSD 10.1 install and startup helper scripts (issue #94) 2015-02-11 22:59:57 +01:00
ejurgensen d542ab9c98 Remove/disable raop_check_cseq because raop/rtsp servers like Reflector and AirFoil don't return it according to spec (issue #98) 2015-02-09 17:57:49 +01:00
ejurgensen ebfff85afa Fix problems with iTunes 12.1, see issue #100
- don't announce group support to iTunes
    - support for absolute http url streaming requests
2015-02-06 22:14:26 +01:00
chme 07b4d6b6a9 first song not shuffled 2015-02-01 10:51:43 +01:00
m42i 360e7213e6 Fix filepath matching for iTunes library import 2015-01-29 21:07:52 +01:00
ejurgensen 1a137db1b4 Better log message when libspotify is missing 2015-01-28 19:59:38 +01:00
ejurgensen dccbe92a75 Only do hex conversion if param is 0x-format. Also accept song-spec from Retune (issue #90). 2015-01-26 22:37:02 +01:00
ejurgensen a2151a2cd5 Add playqueue-edit mode 2 comment 2015-01-18 22:54:01 +01:00
ejurgensen c2bc05cb16 Minor adjustments to cache.c, mostly adjusted log messages 2015-01-18 00:32:07 +01:00
ejurgensen f1a59a3482 Fix laudio buffer underrun (issue #87) 2015-01-17 14:31:41 +01:00
ejurgensen b1903e4551 Always try to start AirPlay when laudio fails (issue #86) 2015-01-16 23:18:21 +01:00
ejurgensen 266d05f5eb Revert "Don't add duplicates (same fname, artist, album and title), issue #85"
This reverts commit 70365422b4.
2015-01-16 22:32:23 +01:00
ejurgensen 70365422b4 Don't add duplicates (same fname, artist, album and title), issue #85 2015-01-14 22:07:24 +01:00
ejurgensen 4df4c50c35 Add option to exclude paths from scanning based on regex 2015-01-14 21:50:25 +01:00
ejurgensen baa3ee63ca Adjust a few log messages 2015-01-14 20:46:03 +01:00
ejurgensen da376cbeb9 Upgrade database schema to v15.0 -> 15.1 2015-01-14 20:37:29 +01:00
ejurgensen d16cf2fe7c Introduce major and minor schema versioning to improve vers compability
- also make database vacuuming on startup optional
2015-01-14 20:32:36 +01:00
ejurgensen 37d990b390 Ignore non-artwork jpg's and png's during filescan
(so ffmpeg doesn't waste time analyzing them)
2015-01-10 23:29:10 +01:00
ejurgensen 829619be5d Vacuum on startup and also make index changes possible without schema updates 2015-01-10 22:44:26 +01:00
ejurgensen 1f81b5ce7e Revert "Upgrade db schema to v16"
This reverts commit bfa9f4d5cf.
2015-01-10 20:31:13 +01:00
ejurgensen b605dc2fc3 Spelling mistake 2015-01-10 19:19:45 +01:00
ejurgensen a96af67a30 Some fixing up of prev commit 2015-01-10 00:45:19 +01:00
ejurgensen bfa9f4d5cf Upgrade db schema to v16 2015-01-10 00:08:50 +01:00
ejurgensen 2208c021aa Improve browse queries (credit @chme)
Adjusted re-commit of commit ec47c6e730
2015-01-09 23:59:38 +01:00
ejurgensen 27a2fabb56 Modify groups queries and improve index 2015-01-09 23:04:50 +01:00
ejurgensen ea598bfeaf Remove upgrade paths for indices (since they don't have any data anyway), and instead implement db_create_indices and db_drop_indices to reduce redundancy 2015-01-09 00:28:06 +01:00
chme 1981237638 Improve select for files table by removing f.media_kind = 32 from the
queries (forked_daapd has no media_kind = 32).
2015-01-08 22:44:09 +01:00
chme 46f770b52d Improve selects for files table by removing the (f.album <> '' AND
f.album IS NOT NULL) from the where clause for album and artist. These
are unnecessary because forked-daapd makes sure that an artist or album
name exists.
2015-01-08 22:43:29 +01:00
ejurgensen ad48ccb804 Revert "Merge branch 'db' of git://github.com/chme/forked-daapd into chme-db"
This reverts commit b8d5e32160, reversing
changes made to 5a02f926e3.
2015-01-08 22:40:47 +01:00
ejurgensen b8d5e32160 Merge branch 'db' of git://github.com/chme/forked-daapd into chme-db
Conflicts:
	src/artwork.c
2015-01-08 22:34:45 +01:00
ejurgensen 5a02f926e3 Fix bug in float to string conversion of raop volume (credit @andreas-p, issue #84) 2015-01-08 22:03:53 +01:00
ejurgensen 70f05049e8 Change text for severity log from ERROR to LOG
To avoid this startup message:
[ERROR]     main: Forked Media Server Version 22.1 taking off
2015-01-07 21:50:24 +01:00
ejurgensen 3b38bee45b Fix wrong log domain 2015-01-06 23:26:29 +01:00
ejurgensen a9bc1a21dc Merge pull request #75 from couteau/ownartwork (and additional artwork.c overhaul) 2015-01-04 22:41:00 +01:00
ejurgensen 103ce0887a Misc artwork fixup 2015-01-04 19:38:13 +01:00
ejurgensen 73bbe831e6 artwork.c overhaul and avoid "Error reading artwork" message when there is no artwork
- try to align return values in artwork.c
2015-01-04 15:12:46 +01:00
chme 6a2dc2d538 log severity in logfile and console 2015-01-03 18:00:31 +01:00
ejurgensen 0d7ec13ede Merge branch 'ownartwork' of @couteau and various modifications (see pr #75) 2015-01-03 00:31:48 +01:00
ejurgensen 2879458e98 Fix for issue #62 (slow internet streams), credit @chme 2015-01-02 23:24:44 +01:00
ejurgensen d55d194201 Remove misplaced quotes 2015-01-01 22:28:26 +01:00
Stuart C. Naifeh f3e21956c4 Add configuration option to disable individual artwork 2014-12-30 10:38:03 -05:00
chme ec47c6e730 optimize queries and indexes for composer/genre 2014-12-29 09:24:29 +01:00
chme 5cb06980e3 Optimize the indexes on the files table to speed up select queries 2014-12-29 09:24:29 +01:00
chme 12b46ad94d Improve select for files table by removing f.media_kind = 32 from the
queries (forked_daapd has no media_kind = 32).
2014-12-29 09:24:29 +01:00
chme fedf571d34 Improve selects for files table by removing the (f.album <> '' AND
f.album IS NOT NULL) from the where clause for album and artist. These
are unnecessary because forked-daapd makes sure that an artist or album
name exists.
2014-12-29 09:24:28 +01:00
chme e321e5137f db update v16 and cache update v2 2014-12-29 09:24:28 +01:00
chme 31870fe046 improve selects for files table by removing the join to the groups table 2014-12-29 09:24:28 +01:00
ejurgensen a69619a5a7 Implement is_remote() and change how transcode_needed() is used
transcode_needed() was getting called needlessly in http_daapd.c,
because 1) once it is determined that a given codec needs transcoding
for a given client there is no reason to call and check again, 2)
transcoding is irrelevant for remotes. Also some cleaning up of
user_agent_filter().
2014-12-28 23:37:12 +01:00
ejurgensen 3e412b5e65 Remove misplaced quotes in db_group_type_bypersistentid() 2014-12-28 23:32:21 +01:00
ejurgensen 4de5f7c19c Fix login/logout problem in spotify.c (see issue #68) 2014-12-28 21:08:52 +01:00
chme 7889d92a81 Identify "android" user-agent as a remote client in transcode_needed()
(similar to the check in user_agent_filter())
2014-12-28 09:37:19 +01:00
chme 3208315503 fix delete query for removing files if a spotify playlist is deleted 2014-12-27 21:44:25 +01:00
Stuart C. Naifeh 431ecdb197 Cache individual artwork 2014-12-27 11:40:52 -05:00
Stuart C. Naifeh 9e9ffe6809 Update cache api, version, and logic to support caching of individual as
well as group artwork
2014-12-27 10:48:12 -05:00
Stuart C. Naifeh 2171a1f2b3 Re-add support for individual artwork 2014-12-27 09:44:16 -05:00
Justin Maggard cdb0048082 Fix invalid read on empty string queries. 2014-12-17 15:03:23 -08:00
Justin Maggard 4efca3660f Fix bad free when encountering an error fetching query results. 2014-12-17 15:03:23 -08:00
Justin Maggard e431b04310 Lower log level for missing revision-number in client update request. This is some clients' normal behavior, so we shouldn't need to need to see a message about it in the error log. 2014-12-17 15:03:23 -08:00
ejurgensen 9b7a22ab0a Avoid threading issue in both ffmpeg and libav that prevents decoding embedded png's 2014-12-09 22:31:41 +01:00
chme 2e5d234ac5 [artwork] do not add cache entry if reading artwork failed 2014-12-07 07:39:27 +01:00
ejurgensen 6f2f44168d Some config file polish (now that it's being updated anyway) 2014-11-17 22:53:52 +01:00
ejurgensen 9d9c82b6b1 Shorten timeout waiting for audio to Spotify 2014-11-11 20:22:39 +01:00
ejurgensen 5e4f449179 Add a timeout waiting for audio to Spotify 2014-11-11 11:59:40 +01:00
ejurgensen f74774f5f7 Be more generous with Spotify image resolution now that the cache protects against poor reponse times 2014-11-11 11:37:03 +01:00
chme 7578bb1205 Artwork caching (pull request #61), and also:
- introduced new section in config file for sqlite pragma settings,
added config for artwork cache
- added setting of pragma synchronous, cache size and journal mode to
daap cache
2014-11-10 22:53:08 +01:00
ejurgensen f24ab29098 Extend cache rebuild to 60 seconds so we are more certain that the library is 'idle' 2014-10-16 22:15:35 +02:00
ejurgensen 9508eba62e Return silence if the pipe read was blocked (credit bfitz) 2014-10-07 19:55:28 +02:00
ejurgensen 88fcfa061d Add compability with ffmpeg's libswresample 2014-10-02 22:48:50 +02:00
ejurgensen 4857f21644 Merge branch 'freebsd': New timing mechanism (issue #46)
- also some libevent 2 adjustments
2014-09-30 21:39:02 +02:00
ejurgensen 376f0ed1c0 Minor fix 2014-09-30 18:55:32 +02:00
ejurgensen 495aebec40 Fix bug where it would hang because it looked for artwork in named pipes
- also some refactoring of the artwork code to diminish redundancy
2014-09-29 23:40:38 +02:00
ejurgensen 513e38dcda Proper update to libevent 2 (artwork, avio_evbuffer, dmap_common, transcode) 2014-09-28 22:44:45 +02:00
ejurgensen 661a557500 Proper update to libevent 2 in spotify.h and pipe.h 2014-09-28 22:26:23 +02:00
ejurgensen a3a689573f Better define in player.c 2014-09-28 22:14:30 +02:00
ejurgensen 1ffbfd8c45 Proper update to libevent 2 in player.c 2014-09-28 22:09:22 +02:00
ejurgensen 965df4fdfc Delete event after disarming timer (maybe not necessary, but for safety) 2014-09-28 15:30:52 +02:00
ejurgensen cf5b702460 Fix malplaced declaration 2014-09-27 23:12:18 +02:00
ejurgensen 4078542eb4 Forgot an include 2014-09-27 23:08:43 +02:00
ejurgensen 29265d6170 Drop special FreeBSD stream period 2014-09-27 23:08:24 +02:00
ejurgensen 861635eb4d timer_delete() instead of close() for FreeBSD timer 2014-09-27 23:05:22 +02:00
ejurgensen 65110a9f39 Fix FreeBSD sound timing problems 2014-09-27 22:59:19 +02:00
ejurgensen dafa26a48a Protect against uinitialized var if query is empty 2014-09-26 23:13:17 +02:00
ejurgensen ca3fada215 Fix ALSA audio problem where threshold will not be reset because
commit 7462290 decreased the value of pcm_pos
2014-09-19 22:18:07 +02:00
ejurgensen 27e7148405 Use STOB() in player.c since it is defined right in player.h 2014-09-19 22:14:31 +02:00
ejurgensen f543b768ac Merge pull request #41 from chme/skipprev
rfc: Change behavior of skip to previous song
2014-09-12 21:45:15 +02:00
ejurgensen 2fc681a971 Add condition for FreeBSD, ignore SCHED_BATCH in filescanner.c 2014-09-12 17:52:08 +02:00
ejurgensen 8c9793d9ef Fix filescanner bugs:
- stop init-rescan/full-rescan from running twice
- set thread priority to batch
- don't request libevent to loop when the loop is already running
2014-09-11 22:41:07 +02:00
ejurgensen 5bfe4673f5 Add a function in filescanner.c to enumerate certain file types
Fixes bug where init-rescan and full-rescan would run twice because
two inotify events get triggered by eg 'touch xxx.init-rescan'
2014-09-10 22:16:52 +02:00
ejurgensen 97910f3a99 Fix bug where LastFM session key in db was ignored 2014-09-08 23:13:12 +02:00
ejurgensen be7a6c7b1e Don't try to login to Spotify if the filescanner got an exit signal 2014-09-08 22:45:05 +02:00
ejurgensen 94c5352db6 Remove EVLOOP_ONCE calls in filescanner
These calls generate error messages when the loop is already running, which
will be the case when using init-rescan or full-rescan. The only purpose
of these calls seems to be to check for exit signals from the main thread
during a startup bulk scan, where the loop is not running yet. However, we
can check for an exit signal by just setting/checking scan_exit.

This commit also removes the unused filescanner_status().
2014-09-08 21:57:52 +02:00
ejurgensen d2d85b29f4 Lower the priority of the thread so forked-daapd may still respond
during file scan on low power devices
2014-09-07 13:48:03 +02:00
ejurgensen 2545aedc2a Avoid duplicate rows in the admin table 2014-08-27 22:12:42 +02:00
ejurgensen ae3b5077ec Add support for .pls playlists 2014-08-27 21:57:16 +02:00
ejurgensen 1b51fcf07c Rename filescanner_m3u to _playlist, because we are going to add
support for pls
2014-08-27 21:54:28 +02:00
ejurgensen b26e507baa Fix memleak in DAAP cache 2014-08-25 22:05:44 +02:00
ejurgensen 271e2c29e1 Add some libevent 1 compability 2014-08-24 14:51:41 +02:00
ejurgensen d157aca620 Save response times in DB and show in log (for debugging) 2014-08-24 12:43:32 +02:00
ejurgensen 31ef4d4e13 Add slow DAAP queries to cache automatically 2014-08-24 01:23:23 +02:00
ejurgensen cf091e8d8b Adjust daapcache so it serves User-Agent to httpd_daap's reply handlers 2014-08-23 00:02:01 +02:00
ejurgensen 624dd40c59 Include DAAP queries from Retune and TunesRemote+ for caching
+ misc fixing up
2014-08-22 22:51:13 +02:00
ejurgensen f997aca452 More DAAP cache adjustments 2014-08-21 23:06:52 +02:00
ejurgensen eac718ea0f Some more daap cache triggers 2014-08-21 10:14:24 +02:00
ejurgensen 76231cac0f Experimental caching of playlist 1 2014-08-21 10:01:47 +02:00
ejurgensen 7623de1ac4 Allow const char tags and handle null requests in dmap_common 2014-08-21 09:59:59 +02:00
ejurgensen 39b9c4fc33 Make DAAP cache use and location configurable 2014-08-20 23:09:23 +02:00
ejurgensen f3a19fce8e Add DAAP cache backend 2014-08-20 00:21:48 +02:00
ejurgensen a594455e09 Add db_query_run() to get rid of some redundancy in db.c 2014-08-18 00:20:23 +02:00
ejurgensen 6d8e4c67aa Support for LastFM scrobbling (issue #19) 2014-08-15 23:36:54 +02:00
ejurgensen 21cf3ab7d3 Add trimwhitespace(), keyval sorting and alloc to misc functions
- features required by the LastFM module
2014-08-15 22:56:39 +02:00
ejurgensen d5efc2dcb3 Add db interface to update the admin table 2014-08-15 22:54:47 +02:00
ejurgensen b0807b168e Preproc defines in evhttp_compat.h to protect against double inclusion 2014-08-15 22:53:47 +02:00
Marlies Heijkoop bbb21b0bad Don't segfault on invalid utf8 while sorting
`strmblen` returns -1 on invalid sequences, which causes a segfault when passed as length to `stpncpy`.
2014-08-14 20:06:45 +02:00
chme 05e6402dc6 Fix skip to next song while the last song in Up Next is playing
(introduced in a6c2a25)
2014-08-02 07:25:18 +02:00
chme 974c6e6323 add missing "#undef Q_TMPL" 2014-07-27 11:16:00 +02:00
chme a6c2a25642 If reshuffling with repeat all songs in queue active, set shuffle-head
to current playing song. Previously the shuffle-head was set to the next
song after the current, therefor the UpNext-queue appeared empty after
adding new songs to the queue.
2014-07-25 18:51:34 +02:00
chme 87b415b0d4 Fix segfault on reshuffling one item 2014-07-25 18:25:20 +02:00
chme 5065c3e4a0 Use query parameter if queuefilter parameter is unkown 2014-07-19 08:45:40 +02:00
chme 49a985391d Ignore queuefilter on playqueue-edit-add if mode = 0 (add to up next) 2014-07-19 08:44:27 +02:00
chme 74622904e3 local audio: do not add pcm_buf_threshold to pcm_pos (leads to wrong
position in Remote)
2014-07-17 20:14:21 +02:00
chme 4d79a85780 Change behavior of skip to previous song to start the current song from
the beginning, if it is playing for more than 3 seconds
2014-07-17 20:14:21 +02:00
chme fe2abfd123 clear queue on playback abort 2014-07-17 20:12:19 +02:00
chme 9527e06f71 reshuffle only songs in the UpNext queue 2014-07-17 20:12:19 +02:00
chme 46c0239a79 Added options to modify the operation of the SQLite database (through PRAGMA statements)
- set cache size (in number of pages)
- set synchronous flag
- set journal mode
2014-07-13 10:35:38 +02:00
ejurgensen 17ffdc56ad Fix bug where streams with sample rate < 44100 stop too early (with libav 10+)
- avresample_convert should be passed max samples to convert, not
number of samples in input (which for low sample rates is lower
than output)
2014-07-06 23:31:20 +02:00
ejurgensen 129c00c3d1 Change some playlist scanner log levels 2014-06-23 01:51:32 +02:00
ejurgensen 0a2d2273bd Remove build warning caused by data type mismatch 2014-06-22 22:29:45 +02:00
ejurgensen 7810f16361 Fix bug where it will wait endlessly if a Spotify track is paused the last few
seconds of a track (after new track has been opened)
2014-06-22 22:27:52 +02:00
ejurgensen a860907202 Another preprocesser condition for OpenWrt compability 2014-06-16 23:46:30 +02:00
ejurgensen 2247fadbfa Some preprocessor conditions for compability on OpenWrt 2014-06-16 23:31:44 +02:00
ejurgensen a181b515f2 Merge branch 'dev' 2014-06-11 23:10:52 +02:00
ejurgensen d993bc3750 Defer loading Spotify playlists until bulk scan is complete
(because of database locking issues)
2014-06-10 22:49:44 +02:00
ejurgensen 1bd11d2895 Fix so permission changes in the library are handled (issue #8) 2014-06-09 23:42:02 +02:00
ejurgensen 30aa93479d Merge branch: libevent compability improvements 2014-06-02 21:59:50 +02:00
ejurgensen 844a9b43c9 Fixup new libav 10 icy extraction 2014-06-02 21:51:50 +02:00
ejurgensen ada7ccca8f Change log level of .remote message to ease pairing troubleshooting 2014-06-02 21:08:24 +02:00
ejurgensen 116289f5b7 Libav 10 (and ffmpeg) now has native support for ICY metadata 2014-06-02 00:00:52 +02:00
ejurgensen b566c41a36 Setting log level to info gave a lot of meaningless db.c messages 2014-06-01 23:58:44 +02:00
ejurgensen c740e6e3b0 Make compatible with libevent 2.0 by crippling streaming and ICY metadata (see issue #30) 2014-05-30 23:39:03 +02:00
ejurgensen 5b4ef31758 Migrate all evhttp to non-deprecated libevent2
- well except a troublemaker in httpd_daap.c (req->flags &= ~EVHTTP_PROXY_REQUEST)
2014-05-29 23:22:00 +02:00
ejurgensen 22d37f240b ICY scanner modifications 2014-05-29 11:50:56 +02:00
chme a4fbeed81e Added comments to queue_clear and queue_empty 2014-05-29 09:45:04 +02:00
ejurgensen 02c23b0065 Better thread sync, cleanup and libevent compability in ICY filescanner 2014-05-26 23:38:19 +02:00
chme b7cb0da2c2 Modifications to the playqueue-clear command:
- do not stop playback when clearing the UpNext queue
- clear history, if mode=0x68697374 ("hist")
2014-05-24 07:34:59 +02:00
ejurgensen aa8344d14d Some filesystems have mtime=0 (Seafile), so add check for stamp before
letting the scanner exit with just a db ping
2014-05-21 22:31:05 +02:00
ejurgensen 519a673503 Extra error check 2014-05-20 22:45:25 +02:00
ejurgensen 8468f55910 Honor the "ek" (encryption) flag for RAOP_DEV_OTHER + slight rewrite of raop_device_cb 2014-05-18 17:19:50 +02:00
chme f60be3c8af Do not use queryfilter on "play next" and "add to up next" commands 2014-05-18 09:04:17 +02:00
chme a1b09903c0 - Fix crash when calling add-next and cur_playing/cur_streaming are NULL
- Append songs after cur_streaming
2014-05-17 14:13:18 +02:00
ejurgensen dafc748bfd Clear watches from db on init-rescan 2014-05-14 21:39:25 +02:00
ejurgensen 915719f0f8 Fix Spotify exemption from purge during init-rescan 2014-05-14 20:44:07 +02:00
ejurgensen 6b0c5997bf Fixup init-rescan 2014-05-13 22:14:19 +02:00
ejurgensen c1be585469 Extra log message for debugging apparent db locking issue 2014-05-13 22:02:32 +02:00
ejurgensen a7d0a603b3 Excempt Spotify items from rescan purge 2014-05-13 20:57:37 +02:00
ejurgensen 851b57017d Add option to trigger startup scan, rename force-rescan and better cleanup in full rescan 2014-05-11 23:55:18 +02:00
ejurgensen 0aa8416a21 Reset inotify when force-rescan is triggered 2014-05-11 23:44:15 +02:00
ejurgensen 5a5163e699 Move db_analyze/db_hook_post_scan (credit @chme) 2014-05-11 23:17:29 +02:00
ejurgensen a5b2fbc0fe Wrap bulk scan in a db transaction (credit @chme) 2014-05-11 23:13:09 +02:00
ejurgensen 44c3dba3d9 queue_remove was removing wrong item 2014-05-06 22:55:59 +02:00
ejurgensen 305c1a141c Indentation 2014-05-04 22:36:37 +02:00
chme 7e43a42c88 Remove dead code: playback_next_bh and playback_prev_bh are only called
during playback_pause. In playback_pause "cur_playing" is always set to
NULL so that in playback_next_bh and playback_prev_bh only the
else-clause can become true.
2014-05-04 05:45:53 +02:00
chme 79646c78e4 fixup indentation 2014-05-03 20:16:51 +02:00
chme 8036a5a6d3 fixes for playqueue-contents 2014-05-03 20:16:51 +02:00
chme 5f307c7ce1 Added support for playqueue-contents with negativ span value (returns the previously played songs) 2014-05-03 20:16:51 +02:00
ejurgensen 20539c0c08 Remove unused variable in queue_next_add 2014-04-30 23:33:42 +02:00
ejurgensen a2f90a997c Make sure albums/artists appear the same despite different capitalization 2014-04-30 23:30:08 +02:00
chme eab4c1c3d2 Fix "play next" command - the queue was not circular anymore due the
missing setting of pl_prev of the next song and start the shuffle-queue
with ps_shuffle
2014-04-23 20:44:40 +02:00
ejurgensen 8eb6b46ed2 Adjustments to queue_move/queue_remove, mostly for consistency 2014-04-21 21:21:40 +02:00
ejurgensen 748ce1413f Revert msed to 0 for now 2014-04-20 23:34:04 +02:00
chme 4c5abdac5e add songs for album or artist ordered by album 2014-04-20 11:03:49 +02:00
chme 2391838ea1 announce support of playlist editing by setting "msed" to 1 2014-04-20 07:33:28 +02:00
chme 01cc83f819 respect coding convention and changed log level 2014-04-20 06:43:01 +02:00
chme 32c3b57fcd added support for the playqueueedit add next command 2014-04-19 09:12:58 +02:00
chme 475a2f4e8f added support for the playqueueedit remove command 2014-04-19 08:35:07 +02:00
chme c3c2c421d2 added support for the playqueueedit move command 2014-04-19 08:09:32 +02:00
ejurgensen 365c5a3bc9 Only queue the rest of the album on quirky query 2014-04-18 22:39:17 +02:00
ejurgensen 2c16b070ed Make the update of playcount non-blocking for playback
- otherwise slow updates would disrupt streaming when switching track
2014-04-18 22:31:37 +02:00
ejurgensen 35e9b3dc30 Fix bug in m3u scanner 2014-04-18 13:08:31 +02:00
ejurgensen c7aaf6eff3 Forgot a spotify enabled condition 2014-04-05 22:30:35 +02:00
ejurgensen c47287a556 Support for Spotify artwork 2014-04-04 23:14:43 +02:00
ejurgensen 1be543b00a Only cache available Spotify tracks 2014-04-03 20:44:36 +02:00
ejurgensen d722b18817 Add optional request-session-id to login request
- should make it easier to write curl scripts to control forked-daapd
since you avoid the need to parse the replies just to find a valid
session id
2014-04-01 22:47:04 +02:00
ejurgensen 7e2f47f9ca Minor adjustment so Valgrind is happy with string handling in user_agent_filter 2014-04-01 21:51:07 +02:00
ejurgensen a3f0145561 Open nonblock so it won't hang if other end is absent 2014-04-01 21:43:30 +02:00
ejurgensen 16756a6632 Clean up old allocations in pipe.c before allocating 2014-03-31 13:13:24 +02:00
ejurgensen 6062ca014b Make the player able to stream from pipes 2014-03-31 13:10:18 +02:00
ejurgensen 9efc97d702 Add support for query-modifier=containers in DACP playqueue-edit 2014-03-31 01:53:46 +02:00
ejurgensen 8740249e05 Clear up some code in filescanner.c 2014-03-31 00:04:03 +02:00
ejurgensen 0c79a02e93 Fix error in filescanner when renaming files. Allow scanner to add
fifos (named pipes) for later Shairport integration.
2014-03-30 23:44:30 +02:00
ejurgensen 49498800ba Add config option for preferred Spotify bitrate. README update. 2014-03-29 22:26:46 +01:00
ejurgensen aef908b093 Don't announce support for playlist editing 2014-03-28 20:44:19 +01:00
ejurgensen 7d410fb6e7 Disable aeMk in databases reply since we don't calculate it properly 2014-03-28 19:25:15 +01:00
ejurgensen 35f8dd4233 DAAP modifications to properly show media kind shares in iTunes 2014-03-26 23:59:28 +01:00
ejurgensen 3ff4fa77be Merge branch 'libevent2' into dev 2014-03-24 04:59:08 +01:00
ejurgensen c01bb54b79 Poor man's natural sort
- sort a1, a2, a11, a21, a100 instead of a1, a11, a100, a2, a21
2014-03-24 04:56:36 +01:00
ejurgensen 87f8b204df Rewrite spotify to use libevent for better reliability 2014-03-23 21:45:06 +01:00
ejurgensen 7c3da47eb7 Small DAAP changes to align with iTunes 2014-03-23 00:23:34 +01:00
ejurgensen 708b76ce1e Play only a single item when playspec has item-spec (Podcasts/Audiobooks) 2014-03-21 23:38:14 +01:00
ejurgensen c01698e462 Filescanner should not watch for IN_MODIFY
- it is bad for performance (triggers many db selects) and is
useless anyway.
2014-03-21 22:57:56 +01:00
ejurgensen 3f1edc0082 Oops 2014-03-18 11:35:47 +01:00
ejurgensen 9484c43601 Prevent notify_main_thread from mucking with SPOTIFY_EVENT before an
event has been processed
2014-03-18 11:31:48 +01:00
ejurgensen 59b6462ba6 Small logging change 2014-03-18 10:01:06 +01:00
ejurgensen 4ab7ea6e31 Reduce Spotify logging a bit 2014-03-18 09:57:49 +01:00
ejurgensen c3f05671b2 Spotify: When track ends, empty buffer before stopping. Also some
safeguards against indefinite waits and null pointer dereferencing.
2014-03-17 22:25:47 +01:00
ejurgensen 8b97d7fdd8 Forgot to remove some debug messages in mdns_avahi.c 2014-03-16 23:14:30 +01:00
ejurgensen ae70bf58fc Make mdns_avahi.c fully compliant with libevent 2, so it doesn't
complain in the logs about missing event base for event_del_
2014-03-16 23:11:21 +01:00
chme d5c6f1f72f Use EVBUFFER_EOL_CRLF for evbuffer_readln to make sure that the end of
the rtsp-header (an empty line) is recognized
2014-03-13 23:34:34 +01:00
ejurgensen 687f349927 Let configure check libevent version and include according to version 2014-03-13 23:33:35 +01:00
ejurgensen 5c40b2344c Another filescanner bug fix after Spotify commit 2014-03-12 22:59:47 +01:00
ejurgensen f6e9ddbc41 Repair legacy filescanners (broken by libav conditions) 2014-03-12 22:54:30 +01:00
ejurgensen 81b285a79e Fix horrible filescanner bug I introduced with the Spotify commit 2014-03-12 21:48:04 +01:00
ejurgensen 7ed6cc98c3 Add support for Spotify (squashed commit), and:
- Try to not return items which a client can't play
    - Remove inotify subscription to IN_MODIFY and IN_CREATE
    - Fix crash on unknown codec type in transcode.c
    - Probably added some new bugs...
2014-03-11 23:20:29 +01:00
ejurgensen 190f91114e Support songartistid (asri) in group requests and queuefilter=artist
- credit misenhower of wp8remote.com
2014-02-21 20:39:57 +01:00
ejurgensen 7997377deb Adjust for libav 10 API
With libav 10 the API is (again...) changed, adjust for that and
add the appropriate version conditions
2014-02-17 23:05:24 +01:00
ejurgensen 1ec1528f3b Mimic iTunes and reply 204 No Content to playqueue-edit&add 2014-02-13 15:46:24 +01:00
ejurgensen 23a7e82a1f Add support for max volume for AirPlay devices (raop) 2014-02-09 16:07:00 +01:00