Commit Graph

4776 Commits

Author SHA1 Message Date
ejurgensen fc5a66f86d [misc] New utility functions: trim, atrim and safe_snprintf_cat 2018-12-31 15:55:49 +01:00
ejurgensen d3121f4ec7 [db] Use prepared statements for file insert, update and ping
Get rid of the SQL query strings, since they are prone to errors and are
probably also slower that using prepared statements.
2018-12-31 15:55:49 +01:00
ejurgensen 53d7005547 [pipe] Error check of b64_decode return value 2018-12-29 16:50:27 +01:00
ejurgensen 103dda29f3 [misc] Move CHECK_NULL inside b64_decode (around the malloc)
To stay in line with general use of the macro
2018-12-29 16:39:52 +01:00
chme 271978f41a [travis-ci] Build on Ubuntu 16.04 (Xenial) 2018-12-29 16:34:56 +01:00
chme 05fd28239b [travis] Build libwebsockets 2.0.3 from source 2018-12-29 16:34:56 +01:00
chme 788cb6f133 [pipe/raop] Check for NULL to avoid scan-build issues (in case of oom) 2018-12-29 16:34:56 +01:00
ejurgensen a37fc0916f [alsa] Fix scan-build issue: Argument with 'nonnull' attribute passed null 2018-12-29 16:34:56 +01:00
chme 2ffb94c9d1 [db] Fix scan-build issue "Argument with 'nonnull' attribute passed
null"
2018-12-29 16:34:56 +01:00
chme 46b37b2c80 [daapd] Fix scan-build issue "Dereference of null pointer" 2018-12-29 16:34:56 +01:00
chme 75432ce73f [rtsp] Initialize addr to avoid scan-build issue "Assigned value is
garbage or undefined"
2018-12-29 16:34:56 +01:00
chme f3a495cd37 [player] Fix memory leak if opening new source failed
player.c:2032:11: warning: Potential leak of memory pointed to by 'ps'
2018-12-29 16:34:56 +01:00
chme b7f3e71f7e [db_upgrade] Fix memory leak in error case
db_upgrade.c:72:7: warning: Potential memory leak
2018-12-29 16:34:56 +01:00
chme 21ce281cd1 [filescanner] Fix Use-after-free error
library/filescanner_ffmpeg.c:396:7: warning: Use of memory after it is
freed
2018-12-29 16:34:56 +01:00
ejurgensen 80a86cbab5
Merge pull request #649 from chme/output_notification
[player] Send notification on output added/removed
2018-12-29 13:56:36 +01:00
chme 2a76e888f0 [player] Send notification on output added/removed 2018-12-29 08:46:00 +01:00
chme d9f00a3ab6
Merge pull request #645 from whatdoineed2do/queue-add-item-count-fix
[jsonapi] correct count of tracks added returned
2018-12-28 19:54:55 +01:00
whatdoineed2do/Ray e9f92ba1a7 [jsonapi] correct count of tracks added returned 2018-12-24 19:27:19 +00:00
chme 4961dd9141
Merge pull request #634 from chme/webinterface
Update player webinterface (v0.3.0)
2018-12-24 07:22:37 +01:00
chme ef68e00b03 [htdocs] Rebuild player web interface v0.3.0
- fix for play shuffle
- index based navigation for artists, albums, genres, genre
albums/tracks
- dedicated genre tracks page
- refactor modal dialogs into separate components
- refactor list item components into functional components
- show queue item modal dialog in now playing page
- add composer to track and queue item modal dialog
- show cover artwork in album modal dialog
- reduce timeout for scroll behavior (should reduce ugly jumps
navigating to different routes)
2018-12-24 06:38:45 +01:00
chme 427772e3c8 [web-src] Add rating to track details 2018-12-24 06:38:45 +01:00
chme 7d4bf8e75e [web-src] Fix building index list for genre/album tracks (use title_sort instead of title) 2018-12-24 06:38:45 +01:00
chme 67af2cc6a9 [web-src] Refactor showing notification after queue add action 2018-12-23 10:35:34 +01:00
chme b0bfa6be60 [web-src] Change style for info button in now playing page 2018-12-23 09:31:05 +01:00
chme 2a3bcead37 [web-src] Fix generating id for index nav (name_sort instead of name) 2018-12-23 09:31:05 +01:00
chme 7714558043 [web-src] Update dependencies 2018-12-23 09:31:05 +01:00
chme c423266b73 [web-src] Add visual indication that for index nav 2018-12-23 09:31:05 +01:00
chme 7b07d9cee7 [web-src] Fix margin/padding top for media item lists in pages with index navigation 2018-12-23 09:31:05 +01:00
chme 11179f7ac5 [web-src] Add index navigation to artist tracks page 2018-12-23 09:31:05 +01:00
chme 8b37039b15 [web-src] Rename PageTracks to PageArtistTracks 2018-12-23 09:31:05 +01:00
chme bb9bf36de7 [web-src] Reduce size of icon + text for actions in dialog footer 2018-12-23 09:31:05 +01:00
chme 63be54313f [web-src] Show cover art in spotify album dialog 2018-12-23 09:31:04 +01:00
chme 1d5d6f4858 [web-src] Add index button list to genre album/tracks page and generate index-id-tag in ListItemXXX 2018-12-23 09:31:04 +01:00
chme 1d21b7cc1d [web-src] Only show index button list if more than one entry is present 2018-12-23 09:31:04 +01:00
chme f8f23ced86 [web-src] Reduce timeout for scroll behavior to 10 ms 2018-12-23 09:31:04 +01:00
chme eefacbbf55 [web-src] Play single podcast track and do not add whole podcast as
context
2018-12-23 09:31:04 +01:00
chme 4fdc2e26d4 [web-src] Remove debug logging to js console 2018-12-23 09:31:04 +01:00
chme e874276bdb [web-src] Refactor spotify modal dialogs into a separate components 2018-12-23 09:31:04 +01:00
chme 6e61c703be [web-src] Cleanup ListItemQueue and ModalDialogAlbum 2018-12-23 09:31:04 +01:00
chme 8f391ecd6a [web-src] Make ListItemXXX functional components 2018-12-23 09:31:04 +01:00
chme 219d9df024 [web-src] Add composer to track and queue item dialogs 2018-12-23 09:31:04 +01:00
chme 0358094908 [web-src] Add margin left/right to modal dialogs 2018-12-23 09:31:04 +01:00
chme 55e75dc850 [web-src] Show queue item details in now playing page
Make the cover artwork clickable to open the details dialog modal.
2018-12-23 09:31:04 +01:00
chme 382036687a [web-src] Refactor ListItemAlbum to be a functional component
This should improve performance of long album lists.
2018-12-23 09:31:04 +01:00
chme 6cd714a4f8 [web-src] Add cover artwork to album dialog 2018-12-23 09:31:04 +01:00
chme 5e85e0b024 [web-src] Refactor details modal dialogs into separate components
This will allow to open a dialog outside of the ListItem component. Also
reduces the size of the generated DOM tree by only including one dialog
per page (per object type) and not for each list item.
2018-12-23 09:31:04 +01:00
chme 0cc4699128 [web-src] Update package-lock.json 2018-12-23 09:31:04 +01:00
chme 73d9bf3ff1 [web-src] Fix styling of genre tracks/albums links 2018-12-23 09:31:04 +01:00
whatdoineed2do/Ray df2b422a0c [web-src] handle 'context_uri' that have no direct db entries, such as smartpl generated 'all tracks' or 'all genre tracks' 2018-12-23 09:31:04 +01:00
whatdoineed2do/Ray 69c73e249d [web-src] dedicated 'genre tracks' page 2018-12-23 09:31:04 +01:00