ejurgensen
3a35a51cb9
[db] Align naming of struct query_params pointers et al
2017-04-16 23:54:07 +02:00
chme
626c77046c
[spotify] Fix empty spotify playlists
2017-04-10 09:33:22 +02:00
chme
cc29c617b0
[filescanner] Switch argument order (input first)
2017-03-19 18:30:46 +01:00
chme
888710612c
[library] Add missing attribute mapping from mfi to queue item
2017-03-19 18:30:46 +01:00
chme
e31fea6c44
[filescanner] Remove unused include and make privat function static
2017-03-19 18:30:46 +01:00
chme
59ade61d7b
[library] Rename constants
2017-03-19 18:30:46 +01:00
chme
f4aade7f3a
[filescanner] Fix and refactor scanning of playlists
2017-03-19 18:30:46 +01:00
chme
f5c65d1eef
[db] Do not notify clients in 'db_queue_add_by_query' if no items were
...
added
2017-03-19 18:30:46 +01:00
chme
a65737b4e7
[filescanner] Add scan-metadata function for non library items
...
For now only support scanning metadata for internet radio streams
2017-03-19 18:30:46 +01:00
chme
8381b7489e
[mpd] Try to read metadata and add to queue if path is not in the
...
library
2017-03-19 18:30:46 +01:00
chme
e6f49b721f
[library] New functions to support scan metadata for arbitrary path and
...
adding a mfi as a queue item
2017-03-19 18:30:46 +01:00
chme
cc899651c7
[db] New function to add a media file info as a new queue item
2017-03-19 18:30:46 +01:00
chme
bdd08f516f
[library] Rename 'library_process_media' to 'library_add_media'
2017-03-19 18:30:46 +01:00
chme
dadba23efc
Refactor library scan of media files
...
Remove the data_kind specific parts out of the general library functions
and into their (library) source specific functions.
2017-03-19 18:30:46 +01:00
ejurgensen
fce68ebd1a
[raop] Add option to exclude particular devices from speaker list
2017-03-15 23:24:24 +01:00
ejurgensen
ef13abe2cf
[artwork] Fix for issue #345 and #367 : Broken PNG rescaling
2017-03-15 22:12:37 +01:00
ejurgensen
efd6805f9e
Merge pull request #365 from chme/spotifybaseplaylist
...
Avoid adding spotify playlist folder
2017-03-11 19:30:31 +01:00
ejurgensen
5d74c98431
[input] Pass read errors to the player through the input buffer
2017-03-11 19:23:49 +01:00
chme
6c97448e2f
[spotify] Remove log messages after token request
...
The whole response is already written to the log in debug mode
2017-03-11 09:55:32 +01:00
chme
247abec88f
[spotify] Only create spotify playlist folder after successful login
...
Before creating the folder there should be either a valid api token or a
valid libspotify session.
2017-03-11 09:44:54 +01:00
ejurgensen
6c94cdd635
[httpd_daap] Honour sort param "artist" for album groups (fixes issue #358 )
2017-03-05 09:45:34 +01:00
ejurgensen
9f2f5566d2
[commands] Protect against race condition by moving event_add() inside lock
...
- otherwise commands_base_destroy() could free cmdbase before event_add()
2017-03-04 17:26:45 +01:00
chme
00e5e098d4
[spotify] Purge spotify songs from db before scanning after oauth ( #361 )
2017-03-04 17:24:42 +01:00
chme
1dde41fb87
[mpd] Fix wrong db playime info in 'stats' command ( #360 )
2017-03-04 17:23:52 +01:00
chme
1dfca1ec22
[dacp] Always start playing from the beginning of the shuffle queue
2017-03-04 08:57:58 +01:00
chme
03e9182423
[spotify] Fix usage of "artist_override" config value
2017-02-26 11:04:04 +01:00
chme
9c90cbcd12
[db] Fix return value of db_queue_add_by_query
2017-02-26 11:04:04 +01:00
chme
82e216c931
Add missing FALLTHROUGH comments to switch-case statements
...
This allows to suppress code analysis warnings in IDEs for missing break
statements.
2017-02-26 11:04:04 +01:00
chme
50b28bde96
[filescanner] Remove unused scan_metadata_icy function declaration
2017-02-26 11:04:04 +01:00
chme
78975b1aa3
[filescanner_ffmpeg] Add doc to scan_metadata_ffmpeg
2017-02-26 11:04:04 +01:00
chme
e4f25f9418
[filescanner_ffmpeg] Refactor: consolidate special handling for
...
http-streams
2017-02-26 11:04:04 +01:00
sshambar
c54c909ae4
Added support for libav/ffmpeg dual installs ( #346 )
...
* [config] Added support for libav/ffmpeg dual installs
Reordered CPPFLAGS/LIBS so that library flags (includes etc) appear
ahead of prefix/global directives and the correct headers/libraries
are checked (if symbols are defined in alternative libraries).
Updated libav checks to use header declaration checks
rather than link checks (so differences between
libav/ffmpeg can be correctly found), and updated code references
to use new defines. Added support the alternate pkg-config
package names for libav. Updated ffmpeg vs libav check
to check MICRO version number (>=100 for ffmpeg). Simplified
resulting configure script by using a function to merge
CPPFLAGS variables.
* [config] Use FORKED_OPTS prefix for libevent_pthreads option
* [config] Add --with-libav option to select libav even if ffmpeg present
2017-02-19 15:21:00 +01:00
ejurgensen
ff49e176f2
[spotify] Fixup header path to json.h
2017-02-16 21:51:46 +01:00
Scott Shambarger
c7855e7c55
[config] Min automake 1.11, support silent rules on automake < 1.13
2017-02-16 10:44:00 -08:00
ejurgensen
26c22144fc
[-] Misc housekeeping (minor memleaks, invalid free's)
2017-02-12 01:19:56 +01:00
chme
3896f61d06
[dacp] Keep the now playing item in the queue when calling ( #353 )
...
playqueueedit_clear
2017-02-11 09:28:35 +01:00
ejurgensen
98348b8fe9
[pipe] Removing CHECK_NULL with malloc, scan-build not happy about it
2017-02-11 00:28:29 +01:00
ejurgensen
f0c9843194
[pipe] Fix exit problem due to misuse of COMMAND_PENDING
2017-02-10 23:56:58 +01:00
ejurgensen
d8255e1d08
[pipe] Fix minor memleak
2017-02-10 23:03:38 +01:00
ejurgensen
13e6889990
[cast] Use friendly device name from mdns announcement
2017-02-10 19:27:52 +01:00
ejurgensen
d2fe608c72
[http_streaming] Reduce log severity if write returns EAGAIN, it
...
just means that pipe was temporarily full (ref issue #329 )
2017-02-08 22:47:49 +01:00
ejurgensen
245ce1d4e4
[player] Allow starting playback with no outputs
2017-02-08 22:31:47 +01:00
ejurgensen
1f15fb1993
[pipe] Refactor pipe input, hopefully into a more thread safe version
2017-02-08 22:29:37 +01:00
ejurgensen
e6793b4779
[player] Add player_playback_start_byid() function, will be needed for pipe input
2017-02-08 22:29:37 +01:00
ejurgensen
f27fb53caf
[input] Rename player source ->xcode to ->input_ctx, because any input may use it, not just transcode
2017-02-08 22:29:37 +01:00
ejurgensen
a183463bb2
[spotify] Try to avoid image load callbacks from Spotify after timeouts,
...
since the artwork struct may have become invalid
2017-02-07 23:23:39 +01:00
ejurgensen
3a7ed96895
[misc] Adding missing header for non-Posix timer platforms
2017-02-07 23:22:38 +01:00
chme
1f4e474671
[spotify] Retrieve playlist tracks based on user country ( #352 )
...
This avoids adding unplayable items to the library and due to the active
track relinking should make additional tracks playable by linking to a
playable version of the track.
2017-02-05 13:56:12 +01:00
ejurgensen
18fe8fe0ef
[pipe] Temporary "fix" for threading issues
2017-02-05 00:11:21 +01:00
chme
9680fa093a
[db] Fix mpd command 'delete' removing to many items
...
Previously db_queue_delete_bypos iterated over the items and called
delete for each item. The delete also adjusted the pos/shuffle_pos
values for the remaining items.
A delete of pos = 0 resulted therefor in:
- fetch item with pos = 0
- delete item at pos
- update remaining items to pos = pos - 1
- fetch item with pos = 0 (returns the new item at pos 0)
- delete item at pos
- ...
2017-02-04 08:37:58 +01:00
chme
d293356d8b
[db] Extract function to fix queue position values
2017-02-04 08:37:58 +01:00
chme
1c8263224e
[db] Fix incorrect query for db_queue_delete_bypos
2017-02-04 08:37:58 +01:00
chme
bd4e379f15
[dacp] Fix requests for cue_play with command = "play"
2017-02-04 08:35:02 +01:00
chme
4e4e91d4a2
[player] Add log messages in case playback_start_item returns -1
2017-02-04 08:35:02 +01:00
ejurgensen
9d8dbaffe1
[db] Fix typo ( closes #347 )
2017-02-01 18:56:34 +01:00
ejurgensen
bbb3322ddc
[spotify] Flush audio buffer on playback stop - and since we are
...
flushing from another thread we use evbuffer_enable_locking() which
in turn adds a requirement for libevent_pthreads to be present
2017-01-30 22:50:02 +01:00
ejurgensen
f7018dc659
[player] Skip/remove unplayable tracks in queue instead of aborting
2017-01-29 22:07:51 +01:00
ejurgensen
b44ae55c1d
Some scan-build fixing up
2017-01-28 22:37:56 +01:00
ejurgensen
12567d8e93
[pipe] Make Shairport metadata parser work with incomplete reads from pipe
2017-01-28 22:20:35 +01:00
ejurgensen
41c5ef1474
[compat] Suppress warnings about unused functions
2017-01-28 22:20:35 +01:00
ejurgensen
b6f969d96e
[pipe/mxml] Add compability with older versions of mxml
2017-01-28 22:20:35 +01:00
ejurgensen
97aa544945
[library] Move library update trigger to new library module
2017-01-28 22:20:35 +01:00
ejurgensen
dc84294348
[input/pipe] Parse basic Shairport metadata using mxml
2017-01-28 22:19:51 +01:00
ejurgensen
ea874154b2
[input/file_http] Use swap_pointers to transfer ownership of metadata
2017-01-27 22:36:00 +01:00
ejurgensen
67d0504700
[input] Let input_metadata_free zero metadata like the other free functions
2017-01-27 22:36:00 +01:00
ejurgensen
c975cf4474
[misc] Set output of safe_xxx to 0 also in error cases (for safety)
2017-01-27 22:36:00 +01:00
ejurgensen
ab06a9fd7d
[player] Update info about player.c
2017-01-27 22:36:00 +01:00
ejurgensen
ae1f2d75d3
[pipe] Prepare reading and parsing Shairport metadata pipes
2017-01-27 22:36:00 +01:00
ejurgensen
8b5cac0538
[file/http/input] Implement metadata handling through input interface
2017-01-27 22:36:00 +01:00
ejurgensen
0b9b008a1a
[player] Try to consolidate metadata handling + use input interface
2017-01-27 22:36:00 +01:00
ejurgensen
7b6a7b65b3
[input] Add interface for getting metadata from input modules
2017-01-27 22:36:00 +01:00
ejurgensen
2696b27972
[artwork] Let the artwork handler for streams use queue->artwork_url instead of calling the player, which was messy
2017-01-27 22:36:00 +01:00
ejurgensen
4d4a4ffd70
[db] Remove special icy update function, add db_queue_update_item()
...
- we will use the latter generalised form from now on, even though it is perhaps a tad slower
2017-01-27 22:36:00 +01:00
ejurgensen
e92152cadb
[db] Upgrade db to 19.03: Add artwork_url column to queue table
2017-01-27 22:36:00 +01:00
ejurgensen
40d50d693b
[misc] Add small function to swap pointers
2017-01-27 22:36:00 +01:00
ejurgensen
ee32b9cb70
[pipe] Reset pipes when required + prepare for metadata pipes
2017-01-27 22:36:00 +01:00
ejurgensen
90f37b75ce
[player] Fix it so source_read() returns silence and not an error until source_check stops playback
2017-01-27 22:36:00 +01:00
ejurgensen
9fb62441d2
[pipe] Use worker thread instead of filescanner for watching pipes
2017-01-27 22:36:00 +01:00
ejurgensen
061beaf272
[worker] Make sure worker accepts NULL-arguments
2017-01-27 22:35:16 +01:00
ejurgensen
7f7207bb87
[pipe] Pipe input interface (wip)
2017-01-27 22:35:15 +01:00
ejurgensen
acc67338a1
[input] Add a buffer full callback for the player
2017-01-27 22:35:15 +01:00
ejurgensen
aa8edeead4
[player] Add suspend/resume on underrun + misc fixing up
2017-01-27 22:35:15 +01:00
ejurgensen
18918ce489
[db] Rename db_file_save_seek -> db_file_seek_update
2017-01-27 22:35:15 +01:00
ejurgensen
6af8fa07b4
[spotify] Use timespec_reltoabs instead of internal mk_reltime
2017-01-27 22:35:15 +01:00
ejurgensen
6db4e40119
[misc] Add function to add a relative time to current clock
2017-01-27 22:34:15 +01:00
ejurgensen
9aede45a12
[pipe] Add a pipe input with autostart capabilities
2017-01-27 22:30:47 +01:00
ejurgensen
938e197fa4
[player] Refactor read/write
...
- remove read skip which is obsolete when input has own thread and cannot block
- simplify code
- fix while loop that could loop infinitely
2017-01-27 22:29:08 +01:00
ejurgensen
1258481202
[listener] Rename LISTENER_PLAYLIST to LISTENER_QUEUE
2017-01-27 22:25:32 +01:00
ejurgensen
60daf03f66
[cache/scan] Let notifications from db.c about library updates go through
...
filescanner/listener instead of directly to the cache
2017-01-27 22:25:32 +01:00
ejurgensen
79639c73ed
[input] Add Spotify input module
2017-01-27 22:08:56 +01:00
ejurgensen
c92ebf9dfb
[player] Fix problem where player_playback_cb triggers after playback stop
2017-01-27 22:01:24 +01:00
ejurgensen
3e24f857fa
[input] Add input interface to player - WIP
2017-01-27 22:01:24 +01:00
ejurgensen
c50b038397
[misc] Move STOB and BTOS macros to misc.h
2017-01-27 22:01:24 +01:00
ejurgensen
171a75375b
[outputs] Fix for (unlikely) situation where all outputs have no init()
2017-01-27 22:01:24 +01:00
ejurgensen
41aa530fd3
[http] Add support for http post in the libevent client (required for scrobbling)
2017-01-25 22:52:11 +01:00
ejurgensen
db4068f046
[artwork] Hardcode destination pixel format for png rescaling since
...
avcode_find_best_pix_fmt_of_list() does not live up to its name
(fixes issue #345 )
2017-01-25 21:02:41 +01:00
ejurgensen
084de7811e
[raop] Fix missing uint64 cast, which since commit fdd85cc
was giving too short song lengths
2017-01-23 23:41:10 +01:00
sshambar
bc4b046897
[logger] Add missing include ( #342 )
2017-01-23 08:41:23 +01:00
ejurgensen
36d9051a91
[misc] Fixup coding style
2017-01-22 23:47:45 +01:00
ejurgensen
5dc8eea4c2
[main] Re-include pthread.h that was removed in pr #334 , needs to be
...
here because it is used by the gcrypt macro
2017-01-22 23:35:38 +01:00
Scott Shambarger
836320518b
Merge branch 'master' into fixosx
2017-01-21 13:04:38 -05:00
Scott Shambarger
a837389ac5
Minor change: remove unused include, init variable.
2017-01-21 08:51:51 -08:00
Scott Shambarger
6f7355dfce
Merge branch 'fixthreads' into fixosx
2017-01-21 10:38:47 -05:00
sshambar
b128271656
Merge branch 'master' into fixthreads
2017-01-21 10:27:26 -05:00
Scott Shambarger
8e3797ec43
[threads] Update mutex/cond functions to use new CHECK_ERR macros
...
Added various macros to check return values and log any errors and abort
if the call fails.
Updated logging to handle early errors before logging initialized.
2017-01-21 07:11:20 -08:00
chme
e092a9ff3e
[spotify] Respect settings for 'artist_override' and 'album_override' ( #340 )
...
when scanning spotify through the web api
The goal is to reduce the artist/album cluttering that happens because
of the users spotify playlists. If 'artist_override' is true, all tracks
not in a saved album are treated as part of a compilation giving them
the configured album-artist (e. g. "Various artists"). I
'album_override' is true, tracks not in a saved album will use the
playlistname as albumname.
2017-01-21 10:17:33 +01:00
chme
6163269832
[dacp/db] Fix issue found with scan-build
...
- Result of operation is garbage or undefined in dacp_reply_cue_play
- Uninitialized argument value in dacp_reply_playqueuecontents
- Uninitialized argument value in queue_fetch_byposrelativetoitem
2017-01-20 19:00:11 +01:00
chme
4e869f6fda
[dacp] Fix indentation
2017-01-20 19:00:11 +01:00
chme
dea5c50b67
[player] Fix memleaks found with scan-build
2017-01-20 19:00:11 +01:00
chme
825236c8bb
[spotify_webapi] Fix memory leaks
2017-01-20 19:00:11 +01:00
chme
a4180a5902
[spotify] Increase log level for skipping playlists during scan
2017-01-18 20:32:02 +01:00
chme
e8d6b17784
fix indentation
2017-01-18 20:28:56 +01:00
chme
77086c9b82
[library] Check for init/deinit functions in library source
2017-01-18 20:12:14 +01:00
Scott Shambarger
9c50429abc
[dnssd] Reworked resolve to use timeout, fixed network order on port
2017-01-17 01:36:03 -05:00
Scott Shambarger
879d9a80aa
[osx] Remove incorrect calculations for timer_getoverrun
2017-01-14 23:29:07 -05:00
chme
00efed7988
[filescanner] Fix scanning of fifos
2017-01-14 13:59:14 +01:00
Scott Shambarger
bb68d59a6e
[osx] Added missing timer/clock functions, support Bonjour mDNS on OSX
...
Added configure checks needed to detect missing functions on OSX
Added compat clock functions using clock_get_time on OSX
Added compat timer functions using clock_gettime and setitimer on OSX
Added byteswap functions on OSX
2017-01-14 00:56:43 -05:00
Scott Shambarger
b54d94fda6
[threads] Added missing initializers, check errors on mutex/cond calls
2017-01-13 17:32:59 -05:00
chme
a15923c377
[spotify] Fix for expired spotify access token and some cleanup
2017-01-13 19:20:24 +01:00
chme
528614909c
[filescanner/library] Move filescanner to subfolder
2017-01-13 19:02:47 +01:00
chme
9c9c583b81
[library] move declaration scan_metadata_ffmpeg back to filescanner.h
2017-01-13 18:56:37 +01:00
chme
2cfb4b6a28
[spotify] Simplify parsing of artist/album-artist name
...
forked-daapd does not support a 1:n relationship between tracks and
artists. Just take the first artist the spotify web api returns
(libspotify does also return only one artist, so this should not
introduce a regression).
2017-01-13 18:56:37 +01:00
chme
03c5ecd690
[spotify] Split into smaller db transactions (do not keep an open
...
transaction between requests)
2017-01-13 18:56:37 +01:00
chme
f632789f8b
[spotify] Set missing values for year, artwork, type, codectype,
...
description and improve logging
2017-01-13 18:56:37 +01:00
chme
ab3582dd69
[spotify_webapi] Cleanup: remove unused functions
2017-01-13 18:56:37 +01:00
chme
66bbcf0576
[spotify] Ignore playlist updates with missing uri
2017-01-13 18:56:37 +01:00
chme
8ee3ef5b15
[filescanner] Trigger library-scan on .init-rescan / .full-rescan
2017-01-13 18:56:37 +01:00
chme
510d38c059
[library/filescanner/spotify] Rework full-rescan logic
2017-01-13 18:56:37 +01:00
chme
4e60626749
[db] Add missing purge of directories in db_purge_all
2017-01-13 18:56:37 +01:00
chme
65ce902e3c
[db_init] Set admint.value to VARCHAR(255)
...
Only a cosmetic change to avoid future confusion. sqlite3 ignores the
number of chars given to VARCHAR (see https://sqlite.org/faq.html#q9 ),
a db upgrade is therefor not necessary.
2017-01-13 18:56:37 +01:00
chme
99945fa576
[spotify] Rescan of single playlists if update trigger received from
...
libspotify (Readds "spotify:savedtracks" playlist to avoid deletion of
saved tracks)
2017-01-13 18:56:37 +01:00
chme
adac1d3b5f
[spotify] Trigger scan after retrieving a valid access token from the
...
webinterface
Library now offers the function "library_exec_async". This allows
library sources to offer functions that will be executed in
the library thread. Useful to allow partial scans of only one source.
2017-01-13 18:56:37 +01:00
chme
ae1a45bacc
[library/spotify] Implement rescan in spotify.c and purge old files
...
after rescan
2017-01-13 18:56:37 +01:00
chme
0bea83cafa
[spotify] Scan saved albums and playlist using the spotify web api
2017-01-13 18:56:37 +01:00
chme
1672b67040
[library/filescanner] Move purging of old content to library; Remove
...
ping for spotify files in filescanner (not needed, either they get
updated through the init-scan or purged)
2017-01-13 18:56:37 +01:00
chme
263edaa8b3
[misc] Helper function safe_strdup (NULL safe strdup)
2017-01-13 18:56:37 +01:00
chme
4bd42dda41
[spotify] Remove loading saved tracks from the webapi (will be readded
...
later)
2017-01-13 18:56:37 +01:00
chme
1a85257fb3
[spotify] Extract function for preparing directories
2017-01-13 18:56:37 +01:00
chme
5efadb6fc2
[spotify_webapi] Add separate file for accessing the web api
2017-01-13 18:56:37 +01:00
chme
56ce3f9cba
[library/filescanner/spotify] Add library source abstraction and new
...
"library" thread
- Implement filescanner as a library_source
- Add library source implementation for spotify
- Move process_media_info to library with small adjustments:
- Remove dependency to F_SCAN_TYPE defines
- Pass data_kind as parameter
- Pass media_kind and compilation as parameter if a source forces a
specific value for these
- Move declaration of scan_ffmpeg to library; add
library_add_playlist_info to library
2017-01-13 18:56:37 +01:00
ejurgensen
785ff21045
Merge pull request #328 from sshambar/fixconfig
...
Updated configure/makefiles related to Issue #327
2017-01-12 22:41:47 +01:00
ejurgensen
45d513d206
[rtsp] Do not fail if ContentLength has chars after num value (e.g. whitespace)
2017-01-10 21:09:08 +01:00
ejurgensen
966a81cc77
[db] Fixup - itemcount not required for finding a playlist
2017-01-06 20:03:02 +01:00
ejurgensen
213b58c012
[db] Forgot to add Q_FIND_PL as a playlist query
2017-01-06 19:58:38 +01:00
ejurgensen
27946a472b
[artwork] Add handler for playlist local artwork (for http items)
...
- ref https://www.raspberrypi.org/forums/viewtopic.php?p=1090166#p1090166
2017-01-06 19:35:05 +01:00
Scott Shambarger
ce4ef0aa23
[config] Many updates to configuration and feature checks
...
- Added custom checks for libraries and pkgconfig modules that test library
presence with additional checks for use of headers and functions with
given options. Also support correct additional feature library checks
using provided flags.
- Added custom enable/disable feature macros to simplify their use.
- Use custom CFLAGS and LIBS variables for Makefiles to simplify maintenance.
- Update many feature checks from platform to function.
- Streamline many function checks.
- Correctly check gnutls, gcrypt and gpg-error libraries.
- Fix chromecast and spotify config and compile on FreeBSD
- Added inotify, signalfd and kqueue, and byte swap checks.
- Many clarifications of error messages.
- Correct json-c checks to properly use supplied CFLAGS.
- Correct many quoting inconsistencies
- Use __DATE__ in place of BUILDDATE
- Use full path for gperf and antlr3
- Remove unnecessary CFLAGS
- Added tests for pthread_setname_np parameters
- Added tests for clock_gettime and timer_settime
- Added tests for time.h
- Test if pthread, dl and rt libs are required/available.
- Updated checks for libunistring
2017-01-06 00:44:18 -08:00
ejurgensen
b7c4256df4
[db] Refactor db_build_query_* to reduce redundancy
2017-01-04 22:29:47 +01:00
Scott Shambarger
8ead7ea3b8
[config] configure.ac checks required features, updated porting
...
Added a real config.rpath
Fixed build date calc for BSD
Require some needed headers at configure time
Correctly check libav functions using pkg-config flags
Made checks for some Linux features available on other ports
Fixed porting issue with antlr dep files
Added default HOST_NAME_MAX if not defined
Added missing libav header
2016-12-29 16:14:22 -08:00
ejurgensen
ce998fb38a
[rtsp] Additional logging
2016-12-29 21:30:47 +01:00
ejurgensen
80fe738583
[mdns] Fix for missing HOST_NAME_MAX on FreeBSD
2016-12-29 19:30:04 +01:00
ejurgensen
82470b5168
[filescanner] Ignore spotify/lastfm/remote during startup, they can give DB deadlocks
...
- see https://www.raspberrypi.org/forums/viewtopic.php?p=1087137#p1087137
2016-12-28 22:53:00 +01:00
Scott Shambarger
8b4b55b748
[config] Make gperf/antlr maintainer tools, support distcheck
...
Updated configure to allow gperf/antlr to be missing if products are
in distribution (allows option of building w/o those tools)
Removed circular dependency of antlr products on clean
Added missing ffmpeg-compat.h header (correct dist)
Include gperf/antlr products in dist
gperf/antlr products removed with maintainer-clean
Support vpath builds, distcheck passes
Added support for non-verbose builds
2016-12-27 15:32:08 -08:00
Scott Shambarger
b38bccc458
[gperf] Renamed products to .h so they aren't built if listed in SOURCES
2016-12-27 15:08:08 -08:00
Scott Shambarger
d7f8dea0ec
[config] Modernize autotools
...
Updated AC_OUTPUT to use AC_CONFIG_FILES
Use PACKAGE in install path
Remove automake -Wno-portability, not needed with foreign option
Fixed typo in evrtsp.h path
Autotools commands moved to build-aux directory
Allow CFLAGS and package CFLAGS/LIBS to be updated at build time
2016-12-27 14:51:37 -08:00
ejurgensen
e4387fe33e
Merge pull request #326 from chme/tx
...
[filescanner] Fix nested transaction
2016-12-27 22:15:10 +01:00
chme
201f019655
[filescanner] Purge old db entries outside of the transaction in bulk
...
scan
2016-12-27 21:32:42 +01:00
chme
be6b4376e8
[db] wrap db_purge_cruft in a transaction
2016-12-27 21:31:01 +01:00
ejurgensen
3bb6220ce9
[transcode] Make sure transcode_seek() only returns negative on error
...
- newer ffmpeg seems to give timestamps that give negative got_pts when seeking to 0
2016-12-27 00:02:02 +01:00
chme
cf7787dbc2
[filescanner] Fix nested transaction
2016-12-24 07:44:03 +01:00
ejurgensen
1748430c48
[db] Review of cache regeneration triggers
2016-12-18 21:18:15 +01:00
ejurgensen
40d34ed4ad
Merge pull request #324 from chme/db3
...
Remove rebuilding the persistent-ids on startup
2016-12-18 11:20:10 +01:00
chme
7856498951
[db] Remove unused functions db_files_update_songartistid,
...
db_files_update_songalbumid
2016-12-17 16:17:23 +01:00
chme
f5fe1e665a
[filescanner] Remove rebuilding of persistent ids (artist, album)
...
The hash is not portable, therefor this removes the ability to build the
database on a different machine than the one running forked-daapd.
It also removes the clearing of the groups table and replaces it with a
cleanup call (removes unreferenced entries from the groups table).
2016-12-17 07:38:51 +01:00
chme
3d3c27190b
[db] Add function to cleanup the 'groups' table (artists and albums)
...
Allows removing of item no longer referenced from the files table
2016-12-17 07:38:47 +01:00
chme
af774ef175
[filescanner] Remove unnecessary query for file id in process_media
...
The previous query for db_file_stamp_bypath already retrieves the file
id for the given path.
2016-12-17 07:11:51 +01:00
chme
351725c8b2
[db] initialize id parameter with 0
2016-12-17 07:11:43 +01:00
ejurgensen
1ab9151489
[http] Repair broken libevent 2.0 compability
2016-12-11 20:20:27 +01:00
ejurgensen
2ee4988a50
[httpd] Add missing include for event2/keyvalq_struct.h ( closes #321 )
2016-12-11 19:10:53 +01:00
chme
de61a3a851
[db] Remove db_admin_update and rename db_admin_add
2016-12-10 06:15:43 +01:00
chme
e29539fa68
[db] add primary key to admin table
2016-12-10 06:15:43 +01:00
ejurgensen
ad4cdc2216
[httpd] Silence compiler warning about unused var
2016-12-09 21:49:22 +01:00
ejurgensen
d7b63ebc6a
Merge pull request #319 from chme/dbgetint
...
[db] Rename db_get_count
2016-12-09 19:29:01 +01:00
chme
c4732b835f
[db] Remove unused function db_file_id_byfilebase
2016-12-09 16:20:50 +01:00
chme
588fe120b7
[db] Rename db_get_count to db_get_one_int
2016-12-09 16:20:03 +01:00
chme
1221244eed
[mpd] Implement consume command and return consume mode in
...
status command
2016-12-09 14:48:24 +01:00
chme
c3e8568782
[player] Add 'consume' mode
...
If consume mode is active the current song is removed from the queue at
eof or if the next song action is triggered.
2016-12-09 14:48:24 +01:00
chme
94f450769d
[db] Fix upgrade to v19.01
2016-12-09 07:08:14 +01:00
ejurgensen
9ba512a340
Merge pull request #309 from chme/persistentqueue3
...
Persistent queue
2016-12-08 21:06:17 +01:00
chme
2d1e5f6d60
[player/db] Remove function "db_file_get_seekpos"
2016-12-04 17:48:35 +01:00
chme
d339f5bcd2
[db] fixup
2016-12-04 11:34:54 +01:00
chme
edc609b531
[db] Queue fetch functions should end the query after start and fetch
2016-12-04 09:32:50 +01:00
chme
09c2e7ca76
[db] Add missing free of query_param.filter
2016-12-04 09:16:49 +01:00
chme
fb55960b0a
[db] Remove db_queue_enum struct and use generic query_params
2016-12-04 08:18:33 +01:00
chme
b9117f9abd
[db] Remove unnecessary setting of query param fields to 0
2016-12-04 07:42:38 +01:00
chme
d431ace5c4
[db] Use a minor version update for the new queue table (v19.01 instead
...
of v20.00)
2016-12-04 07:28:06 +01:00
chme
fdd85ccf66
[raop/dmap] Build raop metadata from queue item
2016-12-03 20:40:54 +01:00
chme
ea56ee91bd
[spotify] Add missing virtual path to "Saved Tracks" playlist
2016-12-03 14:53:47 +01:00
chme
6c6f02fdfa
Rename "queue_item.item_id" to "queue_item.id"
2016-12-03 11:14:03 +01:00
chme
eb896a1085
[db] Fix loglevel
2016-12-03 11:12:19 +01:00
chme
0251f3c514
[db] Rename "queue_add_mediafileinfo" to "queue_add_file"
2016-12-03 11:12:19 +01:00
chme
b5bf1928ff
[db] Rename "plversion" to "queue_version", add missing init query for
...
queue_version
2016-12-03 11:12:19 +01:00
chme
6c7df96371
[db] Remove forward declaration of queue_fetch_byitemid
2016-12-03 11:12:19 +01:00
chme
cef4fedfb4
Remove unused structs and player arguments
2016-12-03 11:12:19 +01:00
chme
6c66d39d91
[player] Fix segfault if player reaches end of queue, fix repeat single
2016-12-03 11:12:19 +01:00
chme
a0590ce548
[db/player] Icy metadata update
2016-12-03 11:12:19 +01:00
chme
e08b4f3b01
[rng] Cleanup: remove unused function 'shuffle_ptr'
2016-12-03 11:12:19 +01:00
chme
a023595b6f
[queue] Remove queue.c/.h
2016-12-03 11:12:19 +01:00
chme
c504abe451
Use queue db table instead of in memory queue struct
2016-12-03 11:11:33 +01:00
chme
8ebf2f9307
[db] Add functions to access/modify the queue table
2016-12-03 10:58:26 +01:00
chme
0beb68e1f1
[db] Upgrade db to v20.00
...
- New table 'queue' for persisting the queue/current playlist
- New entry 'plversion' in admin table for queue version
2016-12-03 10:58:26 +01:00
chme
faaeb92ce5
[player] Reading media_file_info is not necessary in source_pause
2016-12-03 10:58:26 +01:00
chme
2d27636644
[rng] Add function to shuffle an int array
2016-12-03 10:57:56 +01:00
ejurgensen
3921cf5732
Merge branch 'spwebapi2'
2016-11-27 22:54:06 +01:00
ejurgensen
7239d39c5f
[httpd] UI apology
2016-11-27 22:52:59 +01:00
ejurgensen
51e6008ef6
Merge pull request #305 from chme/streamsetup
...
Reduce dependency to media file in stream setup methods
2016-11-26 17:43:24 +01:00
ejurgensen
633d297936
Merge pull request #314 from chme/pipeoutputsync
...
Sync output to fifo
2016-11-20 08:45:15 +01:00
chme
27b9ee16c9
[fifo] Try to keep in sync with airplay speakers
2016-11-20 06:55:55 +01:00
chme
fcbd88c56c
[fifo] Fix: flush must return the number of pending events
2016-11-20 06:55:55 +01:00
chme
5bc52d7bc7
[rsp] Fix nullpointer dereference found by scan-build
2016-11-20 06:38:53 +01:00
chme
a95da7966b
Fixes issues found by scan-build in mpd.c and queue.c
2016-11-20 06:27:45 +01:00
ejurgensen
94a55d9fc9
[scan] readdir_r deprecated, use readdir instead
2016-11-19 23:50:14 +01:00
ejurgensen
bdd6bab982
[-] Lots of housekeeping thanks to scan-build and input from @acmay
2016-11-19 23:08:50 +01:00
ejurgensen
8525c278ec
[http] Fix crash with URLs without any "." chars in the path (issue #311 , @credit acmay)
2016-11-17 19:24:55 +01:00
ejurgensen
bb2a73ddab
[spotify] Keep saved tracks through restarts + misc fixing up
2016-11-13 22:13:35 +01:00
chme
2c801ca6db
[db] Small code improvements (avoid hard coded values in query strings)
2016-11-12 12:35:22 +01:00
chme
6690ba32eb
[player/transcode/httpd] Pass path, data_kind and song_length to
...
transcode_decode_setup/transcode_setup
2016-11-12 09:11:40 +01:00
chme
477088a36c
[player/pipe] Only pass path to pipe_setup
2016-11-12 09:11:40 +01:00
chme
2db3318ce7
[player/spotify] Only pass spotify-path to spotify_playback_setup
2016-11-12 09:11:40 +01:00
ejurgensen
3040346a65
[spotify] Use Spotify OAuth and web api to get saved tracks/albums
2016-11-05 13:44:23 +01:00
ejurgensen
8c0db10e67
[http] Move Curl https client from lastfm to http so it is available for other modules
2016-11-05 13:43:35 +01:00
ejurgensen
575b6e13a8
[httpd] Hooks for OAuth user interface and callbacks
2016-11-05 13:38:15 +01:00
ejurgensen
807951976c
[configure/mdns] Register CNAME forked-daapd.local + generalize CURL detection in configure.ac
2016-11-05 13:33:30 +01:00
ejurgensen
90ecc61ed7
[mdns] CNAME record so we have fixed uri for OAuth redirects
...
- also refactor mdns_avahi
2016-11-05 13:31:13 +01:00
ejurgensen
33c22a59b9
Merge pull request #304 from chme/cleanup
...
Minor cleanup of mdns and dacp
2016-11-04 19:17:17 +01:00
chme
eddab1f1c0
[dacp] Use correct log domain
2016-11-04 19:10:07 +01:00
chme
b75c07625c
[mdns] Use %zu for size_t in printf (removes warning about wrong
...
argument type)
2016-11-04 19:09:59 +01:00
chme
f326cae142
[db] Remove duplication of db schema version
2016-11-04 14:31:15 +01:00
chme
f7aa3c225b
[db] Move initialization of new db into its own file (db_init.c)
2016-11-04 14:31:15 +01:00
ejurgensen
91c3eb622c
[mdns] Put the record browser back
...
We need to browse through all records so that we can filter out link-local that Avahi sometimes gives us
2016-10-31 22:04:27 +01:00
ejurgensen
087bc942ec
Merge pull request #299 from chme/pipeoutput
...
Fifo output
2016-10-31 19:07:37 +01:00
chme
4f2d994151
[outputs] Remove unused old alsa output
2016-10-31 18:47:45 +01:00
chme
65732ccaf6
[outputs] New output type 'fifo'
2016-10-31 18:47:45 +01:00
ejurgensen
be6580d23e
[mdns] Also ignore ipv4 link-local announcements
2016-10-30 20:04:08 +01:00
chme
60f9c779b6
[mpd] Add new command 'outputvolume' to set volume for a specific output
2016-10-25 22:40:48 +02:00
chme
bdb2c74934
[player/dacp/mpd] Pass absolute volume to speaker enumerate callback and
...
add absolute volume to mpd 'outputs' command
2016-10-25 22:40:48 +02:00
ejurgensen
a549f81861
[filescanner] Make for filetypes_ignore work for known file types as well
2016-10-25 09:08:56 +02:00
ejurgensen
bc1fb4b385
[mdns] Ignore ipv6 link-local mdns announcements
2016-10-23 23:27:34 +02:00
chme
39314c1560
[mpd] Do not treat playback_start return value > 0 as an error
2016-10-23 08:25:19 +02:00
chme
3981c67e3a
[player] Do not execute the bottom half if playback_start is called
...
while player is already playing (results in s segfault after adding new
items through dacp clients)
2016-10-23 08:25:19 +02:00
chme
16149d5c61
[command] Only execute "bottom half" function if main command function
...
returns 0
2016-10-23 08:25:19 +02:00
ejurgensen
c0d07ae93b
[httpd] Allow HEAD for evhttp requests just to be safe
2016-10-21 23:06:00 +02:00
ejurgensen
2ce1c8d28f
[httpd] Enable OPTIONS for evhttp (if CORS headers are enabled)
2016-10-19 21:22:14 +02:00
ejurgensen
54a09fce63
[httpd] Add requirement for Access-Control-Request-Method for preflight CORS
2016-10-19 17:29:22 +02:00
ejurgensen
57945a592c
[httpd] Reply to CORS preflight requests
2016-10-18 23:04:51 +02:00
ejurgensen
c44f4310b7
[httpd] Replace evhttp_send_error with the httpd_send_error wrapper
2016-10-18 22:45:22 +02:00
ejurgensen
fe7373e442
[httpd] Implement httpd_send_error, a modified evhttp_send_error, which
...
can include CORS headers (credit @bjoernricks and libevent)
2016-10-17 23:08:02 +02:00
ejurgensen
40c49f1fde
[httpd] Use httpd_send_reply() wrapper in httpd_*, dmap_common and mpd
2016-10-17 22:25:31 +02:00
ejurgensen
e1cfccbce7
[httpd] Exchange evhttp_send_reply with httpd_send_reply in httpd.c
2016-10-17 22:14:10 +02:00
ejurgensen
0b29b4368d
[httpd] Enable CORS headers by default (Access-Control-Allow-Origin: *)
2016-10-17 22:03:32 +02:00
ejurgensen
7dc2a46261
[cache] Save daap replies gzipped - should improve performance
2016-10-17 19:40:25 +02:00
ejurgensen
249d923af2
[httpd] Allow caller of httpd_send_reply to avoid gzipping
2016-10-17 14:18:13 +02:00
ejurgensen
d8696e72ea
[httpd] Don't gzip small messages
2016-10-17 14:09:16 +02:00
ejurgensen
f7185db035
[httpd] Reduce memcpy when gzipping a response
2016-10-16 23:36:27 +02:00
ejurgensen
0c6af89807
[raop] Just remove ipv6 address if we can't connect with the one avahi gave us
2016-10-15 19:14:01 +02:00
ejurgensen
03513c56a8
[mdns] Simplify avahi implementation, e.g. drop record browser
...
- record browser and link level filtering doesn't seem required (I may regret this...)
- fix cast.c so it does not browse for ipv6 when disabled
2016-10-15 19:12:56 +02:00
ejurgensen
1e3df5ba52
[-] Add forgotten type in err2str()
2016-10-11 21:32:16 +02:00
ejurgensen
94e133e8dc
[raop] Temporary fix for issue #293
2016-10-09 00:42:48 +02:00
ejurgensen
9a997551a2
[pulseaudio] Remove PA_STREAM_ADJUST_LATENCY - seems we then get a better match with the requested value
2016-10-08 21:40:49 +02:00
ejurgensen
9bd2ef4f42
[pulseaudio] Misc improvements
...
- Set volume on stream startup
- Change cleanup on server exit
- README update
2016-10-07 22:35:04 +02:00
ejurgensen
8b842b18d5
[pulseaudio] Add start/stop, config latency, avoid underruns when pausing and misc
2016-10-06 23:35:09 +02:00
ejurgensen
a0dfb5c93e
[pulseaudio] Under/overrun detection + request 2 sec latency
2016-10-05 21:13:26 +02:00
ejurgensen
bc8c77c0d1
[pulseaudio] Go full async + some cleaning up
2016-10-05 08:53:14 +02:00
ejurgensen
a03bc2a4e2
[commands] A bit of cleanup
2016-10-02 22:05:53 +02:00
ejurgensen
8f6033e787
[pulseaudio] More logging
2016-10-02 18:48:00 +02:00
ejurgensen
07efdfe24e
[pulseaudio] Drop autostarting again, won't work when running as non-root
2016-09-28 21:17:34 +02:00
ejurgensen
44ad4a8848
Merge branch 'autopulse'
2016-09-26 21:32:27 +02:00
ejurgensen
ac9900ff1a
[pulseaudio] Modification of f202b5d
: Now always try to start Pulseaudio
2016-09-26 20:48:00 +02:00
ejurgensen
89e3f05585
Merge pull request #288 from pcoultha/mixer_device
...
[ALSA] Add mixer_device configuration file option for ALSA
2016-09-26 00:11:28 +02:00
Pat Coulthard
ae79800493
Add mixer_device configuration file option for ALSA
...
Support a separate mixer_device configuration file option for
advanced ALSA configurations. Previously, ALSA local output
happened to work becasue "default" is valid as both a PCM and a
mixer. Now you can separately specify the device name for PCM
output and mixer operations.
In my setup, I am using the following setup:
card = "default:CARD=NVidia"
mixer = "Front"
mixer_device = "hw:CARD=NVidia"
2016-09-25 15:52:15 -05:00
ejurgensen
b3a1e744d6
[player] Fix possible segfault on http timeouts
...
Cause: 1) av_read_frame blocks and times out, 2) cur_streaming gets set to NULL, 3) playback timer callback where cur_streaming gets deref
2016-09-25 22:19:59 +02:00
ejurgensen
e5d328061b
[logger] Be better at logging ffmpeg/libav error messages
2016-09-25 22:01:07 +02:00
ejurgensen
f202b5d2e9
[pulseaudio] Try to spawn Pulseaudio if it doesn't by itself
...
Requiring the user to set up Pulseaudio in system mode is not optimal. This
would, however, be required especially on headless systems. This is the
sledgehammer alternative to starting Pulseaudio.
2016-09-20 22:17:29 +02:00
ejurgensen
9355015b3c
[main] Use waitpid instead of obsolete wait3
2016-09-20 22:17:04 +02:00
ejurgensen
ac290b8b65
[player] Config option to disable speaker autoselection ( closes #282 )
2016-09-10 23:26:06 +02:00
ejurgensen
3d6d4e8521
[config] Print build info in the log
2016-09-07 22:18:29 +02:00
ejurgensen
d66a130064
[lastfm] Also scrobble after regular daap streaming
...
Ref https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813940
2016-09-02 21:52:45 +02:00
ejurgensen
7f0d34d4e1
[pulseaudio] Remove temp log messages
2016-08-29 21:56:05 +02:00
ejurgensen
7af9c25964
Merge branch 'pulseaudio1'
2016-08-28 22:37:41 +02:00
ejurgensen
1d862dd701
[pulseaudio] Extra state check when changing volume
2016-08-28 22:33:58 +02:00
ejurgensen
4318aa19b5
[commands] Update comment
2016-08-25 23:07:43 +02:00
ejurgensen
fa6c6a1832
[pulseaudio] Kill sessions if context becomes invalid
2016-08-25 22:31:25 +02:00
ejurgensen
84a5772439
[Pulseaudio] Implement flush, avoid adding known sinks and misc fixing up
2016-08-24 23:06:25 +02:00
ejurgensen
9b243f855a
[pulseaudio] Support for setting volume
2016-08-24 21:23:33 +02:00
ejurgensen
998ae31a56
[cast] Fixup switched format strings
2016-08-22 21:22:47 +02:00
ejurgensen
202d9b951e
[cast] Use proper print formats for size_t
2016-08-22 21:18:24 +02:00
ejurgensen
da8fa6a686
[cast] Just run empty callback on last request to time out. Running more is unsafe since the first is likely to free the session.
2016-08-13 23:33:06 +02:00
ejurgensen
61457f2a09
[cast] Change how we read from TLS and fix bug due to masking of negative enum, ref issue #270 and #275
...
(should have been two commits...)
2016-08-13 23:31:41 +02:00
ejurgensen
8a9d8c31da
[alsa] Remove risky negative enum (risky when AND'ing with ALSA_F_STARTED)
2016-08-13 17:08:14 +02:00
ejurgensen
d3db30e46d
[smartpl] Add smart playlist support for file modification time
2016-08-13 16:53:09 +02:00
chme
1238fe124a
[commands] Stop command execution, if command function returns an unkown
...
command state
2016-08-06 06:50:27 +02:00
chme
da83af04e2
[player] Fix return value in repeat_set if repeat mode did not change
2016-08-06 06:36:42 +02:00
chme
30d43bef4f
[player] Fix return value in volume_setrel_speaker if device is not
...
selected
2016-08-06 06:34:34 +02:00
chme
2ae94e8f82
[player] Fix return value in playback_prev_bh if source_open failed
2016-08-06 06:31:09 +02:00
chme
cd9a3bae07
[player] Fix return value in playback_start_item if source_open failed
2016-08-06 06:29:55 +02:00
chme
21d2c95eeb
[spotify] Fix return of playback_eot if spotify returns an error
2016-08-06 06:26:38 +02:00
chme
388c5f4311
[filescanner] Fix building directory structure with trailing '/' (second
...
attempt)
2016-08-01 21:27:05 +02:00
ejurgensen
cbc3323111
[cast] Try to fix issue #270 by making a GET_STATUS if the normal reply to a LAUNCH does not arrive
2016-08-01 09:05:09 +02:00
ejurgensen
306dd47f1e
[cast] Fix for issue #275 where gnutls returns the 4 byte prefix of
...
a Chromecast response together with the response message itself
2016-08-01 00:12:08 +02:00
ejurgensen
187ed6c1f7
[cast] Log raw replies when in DEBUG_CONNECTION mode
2016-07-31 23:36:27 +02:00
ejurgensen
1e02dc51fd
[mpd] Modify output enum logging to show shortid as well
2016-07-31 23:28:03 +02:00
ejurgensen
561228d9f7
[misc] Add missing const qualifier
2016-07-31 23:27:57 +02:00
chme
cebf07b2f8
[filescanner] Fix building directory structure with trailing '/'
...
Library directories with a trailing '/' (like '/srv/music/') lead to an
unbrowsable directory structure. The trailing '/' resulted in an update
to the library directory in the directories table with a parent_id
pointing to itself.
2016-07-31 07:41:11 +02:00
chme
595f7c6091
[mpd] Fix copy/paste error in log message
2016-07-30 08:33:23 +02:00
chme
e6b53cb88e
[mpd] Fix mpd command 'playid' if player is already playing
...
While playing issueing command 'playid' starts playback of the song with
the given item-id (if this song is already playing, it starts from the
beginning).
2016-07-30 08:33:22 +02:00
chme
9af09c204d
[mpd] Fix mpd command 'play' if player is already playing
...
While playing issueing command 'play' with a songposition -1 does noting
in mpd, with songposition > 0 it starts playback of the song at this
position (if this song is already playing, it starts from the
beginning).
2016-07-30 08:31:54 +02:00
ejurgensen
db6823d676
[pulseaudio] Support for adding/removing sinks
2016-07-30 00:05:32 +02:00
ejurgensen
ed03c90916
[mpd] Fix typos
2016-07-29 19:26:46 +02:00
ejurgensen
4399466f21
[pulseaudio] Friendly naming of sinks in speaker list
2016-07-21 23:15:06 +02:00
ejurgensen
eb40415348
[pulseaudio] A bit of renaming
2016-07-21 22:31:39 +02:00
ejurgensen
5b67f84855
[pulseaudio] First draft
2016-07-21 22:13:32 +02:00
Björn Ricks
382459ce9b
Allow anonymous access to /content-codes url
...
The content-codes url provides a mapping of dmap content codes to names, it's
types and sizes. It doesn't contain any private information and therefore should
be available to anonymous users too.
2016-07-13 19:52:58 +02:00
ejurgensen
d3078c6534
[remote] Increase pairing success log level
2016-07-10 20:38:03 +02:00
ejurgensen
a99d1b2038
[db] Add song_length to group info ( fixes #265 )
2016-06-11 23:10:13 +02:00
ejurgensen
547783d008
Merge pull request #268 from chme/threadexit
...
Refactor thread exit handling
2016-06-11 22:57:09 +02:00
chme
c0c6cca79f
[commands] Add some code comments
2016-06-11 10:56:27 +02:00
chme
32ac6c2ea9
[commands] Rename commands_cmdloop_break to commands_base_destroy and
...
free commands_base after breaking the libevent loop
2016-06-11 10:56:27 +02:00
chme
a9a656042b
[player] Cleanup: player clock is the only sync-source available
2016-06-11 10:37:09 +02:00
chme
5258ee712c
[commands] Added functionality to break the event loop of a command base
2016-06-11 09:52:31 +02:00
ejurgensen
3527113a9b
[filescanner] Option to import iTunes smart playlists
2016-06-04 23:30:01 +02:00
ejurgensen
777c0c8d27
Merge pull request #264 from bjoernricks/allow-origin
...
Allow to add Access-Control-Allow-Origin header to responses
2016-06-04 20:19:25 +02:00
Björn Ricks
6b6a1e65e1
Allow to add Access-Control-Allow-Origin header to responses
...
Add a new general config setting allow_origin that is included as
Access-Control-Allow-Origin header in http responses. This allows to make http
request against forked-daapd from browsers with enabled CORS
(https://www.w3.org/TR/cors/ ) via JavaScript XMLHttpRequest.
Per default the setting is not defined and no Access-Control-Allow-Origin header
is included in the response.
2016-06-02 13:32:41 +02:00
chme
610ae6a048
[commands] Move function documentation to their implementation
...
Also adds some aditional code documentation and an attempt at making
command_cb easier to understand
2016-05-21 07:57:44 +02:00
chme
5dc1cba5c8
On deinit free event base before freeing command base and pipes
2016-05-21 06:48:02 +02:00
chme
6112c38220
[commands] do not cast return of calloc and allocate struct command on
...
stack if executed in sync
2016-05-21 05:59:45 +02:00
chme
3c9a7d9119
[player] Use generic commands for inter thread communication
2016-05-15 08:42:15 +02:00
chme
85d57394e5
[cache] Use generic inter thread commands util
2016-05-15 08:42:15 +02:00
chme
dd192bd99c
[spotify] Use generic commands util
2016-05-15 08:42:15 +02:00
chme
32944d7273
[worker] Use generic inter thread commands util
2016-05-15 08:42:15 +02:00
chme
3823900394
[filescanner] Use generic inter thread commands util
2016-05-15 08:42:15 +02:00
chme
4aacf487e8
[mpd] Use generic inter thread commands util
2016-05-15 08:42:15 +02:00
chme
9856536fd7
[commands] Add generic functionality for inter-thread communication
...
using libevent and pipes
2016-05-15 08:42:15 +02:00
ejurgensen
1cc4c034d0
[filescanner] Add support for Monkey's audio
2016-05-06 00:30:58 +02:00
ejurgensen
1fbb4b0d59
[transcode] Fix problem for file types where ffmpeg decode returns 0
...
It seems ffmpeg/libav reads a file type like Monkey's audio in large
chunks, so that each packet must be passed to the decoder multiple
times. The decoder will return 0 until the packet is completed. This
change makes forked-daapd able to deal with a return value of 0.
2016-05-06 00:23:07 +02:00
ejurgensen
9a56044c77
[misc] Explicitly check for pthread_setname_np/pthread_set_name_np
...
Seems there is no pthread_setname_np in OpenWrt
2016-05-05 19:39:15 +02:00
ejurgensen
95d0c25be3
[outputs] Forgot an include
2016-05-05 18:49:27 +02:00
ejurgensen
7c68eab11e
[streaming] Log error message from write()
2016-05-05 18:48:47 +02:00
ejurgensen
1f10c6a928
[player] Always reselect output devices when they return online
...
Consider this use case:
1. Playback stops, device switched off
2. Device switched back on, playback started by user
Before this commit, the device would be unselected when it came back on.
I don't think that is desirable, so with this commit the selection will
stay (except if the device comes back on during playback).
2016-04-30 23:55:45 +02:00
ejurgensen
960f89fcbd
[player] Remove unused var
2016-04-14 10:04:21 +02:00
ejurgensen
ad01d65047
[alsa] Let the user configure an offset to sync audio if required
2016-04-14 09:48:48 +02:00
ejurgensen
e23fed4ac4
[alsa] Avoid call to snd_pcm_prepare if already in the right state
2016-04-14 09:48:48 +02:00
ejurgensen
19181007f4
[alsa] Increase max latency variance
...
Latency on the RPi varies quite a bit
2016-04-14 09:48:48 +02:00
ejurgensen
632bfd9a33
[alsa] Add low-tech sync with the player (and AirPlay)
2016-04-14 09:48:48 +02:00
ejurgensen
eca41e306e
[alsa] Try to measure latency
2016-04-14 09:48:48 +02:00
ejurgensen
857055a18d
[player] Insert duplicate packets slowly on timer overrun
2016-04-14 09:48:48 +02:00
ejurgensen
084a86597b
[laudio] Remove OSS4 support and move dummy output to outputs interface
2016-04-14 09:48:48 +02:00
ejurgensen
1a5e1da9ae
[alsa] Fixup of volume return values
2016-04-14 09:48:47 +02:00
ejurgensen
acc1ff4a47
[player] Sort devices and autoselect based on priority
2016-04-14 09:48:47 +02:00
ejurgensen
c5bb83480d
[alsa] Add rewritten ALSA to generic outputs interface
2016-04-14 09:48:47 +02:00
ejurgensen
f1fb86e7e1
[raop] Stop writing when a teardown has been requested
2016-04-14 09:48:47 +02:00
ejurgensen
617303d545
[player] Purge laudio from player.c
2016-04-14 09:48:47 +02:00
ejurgensen
36755031cb
[outputs] Make a wrapper for mp3 streaming so it can be included in
...
the generic outputs interface and so special handling in player.c can
be removed
2016-04-14 09:48:47 +02:00
ejurgensen
a07c24d625
[player] Fix possible segfault after playback stop on FreeBSD/machines with lo-res timers
2016-04-14 08:55:59 +02:00
ejurgensen
bf27a879df
[filescanner] Use libinotify for FreeBSD (should fix issue #245 )
...
Filescanner was broken in FreeBSD. Besides fixing this, using
libinotify instead of kqueue directly should make the code easier
to maintain, since it will be less divergent.
This commit includes these changes:
- Add libinotify to FreeBSD install scripts
- Fix reading multiple events from inotify fd (possible bug in Linux too)
- Deferred scanning since FreeBSD doesn't have IN_CLOSE_WRITE
- Configure search for inotify library
- Removal of kqueue stuff
2016-04-12 22:11:56 +02:00
ejurgensen
3be8afac7b
[daap] Fix problem where playlists in Remote are not in correct order
...
Apparantly having "LIMIT -1 OFFSET 0" makes (certain versions?) of
sqlite3 unable to do the "ORDER BY". Might be a bug in sqlite. This
is only a partial fix, which will work for queries that don't actually
use an index. Those few that do may still be broken.
2016-04-10 00:11:33 +02:00
chme
7713096d84
[mpd] Return playlists if 'lsinfo' is called without any parameters
2016-04-05 21:04:44 +02:00
ejurgensen
36a9ed8fe8
[raop] Omit timing request source address check
...
Creates a problem with ipv6 where the timer request source address may
differ from the address that mdns gave us when we created the seesion.
See https://github.com/mikebrady/shairport-sync/issues/254
2016-03-29 19:36:40 +02:00
ejurgensen
a22aff5d1f
[filescanner] Switch misplaced arguments in process_directories (FreeBSD)
...
Should help with issue #239 . Also change process_directory so it uses
same argument order as process_directories.
2016-03-27 20:35:23 +02:00
ejurgensen
42e68311eb
[transcode] Increase read timeout slightly
2016-03-25 20:56:08 +01:00
ejurgensen
dbf9a208b8
[dacp] Don't return hard error if queue item goes missing
...
Remote doesn't seem to like the 500 Internal error we were sending
if queue item went missing, e.g. during pause.
2016-03-23 20:38:19 +01:00
ejurgensen
c4713d8b39
[httpd] Improve log message
2016-03-21 19:26:54 +01:00
ejurgensen
7d1d52e8f0
[transcode] Fix missing channel number for newer ffmpeg ( closes #241 )
2016-03-20 19:22:16 +01:00
chme
1fb1fc7d2d
[player] Add config option to disable clearing the queue after playback
...
stops (default is clearing the queue) and if true do not clear the
queue.
This option is necessary because some dacp clients rely on the queue
being empty if player is stopped. Retune for example does not always
show the queue contents if player state is stopped.
2016-03-20 07:45:21 +01:00
chme
e3750957f5
[player] Allow removing by position (dacp-requests) if player is stopped
2016-03-19 09:40:36 +01:00
chme
ed2fe682fe
[player] Allow moving by position (dacp-requests) if player is stopped
2016-03-19 09:40:36 +01:00
chme
cb919515e4
[dacp] Start playback from selected song in the playqueue if player is
...
stopped
2016-03-19 09:40:36 +01:00
chme
d000ea571b
[dacp] Return the playqueue even if player is stopped
2016-03-19 09:40:36 +01:00
chme
07947a526d
[mpd] Do not start playback automatically after adding songs to the
...
queue
2016-03-19 09:40:36 +01:00
chme
d35894ac15
[mpd] Return correct item-id for command 'addid' and return correct
...
number of items in the queue if player is stopped for command 'status'
2016-03-19 09:40:36 +01:00
ejurgensen
b454a2fd60
[general] Put back support for platforms without pipe2(), see issue #239
2016-03-17 22:20:16 +01:00
ejurgensen
ec43195633
[alsa] Really don't query snd_pcm_delay() during an underrun
2016-03-17 13:56:15 +01:00
ejurgensen
e65361ba17
[alsa] Don't query snd_pcm_delay() during an underrun
2016-03-17 12:54:17 +01:00
ejurgensen
d2d52c7d68
[alsa] Do not kill threshold, it gives underruns after snd_pcm_prepare()
2016-03-17 12:46:51 +01:00
ejurgensen
8b2c68af0e
[alsa] Try to fix issue where devices with small buffers would
...
overrun, rendering the device unusable because snd_pcm_writei()
starts blocking. This is just a poor temporary fix until we
either start using SND_PCM_NONBLOCK or put alsa in it's own thread
or implement Pulseaudio...
2016-03-16 22:54:27 +01:00
ejurgensen
5f3578ec65
[alsa] Some extra logging for debugging
2016-03-15 22:59:12 +01:00
ejurgensen
abce1d0eeb
Merge pull request #237 from chme/threadnames
...
Set thread names
2016-03-12 17:18:34 +01:00
chme
98d6db002f
Set thread names to make it easier to identify threads during debugging
2016-03-12 14:01:08 +01:00
chme
9a5b67031e
[player] Remove unnecessary check for plid != 0 and set plid always to 0
...
if queue changed
2016-03-12 14:01:08 +01:00
ejurgensen
fba6293be6
Merge pull request #238 from chme/spotifyvirtualpath
...
[spotify] Add the owner of playlist to the virtual path
2016-03-12 13:23:47 +01:00
chme
3e8221e377
[spotify] Add the owner of playlist to the virtual path of a spotify
...
playlist to avoid duplicate virtual paths
2016-03-12 13:10:08 +01:00
chme
39c60cb211
[mpd] Fix indentation
2016-03-12 08:27:59 +01:00
chme
cd5aee1595
[mpd] Allways return an error message if mpd command exits with error,
...
otherwise the command will lead to a segfault (e. g. calling lsinfo with
a non existent directory path segfaults)
2016-03-12 08:27:59 +01:00
ejurgensen
598ae1bd71
[chromecast] json-c < 0.11 compability
2016-03-06 21:33:49 +01:00
ejurgensen
bd61399e49
[player] Only catch up by lowering sample rate if data_kind is http or pipe
2016-03-06 10:55:10 +01:00
ejurgensen
4d1a45e5d8
Merge pull request #235 from chme/queuemovefix
...
[queue] Fix moving a song to the last position in the queue failed
2016-03-05 15:04:36 +01:00
chme
1ec7ad683e
[queue] Fix moving a song to the last position in the queue failed
2016-03-05 14:26:17 +01:00
chme
167d5117be
[spotify] Remove options to exclude starred songs from the artist/album
...
override
2016-03-05 12:55:34 +01:00
ejurgensen
7aba0bf332
[filescanner] Support TDR tag (date released) and parse years better
2016-03-05 00:14:45 +01:00
ejurgensen
1188a79e57
[filescanner] Also set year if date tag present
2016-03-04 22:37:56 +01:00
ejurgensen
cbaea95ff4
[filescanner] Support for songdatereleased and songhasbeenplayed
2016-03-04 22:37:56 +01:00
ejurgensen
7135406531
[filescanner] Log message if user attempts to use LastFM/Spotify on unsupported build
2016-03-03 22:20:13 +01:00
ejurgensen
3000341acd
[player] Different timer catch up for files + remove timer abort
...
Timer abort should no longer apply since we may catch up for more
than a second. Introduce separate catch up strategies for files and
streams, since for files we can read at our own pace.
2016-02-28 22:28:37 +01:00
ejurgensen
220494e8b1
Merge pull request #232 from chme/mpdmove
...
[mpd] Implement mpd command 'move'
2016-02-28 20:28:24 +01:00
chme
494a936caa
[mpd] Implement mpd command 'move'
2016-02-21 19:01:52 +01:00
chme
c1dcc0a937
[db] Make loading of playlistitem count optional
2016-02-21 18:05:11 +01:00
ejurgensen
29dbc6bd9d
[chromecast] Don't set cert file, doesn't seem very portable
2016-02-12 22:04:07 +01:00
ejurgensen
a824f73779
[player] Remove some debug log messages
2016-02-12 22:00:10 +01:00
ejurgensen
00d4148a90
[raop] Move RAOP specific states away from the generic output state enum
2016-02-12 21:59:26 +01:00
ejurgensen
48592406ed
[chromecast] Fix probe segfault
2016-02-12 21:26:06 +01:00
ejurgensen
565d29529a
[chromecast] Remove log message
2016-02-11 22:54:47 +01:00
ejurgensen
441f36a58b
[chromecast] Fix segfault when cleaning up after missing reply
2016-02-11 20:04:30 +01:00
ejurgensen
bd75281340
[player] Save speaker name and rename raop_ to output_
2016-02-11 20:04:30 +01:00
ejurgensen
93ea34796a
[chromecast] Fix typo
2016-02-11 20:04:30 +01:00
ejurgensen
23db4c3f4e
[chromecast] Support protobuf v1
2016-02-11 20:04:30 +01:00
ejurgensen
dcdefea721
[chromecast] Don't let a reply timeout crash the callbacks
2016-02-11 20:04:30 +01:00
ejurgensen
f4719e8681
[chromecast] Add a reply timeout so we don't freeze if a response goes missing
2016-02-11 20:04:30 +01:00
ejurgensen
483a428bae
[chromecast] Try to improve session handling + actually remove device on mdns cb
2016-02-11 20:04:29 +01:00
ejurgensen
e4d209f8a0
[chromecast] Support for most basic functionality
2016-02-11 20:04:29 +01:00
ejurgensen
7d6c670fee
[chromecast] Fix host address, some more commands, add flush timer
2016-02-11 20:04:29 +01:00
ejurgensen
5049426573
[raop] Protect against possible invalid reads in for loops
2016-02-11 20:04:29 +01:00
ejurgensen
ebf2d7722e
[chromecast] Fixup cb register error + use actual hostname
2016-02-11 20:04:29 +01:00
ejurgensen
5e239cfbb2
[chromecast] Volume support and fix double free
2016-02-11 20:04:29 +01:00
ejurgensen
153ed98dba
[chromecast] Begin adding actual Chromecast support (basic playback)
2016-02-11 20:04:29 +01:00
ejurgensen
cd841ad7b5
[outputs] Reorganise new generic output interface
2016-02-11 20:04:29 +01:00
ejurgensen
233fa24ffd
[raop] Fix possibly old "read after free" bug
2016-02-11 20:04:29 +01:00
ejurgensen
ffe8653d9e
[chromecast] Remove RAOP specifics from player.c, add generic output interface
2016-02-11 20:04:29 +01:00
ejurgensen
4c887ba7bb
[chromecast] First building blocks for supporting ChromeCast
2016-02-11 20:04:29 +01:00
ejurgensen
62eb1a067d
[player] Rename ticks to overrun and safeguard against decreasing from 0
2016-02-11 20:02:17 +01:00
ejurgensen
5f5a138c77
[player] Fix for player getting ahead of network streams (issue #218 )
...
Issue caused stuttering after a few hours. This fix will check if
the player is getting behind the playback timer. Apparently, we
sometimes get samples at a rate slightly below 44100 from network
streams, and then we end up consuming too quickly. This introduces
a way of reducing consumption if that happens.
2016-02-11 08:29:29 +01:00
ejurgensen
73cddbb9de
[transcode] Fix type of stream_index so the tests make sense
2016-02-06 19:51:13 +01:00
ejurgensen
3aab9b2622
Merge pull request #227 from chme/plchangesposid
...
[mpd] Implement command 'plchangesposid'
2016-02-06 13:10:20 +01:00
ejurgensen
e9986e9c9f
[filescanner] Remove var not used in FreeBSD section
2016-02-06 11:08:45 +01:00
chme
73d5832d98
[filescanner] Fix use of uninitialized variable
2016-02-06 10:30:10 +01:00
chme
4878dce0b0
[mpd] Implement command 'plchangesposid'
2016-02-06 08:39:01 +01:00
chme
b84df9c5c3
[filescanner] Fix compile error on freebsd
2016-02-06 07:44:19 +01:00
chme
491bf54fdb
[directories/spotify] Init db with disabled spotify-root-directory and
...
enable only on successful login to spotify
2016-01-31 08:14:03 +01:00
chme
cd5462e241
[filescanner] attempt at fixing compile errors on freebsd after the
...
introduction of the directories table
2016-01-31 08:14:03 +01:00
chme
8600c21424
[db-upgrade] add column date_released to files table, add column name to
...
speakers table
2016-01-31 08:14:03 +01:00
chme
dcfec5c1d4
[filescanner] Do not process parent directories on inotify callback
2016-01-29 19:29:02 +01:00
chme
9197f0f64b
[spotify] fixup - added error handling
2016-01-24 18:59:05 +01:00
chme
1a6565e512
[directories] Initialize root directories on db init
2016-01-24 18:51:22 +01:00
chme
7678f98879
fixup - use sizeof instead of PATH_MAX
2016-01-24 18:51:22 +01:00
chme
c23cbde6ac
fixup - remove unused enum, remove unused local variable, remove
...
duplicate error log for failure in create_virtual_path, remove
unnecessary empty lines
2016-01-24 18:51:22 +01:00
chme
171e30aead
[mpd] use qualifier in select queries, return error message if an error
...
occurs (otherwise this results in a segfault)
2016-01-24 18:51:22 +01:00
chme
2611d06ab7
[mpd] add support for commands 'listall' and 'listallinfo'
2016-01-24 18:51:22 +01:00
chme
7703a997c4
[db/filescanner/spotify] Replace filelist-view with separate
...
directories-table
to increase the performance of the mpd command 'lsinfo'
2016-01-24 18:51:22 +01:00
chme
3740486348
[db] Move database upgrade logic to separate file
2016-01-24 18:51:22 +01:00
chme
1d69a3de90
[mpd] Add fallback to IPv4 if IPv6 failed
2016-01-24 18:51:22 +01:00
chme
9a1c8409cf
[mpd] optimize query selecting files for virtual_path to use the index
2016-01-24 18:51:21 +01:00
ejurgensen
5f2fe87351
[spotify] Move purge so Spotify files get cleared even on empty .spotify ( closes #219 )
2016-01-17 15:29:31 +01:00
chme
532e9c3a32
[spotify/artwork] Remove spotify songs after playlist update and delete
...
cached artwork for removed spotify songs
2016-01-16 17:02:57 +01:00
ejurgensen
0f58495e0d
[cache] Prevent log errors if cache disabled
2016-01-09 01:26:59 +01:00
ejurgensen
d356a0ae5c
[spotify] Split artwork_get so we don't wait for artwork callback in the Spotify thread (which might be playing)
2016-01-09 00:36:30 +01:00
ejurgensen
22a1e16c12
[artwork] Move timebase back, it must be set for the AVCodecContext for libav (and older versions of ffmpeg?)
2016-01-07 23:42:27 +01:00
ejurgensen
3a31074c07
[spotify] Increase artwork timeout slightly
2016-01-07 23:11:19 +01:00
ejurgensen
1b24a86169
[artwork] Tidy up artwork.c and handle remaining ffmpeg deprecated warning
2016-01-07 22:48:04 +01:00
ejurgensen
89e3864035
[spotify] Wait for Spotify artwork now that the worker gets artwork async for the player thread
2016-01-07 22:25:25 +01:00
ejurgensen
d56576094a
[artwork] Do like libav says: "Using AVStream.codec.time_base as a timebase hint to the muxer is deprecated. Set AVStream.time_base instead."
2016-01-06 23:02:43 +01:00
ejurgensen
1f1d79025d
[artwork] Keep a raw Spotify source image in case rescaling is not required
2016-01-06 22:39:32 +01:00
ejurgensen
0d55e055c0
[ffmpeg] Update most deprecated functions
2016-01-05 23:22:01 +01:00
ejurgensen
7caf8cc66a
[artwork] Add ability to rescale Spotify (should improve caching so we don't save too large images)
2016-01-05 21:44:44 +01:00
ejurgensen
9a0a390a73
[artwork] Get rid of legacy libav/ffmpeg support in artwork.c
2016-01-03 12:24:21 +01:00
ejurgensen
c3d9f65f8b
[artwork] Adjust existing code to new structure
2016-01-03 12:24:20 +01:00
ejurgensen
238ee3c122
[artwork] Refactor artwork to make it easier to add new backends (WIP)
2016-01-03 12:24:20 +01:00
ejurgensen
599fb20e0b
[cache] Fix return values in cache_artwork_get_impl
2016-01-03 12:24:20 +01:00
ejurgensen
6cabbc4ab7
[httpd] Add fallback to IPv4 if v6 fails
2015-12-21 21:52:21 +01:00
chme
32e1923b39
[mpd] make global event_base static
2015-12-19 09:09:50 +01:00
chme
3b7e1b2737
[mpd] Add missing close for command pipe on deinit
2015-12-19 08:46:38 +01:00
ejurgensen
e8ea00896d
[listener] Fix #205 where listener_remove could break the linked list and orphan some cb's
2015-12-16 23:16:58 +01:00
ejurgensen
6e58af75cf
[http_daapd] Add option to hide albums/artists with just one track
2015-12-12 23:28:48 +01:00
chme
40da57346f
[mpd] fix duplicate return of 'nextsong', 'nextsongid' and return
...
item-id as 'nextsongid'
2015-12-12 09:26:55 +01:00
chme
6d1d2a485c
[mpd] fix seek command
...
Compare the position of the song to be seeked with the position of the
current playing one
2015-12-12 09:26:44 +01:00
ejurgensen
93a6765c8c
[transcode] Fix freeze problem where av_read_frame would block on broken connections
2015-12-09 20:00:09 +01:00
ejurgensen
100cecce3f
[mpd] Add missing db_query_end (was causing database locks)
2015-12-06 20:22:12 +01:00
ejurgensen
d43b306212
[config] Change ipv6 default to enabled
2015-12-03 22:08:55 +01:00
ejurgensen
7a4ce2f68d
[http] Title and artist were swapped when reading ICY packet metadata
2015-11-29 00:55:30 +01:00
chme
b2d2e9286f
[mpd] implement range support for 'delete' command
2015-11-22 12:06:01 +01:00
chme
6d720dec94
[queue] Ignore moving an item to its current position (would results in
...
an invalid queue)
2015-11-22 07:08:59 +01:00
chme
8fc8d08b42
[player] Add missing notification of playlist changes after removing an
...
item from the playlist
2015-11-21 14:23:06 +01:00
chme
10fceb6d3f
[mpd] Fix segfault executing "decoders" command
2015-11-21 14:23:06 +01:00
ejurgensen
9cc4927d50
Merge pull request #198 from chme/mpdzeroconf
...
[mpd] Announce mpd support with avahi/zeroconf
2015-11-07 08:11:32 +01:00
chme
2195db0800
[mpd] Announce mpd support with avahi/zeroconf
2015-11-06 19:50:18 +01:00
chme
461a956288
[mpd] Return the correct values for number of songs, artists, albums and
...
song length sum in the "stats" command (wrong values are still reported
for uptime, db_update and playtime)
2015-11-06 19:11:00 +01:00
chme
0e0fbd006f
[queue] fix segfault if query for queue-items returned an empty result
...
set
This happen for example if a wrong path is passed in "mpc add
[virtual_path]"
2015-11-01 12:47:04 +01:00
chme
350944cddd
[mpd] fix seekid command
...
Seeking with the seekid command for the currently playing item got
broken after introducing the item-id (comparison of item-id passed from
client to db-id)
2015-11-01 12:06:18 +01:00
chme
7b5c80acf4
[queue] If the playing item is not in the queue anymore, the next item
...
should be the first item in the queue
This solves the problem that after clearing the queue and adding new
items while playing, aborts playback when skipped to the next item.
2015-11-01 11:59:39 +01:00
chme
abc689a7e1
[mpd] fix sort in queue after adding songs with findadd and searchadd
...
commands
Always add songs sorted by artist, album, disc, track. Adding by title
is almost never the expected order of songs.
2015-11-01 11:46:54 +01:00
chme
d0232a2315
[mpd] Return playlists if lsinfo is called with an empty path (same
...
handling as if the path is the root directory "/")
2015-10-31 12:53:52 +01:00
ejurgensen
316af87189
Merge pull request #193 from chme/mpd
...
[mpd] Add support for moveid and close command
2015-10-31 11:31:27 +01:00
ejurgensen
6ba350e406
Merge pull request #192 from chme/history
...
[dacp] Fix playing from history for Remote
2015-10-31 11:31:10 +01:00
chme
ba63157429
[mpd] Add 'close' command (ignore the command and does not send a
...
response)
2015-10-31 07:56:52 +01:00
chme
f9c6aa6c48
[mpd] Implement command moveid (movings items in the queue by item-id)
2015-10-31 07:56:51 +01:00
chme
1c409846d5
[player/queue] Add player commands to move queue-items by item-id
2015-10-31 07:56:50 +01:00
chme
c2ba2f6779
[dacp] Fix playing from history for Remote
2015-10-31 06:18:05 +01:00
ejurgensen
7894a4d85f
[transcode] Don't push NULL frames to filtergraph when flushing, can lead to segfault
2015-10-25 19:59:06 +01:00
chme
94895b8eed
[player] if source is not pausable (http-streams or pipe) abort playback
...
on pause command
This restores the behaviour before the queue/player-refactoring.
2015-10-25 09:00:47 +01:00
ejurgensen
43893dff48
Merge pull request #189 from chme/mpd
...
Fix item-id in mpd commands "playlistid", "playlistinfo", "plchanges"
2015-10-24 09:05:58 +02:00
chme
51eb423065
[mpd] Fix item-id in playlist items
2015-10-24 06:06:24 +02:00
ejurgensen
3e80e5c517
[transcode] Don't pass error to player on eof + some comments and cleaning
2015-10-22 22:09:19 +02:00
ejurgensen
e20d2c544d
[transcode] Comments and raise MAX_BAD_PACKETS to 5
2015-10-22 21:01:43 +02:00
ejurgensen
058b2fb0d6
[transcode] Improve decoding to allow for decoder special cases, like decoders not processing
...
entire packets, rejecting packets and not returning frames. Should fix issue with network
streams not opening.
2015-10-21 23:53:21 +02:00
ejurgensen
9853b8f9bd
Merge pull request #188 from chme/playerfixes
...
Playerfixes
2015-10-19 22:15:43 +02:00
chme
551f441273
[dacp] Fix playing from playspec request
2015-10-19 21:55:43 +02:00
chme
7592462571
[player] Fix segfault if reading from source failed for all queue items
2015-10-19 21:33:43 +02:00
ejurgensen
55104015e0
Full removal of libevent 1 legacy code. Also drop pipe() in FreeBSD, since pipe2 is available now.
2015-10-19 21:15:29 +02:00
chme
48691748cd
[mpd] fix log message if binding of artwork http server failed
2015-10-18 14:25:29 +02:00
ejurgensen
2a610812a5
Refactor transcode.c so it can actually transcode + use new capability to support mp3 streaming.
...
Also includes the skeleton for perhaps supporting video in the future. Adds more fine-grained
ffmpeg/libav compability checks. Dependency on libavresample/libswresample exchanged with
dependency on libavfilter, which seems more versatile.
2015-10-09 23:58:27 +02:00
James Le Cuirot
7cf35d1e8b
Allow ANTLR 3.5 to work
...
This involves a harmless backwards-compatible adjustment to the
grammar. I can't explain why this is necessary but this might help.
http://stackoverflow.com/questions/20057063/follow-set-in-is-undefined-in-generated-parser
2015-10-05 23:10:45 +01:00
chme
199b765a7d
[player] Store item-ids in history to allow start of playback from the
...
previously played items in dacp
2015-10-04 08:05:37 +02:00
chme
b19a7280b9
[player] remove unused player_queue struct
2015-10-04 08:05:37 +02:00
chme
fbce3a7d57
[player] Confusing naming of ids cleaned up
2015-10-04 08:05:37 +02:00
chme
ba3385b0ec
[queue] Remove queue_info and queue_item_info structs
2015-10-04 08:05:37 +02:00
chme
35df9455b9
[queue] Fix memory leak in queue_make_item
2015-10-04 08:05:36 +02:00
chme
100e08da9d
Rename make_queue functions
2015-10-04 08:05:36 +02:00
chme
064dfef2de
[player] cleanup metadata_trigger
...
metadata_trigger is always called for the current streaming item and
source_open makes sure that the stream_start and output_start values are
set correctly
2015-10-04 08:05:36 +02:00
chme
64698eb3a4
[player] Some minor cleanup (error handling, comments)
2015-10-04 08:05:36 +02:00
chme
a06424a701
[mpd] Expose queue-item-id instead of dbmfi-id in mpd commands
...
[player] Reshuffle on end of playlist and repeat mode is "repeat all"
2015-10-04 07:59:58 +02:00
chme
cb2805800b
[player] Fix segfault if pause requested in the last two seconds of the
...
last item in the playqueue (cur_streaming is already NULL)
2015-10-04 07:59:58 +02:00
chme
2b037b67d9
[player] Combine stream_stop and stream_cleanup into one function
2015-10-04 07:59:58 +02:00
chme
e44a160b9a
[player] Improve error handling
2015-10-04 07:59:58 +02:00
chme
4595a2f4a6
[player] Add missing metadata trigger on item change (after eof)
2015-10-04 07:59:58 +02:00
chme
c8a61015fc
[dacp] Fix playing of radio streams after queue refactoring
2015-10-04 07:59:58 +02:00
chme
f4faac3cc8
[spotify] Remove duplicate method "resume" in favor of "play"
2015-10-04 07:59:58 +02:00
chme
58069e67f8
[player/spotify] adjust spotify integration to refactoring of player
2015-10-04 07:59:58 +02:00
chme
e1147c00a1
[player] Refactor player to better fit the queue refactor
2015-10-04 07:59:58 +02:00
chme
1f53d7ab1a
[queue] Refactor queue handling
...
Decouple the playing/streaming item from the queue. Move all queue
related functions to seperate file queue.h/c.
Introduce internal item "head" to make iterating over the play-queue and
shuffle-queue easier.
2015-10-04 07:59:57 +02:00
chme
10d7097f98
[player] rename "queue_*"-functions to "playerqueue_*" (avoid naming
...
conflicts with later introduced separate queue file
2015-10-04 07:57:39 +02:00
chme
1fbedaa54f
[player] Refactor queue_get
2015-10-04 07:57:38 +02:00
chme
f0a6a48599
[player] Refactor queue_remove functions
2015-10-04 07:57:38 +02:00
chme
8e1834cdea
Rename make_queue function and set as static
2015-10-04 07:57:38 +02:00
chme
1812848ee1
Move client protocol specific make_queue functions out of player.c/h
2015-10-04 07:57:38 +02:00
ejurgensen
cba9bc05e9
Expire sessions without strict timeout ( closes #163 )
2015-10-03 10:00:42 +02:00
ejurgensen
ebba164a0d
Change MPD deinit position so it matches the init order, and so it will not get called if httpd fails to start
2015-09-29 23:14:44 +02:00
ejurgensen
5125e24cfe
Let db_build_query_index_clause() always return an initialized idx, even on failure
2015-09-29 22:51:23 +02:00
chme
cf70c514b6
Fix memory leak if index clause is used
2015-09-29 22:43:32 +02:00
chme
a1e2f53ab1
Fix memory leak if index clause is used
2015-09-29 22:42:53 +02:00
chme
0245813d34
Fix memory leak when parsing smart playlists
2015-09-29 22:42:30 +02:00
chme
1ed240d92c
Fix memory leak due to missing free for evconnlistener
2015-09-29 22:42:09 +02:00
ejurgensen
6c26d87997
Make some global vars in lastfm.c static
2015-09-28 21:22:51 +02:00
ejurgensen
4db6318a82
Fix issue where volume gets set to -1 on startup of raop devices
2015-09-27 15:24:04 +02:00
ejurgensen
50bcdd2551
Plug minor memleaks in cache.c
2015-09-23 22:29:17 +02:00
ejurgensen
294d7a270f
Protect against possible segfault if the artwork pixel format is unknown
...
- thank you groinwood for reporting this bug
2015-08-24 21:27:55 +02:00
ejurgensen
317ad2ba41
Always treat podcasts, audiobooks and compilations as audio, even if video stream is present
2015-08-05 22:36:28 +02:00
ejurgensen
68912efa1f
Enable resuming playback from saved position for certain media kinds (eg audiobooks)
2015-08-04 22:33:32 +02:00
ejurgensen
7881df67f6
Hack to push live ICY metadata/artwork to remote clients
2015-07-31 14:43:22 +02:00
ejurgensen
1fe6521aff
Remove libevent 1 support in httpd_dacp
2015-07-30 22:50:11 +02:00
ejurgensen
3ba76e8f40
Remove libevent 1 support in httpd_daap
2015-07-29 23:05:47 +02:00
ejurgensen
7e9cf80ec0
Reorganize configure.ac according to subject (and my taste)
2015-07-21 23:00:55 +02:00
ejurgensen
bf72547b9b
Drop legacy FLAC, Musepack and WMA file scanners (ffmpeg/libav can do this now)
2015-07-21 22:16:50 +02:00
chme
c6851eac9b
[mpd] use the same image size as in raop_metadata_prepare (max 600x600)
...
to increase artwork cache hits
2015-07-18 07:34:48 +02:00
chme
1ab318d725
[mpd] support serving artwork over http
2015-07-18 07:17:21 +02:00
ejurgensen
d870b97142
Remove LastFM thread now that it can run from the worker thread
2015-06-27 23:24:07 +02:00
ejurgensen
b6703ab7cd
Don't retrieve ICY StreamUrls without jpg/png extension (don't want to risk initiating a major, useless download)
2015-06-20 23:11:18 +02:00
ejurgensen
ec0ba2c5fa
Fix problem where the http client would ignore the last line in a m3u because of missing CRLF (issue #169 )
2015-06-18 23:03:11 +02:00
chme
ceca9135c5
[mpd] add special handling to command "lsinfo" if the root directory was
...
passed as argument.
Clients like ympd and ncmpcpp are relying on this (deprecated) behavior
2015-06-14 07:11:17 +02:00
chme
b9b3671d58
[mpd] add support for command "decoders"
2015-06-14 07:11:17 +02:00
chme
426e827712
[mpd] Return whole queue for command "playlistinfo" if given argument is
...
-1 (not a valid position in the queue)
2015-06-13 14:38:56 +02:00
ejurgensen
879c2ef350
Avoid cache regeneration triggering during db_query_run (in case the query is long running, like db_files_update_songalbumid might be)
2015-06-08 23:07:56 +02:00
ejurgensen
335517a2e8
Prevent this database deadlock:
...
1. bulk scan begins transaction, locking the db
2. cache regeneration is triggered, but waits for db to unlock
3. bulk scan calls cache_artwork_ping, which can't return because cache thread is waiting
-> scan thread is waiting for cache thread, which is waiting for scan thread
2015-06-08 22:24:33 +02:00
ejurgensen
4fffc057b6
Change queue_remove() to fix segfault because source_head/shuffle_head could become invalid, and to protect against invalid input in general (ref issue #160 ).
...
Also try to failsafe source_position() and implement next_ps() all around.
2015-06-08 00:21:49 +02:00
ejurgensen
3dde23e060
Include terminating null in u8_normalize - not necessary now, but just to be safe
2015-06-06 14:47:54 +02:00
ejurgensen
6224fdb025
UTF-8 conversion was returning string without null termination (thank you @stephan-01010011, ref pr #168 )
2015-06-06 14:22:24 +02:00
ejurgensen
a9437acc1a
Rework pr #162 to avoid mem leaks and string termination problems
2015-06-05 23:55:57 +02:00
ejurgensen
7d231b992b
Fix typo
2015-06-04 22:17:49 +02:00
ejurgensen
cd14522915
Swap misplaced args in db.c
2015-06-04 22:10:30 +02:00
ejurgensen
271c5ff344
Change DB upgrade from v18->v19 to v18->v18.01
2015-06-04 21:58:01 +02:00
chme
7cd96690c0
Remove file extension for playlists from virtual_path during scan and
...
update db to v19 removing the file extensions from the stored playlists
An existing file extension in the virtual path leads to wrong entries in
MPDroid (and mpd does also not return the file extension).
2015-06-04 08:11:46 +02:00
ejurgensen
3655e26703
Code style
2015-06-02 23:10:04 +02:00
ejurgensen
64ef66f030
Merge pull request #162 from stephan-01010011/master
...
Fixed bug that caused icy header metadata to be not correctly encoded
2015-06-03 00:05:56 +03:00
ejurgensen
7a0dfef136
Add sub-sorting when sort=artists, because otherwise Tunesremote SE will not play the artist's tracks in proper order
2015-06-01 23:36:16 +02:00
stephan-01010011
32727bd296
Fixed bug that caused icy header metadata to be not correctly
...
encoded/converted. Characters above x7F were replaced by '?' character
although the rfc defines a ISO−8859−1 encoding for descriptive
field-content.
According to rfc2616 the field-content is defined as follows:
<the OCTETs making up the field-value and consisting of either *TEXT or
combinations of token, separators, and quoted-string>
The TEXT rule is only used for descriptive field contents and values
that are not intended to be interpreted by the message parser. Words of
*TEXT MAY contain characters from character sets other than ISO- 8859-1
only when encoded according to the rules of RFC 2047.
In the previous implementation the icy metadata was converted based on
fromcode "ascii".
Following incoming icy header field-values should be encoded as
"ISO−8859−1" before adding them to the metadata structure.
- misc.c unicode_fixup_string enhanced by an additional parameter to
define the fromcode
- misc.h unicode_fixup_string prototype updated
- filescanner.c function fixup_tags updated to stay compatible to the
previous implementation using fromcode "ascii"
- db.c function unicode_fixup_mfi updated to stay compatible to the
previous implementation using fromcode "ascii"
- http.c function metadata_header_get enhanced to encode the header
field-content as "ISO−8859−1" to comply with rfc2616
2015-05-31 14:05:31 +01:00
chme
7f09438621
[mpd] support "date" argument in find and search commands
2015-05-30 05:56:53 +02:00
chme
2a04740ca2
[mpd] support "file" argument in list command
2015-05-30 05:56:52 +02:00
chme
4299de5ac7
[mpd] implement plchanges to report all songs in the queue as changed
...
(ignores the playlist version parameter).
This is necessary in order to get mpd clients (e. g. sonata) relying on
this command to display the queue.
2015-05-30 05:33:32 +02:00
ejurgensen
4a50a7a326
[spotify] Improve Spotify loading efficiency and set time_added so smart playlists will work
2015-05-29 19:47:53 +02:00
ejurgensen
40d7d044be
Lower log severity of message in spotify.c
2015-05-27 20:32:27 +02:00
ejurgensen
a1e417c571
Rename count_info to fix issue #157
2015-05-26 21:24:10 +02:00
ejurgensen
8dd1e0fde2
Fix problem introduced with commit 475d5db
where genres and composers don't get sorted
2015-05-26 21:10:28 +02:00
ejurgensen
79cdfebf34
Merge pull request #150 from chme/mpdidle
...
Add support for mpd idle command
2015-05-21 22:31:03 +02:00
ejurgensen
d6828b90fc
Merge pull request #149 from chme/mpdcommands
...
Add support for additional mpd commands
2015-05-21 22:30:49 +02:00
chme
8c12929b91
Added source code comments, return error value if adding/removing a
...
listener failed
2015-05-21 07:57:18 +02:00
chme
0b73233197
[mpd] remove libevent1 support
2015-05-21 07:15:05 +02:00
chme
1cde19b5b6
[smartpl] add "grouping" field to smart playlist grammar
2015-05-21 06:22:55 +02:00
ejurgensen
6176f7f4a2
Fix bug where files being copied into library with eg. Samba will get scanned
...
before writing has finished, which may result in no metadata for the file
2015-05-20 22:38:26 +02:00
chme
41a08d1931
[mpd] rework listener events to use a bit map
2015-05-18 20:12:18 +02:00
chme
baffe49887
refactor use for loop to remove item from linked list
2015-05-13 11:37:09 +02:00
chme
3886ec6638
Add version number for playlist (queue)
...
This is necessary to return a valid playlist id for mpd status command.
2015-05-09 07:46:33 +02:00
chme
aa4a12cabe
add events for playlist (queue), volume, speaker, options
...
(random/shuffle) changes
2015-05-09 07:46:33 +02:00
chme
d2c7c87191
use listener logic to send dacp update requests
2015-05-09 07:46:33 +02:00
chme
7097dd15eb
allow removing of listeners
2015-05-09 07:46:33 +02:00
chme
1714f3dee4
[mpd] move include of libevent from mpd.h to mpd.c
2015-05-09 07:46:33 +02:00
chme
36499f4997
[player] added some source code comments
2015-05-09 07:46:33 +02:00
chme
e156181121
[mpd] remove idle client if an eof or error occurred on the event buffer
...
(fixes segfault after closing the connection of an mpd client)
2015-05-09 07:46:33 +02:00
chme
600e48842f
[mpd] idle command
2015-05-09 07:46:33 +02:00
chme
864315eaef
[mpd] fix wrong log message
2015-05-09 07:35:15 +02:00
chme
68c392eb9e
[mpd] ignore requests for client to client commands "subscribe",
...
"unsubscribe", "readmessages", "sendmessages"
2015-05-09 07:35:15 +02:00
chme
decc482e2c
[mpd] only return "id" attribute if song information is requested for
...
the current playlist
mpd does not expose a persistent song id, instead the id returned in
playlistinfo is a unique id for the song in the queue. The same song has
different ids if it occurs more than once in the queue.
2015-05-09 07:35:15 +02:00
chme
5d22d74dba
[mpd] ignore requests for "sticker"
2015-05-09 07:35:15 +02:00
chme
91338c8548
[mpd] ignore requests for "channels"
2015-05-09 07:35:15 +02:00
chme
fefd91fabc
[mpd] support "track" parameter in commands "list", "find", "search"
2015-05-09 07:35:15 +02:00
chme
ed8b69c118
[mpd] return proper error type if playlist does not exist
2015-05-09 07:35:15 +02:00
chme
1300b2f018
[mpd] support "disc" parameter in commands "list", "find", "search"
2015-05-09 07:35:15 +02:00
chme
a03a9d1e7c
[mpd] support "genre" in commands "find" and "search"
2015-05-09 07:35:15 +02:00
chme
0921675efa
[mpd] implement command "searchadd"
2015-05-09 07:35:15 +02:00
chme
76011c927c
[mpd] implement command "findadd"
2015-05-09 07:35:15 +02:00
chme
fb92040d4b
expose generic player_queue_make function
2015-05-09 07:35:15 +02:00
chme
3832692929
move setting query_params.sort out of generic queue make function
2015-05-09 07:35:14 +02:00
chme
3a495a3d48
move setting query_params.idx_type out of generic queue make function
2015-05-09 07:35:14 +02:00
chme
b728db8470
[mpd] implement command "tagtypes" to return the list of supported tags
2015-05-09 07:35:14 +02:00
chme
670187387f
[mpd] ignore requests for "urlhandlers"
2015-05-09 07:35:14 +02:00
chme
eddcd8676d
[mpd] ignore requests for "notcommands"
2015-05-09 07:35:14 +02:00