4420 Commits

Author SHA1 Message Date
Fabian Groffen
5e68381fe4 [mpd] add "plugin" to outputs response
The plugin key is used by some clients to determine whether local
playback is possible via HTTP stream, so mimick it.

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-10 20:38:41 +02:00
Fabian Groffen
b2a957cdec [mpd] return outputs by ascending ID
Simply casting the speaker ID from a 64-bits int to an unsigned short
and hoping that there will be no clashes is just optimistic.  Use an
ascending number instead which is what MPD does too.  The MPD server
specifically documents no persistence in these IDs so we can simply
enumerate the speakers to meet the requirements.

Signed-off-by: Fabian Groffen <grobian@gentoo.org>
2024-08-10 20:38:41 +02:00
ejurgensen
d672332750 [xcode] Fix last seconds being skipped when custom filters enabled
Seems EOF was not marked towards the ffmpeg filtergraph via a NULL frame to
av_buffersrc_add_frame(). This meant that the end of the track would get
stuck in the filters.

Fixes #1787
2024-08-09 17:42:58 +02:00
ejurgensen
297de1409a [xcode] Fix comment 2024-08-09 16:03:11 +02:00
ejurgensen
dab9089f8e [rcp] Fix for RCP devices not getting removed 2024-08-08 00:22:41 +02:00
ejurgensen
cab0204d29 [httpd] Fix for password-based auth for Apple Music
Adds handling of the username from Apple Music that contain colon. Example:
iTunes_Music/1.4.5 (Macintosh; OS X 14.5) AppleWebKit/618.2.12.11.6 build/36 (dt:1):password

Closes #1778
2024-08-02 16:34:57 +02:00
ejurgensen
59bba5e261 [scan] Fix missing rescan if a file is modified quickly multiple times
If db_timestamp == file_mtime we didn't rescan, just pinged the file in the db

Fixes #1782
2024-07-26 16:04:01 +02:00
ejurgensen
90a79090ea [docs] Add documentation of --mdns-no-xxx options to command line help
Closes #1781
2024-07-25 22:53:56 +02:00
ejurgensen
13131f43ef [httpd] Workaround evhttp_connection_get_addr() issue in libevent 2.1.6 and 8
Fixes #1775
2024-07-05 16:02:06 +02:00
ejurgensen
be1bacf278 [cfg] Add "none" as "trusted_networks" option 2024-07-05 16:00:47 +02:00
ejurgensen
bcdd3b2f65 [cache] Silence false gcc maybe-uninitialized warning 2024-06-25 23:39:06 +02:00
ejurgensen
f87b65f086 [misc] Add missing include of stdlib
Thanks @LordMyschkin. Closes #1772.
2024-06-25 23:38:24 +02:00
ejurgensen
5542492d33 [xcode] Fix calculation of estimated wav sizes (causing M1001 crash)
Fix regression from commit 3ee9204 where wav size calculation was changed. The
new method caused Soundbridge M1001 to reboot, and the likely cause seems to be
that the sizes in the wav header may not be multiples of channels x
bytes_per_sample, so typically 4.

Resolves #1770
2024-06-24 23:55:32 +02:00
ejurgensen
7ddb4e9bbb [httpd] Fix startup crash after merge commit 4cbce79
With debug level loggint, the crash would be preceeded with "Checking if client
'(null)' is a speaker"

Resolves #1771
2024-06-22 17:34:04 +02:00
ejurgensen
d6d46de399 [misc] Fixup missing "== 0" in commit c30f44f 2024-06-17 23:35:03 +02:00
ejurgensen
82a0e77eb6 [config] Keep "cache_path" option but mark as deprecated
So OwnTone will still start if user has previously configured "cache_path"
2024-06-17 23:04:20 +02:00
ejurgensen
7dd34792ea [cache] Multitreaded header encoding 2024-06-17 22:25:20 +02:00
ejurgensen
088c393dd6 [httpd/cache] Misc fixing up 2024-06-17 22:25:20 +02:00
ejurgensen
2d9200fcdf [cache] Try to fix cache thread blocking the rest of the server 2024-06-17 22:25:20 +02:00
ejurgensen
ff2d0b4ab1 [httpd] Check speaker settings to determine DAAP/RSP stream format 2024-06-17 22:25:20 +02:00
ejurgensen
62b42ce354 [misc/player] Introduce output ability to announce supported formats
Also introduce default output format and selected device format, should the
user want another format.

As part of this, change enum player_format in player.h to enum media_format in
misc.h so that it is akin to struct media_quality.

Modify json API to support this.
2024-06-17 22:25:20 +02:00
ejurgensen
9f719ca155 [player/jsonapi/db] Add interface to get and set an output format 2024-06-17 22:25:20 +02:00
ejurgensen
c079df5da7 [cache/config] Refactor cache so daap/artwork/xcode is cached in separate db's
Also change config so that the user can just configure a data directory instead
of complete path to each database.
2024-06-17 22:25:20 +02:00
ejurgensen
2efad1466f [cache] Add support for storing MP4 headers 2024-06-17 22:05:07 +02:00
ejurgensen
4a08644806 [xcode] Change the signature of transcode_setup/transcode_en/decode_setup()
Should make it easier to add/remove parameters without changing all calls to the
functions throughout the code.

Also adds an interface through which to call make_mp4_header().
2024-06-17 22:05:07 +02:00
ejurgensen
9dbec4b99e [misc] Move endianess utils from rtp_common.h to misc.h
So that transcode.c can also use them.
2024-06-17 22:05:07 +02:00
ejurgensen
725419d4ac [xcode] Do without _GNU_SOURCE, MacOS doesn't like it 2024-06-17 22:05:07 +02:00
ejurgensen
aed74fbb8a [xcode] Support for ALAC encoded RSP/DAAP streaming
Also changes WAV encoding to use source quality instead of fixed 44100/16/2.
Sets the default to WAV, since it has the best quality, and doesn't have the
delay that creating an MP4 container for ALAC currently has (TODO prepare
the headers to avoid the delay).

Ref issue #1182 and #1665
2024-06-17 22:05:07 +02:00
ejurgensen
c30f44fd01 [misc] New net_peer_address_is_trusted with cfg set default to "lan"
New default for "trusted_networks" = "lan". This will check peer addresses
against the addresses/netmasks of the interfaces to establish whether the peer
is local.

Fixes #1754
2024-06-16 01:17:11 +02:00
ejurgensen
2219e3ce75 [scan] Fix bug where playlist name isn't updated when m3u/pls file is renamed
Closes #1758
2024-06-12 13:12:37 +02:00
ejurgensen
3af04afa61 [dmap] Change date type to int64, fix for "Integer value too large"
uint32 won't work for dates before the Unix epoch, and int32 won't work after
2038, so let's see if clients can handle int64.

Resolves #1742
2024-06-09 22:20:33 +02:00
ejurgensen
e7459e0576 [mdns] Fix OwnTone not updating speaker addresses on ip change
The fix is to use proto instead of addr->proto when creating the record browser
in browse_resolve_callback(). The rest of the commit is just minor
beautification.

Resolves #1760. The issue seems to be a regression from commit
e7a73551ab59d06256602ebce6961ea8811e7584.
2024-06-04 17:11:45 +02:00
ejurgensen
75b8f06e25 [misc] Replace mxml with libxml2
mxml 4 is binary and source incompatible with 3, and there is no easy way to
stay compatible with both. Not great for a library. So replace with libxml2,
hopefully that is more stable. Also means we can get rid of all the mxml hacks
2024-05-31 23:47:46 +02:00
ejurgensen
2bb97c8e0a [cfg] Change ipv6 default to disabled
There is some issue with OwnTone's Airplay ipv6 implementation so disable ipv6
in the config until it is fixed.

Ref issue #1752
2024-05-20 22:21:00 +02:00
ejurgensen
72454de4ef [jsonapi] Fix boolean value assigned to pointer (from cppcheck) 2024-04-10 22:41:08 +02:00
ejurgensen
677aceccb6 [cast] Add missing include 2024-04-10 22:40:52 +02:00
ejurgensen
1c17231b9e [spotify] Fix some logging inaccuracies 2024-04-05 23:45:08 +02:00
ejurgensen
a8342dc513 [xcode] Fix for ffmpeg 7.0 that wants const in avio_alloc_context's signature
Closes #1743
2024-04-05 22:44:46 +02:00
ejurgensen
945bde7c66 [db] Fix memleak if db backup is enabled but fails
Closes issue #1741
2024-04-03 22:04:39 +02:00
ejurgensen
3e7e03b4c1 [jsonapi] Support /api/search?type=genre like type=composers is supported
Ref. #1735
2024-03-30 22:24:53 +01:00
ejurgensen
9b12618b93 [scan] Fix date_released being set to 0 on platforms with musl
%F for ISO date format is only glibc. May affect other date parsing.

Closes #1730
2024-03-21 21:04:21 +01:00
ejurgensen
bf8e433a0e
[scan] Fix error in debug function 2024-03-20 09:27:30 +01:00
ejurgensen
c293f72846 [httpd] Fix for musl libc not having sys/queue.c (closes #1726) 2024-03-03 22:41:25 +01:00
ejurgensen
49de0240b8 [scan] Remove obsolete comments 2024-03-01 23:37:17 +01:00
ejurgensen
4352f54c11 [scan] Use copy_file_range for Linux/FreeBSD file copy
FreeBSD doesn't seem to actually have copyfile.h
2024-03-01 22:59:23 +01:00
whatdoineed2do
2dc448fa30
[scan/library] Media rating sync (#1681)
Automatically read/write ratings to files in the library, if options read_rating/
write_rating are enabled. Also adds a max_rating so the user can set the rating
scale.

Doesn't sync automatic rating updates, because that could lead to whole-playlist
file rewriting.

Closes #1678 

---------

Co-authored-by: whatdoineed2do/Ray <whatdoineed2do@nospam.gmail.com>
Co-authored-by: ejurgensen <espenjurgensen@gmail.com>
2024-01-24 23:30:02 +01:00
ejurgensen
b4e4583e61 [raop] Remove unused function 2024-01-18 18:18:33 +01:00
ejurgensen
74c82141d4 [artwork] Remove errors in log saying "Source 'stream' returned an error..."
Handler for stream doesn't support URL's with "file:", so ignore any such URLs.
2024-01-12 23:04:59 +01:00
ejurgensen
b6ad73e1fa [xcode] Go back to wav as default format for RSP/DAAP transcoding
But add "prefer_format" config option for mp3, incl. a check for an encoder.
The config option is currently not added to owntone.conf.in, so is undocumented
until decided what to do about possible alac support.
2024-01-01 23:22:30 +01:00
ejurgensen
2871a03aa8 [spotify] Fixup commit 182255c 2024-01-01 17:34:07 +01:00