Commit Graph

5557 Commits

Author SHA1 Message Date
ejurgensen
d9177dfb25 [artwork] Remove some superfluous checks
Credit lgtm.com
2020-08-10 22:50:04 +02:00
ejurgensen
a0876e532c [websocket] Prefix globals with websocket_
Avoids e.g. "event" being both the name of a global and a parameter name in
send_notify_reply()

credit lgtm.com
2020-08-10 22:36:00 +02:00
ejurgensen
23be5aa749 [config] Name change to avoid overlapping/hiding global variable "cfg"
credit lgtm.com
2020-08-10 22:29:02 +02:00
ejurgensen
5e6b5fbe8a [httpd/logger] Use gmtime_r/localtime_r instead of gmtime/localtime
gmtime and localtime are not thread safe

credit lgtm.com
2020-08-10 22:23:21 +02:00
ejurgensen
fada4c0ee7 [lastfm] Fix incorrect error condition test 2020-08-10 22:08:35 +02:00
ejurgensen
47779e59e7 [input] Fix memleak of path when seting up a new input file
Credit @whatdoineed2do

Closes #1067
2020-08-10 22:01:49 +02:00
whatdoineed2do/Ray
249809469d [README] fix anchor link 2020-08-10 21:51:44 +02:00
whatdoineed2do/Ray
3a0d4edc21 [README,config] db backup 2020-08-10 21:51:44 +02:00
whatdoineed2do/Ray
76d35f5abc [scan] bulk_scan() counter reset before processing any library dirs 2020-08-09 22:33:23 +02:00
ejurgensen
55d5289c05 [player] Add settings for persisting repeat, shuffle and consume
Closes issue #963
2020-07-24 20:15:03 +02:00
ejurgensen
3245b81e60 [settings] Add shorthand macros for getting/setting options 2020-07-24 20:15:03 +02:00
whatdoineed2do/Ray
d567bd004a [db,conf,json] new backup endpoint 2020-07-24 20:07:42 +02:00
ejurgensen
2ca10d9bba Bump to version 27.2 2020-07-24 00:48:49 +02:00
ejurgensen
607283528b ChangeLog and README for forked-daapd 27.2 2020-07-24 00:48:05 +02:00
ejurgensen
a71444d3e1 [player] Limit auto reconnection + add option for user override
With this commit auto reconnection per default will only be done for ATV4s and
HomePods. Reconnection is not always desirable, for instance if the device cuts
the connection because it is busy with something else, ref. issue #934.

The commit also adds an option to override auto reconnection, thus either
enabling it for other devices or disabling it for affected devices.
2020-07-24 00:10:26 +02:00
ejurgensen
e8bdcd2365 [xcode] Use ffmpeg's "image2pipe" muxer instead of "image2"
With ffmpeg 4.3 it seems image2 no longer works for non-file output, so use
image2pipe instead.

Closes #1061
2020-07-19 23:52:42 +02:00
ejurgensen
d0a7d5114b [http] Drop own Shoutcast metadata requestor, rely on ffmpeg now
ffmpeg/libav has been capable of this since approx 2016, so the fallback
functions can be dropped now.

Also means we don't add automatically add Icy-MetaData: 1 to request
headers any more.
2020-07-17 00:08:16 +02:00
ejurgensen
3e707c4060 [http] Make libcurl a hard requirement
Always using libcurl makes the code simpler, plus makes sure we always have a
https client
2020-07-16 23:30:05 +02:00
ejurgensen
941fb47c1d [player] Only resurrect speakers that fail during playback
Fix bug where we would resurrect speakers, incl restart playback, if the speaker
disconnected after a flush.

Closes #1057
2020-07-16 23:08:58 +02:00
ejurgensen
c4d6e1c251 [raop] Extra logging of invalid retransmit headers 2020-07-16 21:30:48 +02:00
ejurgensen
019b921dc4
Merge pull request #1055 from whatdoineed2do/readme-als-with-devnames
[README] show configuration using ALSA device aliases
2020-07-15 23:10:14 +02:00
whatdoineed2do/Ray
e598e4a592 [README] show configuration using ALSA device aliases 2020-07-15 13:41:00 +01:00
ejurgensen
703f528599
Merge pull request #1054 from whatdoineed2do/alsa-dump-card-with-devnames
[alsa] dump_card() includes ALSA device name
2020-07-15 10:14:14 +02:00
whatdoineed2do/Ray
c6c1e8f9ee [alsa] dump_card() includes ALSA device name
Include ALSA's device name in the ALSA modules 'info' logging to help
identify sound devices as seen by the system for assisting config setup

Many configs use ALSA's hw ids to refer to device but ALSA can also use
device names:

    laudio: Available ALSA playback mixer(s) on hw:0 CARD=Intel (HDA Intel): 'Master' 'Headphone' 'Speaker' 'PCM' 'Mic' 'Beep'
    laudio: Available ALSA playback mixer(s) on hw:1 CARD=E30 (E30): 'E30 '

From the example above can use these ALSA names interchangably:
    'hw:0' and 'hw:Intel'
    'hw:1' and 'hw:E30'
2020-07-14 21:55:46 +01:00
ejurgensen
5a864351d3
[cfg] Minor text changes 2020-07-06 11:31:04 +02:00
ejurgensen
6be2678fe6 Update issue templates 2020-07-06 10:37:58 +02:00
ejurgensen
41688ac53b Update issue templates 2020-07-06 10:37:10 +02:00
ejurgensen
ec6265dcc7 Update issue templates 2020-07-06 10:35:59 +02:00
ejurgensen
a5ae190d7c Update issue templates 2020-07-06 10:30:51 +02:00
ejurgensen
67f16138c5 [pipe] Change int64_t print mask for log message
Removes compiler warning
2020-07-05 20:59:03 +02:00
ejurgensen
2f702ed3ef Merge branch 'spotify_logout1' 2020-07-05 20:45:54 +02:00
ejurgensen
5e60527f40 [spotify] Add an API endpoint for logging out of Spotify 2020-07-05 20:43:51 +02:00
ejurgensen
1b74966ef1 [db] Remove HAVE_SPOTIFY_H conditionals, not required
The db functions don't depend on the Spotify library, so remove conditionals
2020-07-05 20:43:51 +02:00
Christian Meffert
3fd812ef2f
Merge pull request #1008 from chme/web_next
Player web interface v0.7.2
2020-07-05 10:59:15 +02:00
Christian Meffert
0e8e8564bb
Merge pull request #1042 from chme/player-prev-next
[player/jsonapi] Do not report error on skip next/prev if end/start of queue is reached
2020-07-05 10:58:50 +02:00
Christian Meffert
07f3f808c7
Merge pull request #1041 from chme/ws-header-space
[ws] Set websocket header data space
2020-07-05 10:57:54 +02:00
ejurgensen
e393d4a59d
Merge pull request #1045 from whatdoineed2do/README-smart-json-upd
[README] smart pl and  json update
2020-07-04 13:29:52 +02:00
whatdoineed2do/Ray
6b7df9475a [README] update for 'limit' on 'add' endpoint 2020-07-04 11:55:55 +01:00
whatdoineed2do/Ray
558f42baca [README] update for 'random' field-name 2020-07-04 11:55:20 +01:00
Christian Meffert
db51d59be4
Merge pull request #995 from whatdoineed2do/json-add-by-query-with-limit
[jsonapi] support 'limit' on 'api/queue/items/add?expression='
2020-07-03 20:09:00 +02:00
chme
56564dec87 [ws] Set header data space to 4096
Hopefully fixes the "LWS Ran out of header data space" error seen in the
Chrome browser.
2020-07-03 09:53:39 +02:00
chme
569a997f6d [htdocs] Rebuild player web interface 0.7.2 2020-07-01 07:32:13 +02:00
chme
1d274a79bb [web-src] Use generic albums api function for all media kinds 2020-07-01 07:32:12 +02:00
chme
93a170690e [web-src] Remove link to "admin" page
All functionality of the admin page has been moved to the "settings" page
2020-07-01 07:32:12 +02:00
chme
66e482d629 [web-src] Add radio page listing all radio streams 2020-07-01 07:32:12 +02:00
chme
b15b5c88fa [web-src] Only show quality informations if they are available 2020-07-01 07:32:12 +02:00
chme
9616cfdf0c [jsonapi] harmonize "channels" attribute in queue item and track object 2020-07-01 07:32:12 +02:00
chme
1c65ba1ee2 [web-src] Update Spotify album page spacing
Also make cover artwork clickable to open the album details dialog
2020-07-01 07:32:12 +02:00
chme
728b1624ff [web-src] Update dependencies 2020-07-01 07:32:12 +02:00
chme
ade654f96f [web-src] Replace verification request with authorize output request 2020-07-01 07:32:12 +02:00