4182 Commits

Author SHA1 Message Date
ejurgensen
92953f1a2c [cast] Use unsigned ints for ID's so we don't risk negative values
ssrc_id could become negative because rtp_session.ssrc_id is uint32, but we
were printing it with %d.
2020-11-18 23:13:00 +01:00
ejurgensen
504a66a315 [cast] Add some comments 2020-11-18 23:13:00 +01:00
Christian Meffert
22a4af7b93
Merge pull request #1111 from whatdoineed2do/disable-playlist-caching
[db] playlist cache invalidation fix
2020-11-07 08:43:07 +01:00
ejurgensen
745fee4eb9 [db] Remove unused macro STR() 2020-11-05 23:02:44 +01:00
ejurgensen
6eb01f8ffc [outputs] Remove incorrect NULL return if packet buffer seqnum is 0
Since seqnum wraps around it should be ok to call rtp_packet_get() even when
session->seqnum is 0.
2020-11-03 23:44:22 +01:00
whatdoineed2do/Ray
7917695676 [db] add LISTENER_DATABASE for db_pl_*() on CRUD 2020-11-03 10:12:42 +00:00
whatdoineed2do/Ray
827921a028 [db] update db_statement_run() to accepts update events like db_query_run() 2020-11-03 09:28:14 +00:00
nia
4cdeb1afea Remove unnecessary check for FreeBSD
The non-timerfd code path depends on SIGALRM being defined, so signal.h
always needs to be included.

This allows forked-daapd to build and run on NetBSD and probably other
BSD systems too.
2020-11-02 15:07:17 +01:00
Christian Meffert
3395773c9f
Merge pull request #1105 from chme/rescan-metadata
[spotify] Force metadata update on library "metarescan" update
2020-10-24 09:57:40 +02:00
ejurgensen
c20b85a6d9 [artwork] Always stash results of http requests in cache, even if negative
This is an attempt to be nice to peers, so that we don't make many similar
requests to e.g. Discogs. This could happen via proces_items() for an album
where we have the same artwork url for each track, and if it was 404 we
would continue attempting the same request for each track.
2020-10-20 23:22:49 +02:00
ejurgensen
0383f19e9f [artwork] Avoid repeating online search requests with same query
This changes online_source_search_check_last() so that it also works if the
last search query was unsuccesful, i.e. last_artwork_url was NULL.
2020-10-19 22:34:26 +02:00
ejurgensen
f48fae20e2 [db] Remove unused db_speaker_clear_all() 2020-10-19 20:39:03 +02:00
ejurgensen
d2d9b78ae7 [player] Don't unselect disappeared speakers on exit/restart
With the new speaker selection philosophy we aim to preserve user choice, so we
shouldn't unselect speakers just because they happen to be switched off when
the server is restarted.
2020-10-19 20:36:32 +02:00
ejurgensen
ce9fbff8f5 [artwork] Use cache stash to avoid making repeated requests
E.g. for an album we would for each track request artwork from Spotify, even
though the requests are similar and the first one didn't give a result.
2020-10-19 20:25:01 +02:00
ejurgensen
3233aefa8a [scan] Improve logging of inotify events 2020-10-19 20:24:31 +02:00
chme
bda2cff5db [spotify] Force metadata update on library "metarescan" update 2020-10-18 10:35:51 +02:00
chme
d29f56f3eb [httpd] Add "max-age=0" to Cache-Control header to force browsers to
always revalidate cached content
2020-09-27 19:13:07 +02:00
chme
20a2c96b2a [jsonapi] Add boolean field "random" to playlist
The new field "random" is true for smart playlists with an order by
clause "random", otherwise it is false. This allows clients to handle
randomly generated playlists differently from static playlists.
2020-09-27 19:13:07 +02:00
chme
dd811e6c70 [jsonapi] Prevent browsers to cache playlist tracks
The tracks of a smart playlist might change between library rescans.
Allowing them to be cached based on the last rescan timestamp
("Last-Modified" header in the response) leads to potentially showing
incorrect track listing if a cached version is used. Thus the response
for playlist tracks should never be cached by the browser (this is
achieved with setting "Cache-Control" header to "no-store").
2020-09-27 19:13:07 +02:00
Tucker Kern
39b14ff8d4 Use relative paths in web interface to ease reolcation or proxying 2020-09-27 19:13:07 +02:00
chme
023436c959 [settings] Add support for (optional) default values and remove default
value functions for artwork
2020-09-27 19:13:07 +02:00
chme
e86aa95d89 [settings] Add new setting for "webinterface"
- add settings to show/hide menu items in the top nav bar
- add setting to show/hide cover artwork in album lists
2020-09-27 19:13:07 +02:00
Christian Meffert
1258427afc
Merge pull request #1090 from chme/spotify-release-date
Map release date for Spotify tracks + fix release data being off by one day
2020-09-24 06:44:23 +02:00
ejurgensen
81c776fc4a [player] Fixup commit 1f45967 2020-09-21 17:18:09 +02:00
ejurgensen
1f45967481 [player] Fix autoselect so it also applies when there are no selected devices (second attempt)
Second attempt at fixing regression in version 27.2. First attempt was commit 2345885.

Closes #1091.
2020-09-21 17:12:18 +02:00
chme
a28c6ba1d6 [spotify] Scan album info during saved playlists scan (if available) 2020-09-19 08:00:26 +02:00
ejurgensen
513a09e6d1 [player] Reduce log severity of devices not starting 2020-09-06 23:18:08 +02:00
ejurgensen
2345885f19 [player] Fix autoselect so it also applies when there are no selected devices
Regression in version 27.2. Closes #1091.
2020-09-06 00:12:15 +02:00
ejurgensen
500f57ba1a [player] Clear up return value of outputs_start()
Should return 0 if no devices at all, or if none selected. Should not return
negative from failure to stop unselected devices.
2020-09-06 00:08:40 +02:00
chme
451e0bf10b [spotify/jsonapi] Map date_released for Spotify tracks; fix date
released being off by one day in the JSON API
2020-09-01 20:37:10 +02:00
chme
6f5822e461 [jsonapi] Map fields time_added, time_played, seek for album / artist 2020-08-30 09:08:41 +02:00
chme
a74a3e5add [db] Add fields time_added, time_played, seek to group object 2020-08-30 09:08:41 +02:00
chme
382467eb9c [jsonapi] Map additional metadata for artist and album 2020-08-30 09:08:41 +02:00
chme
8afae4a41b [db] Fetch additional metadata for artist and album in group query 2020-08-30 09:08:41 +02:00
ejurgensen
bb9536ef44 [scan] Early skip if file should be ignored
Avoids needless logging, e.g. from failed lstat(). Closes #1078.
2020-08-22 21:38:12 +02:00
ejurgensen
c5df688caf [alsa] Align commit bfe99e5 with coding style 2020-08-22 21:36:10 +02:00
whatdoineed2do/Ray
bfe99e56f7 [alsa] use alsamixer volume adjustment algorithm 2020-08-22 21:25:17 +02:00
ejurgensen
11de4c09bc [misc] Also have buildopts[] have disabled features + regex 2020-08-19 20:12:06 +02:00
ejurgensen
a5ddb3c85d [player] Fix for volumes of unselected devices being reduced
Closes #1077
2020-08-13 20:48:48 +02:00
ejurgensen
de5060bc57 [db] Remove a FIXME, not much of an issue 2020-08-10 23:03:37 +02:00
ejurgensen
d77927d3c3 [xcode] Fix incorrect error check, unsigned int can't be negative
av_find_best_stream() returns an int, with negative being an error

Credit lgtm.com
2020-08-10 22:56:08 +02:00
ejurgensen
d9177dfb25 [artwork] Remove some superfluous checks
Credit lgtm.com
2020-08-10 22:50:04 +02:00
ejurgensen
a0876e532c [websocket] Prefix globals with websocket_
Avoids e.g. "event" being both the name of a global and a parameter name in
send_notify_reply()

credit lgtm.com
2020-08-10 22:36:00 +02:00
ejurgensen
23be5aa749 [config] Name change to avoid overlapping/hiding global variable "cfg"
credit lgtm.com
2020-08-10 22:29:02 +02:00
ejurgensen
5e6b5fbe8a [httpd/logger] Use gmtime_r/localtime_r instead of gmtime/localtime
gmtime and localtime are not thread safe

credit lgtm.com
2020-08-10 22:23:21 +02:00
ejurgensen
fada4c0ee7 [lastfm] Fix incorrect error condition test 2020-08-10 22:08:35 +02:00
ejurgensen
47779e59e7 [input] Fix memleak of path when seting up a new input file
Credit @whatdoineed2do

Closes #1067
2020-08-10 22:01:49 +02:00
whatdoineed2do/Ray
76d35f5abc [scan] bulk_scan() counter reset before processing any library dirs 2020-08-09 22:33:23 +02:00
ejurgensen
55d5289c05 [player] Add settings for persisting repeat, shuffle and consume
Closes issue #963
2020-07-24 20:15:03 +02:00
ejurgensen
3245b81e60 [settings] Add shorthand macros for getting/setting options 2020-07-24 20:15:03 +02:00