Commit Graph

5757 Commits

Author SHA1 Message Date
ejurgensen
0d67f26662 [artwork] Fix memleak on pipe artwork error 2021-11-15 22:57:43 +01:00
ejurgensen
4c5217d3d9
Merge pull request #1339 from owntone/spotify_disconnect1
Fix for Spotify disconnect issues
2021-11-08 23:35:40 +01:00
ejurgensen
6d54886030 [librespot-c] Close connection if peer disconnects
Attempt to fix possible bad state where librespot-c keeps try to using a
connection even after the access point has disconnected.
2021-11-04 17:20:55 +01:00
ejurgensen
5e66dbd8c9 [spotify] Fix Spotify initialization issues
* loading library even though library playback login failed
2021-11-01 10:37:17 +01:00
ejurgensen
65d578f8c8 [scan] Ignore 0-byte files in library so ffmpeg 3.2 doesn't crash 2021-10-29 23:08:37 +02:00
whatdoineed2do
a5f75dab36
[jsonapi] /api/library/*/{id} returns 404 (instead of 500) on not finding item (#1326)
Co-authored-by: whatdoineed2do/Ray <whatdoineed2do@nospam.gmail.com>
2021-10-25 17:36:51 +02:00
ejurgensen
383146eb35
Merge pull request #1327 from owntone/jsonapi-multi-track-put3
[jsonapi] Add PUT /api/library/tracks endpoint (update multiple tracks)
2021-10-10 23:45:26 +02:00
ejurgensen
d2ee9f20fb [jsonapi] Add PUT /api/library/tracks endpoint (update multiple tracks)
Also fix error in json doc (track->id type)
2021-10-10 23:31:34 +02:00
ejurgensen
41e3733ccc [misc] Make safe_xxx integer conversions safer by checking for NULL input
Also don't touch output on error + fix missing check for return in db.c
2021-10-09 23:39:00 +02:00
ejurgensen
c4d57aa5d1 [spotify] Clear spotify_status on logout (clears logged_in and username) 2021-10-05 20:46:44 +02:00
ejurgensen
de2e1b32ed
Merge pull request #1322 from owntone/ci_fixups2
Fix MacOS workflow
2021-10-01 20:43:55 +02:00
ejurgensen
c50f386d68 Fix MacOS build failure due to missing OpenSSL
Seems OpenSSL headers aren't installed by default any more on the virtual host,
but they are required by libwebsockets
2021-10-01 19:52:38 +02:00
ejurgensen
af61c10756 Remove forked-daapd name from MacOS workflow file 2021-10-01 19:03:55 +02:00
ejurgensen
ae7280b770 [library] Fix macos format warning
library.c:233:123: warning: format specifies type 'long' but the argument has type '__darwin_suseconds_t' (aka 'int') [-Wformat]
2021-10-01 19:01:32 +02:00
ejurgensen
679c142212 [db] Remove unused strdup_if() 2021-10-01 18:58:13 +02:00
ejurgensen
5e93080aa2 [airplay] Fix warning about int type seqnum 2021-10-01 16:52:47 +02:00
ejurgensen
aff8ac6a6b [raop] Fix warning about int type seqnum 2021-10-01 16:52:02 +02:00
ejurgensen
7572560bf2 [chromecast] Fix format and type errors 2021-10-01 16:44:30 +02:00
ejurgensen
5ce6c69424
[docs] Update README, remove notice about speaker autoselection 2021-09-30 21:34:08 +02:00
whatdoineed2do/Ray
af91d99468 [web-src] podcast handling of propogated 'play_count_changed' event 2021-09-30 12:52:53 +01:00
ejurgensen
63c3d59d2f [spotify] Preserve fine-grained errors from request_make() 2021-09-24 19:17:47 +02:00
ejurgensen
d6dc92359e Merge branch 'whatdoineed2do-db-files-review-flag' 2021-09-17 23:02:13 +02:00
ejurgensen
6692411040 [-] Fixup PR 1309 (usermark) 2021-09-17 22:58:21 +02:00
whatdoineed2do/Ray
45c5f0b347 [docs] update for "usermark" 2021-09-16 10:51:54 +01:00
whatdoineed2do/Ray
4d5c256327 [db,jsonapi] revert usermark from queue item table 2021-09-16 10:43:55 +01:00
whatdoineed2do/Ray
16cf3cb44b [jsonapi] use u32 types for parsing param: rating 2021-09-16 09:11:31 +01:00
whatdoineed2do/Ray
52d1ba7dd4 [db,jsonapi] remove DB_FILES_USERMARK_MAX 2021-09-15 08:40:07 +01:00
whatdoineed2do/Ray
d43ce017f5 [db,jsonapi,smartpl] db usermark flag review 2021-09-08 14:51:55 +01:00
whatdoineed2do/Ray
e65203e1e2 [db] expand file tbl's flag values 2021-09-07 11:49:24 +01:00
whatdoineed2do/Ray
ad573b8bc7 [db,jsonapi]] update api/library/tracks and db to accept 'flag' param 2021-09-06 20:15:35 +01:00
whatdoineed2do/Ray
5cbb5f061d [smartpl] add review 'flag' 2021-09-06 20:15:35 +01:00
whatdoineed2do/Ray
4dcc9b602e [db] add review 'flag' column to files/queue tbls 2021-09-06 20:15:35 +01:00
Christian Meffert
29cd5a7a19
Merge pull request #1286 from chme/spotify_podcasts
[spotify] Scan spotify podcast subscriptions into library
2021-09-04 12:06:26 +02:00
Christian Meffert
80679180b7
Merge pull request #1305 from chme/smartpl-fix-error-check
Fix wrong check for NULL after creating smartpl parser
2021-09-04 10:25:56 +02:00
chme
d8a344d87c Fix wrong check for NULL after creating smartpl parser 2021-09-04 09:55:11 +02:00
Christian Meffert
5731c53393
Merge pull request #1296 from cdlenfert/master
Add a solid background to PNG to prevent iOS defaulting to black
2021-09-04 09:47:57 +02:00
chme
ce3e79d804 [spotify] Move "has_podcast_support" to spotify_status and expose this
flag in the web API
2021-09-04 09:46:29 +02:00
chme
c58e792ff4 [spotify] Code format change 2021-09-04 09:46:28 +02:00
chme
f700935b57 [spotify] Add artwork support for episodes (podcasts) 2021-09-04 09:46:28 +02:00
chme
24450bc90a [spotify] Scan spotify podcast subscriptions into library 2021-09-04 09:46:28 +02:00
ejurgensen
e63aba61c5 Bump version to 28.2 2021-09-02 20:12:38 +02:00
ejurgensen
ff72b2dfb2 ChangeLog and README for OwnTone 28.2 2021-09-02 20:11:56 +02:00
ejurgensen
8a15603324
Merge pull request #1302 from owntone/easy_install2
Easier installation
2021-09-02 00:37:43 +02:00
ejurgensen
c464f01d58 [docs] Update FreeBSD script to not install systemd files 2021-09-02 00:21:05 +02:00
ejurgensen
28ff1b71f2 [docs] Updates to INSTALL.md
- document --enable-install-user and --disable-install-systemd
- drop LSB init stuff (outdated)
- drop libevent 2.0 notes (outdated)
2021-09-02 00:21:05 +02:00
ejurgensen
ab6bdf0db1 [docs] Drop notice about libevent 2.0, since it is pretty old by now 2021-09-02 00:21:05 +02:00
ejurgensen
8c9a164c4a [config] Easier install by letting 'make install' add user and service files
If --enable-install-user set add owntone system user and group (unless other
user/group specified with --with-user or --with-group). The user will be added
to pulse-access if the group is present.

Don't overwrite config, it's a pita. Use same solution as shairport-sync where
distros can use --disable-install_conf_file if required.

A './configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var' will
result in service files in /etc/systemd/system, which seems sensible. Package
builds can specify other location, e.g. --with-systemdir=/lib/systemd/system,
or ship their own service file and use --disable-install-systemd.

Also added more cleanup on uninstall - before we where leaving stuff in
/var/cache/owntone + the logs + the pid files.
2021-09-02 00:21:05 +02:00
ejurgensen
3f13ab1026 [pipe] Use fstat instead of lstat to fix time-of-check time-of-use warning
Fixes warning from CodeQL. Wasn't really a security issue since the check was
just a service to the user.
2021-09-02 00:17:22 +02:00
ejurgensen
de7ab1547f [library] Remove needless stat() in scan_playlist()
Fixes time-of-check time-of-use warning from CodeQL
2021-09-02 00:12:18 +02:00
ejurgensen
54faa11ce5 [spotify] Update librespot-c so ./configure works with FreeBSD 2021-09-01 17:11:45 +02:00