MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-02-09 04:38:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove/disable raop_check_cseq because raop/rtsp servers like Reflector and AirFoil don't return it according to spec (issue #98)

Browse Source
This commit is contained in:
ejurgensen 2015-02-09 17:55:12 +01:00
parent ebfff85afa
commit d542ab9c98
1 changed files with 6 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/raop.c
View File

@ -1162,57 +1162,15 @@ raop_add_headers(struct raop_session *rs, struct evrtsp_request *req, enum evrts
return 0; return 0;
} }
static int /* This check should compare the reply CSeq with the request CSeq, but it has
raop_grab_cseq(struct evkeyvalq *headers) * been removed because RAOP targets like Reflector and AirFoil don't return
{ * the CSeq according to the rtsp spec, and the CSeq is not really important
const char *param; * anyway.
int cseq; */
int ret;
param = evrtsp_find_header(headers, "CSeq");
if (!param)
return -1;
ret = safe_atoi32(param, &cseq);
if (ret < 0)
{
DPRINTF(E_LOG, L_RAOP, "Could not convert CSeq value to integer (%s)\n", param);
return -1;
}
return cseq;
}
static int static int
raop_check_cseq(struct raop_session *rs, struct evrtsp_request *req) raop_check_cseq(struct raop_session *rs, struct evrtsp_request *req)
{ {
int reply_cseq; return 0;
int request_cseq;
reply_cseq = raop_grab_cseq(req->input_headers);
/* AirFoil won't return cseq, so skip the check */
if (reply_cseq < 0)
{
DPRINTF(E_INFO, L_RAOP, "No CSeq in reply, skipping check\n");
return 0;
}
request_cseq = raop_grab_cseq(req->output_headers);
if (request_cseq < 0)
{
DPRINTF(E_LOG, L_RAOP, "No CSeq in request\n");
return -1;
}
if (reply_cseq == request_cseq)
return 0;
DPRINTF(E_LOG, L_RAOP, "Reply CSeq does not match request CSeq: got %d expected %d\n", reply_cseq, request_cseq);
return -1;
} }
static int static int