MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2024-12-27 07:35:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

[db/library] Use "PRAGMA optimize" instead of "ANALYZE"

Browse Source 
ANALYZE collects and saves statistics even if there were no database
changes and the last collected data is still good.

According to the sqlite3 documentation, it is recommended to use "PRAGMA
optimize" which will call "ANALYZE" if it is necessary. "PRAGMA
optimize" will run "ANALYZE" based on prior queries on the same database
connection. It is recommended to run optimize before closing the
connection.

(see https://www.sqlite.org/lang_analyze.html)
This commit is contained in:
chme 2018-02-23 19:44:40 +01:00 committed by ejurgensen
parent 0014b9001b
commit cd96ec579a
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/db.c
View File

@ -684,9 +684,9 @@ db_exec(const char *query, char **errmsg)
/* Maintenance and DB hygiene */
static void
db_analyze(void)
db_pragma_optimize(void)
{
char *query = "ANALYZE;";
const char *query = "PRAGMA optimize;";
char *errmsg;
int ret;
@ -695,7 +695,7 @@ db_analyze(void)
ret = db_exec(query, &errmsg);
if (ret != SQLITE_OK)
{
DPRINTF(E_LOG, L_DB, "ANALYZE failed: %s\n", errmsg);
DPRINTF(E_LOG, L_DB, "PRAGMA optimize failed: %s\n", errmsg);
sqlite3_free(errmsg);
}
@ -755,7 +755,7 @@ db_hook_post_scan(void)
{
DPRINTF(E_DBG, L_DB, "Running post-scan DB maintenance tasks...\n");
db_analyze();
db_pragma_optimize();
DPRINTF(E_DBG, L_DB, "Done with post-scan DB maintenance\n");
}
@ -6413,8 +6413,6 @@ db_init(void)
}
}
db_analyze();
db_set_cfg_names();
files = db_files_get_count();

4
src/library.c
View File

@ -593,6 +593,9 @@ rescan(void *arg, int *ret)
purge_cruft(starttime);
DPRINTF(E_DBG, L_LIB, "Running post library scan jobs\n");
db_hook_post_scan();
endtime = time(NULL);
DPRINTF(E_LOG, L_LIB, "Library rescan completed in %.f sec (%d changes)\n", difftime(endtime, starttime), deferred_update_notifications);
scanning = false;
@ -982,6 +985,7 @@ library(void *arg)
if (!scan_exit)
DPRINTF(E_FATAL, L_LIB, "Scan event loop terminated ahead of time!\n");
db_hook_post_scan();
db_perthread_deinit();
pthread_exit(NULL);