MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-04-23 20:15:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

[db_upgrade] Fix memory leak in error case

Browse Source 
db_upgrade.c:72:7: warning: Potential memory leak
This commit is contained in:
chme 2018-12-17 08:35:43 +01:00 committed by ejurgensen
parent 21ce281cd1
commit b7f3e71f7e
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/db_upgrade.c
View File

@ -72,7 +72,9 @@ db_drop_indices(sqlite3 *hdl)
DPRINTF(E_LOG, L_DB, "Could not step: %s\n", sqlite3_errmsg(hdl)); DPRINTF(E_LOG, L_DB, "Could not step: %s\n", sqlite3_errmsg(hdl));
sqlite3_finalize(stmt); sqlite3_finalize(stmt);
return -1;
ret = -1;
goto out;
} }
sqlite3_finalize(stmt); sqlite3_finalize(stmt);
@ -80,7 +82,6 @@ db_drop_indices(sqlite3 *hdl)
for (i = 0; i < n; i++) for (i = 0; i < n; i++)
{ {
query = sqlite3_mprintf(Q_TMPL, index[i]); query = sqlite3_mprintf(Q_TMPL, index[i]);
free(index[i]);
DPRINTF(E_DBG, L_DB, "Running query '%s'\n", query); DPRINTF(E_DBG, L_DB, "Running query '%s'\n", query);
@ -90,13 +91,19 @@ db_drop_indices(sqlite3 *hdl)
DPRINTF(E_LOG, L_DB, "DB error while running '%s': %s\n", query, errmsg); DPRINTF(E_LOG, L_DB, "DB error while running '%s': %s\n", query, errmsg);
sqlite3_free(errmsg); sqlite3_free(errmsg);
return -1; sqlite3_free(query);
ret = -1;
goto out;
} }
sqlite3_free(query); sqlite3_free(query);
} }
return 0; out:
for (i = 0; i < n; i++)
free(index[i]);
return ret;
#undef Q_TMPL #undef Q_TMPL
#undef Q_INDEX #undef Q_INDEX
} }