From 8e9e939e49e4c600b81353d3271a7dca73018277 Mon Sep 17 00:00:00 2001 From: ejurgensen Date: Fri, 28 Mar 2025 22:24:19 +0100 Subject: [PATCH] [player] Add log message if speaker_set() called with non-existent speaker id Closes #1879 --- src/outputs.c | 2 +- src/player.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/outputs.c b/src/outputs.c index a4aa9425..b4ae0737 100644 --- a/src/outputs.c +++ b/src/outputs.c @@ -610,7 +610,7 @@ outputs_device_get(uint64_t device_id) return device; } - DPRINTF(E_WARN, L_PLAYER, "Output device with id %" PRIu64 " has disappeared from our list\n", device_id); + DPRINTF(E_WARN, L_PLAYER, "Output device with id %" PRIu64 " is not in our list\n", device_id); return NULL; } diff --git a/src/player.c b/src/player.c index cb989966..8b77c254 100644 --- a/src/player.c +++ b/src/player.c @@ -2683,6 +2683,10 @@ speaker_set(void *arg, int *retval) // why we want to provide a max_volume. max_volume = (player_state != PLAY_STOPPED) ? outputs_volume_get() : -1; + // Log a warning via outputs_device_get() if a speaker doesn't exist + for (i = 1; i <= nspk; i++) + outputs_device_get(ids[i]); + for (device = outputs_list(); device; device = device->next) { for (i = 1; i <= nspk; i++)