From 64c6007aad075afb17ca5b362a0d81d4a8e239b9 Mon Sep 17 00:00:00 2001
From: ejurgensen <espenjurgensen@gmail.com>
Date: Tue, 25 Feb 2020 21:58:18 +0100
Subject: [PATCH] [db] Fix memleak from unexpected return value, closes issue
 #909

On success the function was returning SQLITE_OK = 100, not 0, which made
json_reply_library think that the operation failed.

Credit @whatdoineed2do
---
 src/db.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/db.c b/src/db.c
index 9fd0fe60..212ae5d0 100644
--- a/src/db.c
+++ b/src/db.c
@@ -4415,7 +4415,9 @@ admin_get(void *value, const char *key, short type)
       default:
 	DPRINTF(E_LOG, L_DB, "BUG: Unknown type %d in admin_set\n", type);
 
-	ret = -2;
+	sqlite3_finalize(stmt);
+	sqlite3_free(query);
+	return -1;
     }
 
 #ifdef DB_PROFILE
@@ -4426,7 +4428,7 @@ admin_get(void *value, const char *key, short type)
   sqlite3_finalize(stmt);
   sqlite3_free(query);
 
-  return ret;
+  return 0;
 
 #undef Q_TMPL
 }