From 552c201cf342a3b67bb19f5a73c919bc9447dfd1 Mon Sep 17 00:00:00 2001 From: ejurgensen Date: Sat, 16 May 2020 21:31:18 +0200 Subject: [PATCH] [artwork] Change cache strategy for artwork_url_get Credit @sfeakes --- src/artwork.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/artwork.c b/src/artwork.c index b3793f2c..cd0fe7f1 100644 --- a/src/artwork.c +++ b/src/artwork.c @@ -275,11 +275,14 @@ static struct artwork_source artwork_item_source[] = .cache = ON_SUCCESS | ON_FAILURE, }, { + // Here we must use STASH because this handler must always just be a + // backup when artwork_url_get fails. If we used ON_SUCCESS this image + // would go in permanent cache, and artwork_url_get not get called again. .name = "playlist own", .handler = source_item_ownpl_get, .data_kinds = (1 << DATA_KIND_HTTP), .media_kinds = MEDIA_KIND_ALL, - .cache = ON_SUCCESS | ON_FAILURE, + .cache = STASH, }, { .name = "Spotify search web api (files)",