MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-01-15 16:53:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

[misc] Fix possible read of uninitialized memory in safe_snreplace()

Browse Source
This commit is contained in:
ejurgensen 2022-01-31 17:20:37 +01:00
parent 75c3590741
commit 4fee544a5d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/misc.c
View File

@ -714,13 +714,15 @@ safe_snreplace(char *s, size_t sz, const char *pattern, const char *replacement)
if (dst + num > s + sz) if (dst + num > s + sz)
return -1; // Not enough room return -1; // Not enough room
// Shift everything after the pattern to the right, use memmove since // Move everything after the pattern, use memmove since there might be an overlap
// there might be an overlap
memmove(dst, src, num); memmove(dst, src, num);
// Write replacement, no null terminater // Write replacement, no null terminater
memcpy(ptr, replacement, r_len); memcpy(ptr, replacement, r_len);
// String now has a new length
s_len += r_len - p_len;
// Advance ptr to avoid infinite looping // Advance ptr to avoid infinite looping
ptr = dst; ptr = dst;
} }