Handle SQLITE_SCHEMA error in db_exec()

This happens under database load with many concurrent threads doing updates;
queries failing with SQLITE_SCHEMA at step time need to retried from scratch
until they succeeded or hit a best-effort limit of 5 retries.
This commit is contained in:
Julien BLACHE 2011-05-28 10:48:31 +02:00
parent 4594cc3d63
commit 4f3635e354

View File

@ -535,10 +535,13 @@ static int
db_exec(const char *query, char **errmsg)
{
sqlite3_stmt *stmt;
int try;
int ret;
*errmsg = NULL;
for (try = 0; try < 5; try++)
{
ret = db_blocking_prepare_v2(query, -1, &stmt, NULL);
if (ret != SQLITE_OK)
{
@ -549,16 +552,18 @@ db_exec(const char *query, char **errmsg)
while ((ret = db_blocking_step(stmt)) == SQLITE_ROW)
; /* EMPTY */
sqlite3_finalize(stmt);
if (ret != SQLITE_SCHEMA)
break;
}
if (ret != SQLITE_DONE)
{
*errmsg = sqlite3_mprintf("step failed: %s", sqlite3_errmsg(hdl));
sqlite3_finalize(stmt);
return ret;
}
sqlite3_finalize(stmt);
return SQLITE_OK;
}