MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-02-03 09:56:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

Minor refactoring to make use of some prototype.js niftyties

Browse Source
This commit is contained in:
Anders Betnér 2006-06-04 19:43:20 +00:00
parent ccc6fdd1b6
commit 4a8c32bbd7
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
admin-root/config.js
View File

@ -23,7 +23,10 @@ var ConfigXML = {
return this.config[id]; return this.config[id];
}, },
getAllItems: function () { getAllItems: function () {
return $H(this.config); return $H(this.config).pluck('value');
},
addAdvancedSection: function (sectionName) {
this.advancedSections.push(sectionName);
}, },
isAdvancedSection: function (sectionName) { isAdvancedSection: function (sectionName) {
return this.advancedSections.find(function (name) { return this.advancedSections.find(function (name) {
@ -40,7 +43,7 @@ var ConfigXML = {
$A(xmlDoc.getElementsByTagName('section')).each(function (section) { $A(xmlDoc.getElementsByTagName('section')).each(function (section) {
if ('true' == section.getAttribute('advanced')) { if ('true' == section.getAttribute('advanced')) {
// Only used by Config._showAdvancedConfig, Config._showBasicConfig // Only used by Config._showAdvancedConfig, Config._showBasicConfig
ConfigXML.advancedSections.push(section.getAttribute('name')); ConfigXML.addAdvancedSection(section.getAttribute('name'));
} }
$A(section.getElementsByTagName('item')).each(function (item) { $A(section.getElementsByTagName('item')).each(function (item) {
var returnItem = {}; var returnItem = {};
@ -312,11 +315,11 @@ var Config ={
Effect.BlindDown(ConfigXML.getSectionId(sectionName)); Effect.BlindDown(ConfigXML.getSectionId(sectionName));
}); });
ConfigXML.getAllItems().each(function (item) { ConfigXML.getAllItems().each(function (item) {
if (item.value.advanced) { if (item.advanced) {
var element = $(item.key); var element = $(item.id);
if (!element) { if (!element) {
// Handle options with multiple values // Handle options with multiple values
$A(document.getElementsByName(item.key)).each(function (el) { $A(document.getElementsByName(item.id)).each(function (el) {
Effect.BlindDown(el.parentNode.parentNode); Effect.BlindDown(el.parentNode.parentNode);
}); });
} else { } else {
@ -333,15 +336,15 @@ var Config ={
Effect.BlindUp(ConfigXML.getSectionId(sectionName)); Effect.BlindUp(ConfigXML.getSectionId(sectionName));
}); });
ConfigXML.getAllItems().each(function (item) { ConfigXML.getAllItems().each(function (item) {
if (item.value.advanced) { if (item.advanced) {
var element = $(item.key); var element = $(item.id);
if (!element) { if (!element) {
// Handle options with multiple values // Handle options with multiple values
$A(document.getElementsByName(item.key)).each(function (el) { $A(document.getElementsByName(item.id)).each(function (el) {
Effect.BlindUp(el.parentNode.parentNode); Effect.BlindUp(el.parentNode.parentNode);
}); });
} else { } else {
Effect.BlindUp($(item.key).parentNode); Effect.BlindUp(element.parentNode);
} }
} }
}); });
@ -475,8 +478,6 @@ function saveForm() {
} }
function cancelForm() { function cancelForm() {
ConfigXML.getAllItems().each(function (item) { ConfigXML.getAllItems().each(function (item) {
// this is from a hash $H hence use value
item = item.value;
if (item.multiple) { if (item.multiple) {
var values = ConfigInitialValues.getValue(item.id); var values = ConfigInitialValues.getValue(item.id);
if (!values || values.length === 0) { if (!values || values.length === 0) {