MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-02-10 13:18:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite loop on unknown DACP property

Browse Source 
Missing strtok_r() call in the !dpm case.
This commit is contained in:
Julien BLACHE 2011-08-15 12:50:43 +02:00
parent 177d444f9f
commit 4472f9e955
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/httpd_dacp.c
View File

@ -1260,16 +1260,15 @@ dacp_reply_getproperty(struct evhttp_request *req, struct evbuffer *evbuf, char
while (prop) while (prop)
{ {
dpm = dacp_find_prop(prop, strlen(prop)); dpm = dacp_find_prop(prop, strlen(prop));
if (!dpm) if (dpm)
{ {
DPRINTF(E_LOG, L_DACP, "Could not find requested property '%s'\n", prop);
continue;
}
if (dpm->propget) if (dpm->propget)
dpm->propget(proplist, &status, mfi); dpm->propget(proplist, &status, mfi);
else else
DPRINTF(E_WARN, L_DACP, "No getter method for DACP property %s\n", prop); DPRINTF(E_WARN, L_DACP, "No getter method for DACP property %s\n", prop);
}
else
DPRINTF(E_LOG, L_DACP, "Could not find requested property '%s'\n", prop);
prop = strtok_r(NULL, ",", &ptr); prop = strtok_r(NULL, ",", &ptr);
} }