From 16cfca1bfe9ed6ef9a15374a5f0183ed45e9a08c Mon Sep 17 00:00:00 2001 From: ejurgensen Date: Tue, 14 Jan 2020 20:33:39 +0100 Subject: [PATCH] [scan] Remove some id3 tags that ffmpeg parses better (issue #882) ffmpeg parses TDA, TDAT, TYE, TYER and TDR these days, so there is no need to do that in forked-daapd. Also the parsing of TDA/TDAT was incorrect, since it is MMDD. --- src/library/filescanner_ffmpeg.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/library/filescanner_ffmpeg.c b/src/library/filescanner_ffmpeg.c index 1ccb6914..d6bf5054 100644 --- a/src/library/filescanner_ffmpeg.c +++ b/src/library/filescanner_ffmpeg.c @@ -223,6 +223,8 @@ static const struct metadata_map md_map_vorbis[] = * * Update 20180131: Removed tags supported by ffmpeg 2.5.4 (around 3 years old) * + added some tags used for grouping + * Update 20200114: Removed TDA, TDAT, TYE, TYER, TDR since the they are + * well supported by ffmpeg, and forked-daapd was parsing TDA/TDAT incorrectly * */ static const struct metadata_map md_map_id3[] = @@ -233,11 +235,6 @@ static const struct metadata_map md_map_id3[] = { "GRP1", 0, mfi_offsetof(grouping), NULL }, /* unofficial iTunes */ { "TCM", 0, mfi_offsetof(composer), NULL }, /* ID3v2.2 */ { "TPA", 1, mfi_offsetof(disc), parse_disc }, /* ID3v2.2 */ - { "TYE", 1, mfi_offsetof(year), NULL }, /* ID3v2.2 */ - { "TYER", 1, mfi_offsetof(year), NULL }, /* ID3v2.3 */ - { "TDA", 1, mfi_offsetof(date_released), parse_date }, /* ID3v2.2 */ - { "TDAT", 1, mfi_offsetof(date_released), parse_date }, /* ID3v2.3 */ - { "TDR", 1, mfi_offsetof(date_released), parse_date }, /* ID3v2.2 */ { "XSOA", 0, mfi_offsetof(album_sort), NULL }, /* ID3v2.3 */ { "XSOP", 0, mfi_offsetof(artist_sort), NULL }, /* ID3v2.3 */ { "XSOT", 0, mfi_offsetof(title_sort), NULL }, /* ID3v2.3 */