MyFavMirrors/owntone-server
1
0
Fork 0
mirror of https://github.com/owntone/owntone-server.git synced 2025-11-08 21:24:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

[-] Fix alsa.c null pointer deref + some minor bugs and do some housekeeping

Browse Source 
Thanks to Denis Denisov and cppcheck for notifying about the below. The leaks
are edge cases, but the warning of dereference of avail in alsa.c points at
a bug that could probably cause actual crashes.

[src/evrtsp/rtsp.c:1352]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/httpd_daap.c:228]: (error) Memory leak: s
[src/library.c:280]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/library.c:284]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/library/filescanner_playlist.c:251]: (error) Resource leak: fp
[src/library/filescanner_playlist.c:273]: (error) Resource leak: fp
[src/outputs/alsa.c:143]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/outputs/alsa.c:657]: (warning) Possible null pointer dereference: avail
[src/outputs/dummy.c:75]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/outputs/fifo.c:245]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/outputs/raop.c:1806]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/outputs/raop.c:1371]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/outputs/raop.c:1471]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/outputs/raop_verification.c:705] -> [src/outputs/raop_verification.c:667]: (warning) Either the condition 'if(len_M)' is redundant or there is possible null pointer dereference: len_M.
This commit is contained in:
ejurgensen
2017-10-05 22:13:01 +02:00
parent 2d27d14f3d
commit 0c2773039b
11 changed files with 41 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/library/filescanner_playlist.c
View File

@@ -248,7 +248,7 @@ scan_playlist(char *file, time_t mtime, int dir_id)
{
DPRINTF(E_LOG, L_SCAN, "Out of memory\n");
return;
goto out_close;
}
memset(pli, 0, sizeof(struct playlist_info));
@@ -270,7 +270,7 @@ scan_playlist(char *file, time_t mtime, int dir_id)
DPRINTF(E_LOG, L_SCAN, "Error adding playlist '%s'\n", file);
free_pli(pli, 0);
return;
goto out_close;
}
DPRINTF(E_INFO, L_SCAN, "Added playlist as id %d\n", pl_id);
@@ -346,11 +346,11 @@ scan_playlist(char *file, time_t mtime, int dir_id)
{
DPRINTF(E_LOG, L_SCAN, "Error reading playlist '%s': %s\n", file, strerror(errno));
fclose(fp);
return;
goto out_close;
}
fclose(fp);
DPRINTF(E_INFO, L_SCAN, "Done processing playlist\n");
out_close:
fclose(fp);
}