5 Commits

Author	SHA1	Message	Date
Scott Lamb	9d6dec2565	fix incorrect Javascript private variable style ... It's supposed to be a trailing underscore, not a leading underscore, as described here: https://google.github.io/styleguide/jsguide.html#naming-method-names https://google.github.io/styleguide/jsguide.html#naming-non-constant-field-names and discussed in an earlier PR: https://github.com/scottlamb/moonfire-nvr/pull/48#discussion_r175678736 I fixed these mechanically: rg -l0 'this[.]_' | xargs -0 perl -pi -e 's/this[.]_(\w+)/this.$1_/g' rg -l0 '\s_\w+\(' | xargs -0 perl -pi -e 's/_(\w+)\(/$1_(/g'	2020-03-14 15:20:18 -07:00
Scott Lamb	317a620e6e	upgrade copyright notices ... * As discussed in #48, say "The Moonfire NVR Authors" at the top of every file rather than whoever created that file. Have one AUTHORS file listing everyone. * Consistently call it a "security camera network video recorder" rather than "security camera digital video recorder".	2020-03-01 22:53:41 -08:00
Scott Lamb	aa25a85477	Fix a whole bunch of eslint errors ... These apparently were silent until 92c532d mass-upgraded deps. Apparently eslint returned status 0 despite errors before and now returns 1. Most of these were handled by its "--fix" option; I manually took care of the remaining two: /Users/slamb/git/moonfire-nvr/ui-src/lib/views/RecordingsView.js 140:1 error This line has a length of 82. Maximum allowed is 80 max-len /Users/slamb/git/moonfire-nvr/ui-src/lib/views/StreamSelectorView.js 72:1 error This line has a length of 82. Maximum allowed is 80 max-len	2020-03-01 22:28:24 -08:00
Scott Lamb	f2888e2b32	couple fixes to the dialog close button ... * add back in button.css (broken with f5aa008) * remove a redundant .png file-loader which apparently caused the .png asset to not load properly (broken with f5aa008)	2018-04-28 06:39:29 -07:00
Dolf Starreveld	f5aa0080bb	A little more UI refactor, cleanup, eslint more strict (#54) ... * A little more UI refactor, cleanup, eslint more strict * Split out imports for jQuery components and put them where needed. * No longer do all of it in application module. * Prepares better for code splitting. * Split out video player dialog * Simplifies jquery-ui dependencies for code splitting * Simplifies code * Configure to generate more, but smaller bundles. * Setup some more strict eslint settings * Fix css to import rather than require * Change settings to correctly support tree shaking in production build Signed-off-by: Dolf Starreveld <dolf@starreveld.com> * Remove “old” code from TimeFormatter * Accidentally left behind due to overlapping PRs Signed-off-by: Dolf Starreveld <dolf@starreveld.com>	2018-03-25 22:18:56 -07:00