4 Commits

Author	SHA1	Message	Date
Scott Lamb	1fe5ef8e94	fix #79: errors when "infinite" selected on load ... I've never seen this happen in Chrome; each load/reload starts fresh, so infinite is never selected. But on Firefox it seems to remember the setting across reloads, triggering this bug. This bug was introduced in 58152e8: it started parsing/normalizing the HTML form into a Javascript field on change. It didn't handle the initial load properly. Prior to that commit, fetch() simply read directly from the HTML form, so it didn't care about initial vs update.	2020-06-08 10:36:01 -07:00
Scott Lamb	9d6dec2565	fix incorrect Javascript private variable style ... It's supposed to be a trailing underscore, not a leading underscore, as described here: https://google.github.io/styleguide/jsguide.html#naming-method-names https://google.github.io/styleguide/jsguide.html#naming-non-constant-field-names and discussed in an earlier PR: https://github.com/scottlamb/moonfire-nvr/pull/48#discussion_r175678736 I fixed these mechanically: rg -l0 'this[.]_' | xargs -0 perl -pi -e 's/this[.]_(\w+)/this.$1_/g' rg -l0 '\s_\w+\(' | xargs -0 perl -pi -e 's/_(\w+)\(/$1_(/g'	2020-03-14 15:20:18 -07:00
Scott Lamb	317a620e6e	upgrade copyright notices ... * As discussed in #48, say "The Moonfire NVR Authors" at the top of every file rather than whoever created that file. Have one AUTHORS file listing everyone. * Consistently call it a "security camera network video recorder" rather than "security camera digital video recorder".	2020-03-01 22:53:41 -08:00
Dolf Starreveld	58152e8d94	Major refactoring of UI code, small UI changes. (#48) ... * Major refactoring of UI code, small UI changes. * Single file index.js split up into separate modules * Modules for handling UI view components * Modules for handling JSON/Model data * Modules for support tasks * Module to encapsulate Moonfire API * Main application module * index.js simplified to just activating main app * Settings file functionality expanded * UI adds "Time Format" popup to allow changing time representation * CSS changes/additions to streamline looks * Recordings loading indicator only appears after 500ms delay, if at all * Address first set of PR change requests from Scott. * Add copyright headers to all files (except JSON files) * Fix bug with entering time values in range pickers * Fixed an erroneous comment and/or spelling error here and there * Fixed JSDoc comments where [description] was not filled in * Removed a TODO from NVRApplication as it no longer applies * Fixed bug handling "infinite" case of video segment lengths * Fixed bug in "trim" handler and trim execution * Retrofit video continues loading from separate PR Signed-off-by: Dolf Starreveld <dolf@starreveld.com> * Address PR comments Signed-off-by: Dolf Starreveld <dolf@starreveld.com> * Address PR comments Signed-off-by: Dolf Starreveld <dolf@starreveld.com>	2018-03-20 07:03:12 -07:00