MyFavMirrors/moonfire-nvr
1
0
Fork 0
mirror of https://github.com/scottlamb/moonfire-nvr.git synced 2025-04-14 00:09:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

when developing on Safari, strip HttpOnly

Browse Source 
This might be necessary in the production/https case too. But try this
first.
This commit is contained in:
Scott Lamb 2021-03-30 16:23:58 -07:00
parent 478323ec62
commit d7f4b255bf
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui/src/setupProxy.js
View File

@ -21,13 +21,24 @@ module.exports = (app) => {
// this attribute in the proxy with code from here: // this attribute in the proxy with code from here:
// https://github.com/chimurai/http-proxy-middleware/issues/169#issuecomment-575027907 // https://github.com/chimurai/http-proxy-middleware/issues/169#issuecomment-575027907
// See also discussion in guide/developing-ui.md. // See also discussion in guide/developing-ui.md.
//
// Additionally, Safari appears to (sometimes?) prevent http-only cookies
// (meaning cookies that Javascript shouldn't be able to access) from
// being passed to WebSocket requests (possibly only when not using
// https/wss). Also strip HttpOnly when using Safari.
// https://developer.apple.com/forums/thread/104488
onProxyRes: (proxyRes, req, res) => { onProxyRes: (proxyRes, req, res) => {
const sc = proxyRes.headers["set-cookie"]; const sc = proxyRes.headers["set-cookie"];
if (Array.isArray(sc)) { if (Array.isArray(sc)) {
proxyRes.headers["set-cookie"] = sc.map((sc) => { proxyRes.headers["set-cookie"] = sc.map((sc) => {
return sc return sc
.split(";") .split(";")
.filter((v) => v.trim().toLowerCase() !== "secure") .filter(
(v) =>
v.trim().toLowerCase() !== "secure" &&
(v.trim().toLowerCase() !== "httponly" ||
!req.headers["user-agent"].includes("Safari"))
)
.join("; "); .join("; ");
}); });
} }