MyFavMirrors/moonfire-nvr
1
0
Fork 0
mirror of https://github.com/scottlamb/moonfire-nvr.git synced 2024-12-24 06:05:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

improve end reason in list ui

Browse Source 
* in backend, save the full reason, not just the most direct error,
  which is often the useless `UNKNOWN`

* in UI, instead of wrapping in `<Typography>` which just resorts in
  a weird ransom-note mixed size look, reserve space for or actually
  use an icon.
This commit is contained in:
Scott Lamb 2024-09-01 22:12:28 -07:00
parent 1473e79e96
commit 3efff2cfd6
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/src/streamer.rs
View File

@ -204,7 +204,7 @@ where
let frame = match frame {
Ok(f) => f,
Err(e) => {
let _ = w.close(None, Some(e.to_string()));
let _ = w.close(None, Some(e.chain().to_string()));
return Err(e);
}
};

10
ui/src/List/VideoList.tsx
View File

@ -12,7 +12,8 @@ import TableRow, { TableRowProps } from "@mui/material/TableRow";
import Skeleton from "@mui/material/Skeleton";
import Alert from "@mui/material/Alert";
import Tooltip from "@mui/material/Tooltip";
import Typography from "@mui/material/Typography";
import ErrorIcon from "@mui/icons-material/Error";
import Icon from "@mui/material/Icon";
interface Props {
stream: Stream;
@ -153,12 +154,15 @@ const Row = ({
<TableRow {...rest}>
<TableCell align="right">{start}</TableCell>
<TableCell align="right">
{end}
{endReason !== undefined ? (
<Tooltip title={endReason}>
<Typography>{end}</Typography>
<Icon sx={{ verticalAlign: "bottom", marginLeft: ".5em" }}>
<ErrorIcon />
</Icon>
</Tooltip>
) : (
end
<Icon sx={{ verticalAlign: "bottom", marginLeft: ".5em" }} />
)}
</TableCell>
<TableCell align="right" className="opt">