mirror of
https://github.com/minio/minio.git
synced 2024-12-25 14:45:54 -05:00
f8024cadbb
This is an improvement upon existing implementation by avoiding transfer of access and secret keys over the network. This change only exchanges JWT tokens generated by an rpc client. Even if the JWT can be traced over the network on a non-TLS connection, this change makes sure that we never really expose the secret key over the network.
173 lines
4.4 KiB
Go
173 lines
4.4 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"net/http"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func testAuthenticate(authType string, t *testing.T) {
|
|
testPath, err := newTestConfig(globalMinioDefaultRegion)
|
|
if err != nil {
|
|
t.Fatalf("unable initialize config file, %s", err)
|
|
}
|
|
defer os.RemoveAll(testPath)
|
|
// Create access and secret keys in length, 300 and 600
|
|
cred, err := getNewCredential(300, 600)
|
|
if err != nil {
|
|
t.Fatalf("unable to get new credential, %v", err)
|
|
}
|
|
serverConfig.SetCredential(cred)
|
|
|
|
// Define test cases.
|
|
testCases := []struct {
|
|
accessKey string
|
|
secretKey string
|
|
expectedErr error
|
|
}{
|
|
// Access key (less than 5 chrs) too small.
|
|
{"user", cred.SecretKey, errInvalidAccessKeyLength},
|
|
// Secret key (less than 8 chrs) too small.
|
|
{cred.AccessKey, "pass", errInvalidSecretKeyLength},
|
|
// Authentication error.
|
|
{"myuser", "mypassword", errInvalidAccessKeyID},
|
|
// Authentication error.
|
|
{cred.AccessKey, "mypassword", errAuthentication},
|
|
// Success.
|
|
{cred.AccessKey, cred.SecretKey, nil},
|
|
}
|
|
|
|
// Run tests.
|
|
for _, testCase := range testCases {
|
|
var err error
|
|
if authType == "node" {
|
|
_, err = authenticateNode(testCase.accessKey, testCase.secretKey)
|
|
} else if authType == "web" {
|
|
_, err = authenticateWeb(testCase.accessKey, testCase.secretKey)
|
|
} else if authType == "url" {
|
|
_, err = authenticateURL(testCase.accessKey, testCase.secretKey)
|
|
}
|
|
|
|
if testCase.expectedErr != nil {
|
|
if err == nil {
|
|
t.Fatalf("%+v: expected: %s, got: <nil>", testCase, testCase.expectedErr)
|
|
}
|
|
if testCase.expectedErr.Error() != err.Error() {
|
|
t.Fatalf("%+v: expected: %s, got: %s", testCase, testCase.expectedErr, err)
|
|
}
|
|
} else if err != nil {
|
|
t.Fatalf("%+v: expected: <nil>, got: %s", testCase, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAuthenticateNode(t *testing.T) {
|
|
testAuthenticate("node", t)
|
|
}
|
|
|
|
func TestAuthenticateWeb(t *testing.T) {
|
|
testAuthenticate("web", t)
|
|
}
|
|
|
|
func TestAuthenticateURL(t *testing.T) {
|
|
testAuthenticate("url", t)
|
|
}
|
|
|
|
// Tests web request authenticator.
|
|
func TestWebRequestAuthenticate(t *testing.T) {
|
|
testPath, err := newTestConfig(globalMinioDefaultRegion)
|
|
if err != nil {
|
|
t.Fatalf("unable initialize config file, %s", err)
|
|
}
|
|
defer os.RemoveAll(testPath)
|
|
|
|
creds := serverConfig.GetCredential()
|
|
token, err := getTokenString(creds.AccessKey, creds.SecretKey)
|
|
if err != nil {
|
|
t.Fatalf("unable get token %s", err)
|
|
}
|
|
testCases := []struct {
|
|
req *http.Request
|
|
expectedErr error
|
|
}{
|
|
// Set valid authorization header.
|
|
{
|
|
req: &http.Request{
|
|
Header: http.Header{
|
|
"Authorization": []string{token},
|
|
},
|
|
},
|
|
expectedErr: nil,
|
|
},
|
|
// No authorization header.
|
|
{
|
|
req: &http.Request{
|
|
Header: http.Header{},
|
|
},
|
|
expectedErr: errNoAuthToken,
|
|
},
|
|
// Invalid authorization token.
|
|
{
|
|
req: &http.Request{
|
|
Header: http.Header{
|
|
"Authorization": []string{"invalid-token"},
|
|
},
|
|
},
|
|
expectedErr: errAuthentication,
|
|
},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
gotErr := webRequestAuthenticate(testCase.req)
|
|
if testCase.expectedErr != gotErr {
|
|
t.Errorf("Test %d, expected err %s, got %s", i+1, testCase.expectedErr, gotErr)
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkAuthenticateNode(b *testing.B) {
|
|
testPath, err := newTestConfig(globalMinioDefaultRegion)
|
|
if err != nil {
|
|
b.Fatalf("unable initialize config file, %s", err)
|
|
}
|
|
defer os.RemoveAll(testPath)
|
|
|
|
creds := serverConfig.GetCredential()
|
|
b.ResetTimer()
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
authenticateNode(creds.AccessKey, creds.SecretKey)
|
|
}
|
|
}
|
|
|
|
func BenchmarkAuthenticateWeb(b *testing.B) {
|
|
testPath, err := newTestConfig(globalMinioDefaultRegion)
|
|
if err != nil {
|
|
b.Fatalf("unable initialize config file, %s", err)
|
|
}
|
|
defer os.RemoveAll(testPath)
|
|
|
|
creds := serverConfig.GetCredential()
|
|
b.ResetTimer()
|
|
b.ReportAllocs()
|
|
for i := 0; i < b.N; i++ {
|
|
authenticateWeb(creds.AccessKey, creds.SecretKey)
|
|
}
|
|
}
|