mirror of
https://github.com/minio/minio.git
synced 2024-12-26 07:05:55 -05:00
f8024cadbb
This is an improvement upon existing implementation by avoiding transfer of access and secret keys over the network. This change only exchanges JWT tokens generated by an rpc client. Even if the JWT can be traced over the network on a non-TLS connection, this change makes sure that we never really expose the secret key over the network.
126 lines
3.5 KiB
Go
126 lines
3.5 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"path"
|
|
"testing"
|
|
)
|
|
|
|
// API suite container common to both FS and XL.
|
|
type TestRPCBrowserPeerSuite struct {
|
|
serverType string
|
|
testServer TestServer
|
|
testAuthConf authConfig
|
|
}
|
|
|
|
// Setting up the test suite and starting the Test server.
|
|
func (s *TestRPCBrowserPeerSuite) SetUpSuite(c *testing.T) {
|
|
s.testServer = StartTestBrowserPeerRPCServer(c, s.serverType)
|
|
s.testAuthConf = authConfig{
|
|
serverAddr: s.testServer.Server.Listener.Addr().String(),
|
|
accessKey: s.testServer.AccessKey,
|
|
secretKey: s.testServer.SecretKey,
|
|
serviceEndpoint: path.Join(minioReservedBucketPath, browserPeerPath),
|
|
serviceName: "BrowserPeer",
|
|
}
|
|
}
|
|
|
|
// No longer used with gocheck, but used in explicit teardown code in
|
|
// each test function. // Called implicitly by "gopkg.in/check.v1"
|
|
// after all tests are run.
|
|
func (s *TestRPCBrowserPeerSuite) TearDownSuite(c *testing.T) {
|
|
s.testServer.Stop()
|
|
}
|
|
|
|
func TestBrowserPeerRPC(t *testing.T) {
|
|
// setup code
|
|
s := &TestRPCBrowserPeerSuite{serverType: "XL"}
|
|
s.SetUpSuite(t)
|
|
|
|
// run test
|
|
s.testBrowserPeerRPC(t)
|
|
|
|
// teardown code
|
|
s.TearDownSuite(t)
|
|
}
|
|
|
|
// Tests for browser peer rpc.
|
|
func (s *TestRPCBrowserPeerSuite) testBrowserPeerRPC(t *testing.T) {
|
|
// Construct RPC call arguments.
|
|
creds, err := createCredential("abcd1", "abcd1234")
|
|
if err != nil {
|
|
t.Fatalf("unable to create credential. %v", err)
|
|
}
|
|
|
|
// Validate for invalid token.
|
|
args := SetAuthPeerArgs{Creds: creds}
|
|
args.AuthToken = "garbage"
|
|
rclient := newRPCClient(s.testAuthConf.serverAddr, s.testAuthConf.serviceEndpoint, false)
|
|
defer rclient.Close()
|
|
err = rclient.Call("BrowserPeer.SetAuthPeer", &args, &AuthRPCReply{})
|
|
if err != nil {
|
|
if err.Error() != errInvalidToken.Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// Validate for successful Peer update.
|
|
args = SetAuthPeerArgs{Creds: creds}
|
|
client := newAuthRPCClient(s.testAuthConf)
|
|
defer client.Close()
|
|
err = client.Call("BrowserPeer.SetAuthPeer", &args, &AuthRPCReply{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Validate for failure in login handler with previous credentials.
|
|
rclient = newRPCClient(s.testAuthConf.serverAddr, s.testAuthConf.serviceEndpoint, false)
|
|
defer rclient.Close()
|
|
token, err := authenticateNode(creds.AccessKey, creds.SecretKey)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
rargs := &LoginRPCArgs{
|
|
AuthToken: token,
|
|
Version: Version,
|
|
RequestTime: UTCNow(),
|
|
}
|
|
rreply := &LoginRPCReply{}
|
|
err = rclient.Call("BrowserPeer"+loginMethodName, rargs, rreply)
|
|
if err != nil {
|
|
if err.Error() != errInvalidAccessKeyID.Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
token, err = authenticateNode(creds.AccessKey, creds.SecretKey)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Validate for success in loing handled with valid credetnails.
|
|
rargs = &LoginRPCArgs{
|
|
AuthToken: token,
|
|
Version: Version,
|
|
RequestTime: UTCNow(),
|
|
}
|
|
rreply = &LoginRPCReply{}
|
|
if err = rclient.Call("BrowserPeer"+loginMethodName, rargs, rreply); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|