mirror of
https://github.com/minio/minio.git
synced 2024-12-25 06:35:56 -05:00
5a80cbec2a
This PR adds pass-through, single encryption at gateway and double encryption support (gateway encryption with pass through of SSE headers to backend). If KMS is set up (either with Vault as KMS or using MINIO_SSE_MASTER_KEY),gateway will automatically perform single encryption. If MINIO_GATEWAY_SSE is set up in addition to Vault KMS, double encryption is performed.When neither KMS nor MINIO_GATEWAY_SSE is set, do a pass through to backend. When double encryption is specified, MINIO_GATEWAY_SSE can be set to "C" for SSE-C encryption at gateway and backend, "S3" for SSE-S3 encryption at gateway/backend or both to support more than one option. Fixes #6323, #6696
547 lines
16 KiB
Go
547 lines
16 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
// Tests validate bucket name.
|
|
func TestIsValidBucketName(t *testing.T) {
|
|
testCases := []struct {
|
|
bucketName string
|
|
shouldPass bool
|
|
}{
|
|
// cases which should pass the test.
|
|
// passing in valid bucket names.
|
|
{"lol", true},
|
|
{"1-this-is-valid", true},
|
|
{"1-this-too-is-valid-1", true},
|
|
{"this.works.too.1", true},
|
|
{"1234567", true},
|
|
{"123", true},
|
|
{"s3-eu-west-1.amazonaws.com", true},
|
|
{"ideas-are-more-powerful-than-guns", true},
|
|
{"testbucket", true},
|
|
{"1bucket", true},
|
|
{"bucket1", true},
|
|
{"a.b", true},
|
|
{"ab.a.bc", true},
|
|
// cases for which test should fail.
|
|
// passing invalid bucket names.
|
|
{"------", false},
|
|
{"my..bucket", false},
|
|
{"192.168.1.1", false},
|
|
{"$this-is-not-valid-too", false},
|
|
{"contains-$-dollar", false},
|
|
{"contains-^-carret", false},
|
|
{"contains-$-dollar", false},
|
|
{"contains-$-dollar", false},
|
|
{"......", false},
|
|
{"", false},
|
|
{"a", false},
|
|
{"ab", false},
|
|
{".starts-with-a-dot", false},
|
|
{"ends-with-a-dot.", false},
|
|
{"ends-with-a-dash-", false},
|
|
{"-starts-with-a-dash", false},
|
|
{"THIS-BEGINS-WITH-UPPERCASe", false},
|
|
{"tHIS-ENDS-WITH-UPPERCASE", false},
|
|
{"ThisBeginsAndEndsWithUpperCasE", false},
|
|
{"una ñina", false},
|
|
{"dash-.may-not-appear-next-to-dot", false},
|
|
{"dash.-may-not-appear-next-to-dot", false},
|
|
{"dash-.-may-not-appear-next-to-dot", false},
|
|
{"lalalallalallalalalallalallalala-thestring-size-is-greater-than-63", false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
isValidBucketName := IsValidBucketName(testCase.bucketName)
|
|
if testCase.shouldPass && !isValidBucketName {
|
|
t.Errorf("Test case %d: Expected \"%s\" to be a valid bucket name", i+1, testCase.bucketName)
|
|
}
|
|
if !testCase.shouldPass && isValidBucketName {
|
|
t.Errorf("Test case %d: Expected bucket name \"%s\" to be invalid", i+1, testCase.bucketName)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests for validate object name.
|
|
func TestIsValidObjectName(t *testing.T) {
|
|
testCases := []struct {
|
|
objectName string
|
|
shouldPass bool
|
|
}{
|
|
// cases which should pass the test.
|
|
// passing in valid object name.
|
|
{"object", true},
|
|
{"The Shining Script <v1>.pdf", true},
|
|
{"Cost Benefit Analysis (2009-2010).pptx", true},
|
|
{"117Gn8rfHL2ACARPAhaFd0AGzic9pUbIA/5OCn5A", true},
|
|
{"SHØRT", true},
|
|
{"f*le", true},
|
|
{"contains-^-carret", true},
|
|
{"contains-|-pipe", true},
|
|
{"contains-\"-quote", true},
|
|
{"contains-`-tick", true},
|
|
{"..test", true},
|
|
{".. test", true},
|
|
{". test", true},
|
|
{".test", true},
|
|
{"There are far too many object names, and far too few bucket names!", true},
|
|
// cases for which test should fail.
|
|
// passing invalid object names.
|
|
{"", false},
|
|
{"a/b/c/", false},
|
|
{"/a/b/c", false},
|
|
{"../../etc", false},
|
|
{"../../", false},
|
|
{"/../../etc", false},
|
|
{" ../etc", false},
|
|
{"./././", false},
|
|
{"./etc", false},
|
|
{"contains-\\-backslash", false},
|
|
{string([]byte{0xff, 0xfe, 0xfd}), false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
isValidObjectName := IsValidObjectName(testCase.objectName)
|
|
if testCase.shouldPass && !isValidObjectName {
|
|
t.Errorf("Test case %d: Expected \"%s\" to be a valid object name", i+1, testCase.objectName)
|
|
}
|
|
if !testCase.shouldPass && isValidObjectName {
|
|
t.Errorf("Test case %d: Expected object name \"%s\" to be invalid", i+1, testCase.objectName)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests getCompleteMultipartMD5
|
|
func TestGetCompleteMultipartMD5(t *testing.T) {
|
|
testCases := []struct {
|
|
parts []CompletePart
|
|
expectedResult string
|
|
expectedErr string
|
|
}{
|
|
// Wrong MD5 hash string
|
|
{[]CompletePart{{ETag: "wrong-md5-hash-string"}}, "", "encoding/hex: invalid byte: U+0077 'w'"},
|
|
|
|
// Single CompletePart with valid MD5 hash string.
|
|
{[]CompletePart{{ETag: "cf1f738a5924e645913c984e0fe3d708"}}, "10dc1617fbcf0bd0858048cb96e6bd77-1", ""},
|
|
|
|
// Multiple CompletePart with valid MD5 hash string.
|
|
{[]CompletePart{{ETag: "cf1f738a5924e645913c984e0fe3d708"}, {ETag: "9ccbc9a80eee7fb6fdd22441db2aedbd"}}, "0239a86b5266bb624f0ac60ba2aed6c8-2", ""},
|
|
}
|
|
|
|
for i, test := range testCases {
|
|
result, err := getCompleteMultipartMD5(context.Background(), test.parts)
|
|
if result != test.expectedResult {
|
|
t.Fatalf("test %d failed: expected: result=%v, got=%v", i+1, test.expectedResult, result)
|
|
}
|
|
errString := ""
|
|
if err != nil {
|
|
errString = err.Error()
|
|
}
|
|
if errString != test.expectedErr {
|
|
t.Fatalf("test %d failed: expected: err=%v, got=%v", i+1, test.expectedErr, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestIsMinioBucketName - Tests isMinioBucketName helper function.
|
|
func TestIsMinioMetaBucketName(t *testing.T) {
|
|
testCases := []struct {
|
|
bucket string
|
|
result bool
|
|
}{
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaBucket,
|
|
result: true,
|
|
},
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaMultipartBucket,
|
|
result: true,
|
|
},
|
|
// Minio meta bucket.
|
|
{
|
|
bucket: minioMetaTmpBucket,
|
|
result: true,
|
|
},
|
|
// Normal bucket
|
|
{
|
|
bucket: "mybucket",
|
|
result: false,
|
|
},
|
|
}
|
|
|
|
for i, test := range testCases {
|
|
actual := isMinioMetaBucketName(test.bucket)
|
|
if actual != test.result {
|
|
t.Errorf("Test %d - expected %v but received %v",
|
|
i+1, test.result, actual)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests RemoveStandardStorageClass method. Expectation is metadata map
|
|
// should be cleared of x-amz-storage-class, if it is set to STANDARD
|
|
func TestRemoveStandardStorageClass(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := removeStandardStorageClass(tt.metadata); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests CleanMetadata method. Expectation is metadata map
|
|
// should be cleared of etag, md5Sum and x-amz-storage-class, if it is set to STANDARD
|
|
func TestCleanMetadata(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "md5Sum": "abcde"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := cleanMetadata(tt.metadata); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests CleanMetadataKeys method. Expectation is metadata map
|
|
// should be cleared of keys passed to CleanMetadataKeys method
|
|
func TestCleanMetadataKeys(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
metadata map[string]string
|
|
keys []string
|
|
want map[string]string
|
|
}{
|
|
{
|
|
name: "1",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "STANDARD", "md5": "abcde"},
|
|
keys: []string{"etag", "md5"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "STANDARD"},
|
|
},
|
|
{
|
|
name: "2",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "x-amz-storage-class": "REDUCED_REDUNDANCY", "md5sum": "abcde"},
|
|
keys: []string{"etag", "md5sum"},
|
|
want: map[string]string{"content-type": "application/octet-stream", "x-amz-storage-class": "REDUCED_REDUNDANCY"},
|
|
},
|
|
{
|
|
name: "3",
|
|
metadata: map[string]string{"content-type": "application/octet-stream", "etag": "de75a98baf2c6aef435b57dd0fc33c86", "xyz": "abcde"},
|
|
keys: []string{"etag", "xyz"},
|
|
want: map[string]string{"content-type": "application/octet-stream"},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
if got := cleanMetadataKeys(tt.metadata, tt.keys...); !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("Test %s failed, expected %v, got %v", tt.name, tt.want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests isCompressed method
|
|
func TestIsCompressed(t *testing.T) {
|
|
testCases := []struct {
|
|
objInfo ObjectInfo
|
|
result bool
|
|
}{
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"X-Minio-Internal-compression": "golang/snappy/LZ77",
|
|
"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
},
|
|
result: true,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"X-Minio-Internal-XYZ": "golang/snappy/LZ77",
|
|
"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
},
|
|
result: false,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
},
|
|
result: false,
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
got := test.objInfo.IsCompressed()
|
|
if got != test.result {
|
|
t.Errorf("Test %d - expected %v but received %v",
|
|
i+1, test.result, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests excludeForCompression.
|
|
func TestExcludeForCompression(t *testing.T) {
|
|
testCases := []struct {
|
|
object string
|
|
header http.Header
|
|
result bool
|
|
}{
|
|
{
|
|
object: "object.txt",
|
|
header: http.Header{
|
|
"Content-Type": []string{"application/zip"},
|
|
},
|
|
result: true,
|
|
},
|
|
{
|
|
object: "object.zip",
|
|
header: http.Header{
|
|
"Content-Type": []string{"application/XYZ"},
|
|
},
|
|
result: true,
|
|
},
|
|
{
|
|
object: "object.json",
|
|
header: http.Header{
|
|
"Content-Type": []string{"application/json"},
|
|
},
|
|
result: false,
|
|
},
|
|
{
|
|
object: "object.txt",
|
|
header: http.Header{
|
|
"Content-Type": []string{"text/plain"},
|
|
},
|
|
result: false,
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
globalIsCompressionEnabled = true
|
|
got := excludeForCompression(test.header, test.object)
|
|
globalIsCompressionEnabled = false
|
|
if got != test.result {
|
|
t.Errorf("Test %d - expected %v but received %v",
|
|
i+1, test.result, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Test getPartFile function.
|
|
func TestGetPartFile(t *testing.T) {
|
|
testCases := []struct {
|
|
entries []string
|
|
partNumber int
|
|
etag string
|
|
result string
|
|
}{
|
|
{
|
|
entries: []string{"00001.8a034f82cb9cb31140d87d3ce2a9ede3.67108864", "fs.json", "00002.d73d8ab724016dfb051e2d3584495c54.32891137"},
|
|
partNumber: 1,
|
|
etag: "8a034f82cb9cb31140d87d3ce2a9ede3",
|
|
result: "00001.8a034f82cb9cb31140d87d3ce2a9ede3.67108864",
|
|
},
|
|
{
|
|
entries: []string{"00001.8a034f82cb9cb31140d87d3ce2a9ede3.67108864", "fs.json", "00002.d73d8ab724016dfb051e2d3584495c54.32891137"},
|
|
partNumber: 2,
|
|
etag: "d73d8ab724016dfb051e2d3584495c54",
|
|
result: "00002.d73d8ab724016dfb051e2d3584495c54.32891137",
|
|
},
|
|
{
|
|
entries: []string{"00001.8a034f82cb9cb31140d87d3ce2a9ede3.67108864", "fs.json", "00002.d73d8ab724016dfb051e2d3584495c54.32891137"},
|
|
partNumber: 1,
|
|
etag: "d73d8ab724016dfb051e2d3584495c54",
|
|
result: "",
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
got := getPartFile(test.entries, test.partNumber, test.etag)
|
|
if got != test.result {
|
|
t.Errorf("Test %d - expected %s but received %s",
|
|
i+1, test.result, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetActualSize(t *testing.T) {
|
|
testCases := []struct {
|
|
objInfo ObjectInfo
|
|
result int64
|
|
}{
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"X-Minio-Internal-compression": "golang/snappy/LZ77",
|
|
"X-Minio-Internal-actual-size": "100000001",
|
|
"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
Parts: []ObjectPartInfo{
|
|
{
|
|
Size: 39235668,
|
|
ActualSize: 67108864,
|
|
},
|
|
{
|
|
Size: 19177372,
|
|
ActualSize: 32891137,
|
|
},
|
|
},
|
|
},
|
|
result: 100000001,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"X-Minio-Internal-compression": "golang/snappy/LZ77",
|
|
"X-Minio-Internal-actual-size": "841",
|
|
"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
Parts: []ObjectPartInfo{},
|
|
},
|
|
result: 841,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
UserDefined: map[string]string{"X-Minio-Internal-compression": "golang/snappy/LZ77",
|
|
"content-type": "application/octet-stream",
|
|
"etag": "b3ff3ef3789147152fbfbc50efba4bfd-2"},
|
|
Parts: []ObjectPartInfo{},
|
|
},
|
|
result: -1,
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
got := test.objInfo.GetActualSize()
|
|
if got != test.result {
|
|
t.Errorf("Test %d - expected %d but received %d",
|
|
i+1, test.result, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetCompressedOffsets(t *testing.T) {
|
|
testCases := []struct {
|
|
objInfo ObjectInfo
|
|
offset int64
|
|
startOffset int64
|
|
snappyStartOffset int64
|
|
}{
|
|
{
|
|
objInfo: ObjectInfo{
|
|
Parts: []ObjectPartInfo{
|
|
{
|
|
Size: 39235668,
|
|
ActualSize: 67108864,
|
|
},
|
|
{
|
|
Size: 19177372,
|
|
ActualSize: 32891137,
|
|
},
|
|
},
|
|
},
|
|
offset: 79109865,
|
|
startOffset: 39235668,
|
|
snappyStartOffset: 12001001,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
Parts: []ObjectPartInfo{
|
|
{
|
|
Size: 39235668,
|
|
ActualSize: 67108864,
|
|
},
|
|
{
|
|
Size: 19177372,
|
|
ActualSize: 32891137,
|
|
},
|
|
},
|
|
},
|
|
offset: 19109865,
|
|
startOffset: 0,
|
|
snappyStartOffset: 19109865,
|
|
},
|
|
{
|
|
objInfo: ObjectInfo{
|
|
Parts: []ObjectPartInfo{
|
|
{
|
|
Size: 39235668,
|
|
ActualSize: 67108864,
|
|
},
|
|
{
|
|
Size: 19177372,
|
|
ActualSize: 32891137,
|
|
},
|
|
},
|
|
},
|
|
offset: 0,
|
|
startOffset: 0,
|
|
snappyStartOffset: 0,
|
|
},
|
|
}
|
|
for i, test := range testCases {
|
|
startOffset, snappyStartOffset := getCompressedOffsets(test.objInfo, test.offset)
|
|
if startOffset != test.startOffset {
|
|
t.Errorf("Test %d - expected startOffset %d but received %d",
|
|
i+1, test.startOffset, startOffset)
|
|
}
|
|
if snappyStartOffset != test.snappyStartOffset {
|
|
t.Errorf("Test %d - expected snappyOffset %d but received %d",
|
|
i+1, test.snappyStartOffset, snappyStartOffset)
|
|
}
|
|
}
|
|
}
|