mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
8975da4e84
This is an enhancement to the XL/distributed-XL mode. FS mode is unaffected. The ReadFileWithVerify storage-layer call is similar to ReadFile with the additional functionality of performing bit-rot checking. It accepts additional parameters for a hashing algorithm to use and the expected hex-encoded hash string. This patch provides significant performance improvement because: 1. combines the step of reading the file (during erasure-decoding/reconstruction) with bit-rot verification; 2. limits the number of file-reads; and 3. avoids transferring the file over the network for bit-rot verification. ReadFile API is implemented as ReadFileWithVerify with empty hashing arguments. Credits to AB and Harsha for the algorithmic improvement. Fixes #4236.
175 lines
4.4 KiB
Go
175 lines
4.4 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"github.com/minio/minio/pkg/disk"
|
|
)
|
|
|
|
// naughtyDisk wraps a POSIX disk and returns programmed errors
|
|
// specified by the developer. The purpose is to simulate errors
|
|
// that are hard to simulate in practice like DiskNotFound.
|
|
// Programmed errors are stored in errors field.
|
|
type naughtyDisk struct {
|
|
// The real disk
|
|
disk *retryStorage
|
|
// Programmed errors: API call number => error to return
|
|
errors map[int]error
|
|
// The error to return when no error value is programmed
|
|
defaultErr error
|
|
// The current API call number
|
|
callNR int
|
|
// Data protection
|
|
mu sync.Mutex
|
|
}
|
|
|
|
func newNaughtyDisk(d *retryStorage, errs map[int]error, defaultErr error) *naughtyDisk {
|
|
return &naughtyDisk{disk: d, errors: errs, defaultErr: defaultErr}
|
|
}
|
|
|
|
func (d *naughtyDisk) String() string {
|
|
return d.disk.String()
|
|
}
|
|
|
|
func (d *naughtyDisk) Init() (err error) {
|
|
if err = d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.Init()
|
|
}
|
|
|
|
func (d *naughtyDisk) Close() (err error) {
|
|
if err = d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.Close()
|
|
}
|
|
|
|
func (d *naughtyDisk) calcError() (err error) {
|
|
d.mu.Lock()
|
|
defer d.mu.Unlock()
|
|
d.callNR++
|
|
if err, ok := d.errors[d.callNR]; ok {
|
|
return err
|
|
}
|
|
if d.defaultErr != nil {
|
|
return d.defaultErr
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (d *naughtyDisk) DiskInfo() (info disk.Info, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return info, err
|
|
}
|
|
return d.disk.DiskInfo()
|
|
}
|
|
|
|
func (d *naughtyDisk) MakeVol(volume string) (err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.MakeVol(volume)
|
|
}
|
|
|
|
func (d *naughtyDisk) ListVols() (vols []VolInfo, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return nil, err
|
|
}
|
|
return d.disk.ListVols()
|
|
}
|
|
|
|
func (d *naughtyDisk) StatVol(volume string) (volInfo VolInfo, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return VolInfo{}, err
|
|
}
|
|
return d.disk.StatVol(volume)
|
|
}
|
|
func (d *naughtyDisk) DeleteVol(volume string) (err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.DeleteVol(volume)
|
|
}
|
|
|
|
func (d *naughtyDisk) ListDir(volume, path string) (entries []string, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return []string{}, err
|
|
}
|
|
return d.disk.ListDir(volume, path)
|
|
}
|
|
|
|
func (d *naughtyDisk) ReadFile(volume string, path string, offset int64, buf []byte) (n int64, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return 0, err
|
|
}
|
|
return d.disk.ReadFile(volume, path, offset, buf)
|
|
}
|
|
|
|
func (d *naughtyDisk) ReadFileWithVerify(volume, path string, offset int64,
|
|
buf []byte, algo HashAlgo, expectedHash string) (n int64, err error) {
|
|
|
|
if err := d.calcError(); err != nil {
|
|
return 0, err
|
|
}
|
|
return d.disk.ReadFileWithVerify(volume, path, offset, buf, algo, expectedHash)
|
|
}
|
|
|
|
func (d *naughtyDisk) PrepareFile(volume, path string, length int64) error {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.PrepareFile(volume, path, length)
|
|
}
|
|
|
|
func (d *naughtyDisk) AppendFile(volume, path string, buf []byte) error {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.AppendFile(volume, path, buf)
|
|
}
|
|
|
|
func (d *naughtyDisk) RenameFile(srcVolume, srcPath, dstVolume, dstPath string) error {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.RenameFile(srcVolume, srcPath, dstVolume, dstPath)
|
|
}
|
|
|
|
func (d *naughtyDisk) StatFile(volume string, path string) (file FileInfo, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return FileInfo{}, err
|
|
}
|
|
return d.disk.StatFile(volume, path)
|
|
}
|
|
|
|
func (d *naughtyDisk) DeleteFile(volume string, path string) (err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return err
|
|
}
|
|
return d.disk.DeleteFile(volume, path)
|
|
}
|
|
|
|
func (d *naughtyDisk) ReadAll(volume string, path string) (buf []byte, err error) {
|
|
if err := d.calcError(); err != nil {
|
|
return nil, err
|
|
}
|
|
return d.disk.ReadAll(volume, path)
|
|
}
|