mirror of
https://github.com/minio/minio.git
synced 2024-12-25 22:55:54 -05:00
9e7a3e6adc
- This PR allows config KVS to be validated properly without being affected by ENV overrides, rejects invalid values during set operation - Expands unit tests and refactors the error handling for notification targets, returns error instead of ignoring targets for invalid KVS - Does all the prep-work for implementing safe-mode style operation for MinIO server, introduces a new global variable to toggle safe mode based operations NOTE: this PR itself doesn't provide safe mode operations
123 lines
3.8 KiB
Go
123 lines
3.8 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2019 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cache
|
|
|
|
import (
|
|
"reflect"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Tests cache drive parsing.
|
|
func TestParseCacheDrives(t *testing.T) {
|
|
testCases := []struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{
|
|
// Invalid input
|
|
|
|
{"bucket1/*;*.png;images/trip/barcelona/*", []string{}, false},
|
|
{"bucket1", []string{}, false},
|
|
{";;;", []string{}, false},
|
|
{",;,;,;", []string{}, false},
|
|
}
|
|
|
|
// Valid inputs
|
|
if runtime.GOOS == "windows" {
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"C:/home/drive1;C:/home/drive2;C:/home/drive3", []string{"C:/home/drive1", "C:/home/drive2", "C:/home/drive3"}, true})
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"C:/home/drive{1...3}", []string{"C:/home/drive1", "C:/home/drive2", "C:/home/drive3"}, true})
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"C:/home/drive{1..3}", []string{}, false})
|
|
} else {
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"/home/drive1;/home/drive2;/home/drive3", []string{"/home/drive1", "/home/drive2", "/home/drive3"}, true})
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"/home/drive{1...3}", []string{"/home/drive1", "/home/drive2", "/home/drive3"}, true})
|
|
testCases = append(testCases, struct {
|
|
driveStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{"/home/drive{1..3}", []string{}, false})
|
|
}
|
|
for i, testCase := range testCases {
|
|
drives, err := parseCacheDrives(strings.Split(testCase.driveStr, cacheDelimiter))
|
|
if err != nil && testCase.success {
|
|
t.Errorf("Test %d: Expected success but failed instead %s", i+1, err)
|
|
}
|
|
if err == nil && !testCase.success {
|
|
t.Errorf("Test %d: Expected failure but passed instead", i+1)
|
|
}
|
|
if err == nil {
|
|
if !reflect.DeepEqual(drives, testCase.expectedPatterns) {
|
|
t.Errorf("Test %d: Expected %v, got %v", i+1, testCase.expectedPatterns, drives)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests cache exclude parsing.
|
|
func TestParseCacheExclude(t *testing.T) {
|
|
testCases := []struct {
|
|
excludeStr string
|
|
expectedPatterns []string
|
|
success bool
|
|
}{
|
|
// Invalid input
|
|
{"/home/drive1;/home/drive2;/home/drive3", []string{}, false},
|
|
{"/", []string{}, false},
|
|
{";;;", []string{}, false},
|
|
|
|
// valid input
|
|
{"bucket1/*;*.png;images/trip/barcelona/*", []string{"bucket1/*", "*.png", "images/trip/barcelona/*"}, true},
|
|
{"bucket1", []string{"bucket1"}, true},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
excludes, err := parseCacheExcludes(strings.Split(testCase.excludeStr, cacheDelimiter))
|
|
if err != nil && testCase.success {
|
|
t.Errorf("Test %d: Expected success but failed instead %s", i+1, err)
|
|
}
|
|
if err == nil && !testCase.success {
|
|
t.Errorf("Test %d: Expected failure but passed instead", i+1)
|
|
}
|
|
if err == nil {
|
|
if !reflect.DeepEqual(excludes, testCase.expectedPatterns) {
|
|
t.Errorf("Test %d: Expected %v, got %v", i+1, testCase.expectedPatterns, excludes)
|
|
}
|
|
}
|
|
}
|
|
}
|